Re: persist logical slots to disk during shutdown checkpoint

2023-08-19 Thread Amit Kapila
On Sat, Aug 19, 2023 at 12:46 PM Julien Rouhaud wrote: > > On Sat, 19 Aug 2023, 14:16 Amit Kapila, wrote: >> > >> The idea discussed in the thread [1] is to always persist logical >> slots to disk during the shutdown checkpoint. I have extracted the >> patch to achieve the same from that thread a

Re: PostgreSQL 16 release announcement draft

2023-08-19 Thread jian he
> Additionally, this release adds a new field to the pg_stat_all_tables view, capturing a timestamp representing when a table or index was last scanned. PostgreSQL also makes auto_explain more readable by logging values passed into parameterized statements, and improves accuracy of pg_stat_acti

Re: ci: Improve macos startup using a cached macports installation

2023-08-19 Thread Andres Freund
On 2023-08-19 11:47:33 -0700, Andres Freund wrote: > Given how significant an improvement this is in test time, and the limited > blast radius, I am planning to push this soon, unless somebody opposes that > soon. And done.

PostgreSQL 16 release announcement draft

2023-08-19 Thread Jonathan S. Katz
Hi, Attached is the first draft of the PostgreSQL 16 release announcement, authored by Chelsea Dole & myself. To frame this up, the goal of the GA release announcement is to help folks discover the awesome new features of PostgreSQL. It's impossible to list out every single feature in the re

Re: postgres_fdw: wrong results with self join + enable_nestloop off

2023-08-19 Thread Andres Freund
Hi, On 2023-08-19 20:09:25 +0900, Etsuro Fujita wrote: > Maybe my explanation was not enough, so let me explain: > > * I think you could use the set_join_pathlist_hook hook as you like at > your own responsibility, but typical use cases of the hook that are > designed to support in the core syste

Re: CREATE FUNCTION ... SEARCH { DEFAULT | SYSTEM | SESSION }

2023-08-19 Thread Andres Freund
Hi, On 2023-08-14 12:25:30 -0700, Jeff Davis wrote: > On Sat, 2023-08-12 at 11:25 -0700, Andres Freund wrote: > > > > I'm not sure that anything based, directly or indirectly, on > > search_path > > really is a realistic way to get there. > > Can you explain a little more? I see what you mean gene

Re: ci: Improve macos startup using a cached macports installation

2023-08-19 Thread Andres Freund
Hi, On 2023-08-05 13:25:39 -0700, Andres Freund wrote: > We have some issues with CI on macos and windows being too expensive (more on > that soon in a separate email). For macos most of the obviously wasted time is > spent installing packages with homebrew. Even with the package downloads being >

Re: BUG #18059: Unexpected error 25001 in stored procedure

2023-08-19 Thread Tom Lane
[ redirected to -hackers ] PG Bug reporting form writes: > Steps to reproduce: > 1. Create stored procedure > create or replace procedure test_proc() > language plpgsql as $procedure$ > begin >commit; >set transaction isolation level repeatable read; >-- here follows some useful code

Re: PG 16 draft release notes ready

2023-08-19 Thread Bruce Momjian
On Thu, Aug 17, 2023 at 08:37:28AM +0300, Pavel Luzanov wrote: > On 17.08.2023 05:36, Bruce Momjian wrote: > > On Wed, Aug 9, 2023 at 08:35:21PM -0400, Bruce Momjian wrote: > > > On Sat, Aug 5, 2023 at 04:08:47PM -0700, Noah Misch wrote: > > > > > Author: Robert Haas > > > > > 2022-08-25 [e3ce2d

Re: WIP: new system catalog pg_wait_event

2023-08-19 Thread Drouvot, Bertrand
Hi, On 8/19/23 12:00 PM, Michael Paquier wrote: On Sat, Aug 19, 2023 at 11:35:01AM +0200, Drouvot, Bertrand wrote: Hi, On 8/18/23 12:31 PM, Michael Paquier wrote: Thanks! Please find attached v9 fixing this typo. I was looking at v8, and this looks pretty good to me. Great! I have spott

Re: pg_upgrade fails with in-place tablespace

2023-08-19 Thread Rui Zhao
On Sat, Aug 19, 2023 at 12:45 PM +0800, Michael Paquier wrote: > I am not sure to follow the meaning of this logic. There could be > in-place tablespaces that got created with the GUC enabled during a > session, while the GUC has disabled the GUC. Shouldn't this stuff be > more restrictive and not

Re: Fix typo in src/interfaces/libpq/po/zh_CN.po

2023-08-19 Thread Zhang Mingli
> On Aug 16, 2023, at 22:24, Peter Eisentraut wrote: > > On 16.08.23 09:34, Zhang Mingli wrote: >> The Chinese words there are ok, but the `Unix-domian` should be >> `Unix-domain`. > > fixed, thanks > Hi, Peter, thanks and just want to make sure that it is pushed? Zhang Mingli HashData

Re: postgres_fdw: wrong results with self join + enable_nestloop off

2023-08-19 Thread Etsuro Fujita
Hi Onder, On Wed, Aug 16, 2023 at 10:58 PM Önder Kalacı wrote: >> Maybe we could do so by leaving to extensions the decision whether >> they replace joins with pseudoconstant clauses, but I am not sure that >> that is a good idea, because that would require the authors to modify >> and recompile

Re: pgbench: allow to exit immediately when any client is aborted

2023-08-19 Thread Tatsuo Ishii
> I have tested the v4 patch with default_transaction_isolation = > 'repeatable read'. > > pgbench --exit-on-abort -N -p 11002 -c 10 -T 30 test > pgbench (17devel, server 15.3) > starting vacuum...end. > transaction type: > scaling factor: 1 > query mode: simple > number of clients: 10 > number o

Re: [PoC] pg_upgrade: allow to upgrade publisher node

2023-08-19 Thread Amit Kapila
On Fri, Aug 18, 2023 at 7:21 PM Hayato Kuroda (Fujitsu) wrote: > Few comments on new patches: 1. + ALTER SUBSCRIPTION ... DISABLE. + After the upgrade is complete, execute the + ALTER SUBSCRIPTION ... CONNECTION command to update the + connection string, and then re-enable the sub

Re: WIP: new system catalog pg_wait_event

2023-08-19 Thread Michael Paquier
On Sat, Aug 19, 2023 at 11:35:01AM +0200, Drouvot, Bertrand wrote: > Hi, > > On 8/18/23 12:31 PM, Michael Paquier wrote: > Thanks! Please find attached v9 fixing this typo. I was looking at v8, and this looks pretty good to me. I have spotted a few minor things. + proretset => 't', provolatile

Re: WIP: new system catalog pg_wait_event

2023-08-19 Thread Drouvot, Bertrand
Hi, On 8/18/23 12:31 PM, Michael Paquier wrote: On Fri, Aug 18, 2023 at 10:56:55AM +0200, Drouvot, Bertrand wrote: Okay, using the plural form in v8 attached. Noting in passing: - Here is an example of how wait events can be viewed: + Here is are examples of how wait events can be vie

Re: [PATCH] Add function to_oct

2023-08-19 Thread Dean Rasheed
On Thu, 17 Aug 2023 at 16:26, Nathan Bossart wrote: > > Works for me. I did it that way in v7. > I note that there are no tests for negative inputs. Doing a quick test, shows that this changes the current behaviour, because all inputs are now treated as 64-bit: HEAD: select to_hex((-1234)::in

Re: persist logical slots to disk during shutdown checkpoint

2023-08-19 Thread Julien Rouhaud
On Sat, 19 Aug 2023, 14:16 Amit Kapila, wrote: > It's entirely possible for a logical slot to have a confirmed_flush > LSN higher than the last value saved on disk while not being marked as > dirty. It's currently not a problem to lose that value during a clean > shutdown / restart cycle but to