Re: [PATCH] Tracking statements entry timestamp in pg_stat_statements

On 25/10/2023 20:00, Andrei Zubkov wrote: Hi Andrei, On Wed, 2023-10-25 at 13:59 +0700, Andrei Lepikhov wrote: But minmax_stats_since and changes in the UI of the reset routine look like syntactic sugar here. I can't convince myself that it is really needed. Do you have some set of cases that

Re: Synchronizing slots from primary to standby

On Wed, Oct 25, 2023 at 8:49 PM Drouvot, Bertrand wrote: > > On 10/9/23 12:30 PM, shveta malik wrote: > > PFA v22 patch-set. It has below changes: > > > > patch 001: > > 1) Now physical walsender wakes up logical walsender(s) by using a new > > CV as suggested in [1] > > Thanks! > > I think that

RE: Open a streamed block for transactional messages during decoding

On Thursday, October 26, 2023 12:42 PM Amit Kapila wrote: > > On Tue, Oct 24, 2023 at 5:27 PM Zhijie Hou (Fujitsu) > wrote: > > > > While reviewing the test_decoding code, I noticed that when > > skip_empty_xacts option is specified, it doesn't open the streaming > block( e.g. > >

Re: [patch] pg_basebackup: mention that spread checkpoints are the default in --help

Hi, On Wed, Oct 25, 2023 at 04:36:41PM +0200, Peter Eisentraut wrote: > On 19.10.23 11:39, Michael Banck wrote: > > Hi, > > > > I believed that spread (not fast) checkpoints are the default in > > pg_basebackup, but noticed that --help does not specify which is which - > > contrary to the

Re: Reconcile stats in find_tabstat_entry() and get rid of PgStat_BackendFunctionEntry

Hi, On 3/27/23 8:35 AM, Michael Paquier wrote: On Fri, Mar 24, 2023 at 08:00:44PM -0700, Andres Freund wrote: I don't understand what we're optimizing for here. These functions are very very very far from being a hot path. The xact functions are barely ever used. Compared to the cost of query

Re: libpq async connection and multiple hosts

On Thu, 26 Oct 2023 at 03:31, Daniele Varrazzo wrote: > The goal here was only non-blocking name resolution. Ahaini understand we > should do is to split on the hosts for sync connections too, shuffle if > requested, and make separate connection attempts. If you pack the resolved addresses in

Re: pg_upgrade and logical replication

On Fri, Sep 29, 2023 at 05:32:52PM +0530, Amit Kapila wrote: > Such a use case is possible to achieve even without this patch. > Sawada-San has already given an alternative to slightly tweak the > steps mentioned by Julien to achieve it. Also, there are other ways to > achieve it by slightly

Re: Is this a problem in GenericXLogFinish()?

On Wed, Oct 25, 2023 at 10:06:23PM -0700, Jeff Davis wrote: > Thank you for the report! I was able to reproduce and observe that the > buffer is not marked dirty. > > The call (hashovfl.c:671): > > XLogRegisterBuffer(1, wbuf, REGBUF_STANDARD) > > is followed unconditionally by: > >

RE: CRC32C Parallel Computation Optimization on ARM

On Wed, 25 Oct, 2023 at 10:43:25 -0500, Nathan Bossart wrote: >+pg_crc32c >+pg_comp_crc32c_with_vmull_armv8(pg_crc32c crc, const void *data, size_t len) >It looks like most of this function is duplicated from >pg_comp_crc32c_armv8(). I understand that we probably need a separate >function

Parallel query behaving different with custom GUCs

Hi All, We observed the behavioral difference when query(with custom GUC) using the PARALLEL plan vs the Non-PARALLEL plan. Consider the below test: I understand the given testcase doesn't make much sense, but this is the simplest version of the test - to demonstrate the problem. create table

RE: Synchronizing slots from primary to standby

Dear Shveta, > PFA v25 patch set. The changes are: Thanks for making the patch! It seems that there are lots of comments, so I can put some high-level comments for 0001. Sorry if there are duplicated comments. 1. The patch seemed not to consider the case that failover option between

Re: RFC: Logging plan of the running query

On 2023-10-25 12:40, Ashutosh Bapat wrote: On Wed, Oct 18, 2023 at 10:04 PM James Coleman wrote: While that decision as regards auto_explain has long since been made (and there would be work to undo it), I don't believe that we should repeat that choice here. I'm -10 on moving this into

Re: Show WAL write and fsync stats in pg_stat_io

On Wed, Sep 20, 2023 at 10:57:48AM +0300, Nazir Bilal Yavuz wrote: > Any kind of feedback would be appreciated. This was registered in the CF, so I have given it a look. Note that 0001 has a conflict with pgstat_count_io_op_time(), so it cannot be applied. +pgstat_should_track_io_time(IOObject

Re: Container Types

On Wed, 2023-10-25 at 16:01 -0700, Andres Freund wrote: > I'd look whether you can generalize that infrastructure. I had briefly looked at using the record type mechanism before, and it seemed like a challenge because it doesn't really work when passing through a function call: CREATE TABLE

<    1   2