RE: pg_upgrade test failure

2023-10-28 Thread Hayato Kuroda (Fujitsu)
Dear Andres, While tracking BF failures related with pg_ugprade, I found the same failure has still happened [1] - [4]. According to the log, the output directory was remained even after the successful upgrade [5]. I analyzed and attached the fix patch, and below is my analysis... how do you

Re: COPY TO (FREEZE)?

2023-10-28 Thread Bruce Momjian
On Sat, Oct 28, 2023 at 09:54:05PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Sat, Oct 28, 2023 at 09:39:53PM -0400, Tom Lane wrote: > >> Not thrilled by the wording here. > > > I think it is modeled after: > > > errmsg("COPY force null only available using COPY FROM"))); > >

Re: COPY TO (FREEZE)?

2023-10-28 Thread Tom Lane
Bruce Momjian writes: > On Sat, Oct 28, 2023 at 09:39:53PM -0400, Tom Lane wrote: >> Not thrilled by the wording here. > I think it is modeled after: > errmsg("COPY force null only available using COPY FROM"))); Well, now that you bring it up, that's no sterling example of clear writing

Re: COPY TO (FREEZE)?

2023-10-28 Thread Bruce Momjian
On Sat, Oct 28, 2023 at 09:39:53PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > My apologies, wrong patch attached, right one attached now. > > I think this one is fine as-is: > > /* Only single-byte delimiter strings are supported. */ > if (strlen(opts_out->delim) != 1) >

Re: COPY TO (FREEZE)?

2023-10-28 Thread Tom Lane
Bruce Momjian writes: > My apologies, wrong patch attached, right one attached now. I think this one is fine as-is: /* Only single-byte delimiter strings are supported. */ if (strlen(opts_out->delim) != 1) ereport(ERROR, -

Re: COPY TO (FREEZE)?

2023-10-28 Thread Bruce Momjian
On Sat, Oct 28, 2023 at 08:38:26PM -0400, Bruce Momjian wrote: > I would like to apply the attached patch to master. Looking at your > adjustments for ERRCODE_FEATURE_NOT_SUPPORTED to > ERRCODE_INVALID_PARAMETER_VALUE, I only changed the cases where it would > be illogical to implement the

Re: COPY TO (FREEZE)?

2023-10-28 Thread Bruce Momjian
On Tue, Aug 2, 2022 at 05:17:35PM +0900, Kyotaro Horiguchi wrote: > At Tue, 2 Aug 2022 14:17:46 +0800, Julien Rouhaud wrote > in > > Hi, > > > > On Tue, Aug 02, 2022 at 01:30:46PM +0900, Kyotaro Horiguchi wrote: > > > I noticed that COPY TO accepts FREEZE option but it is pointless. > > > > >

Re: Why is DEFAULT_FDW_TUPLE_COST so insanely low?

2023-10-28 Thread Bruce Momjian
Has anything been done about this issue? --- On Wed, Aug 3, 2022 at 02:56:12AM +1200, David Rowley wrote: > Over on [1] I was complaining that I thought DEFAULT_FDW_TUPLE_COST, > which is defined as 0.01 was

Re: remove useless comments

2023-10-28 Thread Bruce Momjian
On Wed, Aug 10, 2022 at 12:24:02AM +0800, Junwang Zhao wrote: > Fair enough, the rephased version of the comments is in the attachment, > please take a look. > > --- a/src/backend/postmaster/postmaster.c > +++ b/src/backend/postmaster/postmaster.c > @@ -1583,8 +1583,8 @@

Re: run pgindent on a regular basis / scripted manner

2023-10-28 Thread Tom Lane
Andrew Dunstan writes: > Based on recent experience, where a lot koel's recent complaints seem to > be about comments, I'd like to suggest a modest adjustment. > First, we should provide a mode of pgindent that doesn't reflow > comments. pg_bsd_indent has a flag for this (-nfcb), so this

Re: run pgindent on a regular basis / scripted manner

2023-10-28 Thread Andrew Dunstan
On 2023-08-12 Sa 11:57, Andrew Dunstan wrote: On 2023-08-11 Fr 19:17, Tom Lane wrote: Peter Geoghegan writes: I'm starting to have doubts about this policy. There have now been quite a few follow-up "fixes" to indentation issues that koel complained about. None of these fixups have been

Re: Enderbury Island disappeared from timezone database

2023-10-28 Thread Tom Lane
Victor Wagner writes: > Tom Lane пишет: >> This means that if we substitute Kanton for Enderbury, things >> will work fine against tzdata 2021b or later, but will fail in >> the reverse way against older tzdata sets. Do we want to >> bet that everybody in the world has up-to-date tzdata

Re: Enderbury Island disappeared from timezone database

2023-10-28 Thread Victor Wagner
В Fri, 27 Oct 2023 14:00:38 -0400 Tom Lane пишет: > This means that if we substitute Kanton for Enderbury, things > will work fine against tzdata 2021b or later, but will fail in > the reverse way against older tzdata sets. Do we want to > bet that everybody in the world has up-to-date tzdata

Re: maybe a type_sanity. sql bug

2023-10-28 Thread Michael Paquier
On Fri, Oct 27, 2023 at 09:44:30PM -0400, Tom Lane wrote: > Anyway, we should fix this if only for clarity's sake. > I do not feel a need to back-patch though. Agreed. Thanks for the commit. -- Michael signature.asc Description: PGP signature

Re: Is this a problem in GenericXLogFinish()?

2023-10-28 Thread Michael Paquier
On Sat, Oct 28, 2023 at 03:45:13PM +0530, Amit Kapila wrote: > Yes, we need it to exclude any concurrent in-progress scans that could > return incorrect tuples during bucket squeeze operation. Thanks. So I assume that we should just set REGBUF_NO_CHANGE when the primary and write buffers are the

Re: Issues with Information_schema.views

2023-10-28 Thread jian he
On Sat, Oct 28, 2023 at 5:27 PM Erki Eessaar wrote: > > Hello > > > /*After that: is_updatable=YES*/ > > 1. Indeed, now I can execute INSERT/UPDATE/DELETE against the view without > getting an error. However, I still cannot change the data in the database > through the views.

Re: Is this a problem in GenericXLogFinish()?

2023-10-28 Thread Amit Kapila
On Fri, Oct 27, 2023 at 5:45 AM Michael Paquier wrote: > > On Thu, Oct 26, 2023 at 09:40:09AM -0400, Robert Haas wrote: > > Because of this, it is possible for bucketbuf, prevbuf, and wbuf to be > > the same (your first scenario) but the second scenario you mention > > (nextbuf == wbuf) should

Issues with Information_schema.views

2023-10-28 Thread Erki Eessaar
Hello The following was tested in a PostgreSQL (16) database. In my opinion queries based on Information_schema.views sometimes give unexpected results. CREATE TABLE Dept(deptno SMALLINT NOT NULL, dname VARCHAR(50) NOT NULL, CONSTRAINT pk_dept PRIMARY KEY (deptno)); CREATE TABLE Emp(empno

Re: Version 14/15 documentation Section "Alter Default Privileges"

2023-10-28 Thread Michael Banck
Hi, On Fri, Oct 27, 2023 at 05:49:42PM +0200, Laurenz Albe wrote: > On Fri, 2023-10-27 at 11:34 +0200, Michael Banck wrote: > > On Fri, Oct 27, 2023 at 09:03:04AM +0200, Laurenz Albe wrote: > > > On Fri, 2022-11-04 at 10:49 +0100, Laurenz Albe wrote: > > > > On Thu, 2022-11-03 at 11:32 +0100,

Re: [PoC] Improve dead tuple storage for lazy vacuum

2023-10-28 Thread John Naylor
I wrote: > Seems fine at a glance, thanks. I will build on this to implement > variable-length values. I have already finished one prerequisite which is: > public APIs passing pointers to values. Since my publishing schedule has not kept up, I'm just going to share something similar to what I

RE: pg_dump not dumping the run_as_owner setting from version 16?

2023-10-28 Thread Philip Warner
...patch actually attached this time... > > I as far as I can tell, pg_dump does not dup the ‘run_as_owner` setting for > > a subscription. > > > > Should it? Should I submit a patch? It seems pretty trivial to fix if > > anyone else is working on it. > > Yes, it certainly should.  That is an

Re: unnest multirange, returned order

2023-10-28 Thread Laurenz Albe
On Fri, 2023-10-27 at 16:08 -0700, Jeff Davis wrote: > On Fri, 2023-10-27 at 08:48 +0200, Laurenz Albe wrote: > > On Fri, 2023-10-13 at 15:33 -0400, Daniel Fredouille wrote: > > > sorry it took me some time to reply. Yes, the patch is perfect if > > > this is indeed the behavior. > > > > I'm

Re: Supporting MERGE on updatable views

2023-10-28 Thread jian he
hi. Excellent work! regress test passed! The code looks so intuitive! doc/src/sgml/ref/create_view.sgml. Do we need to add

Re: SQL:2011 application time

2023-10-28 Thread jian he
V16 patch doc/src/sgml/html/sql-createtable.html doc SET NULL description: ` SET NULL [ ( column_name [, ... ] ) ] Set all of the referencing columns, or a specified subset of the referencing columns, to null. A subset of columns can only be specified for ON DELETE actions. In a temporal foreign

RE: pg_dump not dumping the run_as_owner setting from version 16?

2023-10-28 Thread Philip Warner
> > I as far as I can tell, pg_dump does not dup the ‘run_as_owner` setting for > > a subscription. > > > > Should it? Should I submit a patch? It seems pretty trivial to fix if > > anyone else is working on it. > > Yes, it certainly should. That is an omission in 482675987b. > Go ahead and