On 17.11.23 19:39, Paul Jungwirth wrote:
But I feel the overall approach is wrong: originally I used hardcoded
"=" and "&&" operators, and you asked me to look them up by strategy
number instead. But that leads to trouble with core gist types vs
btree_gist types. The core gist opclasses use RT*
On Thu, Nov 09, 2023 at 02:39:26PM +0300, Nazir Bilal Yavuz wrote:
> There are some differences between pg_stat_wal and pg_stat_io while
> collecting WAL stats. For example in the XLogWrite() function in the
> xlog.c file, pg_stat_wal counts wal_writes as write system calls. This
> is not something
On 17.11.23 13:25, Amul Sul wrote:
To fix this we should be doing something like ALTER COLUMN TYPE and the pass
should be AT_PASS_ALTER_TYPE (rename it or invent a new one near to that) so
that in ATRewriteCatalogs(), we would execute ATPostAlterTypeCleanup().
I simply tried that by doing blind
On Sat, Oct 28, 2023 at 12:15:22PM +0800, jian he wrote:
> reindex_event_trigger_collect_relation called in
> ReindexMultipleInternal, ReindexTable (line 2979).
> Both are "under concurrent is false" branches.
>
> So it should be fine.
Sorry for the delay in replying.
Indeed, you're right. rein
On 17.11.23 19:53, Andres Freund wrote:
I pushed the first two commits (the selinux stuff) and worked a bit more on
the subsequent ones.
Patches 0001 through 0004 look good to me.
Some possible small tweaks in 0004:
+perl, '-ne', 'next if /^#/; print',
If you're going for super-brief mod
Hi,
While reviewing another patch I was looking at the walsender's static
function CreateReplicationSlot
I found that the current logic seemed to have some unnecessary if/else
checking which can be simplified.
~~
To summarise:
CURRENT
if (cmd->kind == REPLICATION_KIND_PHYSICAL)
{
...
}
else
On 16.11.23 02:07, Andres Freund wrote:
It doesn't seem like your patch has it quite that way? I see
MinGW
...
Windows
Where "Windows" actually seems to solely describe visual studio? That seems
confusing.
I had suggested this arrangement as a way to reduce churn in this patch
On Sun, Nov 19, 2023 at 1:24 PM Paul A Jungwirth
wrote:
>
> Thank you for continuing to review this submission! My changes are in
> the v18 patch I sent a few days ago. Details below.
>
> On Sun, Oct 29, 2023 at 5:01 PM jian he wrote:
> > * The attached patch makes foreign keys with PERIOD fail i
Hi
I was pondering replacing the is_include handling with returning an enum for
>> the operation, to keep things more future proof in case we add more
>> operations
>> (and also a bit less magic IMHO).
>>
>
> +1
>
I did it.
Regards
Pavel
>
> Pavel
>
>
>> --
>> Daniel Gustafsson
>>
>>
From 246
Here are some review comments for patch v15-0001
==
src/bin/pg_dump/pg_dump.c
1. getSubscriptions
+ if (fout->remoteVersion >= 17)
+ appendPQExpBufferStr(query, "o.remote_lsn AS suboriginremotelsn\n");
+ else
+ appendPQExpBufferStr(query, "NULL AS suboriginremotelsn\n");
+
There should
On 27/9/2023 14:28, Yuya Watari wrote:
Thank you for pointing it out. The ec_source_indexes and
ec_derive_indexes are just picked up from the previous patch, and I
have not changed their design. I think a similar approach to
EquivalenceMembers may be applied to RestrictInfos. I will experiment
wi
On Sun, Nov 19, 2023 at 12:39 PM Andrey M. Borodin wrote:
>
> I’ve skimmed through the patch set. Here are some minor notes.
Thanks for the review
>
> 1. Cycles “for (slotno = bankstart; slotno < bankend; slotno++)” in
> SlruSelectLRUPage() and SimpleLruReadPage_ReadOnly() now have identical
>
On Tue, Nov 14, 2023 at 7:21 AM vignesh C wrote:
>
> On Mon, 13 Nov 2023 at 13:52, Michael Paquier wrote:
> >
> > Anyway, after a closer lookup, I think that your conclusions regarding
> > the states that are allowed in the patch during the upgrade have some
> > flaws.
> >
> > First, are you sure
I test the V4 patch and found the backend does't process SIGINT while it's in
secure_read.
And it seems not a good choice to report ERROR during secure_read, which will
turns into
FATAL "terminating connection because protocol synchronization was lost".
It might be much easier to terminate the
On Fri, Nov 17, 2023 at 11:38 AM Tom Lane wrote:
> That line of argument also leads to the conclusion that it'd be
> okay to expose info about the ordering of the CTE result to the
> upper planner. This patch doesn't do that, and I'm not sufficiently
> excited about the issue to go write some co
I clicked "Trigger" to get a Mingw test run of this, and it failed[1].
I see why: our function win32_langinfo() believes that it shouldn't
call GetLocaleInfoEx() on non-MSVC compilers, so we see 'initdb:
error: could not find suitable encoding for locale "en-US"'. I think
it has fallback code that
2023年7月3日(月) 18:22 Peter Eisentraut :
>
> On 23.06.23 09:45, Ian Lawrence Barwick wrote:
> > if (!HeapTupleIsValid(tp))
> > + {
> > + ForeignServer *server = GetForeignServer(serverid);
> > +
> > ereport(ERROR,
> > (errcode(ERRCODE_U
(I am not exactly sure how, but we've lost pgsql-hackers on the way
when you sent v5. Now added back in CC with the two latest patches
you've proposed attached.)
Here is a short summary of what has been missed by the lists:
- I've commented that the patch should not create, not show up in
fields
On Mon, Nov 20, 2023 at 11:36 AM Tom Lane wrote:
> Thomas Munro writes:
> > BTW is this comment in snprintf.c true?
>
> > * 1. No locale support: the radix character is always '.' and the '
> > * (single quote) format flag is ignored.
>
> > It is in the backend but only because we nail down LC_
On Sun, Nov 19, 2023 at 06:56:05AM +0530, vignesh C wrote:
> On Sun, 19 Nov 2023 at 06:52, vignesh C wrote:
>> On Fri, 10 Nov 2023 at 19:26, vignesh C wrote:
>>> I will analyze more on this and post the analysis in the subsequent mail.
>>
>> I analyzed further and felt that retaining subscription
Another country has changed its name, and a Windows OS update has
again broken every PostgreSQL cluster in that whole country[1] (or at
least those that had accepted initdb's default choice of locale,
probably most). Let's get to the bottom of this, because otherwise it
is simply going to keep hap
Hi,
On Fri, 2023-11-17 at 16:10 -0800, Andres Freund wrote:
> > The requested name is already case-folded in most contexts. We can
> > do a
> > lookup first, and if that fails, case-fold and try again. I'll hack
> > up
> > a patch -- I believe that would be measurable for the proconfigs.
>
> I'd
Thomas Munro writes:
> BTW is this comment in snprintf.c true?
> * 1. No locale support: the radix character is always '.' and the '
> * (single quote) format flag is ignored.
> It is in the backend but only because we nail down LC_NUMERIC early
> on, not because of any property of snprintf.c,
On Sat, Nov 18, 2023 at 11:58 AM Tom Lane wrote:
> I wrote:
> > I've not reviewed this closely, but I did try it on mamba's host.
> > It compiles and passes regression testing, but I see two warnings:
>
> > common.c: In function 'PGTYPESsprintf':
> > common.c:120:2: warning: function 'PGTYPESsprin
On Fri, Nov 17, 2023 at 12:22 AM Heikki Linnakangas wrote:
> On 16/11/2023 01:08, Tom Lane wrote:
> > Heikki Linnakangas writes:
> >> On 09/03/2023 20:51, Tom Lane wrote:
> >>> After further thought that seems like a pretty ad-hoc solution.
> >>> We probably can do no better in the back branches,
I've pushed a cleaned up version of the fix.
I had to make some adjustments in the backbranches, because the way we
store the analyzed statistics evolved, and RemoveStatisticsById() used
to do everything. I ended up introducing RemoveStatisticsDataById() in
the backbranches too, but only as a stat
26 matches
Mail list logo
