Re: Addressing SECURITY DEFINER Function Vulnerabilities in PostgreSQL Extensions

2024-06-11 Thread Ashutosh Bapat
On Wed, Jun 12, 2024 at 9:51 AM Ashutosh Sharma wrote: > On Wed, Jun 12, 2024 at 9:35 AM Ashutosh Sharma > wrote: > > > > Hi Jeff, > > > > On Wed, Jun 12, 2024 at 3:07 AM Jeff Davis wrote: > > > > > > On Tue, 2024-06-11 at 15:24 +0530, Ashutosh Sharma wrote: > > > > 3) When the ALTER EXTENSION

Re: Vacuum statistics

2024-06-11 Thread Alena Rybakina
Hi! On 11.06.2024 16:09, Alena Rybakina wrote: On 08.06.2024 09:30, Alena Rybakina wrote: Iam currentlyworkingondividingthispatchintothreepartstosimplifythe reviewprocess:oneofthemwillcontaincodeforcollectingvacuumstatisticsontables,the secondonindexesandthe lastondatabases. I have divided

Re: Conflict Detection and Resolution

2024-06-11 Thread Amit Kapila
On Mon, Jun 10, 2024 at 5:12 PM Tomas Vondra wrote: > > On 6/10/24 10:54, Amit Kapila wrote: > > On Fri, Jun 7, 2024 at 6:08 PM Tomas Vondra > > wrote: > >> > >> On 5/27/24 07:48, shveta malik wrote: > >>> On Sat, May 25, 2024 at 2:39 AM Tomas Vondra > >>> wrote: > > Which architecture

RE: Partial aggregates pushdown

2024-06-11 Thread fujii.y...@df.mitsubishielectric.co.jp
Hi Jelte, Thank you for your comment! > From: Jelte Fennema-Nio > Sent: Tuesday, June 11, 2024 11:00 PM > How about instead of trying to serialize the output of serialfn/deserialfn, > instead we don't use the "internal" type and > create actual types in pg_type for these transtypes? Then we can

Re: Logical Replication of sequences

2024-06-11 Thread Dilip Kumar
On Tue, Jun 11, 2024 at 4:06 PM vignesh C wrote: > > Amit and I engaged in an offline discussion regarding the design and > contemplated that it could be like below: If I understand correctly, does this require the sequences to already exist on the subscribing node before creating the subscriptio

Re: Logical Replication of sequences

2024-06-11 Thread Masahiko Sawada
On Tue, Jun 11, 2024 at 7:36 PM vignesh C wrote: > > On Tue, 11 Jun 2024 at 12:38, Masahiko Sawada wrote: > > > > On Tue, Jun 11, 2024 at 12:25 PM vignesh C wrote: > > > > > > On Mon, 10 Jun 2024 at 14:48, Amit Kapila wrote: > > > > > > > > On Mon, Jun 10, 2024 at 12:43 PM Masahiko Sawada > >

Re: Conflict Detection and Resolution

2024-06-11 Thread Dilip Kumar
On Tue, Jun 11, 2024 at 7:44 PM Tomas Vondra wrote: > > Yes, that's correct. However, many cases could benefit from the > > update_deleted conflict type if it can be implemented reliably. That's > > why we wanted to give it a try. But if we can't achieve predictable > > results with it, I'm fine

Re: Addressing SECURITY DEFINER Function Vulnerabilities in PostgreSQL Extensions

2024-06-11 Thread Ashutosh Sharma
On Wed, Jun 12, 2024 at 9:35 AM Ashutosh Sharma wrote: > > Hi Jeff, > > On Wed, Jun 12, 2024 at 3:07 AM Jeff Davis wrote: > > > > On Tue, 2024-06-11 at 15:24 +0530, Ashutosh Sharma wrote: > > > 3) When the ALTER EXTENSION SET SCHEMA command is executed and if the > > > function's search_path cont

Re: Addressing SECURITY DEFINER Function Vulnerabilities in PostgreSQL Extensions

2024-06-11 Thread Ashutosh Sharma
Hi Jeff, On Wed, Jun 12, 2024 at 3:07 AM Jeff Davis wrote: > > On Tue, 2024-06-11 at 15:24 +0530, Ashutosh Sharma wrote: > > 3) When the ALTER EXTENSION SET SCHEMA command is executed and if the > > function's search_path contains the old schema of the extension, it > > is > > updated with the ne

Re: confirmed flush lsn seems to be move backward in certain error cases

2024-06-11 Thread Amit Kapila
On Tue, Jun 11, 2024 at 7:12 PM Tomas Vondra wrote: > > Sorry for not responding to this thread earlier (two conferences in two > weeks), but isn't the pushed fix addressing a symptom instead of the > actual root cause? > > Why should it be OK for the subscriber to confirm a flush LSN and then > l

Re: Skip collecting decoded changes of already-aborted transactions

2024-06-11 Thread Peter Smith
Hi, here are some review comments for your patch v4-0001. == contrib/test_decoding/sql/stats.sql 1. Huh? The test fails because the "expected results" file for these new tests is missing from the patch. == .../replication/logical/reorderbuffer.c 2. static void ReorderBufferTruncateTXN(

Re:Re: Re: Add support to TLS 1.3 cipher suites and curves lists

2024-06-11 Thread Erica Zhang
Hi Michael and Peter, Thanks a lot for the elaboration of the patch process for PG17.  It's really unfortunate missing the the development cycle of PG17. Just some context of why we hurry to try to catch up with PG17. There are certain government, financial and other enterprise organizations t

Re: 001_rep_changes.pl fails due to publisher stuck on shutdown

2024-06-11 Thread Kyotaro Horiguchi
At Tue, 11 Jun 2024 14:27:28 +0530, Amit Kapila wrote in > On Tue, Jun 11, 2024 at 12:34 PM Kyotaro Horiguchi > wrote: > > > > At Tue, 11 Jun 2024 11:32:12 +0530, Amit Kapila > > wrote in > > > Sorry, it is not clear to me why we failed to flush the last > > > continuation record in logical w

Re: Remove dependence on integer wrapping

2024-06-11 Thread Joseph Koshakow
On Tue, Jun 11, 2024 at 12:22 PM Nathan Bossart wrote: >I personally find that much easier to read. Since the existing open-coded >overflow check is apparently insufficient, I think there's a reasonably >strong case for centralizing this sort of thing so that we don't continue >t

Re: Postgresql OOM

2024-06-11 Thread Andres Freund
Hi, On 2024-06-07 21:42:58 +0300, Radu Radutiu wrote: > On Fri, Jun 7, 2024 at 7:59 PM Andres Freund wrote: > > On 2024-06-06 15:25:25 +0300, Radu Radutiu wrote: > > > I have a query that forces an out of memory error, where the OS will kill > > > the postgresql process. > > > > FWIW, it can be u

Re: RFC: adding pytest as a supported test framework

2024-06-11 Thread Noah Misch
On Mon, Jun 10, 2024 at 06:49:11PM -0700, Andres Freund wrote: > On 2024-06-10 16:46:56 -0400, Andrew Dunstan wrote: > > On 2024-06-10 Mo 16:04, Andres Freund wrote: > > > Just for context for the rest the email: I think we desperately need to > > > move > > > off perl for tests. The infrastructur

Re: Adding comments to help understand psql hidden queries

2024-06-11 Thread David Christensen
On Thu, Apr 4, 2024 at 11:12 AM David Christensen wrote: > > On Thu, Apr 4, 2024 at 9:32 AM Peter Eisentraut wrote: > > > > On 03.04.24 19:16, David Christensen wrote: > > > I removed _() in the output of the query/stars since there'd be no > > > sensible existing translations for the constructed

Re: Reuse child_relids in try_partitionwise_join was Re: Assert failure on bms_equal(child_joinrel->relids, child_joinrelids)

2024-06-11 Thread David Christensen
On Mon, Jun 10, 2024 at 8:15 AM Robert Haas wrote: > > On Mon, Jun 10, 2024 at 3:09 AM Ashutosh Bapat > wrote: > > This is just one instance of measurements. If I run the experiment multiple > > times the results and the patterns will vary. Usually I have found planning > > time to vary within

Re: Doc: fix a description regarding WAL summarizer on glossary page

2024-06-11 Thread Michael Paquier
On Tue, Jun 11, 2024 at 06:06:11PM +0900, Masahiro Ikeda wrote: > While searching the definition of auxiliary processes, I noticed that the > description of the WAL summarizer is incorrect. Additionally, I think it's > better to add a description for the WAL writer similar to other Auxiliary > proc

Re: Addressing SECURITY DEFINER Function Vulnerabilities in PostgreSQL Extensions

2024-06-11 Thread Jeff Davis
On Tue, 2024-06-11 at 15:24 +0530, Ashutosh Sharma wrote: > 3) When the ALTER EXTENSION SET SCHEMA command is executed and if the > function's search_path contains the old schema of the extension, it > is > updated with the new schema. I don't think it's reasonable to search-and-replace within a f

Re: Addressing SECURITY DEFINER Function Vulnerabilities in PostgreSQL Extensions

2024-06-11 Thread Jeff Davis
On Tue, 2024-06-11 at 14:56 +0200, Alexander Kukushkin wrote: > Now attackers can just set search_path for the current session. IIUC, the proposal is that only the function's "SET" clause can override the behavior, not a top-level SET command. Regards, Jeff Davis

Re: Track the amount of time waiting due to cost_delay

2024-06-11 Thread Imseih (AWS), Sami
>> I'm struggling to think of a scenario in which the number of waits would be >> useful, assuming you already know the amount of time spent waiting. Even >> if the number of waits is huge, it doesn't tell you much else AFAICT. I'd >> be much more likely to adjust the cost settings based on the per

Re: Keeping track of buildfarm animals' personality

2024-06-11 Thread Tom Lane
Thomas Munro writes: > On second thoughts, perhaps we always want to capture the uname > version, +1. Is there any reason not to capture "uname -a"? The configure-based animals are effectively doing that already. regards, tom lane

Re: Keeping track of buildfarm animals' personality

2024-06-11 Thread Thomas Munro
On Wed, Jun 12, 2024 at 8:29 AM Thomas Munro wrote: > For eg FreeBSD you can also have the kernel out of sync > with the user space but normally you wouldn't so I think that's good > enough. On second thoughts, perhaps we always want to capture the uname version, which is most likely about the ke

Re: small pg_dump code cleanup

2024-06-11 Thread Nathan Bossart
On Wed, Jun 05, 2024 at 01:58:54PM -0400, Tom Lane wrote: > Nathan Bossart writes: >> On Wed, Jun 05, 2024 at 12:22:03PM -0400, Neil Conway wrote: >>> (2) These functions malloc() a single ntups * sizeof(struct) allocation and >>> then index into it to fill-in each struct before entering it into t

Re: Keeping track of buildfarm animals' personality

2024-06-11 Thread Thomas Munro
On Wed, Jun 12, 2024 at 4:13 AM Andrew Dunstan wrote: > Way back in 2004 there was discussion of how we wanted to differentiate > buildfarm animals. We were flying blind to a large extent, as we didn't > have many similar things to compare to. We settled on {OS-name, > OS-version, Compiler-name, C

Re: confirmed flush lsn seems to be move backward in certain error cases

2024-06-11 Thread Tom Lane
Tomas Vondra writes: > Why should it be OK for the subscriber to confirm a flush LSN and then > later take that back and report a lower LSN? Seems somewhat against my > understanding of what "flush LSN" means. > The commit message explains this happens when the subscriber does not > need to do any

Re: Assertion failure in SnapBuildInitialSnapshot()

2024-06-11 Thread Alexander Lakhin
Hello, 01.02.2024 21:20, vignesh C wrote: The patch which you submitted has been awaiting your attention for quite some time now. As such, we have moved it to "Returned with Feedback" and removed it from the reviewing queue. Depending on timing, this may be reversible. Kindly address the feedb

Re: Track the amount of time waiting due to cost_delay

2024-06-11 Thread Robert Haas
On Tue, Jun 11, 2024 at 2:47 PM Nathan Bossart wrote: > I'm struggling to think of a scenario in which the number of waits would be > useful, assuming you already know the amount of time spent waiting. Even > if the number of waits is huge, it doesn't tell you much else AFAICT. I'd > be much mor

Re: Track the amount of time waiting due to cost_delay

2024-06-11 Thread Nathan Bossart
On Tue, Jun 11, 2024 at 06:19:23PM +, Imseih (AWS), Sami wrote: >> I'm not convinced that reporting the number of waits is useful. If we >> were going to report a possibly-inaccurate amount of actual waiting, >> then also reporting the number of waits might make it easier to figure >> out when

Re: Optimize numeric.c mul_var() using the Karatsuba algorithm

2024-06-11 Thread Aaron Altman
Hi Joel, thanks for posting this.  Although I have only a cursory familiarity with fast multiplication algorithms, I'd like to try and give it a review.  To start with, can you help me understand the choice of this algorithm versus others like Toom?  If this looks correct on a closer view I'll

Re: Track the amount of time waiting due to cost_delay

2024-06-11 Thread Imseih (AWS), Sami
> I'm not convinced that reporting the number of waits is useful. If we > were going to report a possibly-inaccurate amount of actual waiting, > then also reporting the number of waits might make it easier to figure > out when the possibly-inaccurate number was in fact inaccurate. But I > think it'

Re: Track the amount of time waiting due to cost_delay

2024-06-11 Thread Jan Wieck
On 6/11/24 13:13, Robert Haas wrote: On Tue, Jun 11, 2024 at 5:49 AM Bertrand Drouvot wrote: As we can see the actual wait time is 30ms less than the intended wait time with this simple test. So I still think we should go with 1) actual wait time and 2) report the number of waits (as mentioned

Re: Track the amount of time waiting due to cost_delay

2024-06-11 Thread Robert Haas
On Tue, Jun 11, 2024 at 5:49 AM Bertrand Drouvot wrote: > As we can see the actual wait time is 30ms less than the intended wait time > with > this simple test. So I still think we should go with 1) actual wait time and > 2) > report the number of waits (as mentioned in [1]). Does that make sens

Re: Improve the granularity of PQsocketPoll's timeout parameter?

2024-06-11 Thread Robert Haas
On Mon, Jun 10, 2024 at 5:39 PM Tom Lane wrote: > In [1] Dominique Devienne complained that PQsocketPoll would be > far more useful to him if it had better-than-one-second timeout > resolution. I initially pushed back on that on the grounds that > post-beta1 is a bit late to be redefining public

Re: Track the amount of time waiting due to cost_delay

2024-06-11 Thread Nathan Bossart
On Tue, Jun 11, 2024 at 07:25:11AM +, Bertrand Drouvot wrote: > So I think that in v2 we could: 1) measure the actual wait time instead, 2) > count the number of times the vacuum slept. We could also 3) reports the > effective cost limit (as proposed by Nathan up-thread) (I think that 3) could

Re: Improve the granularity of PQsocketPoll's timeout parameter?

2024-06-11 Thread Ranier Vilela
Em seg., 10 de jun. de 2024 às 18:39, Tom Lane escreveu: > In [1] Dominique Devienne complained that PQsocketPoll would be > far more useful to him if it had better-than-one-second timeout > resolution. I initially pushed back on that on the grounds that > post-beta1 is a bit late to be redefini

Re: Remove dependence on integer wrapping

2024-06-11 Thread Nathan Bossart
On Tue, Jun 11, 2024 at 09:31:39AM -0400, Joseph Koshakow wrote: > tmp is an uint16 here, it seems like you might have read it as an > int16? We would need some helper method like > > static inline bool > pg_neg_u16_overflow(uint16 a, int16 *result); > > and then we could replace

Keeping track of buildfarm animals' personality

2024-06-11 Thread Andrew Dunstan
Way back in 2004 there was discussion of how we wanted to differentiate buildfarm animals. We were flying blind to a large extent, as we didn't have many similar things to compare to. We settled on {OS-name, OS-version, Compiler-name, Compiler-version}. The idea was that the names would be inva

Re: use CREATE DATABASE STRATEGY = FILE_COPY in pg_upgrade

2024-06-11 Thread Nathan Bossart
On Tue, Jun 11, 2024 at 10:39:51AM +0200, Matthias van de Meent wrote: > On Tue, 11 Jun 2024 at 04:01, Nathan Bossart wrote: >> I did a handful of benchmarks on an r5.24xlarge that seem to prove your >> point. The following are the durations of the pg_restore step of >> pg_upgrade: >> >> * 10k em

Re: Trying out read streams in pgvector (an extension)

2024-06-11 Thread Jonathan S. Katz
On 6/11/24 12:53 AM, Thomas Munro wrote: Hi, I was looking around for an exotic index type to try the experience of streamifying an extension, ie out-of-core code. I am totally new to pgvector, but since everyone keeps talking about it, I could not avoid picking up some basic facts in the pgcon

Re: Windows: openssl & gssapi dislike each other

2024-06-11 Thread Dave Page
On Tue, 11 Jun 2024 at 12:22, Andrew Dunstan wrote: > > On 2024-06-11 Tu 05:19, Dave Page wrote: > > Hi > > On Sun, 9 Jun 2024 at 08:29, Imran Zaheer wrote: > >> Hi >> >> I am submitting two new patches. We can undefine the macro at two >> locations >> >> 1). As be-secure-openssl.c [1] was the a

Re: Proposal: Document ABI Compatibility

2024-06-11 Thread David E. Wheeler
On Jun 10, 2024, at 15:39, Andres Freund wrote: > That's 6 years ago, not sure we can really learn that much from that. > > And it's not like it's actually impossible, #ifdefs aren't great, but they are > better than nothing. Right, it’s just that extension authors could use some notification t

Re: RFC: adding pytest as a supported test framework

2024-06-11 Thread Jacob Champion
On Mon, Jun 10, 2024 at 12:26 PM Alexander Korotkov wrote: > Thank you for working on this. > Do you think you could re-use something from testgres[1] package? Possibly? I think we're all coming at this with our own bags of tricks and will need to carve off pieces to port, contribute, or reimplem

Re: RFC: adding pytest as a supported test framework

2024-06-11 Thread Jacob Champion
On Mon, Jun 10, 2024 at 1:04 PM Andres Freund wrote: > Just for context for the rest the email: I think we desperately need to move > off perl for tests. The infrastructure around our testing is basically > unmaintained and just about nobody that started doing dev stuff in the last 10 > years lear

Re: Conflict Detection and Resolution

2024-06-11 Thread Tomas Vondra
On 6/11/24 10:35, shveta malik wrote: > On Mon, Jun 10, 2024 at 5:24 PM Tomas Vondra > wrote: >> >> >> >> On 6/10/24 12:56, shveta malik wrote: >>> On Fri, Jun 7, 2024 at 6:08 PM Tomas Vondra >>> wrote: >>> >>> UPDATE >>> >>> >>> Conflict Detection Me

Re: Partial aggregates pushdown

2024-06-11 Thread Jelte Fennema-Nio
On Tue, 11 Jun 2024 at 13:40, fujii.y...@df.mitsubishielectric.co.jp wrote: > > From: Bruce Momjian > > So, we need import/export text representation for the partial aggregate > > mode for these eight, and call the base data type > > text import/export functions for the zero ones when in this mo

Re: ODBC Source Downloads Missing

2024-06-11 Thread Fahar Abbas
In case source code is not available, he can use the linked already shared. On Tuesday, June 11, 2024, Kashif Zeeshan wrote: > > > On Tue, Jun 11, 2024 at 4:52 PM Fahar Abbas > wrote: > >> Hello Mark, >> >> You can found psqlodbc on Link below >> >> https://www.postgresql.org/ftp/odbc/releases/

Re: ODBC Source Downloads Missing

2024-06-11 Thread Yogesh Sharma
On 6/10/24 15:33, Mark Hill wrote: Is there an issue with the ODBC Source downloads today? The source download URL isn’t working: https://www.postgresql.org/ftp/odbc/versions/src/ Thanks, Mark Here is github repo https://github.com/postgresql-interfaces/psqlodbc -- Kind Regards, Yogesh S

RE: ODBC Source Downloads Missing

2024-06-11 Thread Mark Hill
Thanks All! From: Kashif Zeeshan Sent: Tuesday, June 11, 2024 7:55 AM To: Fahar Abbas Cc: Mark Hill ; pgsql-hackers@lists.postgresql.org Subject: Re: ODBC Source Downloads Missing EXTERNAL On Tue, Jun 11, 2024 at 4:52 PM Fahar Abbas mailto:syed.fahar.ab...@gmail.com>> wrote: Hello Mark, Yo

Re: confirmed flush lsn seems to be move backward in certain error cases

2024-06-11 Thread Tomas Vondra
Hi, On 6/11/24 10:39, Amit Kapila wrote: > On Mon, Jun 10, 2024 at 7:24 PM vignesh C wrote: >> >> I have re-verified the issue by running the tests in a loop of 150 >> times and found it to be working fine. Also patch applies neatly, >> there was no pgindent issue and all the regression/tap test

Re: Revive num_dead_tuples column of pg_stat_progress_vacuum

2024-06-11 Thread Masahiko Sawada
On Fri, Jun 7, 2024 at 10:22 AM Masahiko Sawada wrote: > > On Wed, Jun 5, 2024 at 7:19 PM Andrey M. Borodin wrote: > > > > > > > > > On 4 Jun 2024, at 00:26, Masahiko Sawada wrote: > > > > Thank you! Vacuum enhancement is a really good step forward, and this small > > change would help a lot of

Re: Remove dependence on integer wrapping

2024-06-11 Thread Joseph Koshakow
>> /* check the negative equivalent will fit without overflowing */ >> if (unlikely(tmp > (uint16) (-(PG_INT16_MIN + 1)) + 1)) >> goto out_of_range; >> + >> + /* >> + * special case the minimum integer because its negation c

Re: Addressing SECURITY DEFINER Function Vulnerabilities in PostgreSQL Extensions

2024-06-11 Thread Ashutosh Sharma
Hi Alexander, On Tue, Jun 11, 2024 at 6:26 PM Alexander Kukushkin wrote: > > Hi, > > On Tue, 11 Jun 2024 at 14:50, Ashutosh Sharma wrote: >> >> If the author has configured the search_path for any desired function, >> using this option with the CREATE EXTENSION command will not affect >> those f

Re: Improve the granularity of PQsocketPoll's timeout parameter?

2024-06-11 Thread Ranier Vilela
Em seg., 10 de jun. de 2024 às 18:39, Tom Lane escreveu: > In [1] Dominique Devienne complained that PQsocketPoll would be > far more useful to him if it had better-than-one-second timeout > resolution. I initially pushed back on that on the grounds that > post-beta1 is a bit late to be redefini

Re: Addressing SECURITY DEFINER Function Vulnerabilities in PostgreSQL Extensions

2024-06-11 Thread Alexander Kukushkin
Hi, On Tue, 11 Jun 2024 at 14:50, Ashutosh Sharma wrote: > If the author has configured the search_path for any desired function, > using this option with the CREATE EXTENSION command will not affect > those functions. > Then effectively this feature is useless. Now attackers can just set searc

Re: Addressing SECURITY DEFINER Function Vulnerabilities in PostgreSQL Extensions

2024-06-11 Thread Ashutosh Sharma
Hi, On Tue, Jun 11, 2024 at 5:02 PM Jelte Fennema-Nio wrote: > > On Tue, 11 Jun 2024 at 11:54, Ashutosh Sharma wrote: > > 1) Extends the CREATE EXTENSION command to support a new option, SET > > SEARCH_PATH. > > > I don't think it makes sense to add such an option to CREATE EXTENSION. > I feel l

Re: Speed up JSON escape processing with SIMD plus other optimisations

2024-06-11 Thread David Rowley
Thanks for having a look. On Wed, 12 Jun 2024 at 00:08, Melih Mutlu wrote: > In 0001 patch, I see that there are some escape_json() calls with > NUL-terminated strings and gets the length by calling strlen(), like below: > >> - escape_json(&buf, "timestamp"); >> + escape_json(&buf, "timestamp",

Re: Speed up JSON escape processing with SIMD plus other optimisations

2024-06-11 Thread Andrew Dunstan
On 2024-06-11 Tu 08:08, Melih Mutlu wrote: Hi David, Thanks for the patch. In 0001 patch, I see that there are some escape_json() calls with NUL-terminated strings and gets the length by calling strlen(), like below: - escape_json(&buf, "timestamp"); + escape_json(&buf, "timestamp"

Re: Speed up JSON escape processing with SIMD plus other optimisations

2024-06-11 Thread Melih Mutlu
Hi David, Thanks for the patch. In 0001 patch, I see that there are some escape_json() calls with NUL-terminated strings and gets the length by calling strlen(), like below: - escape_json(&buf, "timestamp"); > + escape_json(&buf, "timestamp", strlen("timestamp")); Wouldn't using escape_json_c

Re: RFC: adding pytest as a supported test framework

2024-06-11 Thread Andrew Dunstan
On 2024-06-10 Mo 21:49, Andres Freund wrote: Hi, On 2024-06-10 16:46:56 -0400, Andrew Dunstan wrote: On 2024-06-10 Mo 16:04, Andres Freund wrote: Hi, Just for context for the rest the email: I think we desperately need to move off perl for tests. The infrastructure around our testing is bas

Re: ODBC Source Downloads Missing

2024-06-11 Thread Kashif Zeeshan
On Tue, Jun 11, 2024 at 4:52 PM Fahar Abbas wrote: > Hello Mark, > > You can found psqlodbc on Link below > > https://www.postgresql.org/ftp/odbc/releases/REL-16_00_0005/ > > He is talking about Source code whereas this link contains installer. Regards Kashif Zeeshan Bitnine Global > Kind Regar

Re: ODBC Source Downloads Missing

2024-06-11 Thread Fahar Abbas
Hello Mark, You can found psqlodbc on Link below https://www.postgresql.org/ftp/odbc/releases/REL-16_00_0005/ Kind Regards, Fahar Abbas On Tuesday, June 11, 2024, Mark Hill wrote: > Is there an issue with the ODBC Source downloads today? > > The source download URL isn’t working: https://www

RE: Partial aggregates pushdown

2024-06-11 Thread fujii.y...@df.mitsubishielectric.co.jp
Hi. Bruce. Sorry for the late. Thank you for comment. > From: Bruce Momjian > Sent: Wednesday, June 5, 2024 11:04 PM > > > * Passes unsafe binary data from the foreign server. > > > > > > Can someone show me where that last item is in the patch, and why > > > can't we just pass back values cast

RE: AIX support

2024-06-11 Thread Srirama Kucherlapati
Hi Laurenz, we are working on the other file changes, we shall post you the updates soon. Warm regards, Sriram.

Re: Addressing SECURITY DEFINER Function Vulnerabilities in PostgreSQL Extensions

2024-06-11 Thread Jelte Fennema-Nio
On Tue, 11 Jun 2024 at 11:54, Ashutosh Sharma wrote: > 1) Extends the CREATE EXTENSION command to support a new option, SET > SEARCH_PATH. I don't think it makes sense to add such an option to CREATE EXTENSION. I feel like such a thing should be part of the extension control file instead. That w

Re: Windows: openssl & gssapi dislike each other

2024-06-11 Thread Andrew Dunstan
On 2024-06-11 Tu 05:19, Dave Page wrote: Hi On Sun, 9 Jun 2024 at 08:29, Imran Zaheer wrote: Hi I am submitting two new patches. We can undefine the macro at two locations 1). As be-secure-openssl.c [1] was the actual file where the conflict happened so I undefined the m

Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY

2024-06-11 Thread Michail Nikolaev
Hello, hackers. While testing my work on (1) I was struggling with addressing a strange issue with ON CONFLICT UPDATE and REINDEX CONCURRENTLY. After some time, I have realized the same issue persists on the master branch as well :) I have prepared two TAP tests to reproduce the issues (2), also

Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop()

2024-06-11 Thread fujii.y...@df.mitsubishielectric.co.jp
Hi. Tender. > From: Tender Wang > Sent: Tuesday, June 11, 2024 5:11 PM > > > From: Tender Wang mailto:tndrw...@gmail.com> > > > Sent: Tuesday, June 4, 2024 7:51 PM > > Please add more tests. Especially please add some negative > tests; > > current patch chec

Re: Logical Replication of sequences

2024-06-11 Thread vignesh C
On Tue, 11 Jun 2024 at 12:38, Masahiko Sawada wrote: > > On Tue, Jun 11, 2024 at 12:25 PM vignesh C wrote: > > > > On Mon, 10 Jun 2024 at 14:48, Amit Kapila wrote: > > > > > > On Mon, Jun 10, 2024 at 12:43 PM Masahiko Sawada > > > wrote: > > > > > > > > On Mon, Jun 10, 2024 at 3:14 PM Masahiko

Re: Allow logical failover slots to wait on synchronous replication

2024-06-11 Thread Bertrand Drouvot
Hi, On Mon, Jun 10, 2024 at 09:25:10PM -0500, Nathan Bossart wrote: > On Mon, Jun 10, 2024 at 03:51:05PM -0700, John H wrote: > > The existing 'standby_slot_names' isn't great for users who are running > > clusters with quorum-based synchronous replicas. For instance, if > > the user has synchron

Re: Addressing SECURITY DEFINER Function Vulnerabilities in PostgreSQL Extensions

2024-06-11 Thread Ashutosh Sharma
On Thu, Jun 6, 2024 at 2:36 AM Jeff Davis wrote: > > On Wed, 2024-06-05 at 14:36 +0530, Ashutosh Sharma wrote: > > Thank you, Ashutosh, for the quick response. I've drafted a patch > > aimed at addressing this issue. The patch attempts to solve this > > issue by configuring the search_path for all

Re: Track the amount of time waiting due to cost_delay

2024-06-11 Thread Bertrand Drouvot
Hi, On Mon, Jun 10, 2024 at 05:58:13PM -0400, Robert Haas wrote: > I'm always suspicious of this sort of thing. I tend to find nothing > gives me the right answer unless I assume that the actual sleep times > are randomly and systematically different from the intended sleep > times but arbitrarily

Re: Conflict Detection and Resolution

2024-06-11 Thread Ashutosh Bapat
On Sat, Jun 8, 2024 at 3:52 PM Amit Kapila wrote: > On Fri, Jun 7, 2024 at 5:39 PM Ashutosh Bapat > wrote: > > > > On Thu, Jun 6, 2024 at 5:16 PM Nisha Moond > wrote: > >> > >> > > >> > >> Here are more use cases of the "earliest_timestamp_wins" resolution > method: > >> 1) Applications where t

Re: Windows: openssl & gssapi dislike each other

2024-06-11 Thread Dave Page
Hi On Sun, 9 Jun 2024 at 08:29, Imran Zaheer wrote: > Hi > > I am submitting two new patches. We can undefine the macro at two locations > > 1). As be-secure-openssl.c [1] was the actual > file where the conflict happened so I undefined the macro here before > the ssl includes. I changed the com

Doc: fix a description regarding WAL summarizer on glossary page

2024-06-11 Thread Masahiro Ikeda
Hi, While searching the definition of auxiliary processes, I noticed that the description of the WAL summarizer is incorrect. Additionally, I think it's better to add a description for the WAL writer similar to other Auxiliary processes. What do you think? # patch ``` diff --git a/doc/src/s

Re: Revisiting {CREATE INDEX, REINDEX} CONCURRENTLY improvements

2024-06-11 Thread Michail Nikolaev
Hello. I did the POC (1) of the method described in the previous email, and it looks promising. It doesn't block the VACUUM, indexes are built about 30% faster (22 mins vs 15 mins). Additional index is lightweight and does not produce any WAL. I'll continue the more stress testing for a while. A

Re: 001_rep_changes.pl fails due to publisher stuck on shutdown

2024-06-11 Thread Amit Kapila
On Tue, Jun 11, 2024 at 12:34 PM Kyotaro Horiguchi wrote: > > At Tue, 11 Jun 2024 11:32:12 +0530, Amit Kapila > wrote in > > Sorry, it is not clear to me why we failed to flush the last > > continuation record in logical walsender? I see that we try to flush > > the WAL after receiving got_STOPP

Re: use CREATE DATABASE STRATEGY = FILE_COPY in pg_upgrade

2024-06-11 Thread Matthias van de Meent
On Tue, 11 Jun 2024 at 04:01, Nathan Bossart wrote: > > On Fri, Jun 07, 2024 at 11:10:25AM +0200, Matthias van de Meent wrote: > > My primary concern isn't the IO, but the O(shared_buffers) that we > > have to go through during a checkpoint. As I mentioned upthread, it is > > reasonably possible t

Re: confirmed flush lsn seems to be move backward in certain error cases

2024-06-11 Thread Amit Kapila
On Mon, Jun 10, 2024 at 7:24 PM vignesh C wrote: > > I have re-verified the issue by running the tests in a loop of 150 > times and found it to be working fine. Also patch applies neatly, > there was no pgindent issue and all the regression/tap tests run were > successful. > Thanks, I have pushe

Re: Conflict Detection and Resolution

2024-06-11 Thread shveta malik
On Mon, Jun 10, 2024 at 5:24 PM Tomas Vondra wrote: > > > > On 6/10/24 12:56, shveta malik wrote: > > On Fri, Jun 7, 2024 at 6:08 PM Tomas Vondra > > wrote: > >> > > > > UPDATE > > > > > > Conflict Detection Method: > > >

Re: Track the amount of time waiting due to cost_delay

2024-06-11 Thread Bertrand Drouvot
Hi, On Tue, Jun 11, 2024 at 04:07:05PM +0900, Masahiko Sawada wrote: > Thank you for the proposal and the patch. I understand the motivation > of this patch. Thanks for looking at it! > Beside the point Nathan mentioned, I'm slightly worried > that massive parallel messages could be sent to the

Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop()

2024-06-11 Thread Tender Wang
fujii.y...@df.mitsubishielectric.co.jp < fujii.y...@df.mitsubishielectric.co.jp> 于2024年6月5日周三 09:26写道: > Hi. Tender. > > Thank you for modification. > > > From: Tender Wang > > Sent: Tuesday, June 4, 2024 7:51 PM > > Please add more tests. Especially please add some negative tests; > >

Re: Trying out read streams in pgvector (an extension)

2024-06-11 Thread Heikki Linnakangas
On 11/06/2024 07:53, Thomas Munro wrote: Someone involved in that project mentioned that it's probably not a great topic to research in practice, because real world users of HNSW use fully cached ie prewarmed indexes, because the performance is so bad otherwise. (Though maybe that argument is a

Re: Track the amount of time waiting due to cost_delay

2024-06-11 Thread Bertrand Drouvot
Hi, On Mon, Jun 10, 2024 at 05:58:13PM -0400, Robert Haas wrote: > On Mon, Jun 10, 2024 at 11:36 AM Nathan Bossart > wrote: > > Hm. Should we measure the actual time spent sleeping, or is a rough > > estimate good enough? I believe pg_usleep() might return early (e.g., if > > the process is sig

Re: 001_rep_changes.pl fails due to publisher stuck on shutdown

2024-06-11 Thread Kyotaro Horiguchi
At Tue, 11 Jun 2024 09:27:20 +0900, Michael Paquier wrote in > On Thu, Jun 06, 2024 at 03:19:20PM +0900, Kyotaro Horiguchi wrote: > > So, I believe the attached small patch fixes the behavior. I haven't > > come up with a good test script for this issue. Something like > > 026_overwrite_contreco

Re: Logical Replication of sequences

2024-06-11 Thread Masahiko Sawada
On Tue, Jun 11, 2024 at 12:25 PM vignesh C wrote: > > On Mon, 10 Jun 2024 at 14:48, Amit Kapila wrote: > > > > On Mon, Jun 10, 2024 at 12:43 PM Masahiko Sawada > > wrote: > > > > > > On Mon, Jun 10, 2024 at 3:14 PM Masahiko Sawada > > > wrote: > > > > > > > > On Fri, Jun 7, 2024 at 7:30 PM Am

Re: Track the amount of time waiting due to cost_delay

2024-06-11 Thread Masahiko Sawada
Hi, On Mon, Jun 10, 2024 at 3:05 PM Bertrand Drouvot wrote: > > Hi hackers, > > During the last pgconf.dev I attended Robert’s presentation about autovacuum > and > it made me remember of an idea I had some time ago: $SUBJECT > > Please find attached a patch doing so by adding a new field (aka

Re: 001_rep_changes.pl fails due to publisher stuck on shutdown

2024-06-11 Thread Kyotaro Horiguchi
At Tue, 11 Jun 2024 11:32:12 +0530, Amit Kapila wrote in > Sorry, it is not clear to me why we failed to flush the last > continuation record in logical walsender? I see that we try to flush > the WAL after receiving got_STOPPING in WalSndWaitForWal(), why is > that not sufficient? It seems tha