Re: Psql meta-command conninfo+

2024-09-15 Thread Hunaid Sohail
Hi, On Sat, Sep 14, 2024 at 10:50 PM Tom Lane wrote: > Alvaro Herrera writes: > > I don't understand why this is is printing half the information in > > free-form plain text and the other half in tabular format. All these > > items that you have in the free-form text lines should be part of th

Re: A starter task

2024-09-15 Thread Tony Wayne
FWIW, maybe it'd be better to start by looking at existing patches and do a bit of a review, learn how to apply/test those and learn from them. lets say i have experience in wal,physical replication,buffer management where can i find patches to review on these topics? regards Tony Wayne On Mon,

Re: Support LIKE with nondeterministic collations

2024-09-15 Thread Peter Eisentraut
Here is an updated patch. It is rebased over the various recent changes in the locale APIs. No other changes. On 30.07.24 21:46, Peter Eisentraut wrote: On 27.07.24 00:32, Paul A Jungwirth wrote: On Thu, Jun 27, 2024 at 11:31 PM Peter Eisentraut wrote: Here is an updated patch for this.

Re: Robocopy might be not robust enough for never-ending testing on Windows

2024-09-15 Thread Alexander Lakhin
Hello Thomas, 14.09.2024 23:32, Thomas Munro wrote: On Sun, Sep 15, 2024 at 1:00 AM Alexander Lakhin wrote: (That is, 0.1-0.2 MB leaks per one robocopy run.) I observed this on Windows 10 (Version 10.0.19045.4780), with all updates installed, but not on Windows Server 2016 (10.0.14393.0). Mor

Re: Allow logical failover slots to wait on synchronous replication

2024-09-15 Thread Amit Kapila
On Fri, Sep 13, 2024 at 3:13 PM shveta malik wrote: > > On Thu, Sep 12, 2024 at 3:04 PM shveta malik wrote: > > > > On Wed, Sep 11, 2024 at 2:40 AM John H wrote: > > > > > > Hi Shveta, > > > > > > On Sun, Sep 8, 2024 at 11:16 PM shveta malik > > > wrote: > > > > > > > > > > > I was trying to h

Re: Regression tests fail with tzdata 2024b

2024-09-15 Thread Tom Lane
Wolfgang Walther writes: > Tom Lane: >> Also, as a real place to a greater extent >> than "PST8PDT" is, it's more subject to historical revisionism when >> somebody turns up evidence of local law having been different than >> TZDB currently thinks. > I now tried all versions of tzdata which we ha

information_schema.view attgenerated

2024-09-15 Thread jian he
hi. one minor issue in src/backend/catalog/information_schema.sql /* * 6.22 * COLUMNS view */ CREATE VIEW columns CAST(CASE WHEN a.attgenerated = '' THEN pg_get_expr(ad.adbin, ad.adrelid) END AS character_data) AS column_default, can change to CAST(CASE WHEN a.attgenerated = '' AND a.atth

Re: Introduce XID age and inactive timeout based replication slot invalidation

2024-09-15 Thread Amit Kapila
On Tue, Sep 10, 2024 at 12:13 AM Bharath Rupireddy wrote: > > On Mon, Sep 9, 2024 at 3:04 PM Amit Kapila wrote: > > > > > > > > We should not allow the invalid replication slot to be altered > > > > > > irrespective of the reason unless there is any benefit. > > > > > > > > > > Okay, then I think

Re: POC, WIP: OR-clause support for indexes

2024-09-15 Thread Alena Rybakina
Hi! On 09.09.2024 13:36, Alexander Korotkov wrote: On Wed, Sep 4, 2024 at 6:42 PM Alena Rybakina wrote: On 04.09.2024 18:31, Alena Rybakina wrote: I rewrote the tests with integer types. Thanks for your suggestion. If you don't mind, I've updated the diff file you attached earlier to include

Re: ANALYZE ONLY

2024-09-15 Thread jian he
hi. in https://www.postgresql.org/docs/current/ddl-inherit.html <<< Commands that do database maintenance and tuning (e.g., REINDEX, VACUUM) typically only work on individual, physical tables and do not support recursing over inheritance hierarchies. The respective behavior of each individual comm

Re: SQL:2011 application time

2024-09-15 Thread Paul A Jungwirth
On Mon, Feb 12, 2024 at 3:55 AM Peter Eisentraut wrote: > Have you checked that the generated queries can use indexes and have > suitable performance? Do you have example execution plans maybe? This took longer than expected, but I wrote a long blog post about it here: https://illuminatedcomput

Re: A starter task

2024-09-15 Thread Tomas Vondra
On 9/16/24 00:32, Tom Lane wrote: > sia kc writes: >> About reply to all button, I think only sending to mailing list address >> should suffice. Why including previous recipients too? > > It's a longstanding habit around here for a couple of reasons: > > * The mail list servers are occasionally

Re: A starter task

2024-09-15 Thread Tom Lane
sia kc writes: > About reply to all button, I think only sending to mailing list address > should suffice. Why including previous recipients too? It's a longstanding habit around here for a couple of reasons: * The mail list servers are occasionally slow. (Our infrastructure is way better than

Re: A starter task

2024-09-15 Thread sia kc
I have a bad experience. I picked up a task from MariaDB backlog, explained in their chat rooms that I started doing that. After it was done which was a SQL command which MySQL already supported to restart server instance with SQL, they started rethinking the validity of the feature for the MariaDB

Re: how to speed up 002_pg_upgrade.pl and 025_stream_regress.pl under valgrind

2024-09-15 Thread Tom Lane
Thomas Munro writes: > (An interesting archeological detail about the regression tests is > that they seem to derive from the Wisconsin benchmark, famous for > benchmark wars and Oracle lawyers[1]. This is quite off-topic for the thread, but ... we actually had an implementation of the Wisconsin

Re: how to speed up 002_pg_upgrade.pl and 025_stream_regress.pl under valgrind

2024-09-15 Thread Thomas Munro
On Mon, Sep 16, 2024 at 6:31 AM Tom Lane wrote: > Really the way to fix those two tests would be to rewrite them to not > depend on the core regression tests. The core tests do a lot of work > that's not especially useful for the purposes of those tests, and it's > not even clear that they are ex

Re: A starter task

2024-09-15 Thread Tom Lane
Tomas Vondra writes: > Presumably a new contributor will start by discussing the patch first, > and won't waste too much time on it. Yeah, that is a really critical piece of advice for a newbie: no matter what size of patch you are thinking about, a big part of the job will be to sell it to the r

Re: A starter task

2024-09-15 Thread Tomas Vondra
On 9/15/24 22:43, Tom Lane wrote: > Tomas Vondra writes: >> I think you can take a look at https://wiki.postgresql.org/wiki/Todo and >> see if there's a patch/topic you would be interested in. It's really >> difficult to "assign" a task based on a single sentence, with no info >> about the person

Re: A starter task

2024-09-15 Thread sia kc
So isn't there something like Jira backlog to manage the tasks? My plan is to do some really small tasks like adding an option to a command but aim for harder ones like optimizer stuff. On Mon, Sep 16, 2024, 00:14 Tom Lane wrote: > Tomas Vondra writes: > > I think you can take a look at https:

Re: A starter task

2024-09-15 Thread Tomas Vondra
On 9/15/24 22:10, sia kc wrote: > I am reading the documents. Think the Todo list is what I needed thanks. > I think I should respond by sending my response to the mailing list but > not sure why gmail does not have such a button. Please correct me if I > am wrong. > I'm pretty sure gmail has "re

Re: A starter task

2024-09-15 Thread Tom Lane
Tomas Vondra writes: > I think you can take a look at https://wiki.postgresql.org/wiki/Todo and > see if there's a patch/topic you would be interested in. It's really > difficult to "assign" a task based on a single sentence, with no info > about the person (experience with other projects, etc.).

Re: A starter task

2024-09-15 Thread sia kc
I am reading the documents. Think the Todo list is what I needed thanks. I think I should respond by sending my response to the mailing list but not sure why gmail does not have such a button. Please correct me if I am wrong. On Sun, Sep 15, 2024 at 11:30 PM Tomas Vondra wrote: > On 9/15/24 21:4

Re: A starter task

2024-09-15 Thread Tomas Vondra
On 9/15/24 21:42, sia kc wrote: > Sorry I am not sure if I am doing this right. Should I look somewhere > else for tasks? > Hi, I think you can take a look at https://wiki.postgresql.org/wiki/Todo and see if there's a patch/topic you would be interested in. It's really difficult to "assign" a ta

Re: how to speed up 002_pg_upgrade.pl and 025_stream_regress.pl under valgrind

2024-09-15 Thread Tomas Vondra
On 9/15/24 20:31, Tom Lane wrote: > Tomas Vondra writes: >> [ 002_pg_upgrade and 027_stream_regress are slow ] > >> I don't have a great idea how to speed up these tests, unfortunately. >> But one of the problems is that all the TAP tests run serially - one >> after each other. Could we instead r

Re: A starter task

2024-09-15 Thread sia kc
Sorry I am not sure if I am doing this right. Should I look somewhere else for tasks? On Fri, Sep 13, 2024 at 7:57 PM sia kc wrote: > Can you lead me to a beginner friendly task so I can start hacking? > > -- > > Siavosh Kasravi > * "Save a Tree" - Please print this email only if necessary.* >

Re: Trim the heap free memory

2024-09-15 Thread Tom Lane
I wrote: > The single test case you showed suggested that maybe we could > usefully prod glibc to free memory at query completion, but we > don't need all this interrupt infrastructure to do that. I think > we could likely get 95% of the benefit with about a five-line > patch. To try to quantify

Re: how to speed up 002_pg_upgrade.pl and 025_stream_regress.pl under valgrind

2024-09-15 Thread Tom Lane
Tomas Vondra writes: > [ 002_pg_upgrade and 027_stream_regress are slow ] > I don't have a great idea how to speed up these tests, unfortunately. > But one of the problems is that all the TAP tests run serially - one > after each other. Could we instead run them in parallel? The tests setup > the

Re: Trim the heap free memory

2024-09-15 Thread Tom Lane
shawn wang writes: > I have successfully registered my patch for the commitfest. However, upon > integration, I encountered several errors during the testing phase. I am > currently investigating the root causes of these issues and will work on > providing the necessary fixes. I should think the

how to speed up 002_pg_upgrade.pl and 025_stream_regress.pl under valgrind

2024-09-15 Thread Tomas Vondra
Hi, I've been doing a lot of tests under valgrind lately, and it made me acutely aware of how long check-world takes. I realize valgrind is inherently expensive and slow, and maybe the reasonable reply is to just run a couple tests that are "interesting" for a patch ... Anyway, I did a simple exp

Re: Trim the heap free memory

2024-09-15 Thread shawn wang
Thank you for your valuable suggestion. I have successfully registered my patch for the commitfest. However, upon integration, I encountered several errors during the testing phase. I am currently investigating the root causes of these issues and will work on providing the necessary fixes. If you

Re: Regression tests fail with tzdata 2024b

2024-09-15 Thread Wolfgang Walther
Tom Lane: Also, as a real place to a greater extent than "PST8PDT" is, it's more subject to historical revisionism when somebody turns up evidence of local law having been different than TZDB currently thinks. I now tried all versions of tzdata which we had in tree back to 2018g, they all work