> On 8 Oct 2024, at 22:24, Andrew Dunstan wrote:
>
> On 2024-10-08 Tu 5:26 AM, Daniel Gustafsson wrote:
>>> On 8 Oct 2024, at 03:50, Erik Wienhold wrote:
Calling the import method of an unknown package produces a warning
[...]
It will also detect cases where a user passes an argum
On Sat, Sep 28, 2024 at 8:13 AM Melanie Plageman
wrote:
> For the top-level TableScanDescData, I suggest we use a union with the
> members of each scan type in it in anonymous structs (see 0001).
Just by the way, you can't use anonymous structs or unions in C99
(that was added to C11), but most c
> On 7 Oct 2024, at 20:42, Dagfinn Ilmari Mannsåker wrote:
>
> Tomas Vondra writes:
>
>> 3) unnecessary ListCell in DataChecksumsWorkerMain() on line 1345,
>> shadowing earlier variable
>
> All the ListCell variables can be eliminated by using the foreach_ptr
> and foreach_oid macros instead
On 2024-10-08 Tu 5:26 AM, Daniel Gustafsson wrote:
On 8 Oct 2024, at 03:50, Erik Wienhold wrote:
Calling the import method of an unknown package produces a warning
[...]
It will also detect cases where a user passes an argument when using a
package that does not provide its own import
[...]
Thank you for the introduction, Paul.
Hi all, I'm currently in the process of reviewing and analyzing Paul's patch.
In the meantime, I'm open to addressing any questions or feedback you may have.
> Hi all,
>
> I will be retiring from Intel at the end of this week. I wanted to introduce
> the
I wrote:
> ... There's still a question
> of whether reporting the whole script as the query is OK when
> we have a syntax error, but I have no good ideas as to how to
> make that terser.
I had an idea about this: we can use a pretty simple heuristic
such as "break at semicolon-newline sequences".
Hi.
The port function *bsearch_arg* mimics the C function
*bsearch*.
The API signature is:
void *
bsearch_arg(const void *key, const void *base0,
size_t nmemb, size_t size,
int (*compar) (const void *, const void *, void *),
void *arg)
So, the parameter *nmemb* is size_t.
Therefore, a call with
On Wed, Sep 25, 2024 at 01:05:26PM +0900, Michael Paquier wrote:
> On Tue, Sep 24, 2024 at 02:26:08PM -0500, Nathan Bossart wrote:
>> So... maybe we
>> should just remove pg_replication_origin's TOAST table instead...
>
> I'd rather keep it, FWIW. Contrary to pg_authid it does not imply
> problem
On 08.10.2024 18:49, Laurenz Albe wrote:
On Tue, 2024-10-08 at 18:12 +0300, Alena Rybakina wrote:
However you are right that this display will not appear for all
nodes that only contain a data collection procedure, such as Append,
MergeAppend, Gather, etc. And I agree with you that we should
in
Thank you for the corrections. I was busy recently and did not follow
conversations in the mailing list. Sorry about that.
--
With best regards,
Marat Bukharov
вт, 8 окт. 2024 г. в 17:24, Aleksander Alekseev :
>
> Hi,
>
> > I just glanced over this patch. Are you still planning on working on
> >
On Tue, Oct 8, 2024 at 9:25 AM Bertrand Drouvot
wrote:
>
> Hi,
>
> On Tue, Oct 08, 2024 at 04:25:29PM +1100, Peter Smith wrote:
> > Hi, here are some review comments for patch v11.
>
> Thanks for looking at it!
>
> > ==
> > contrib/pg_logicalinspect/specs/logical_inspect.spec
> >
> > 1.
> > ni
"Andrey M. Borodin" writes:
> IMO the patch looks RfC.
LGTM too. Pushed.
regards, tom lane
> On 8 Oct 2024, at 19:23, Aleksander Alekseev wrote:
>
> PFA patch v6.
IMO the patch looks RfC.
Best regards, Andrey Borodin.
Hi,
On Tue, 8 Oct 2024 at 00:55, Heikki Linnakangas wrote:
>
> On 05/10/2024 22:51, Dagfinn Ilmari Mannsåker wrote:
> > Heikki Linnakangas writes:
> >> Sadly Windows' IO::Socket::UNIX hasn't been implemented on Windows (or
> >> at least on this perl distribution we're using in Cirrus CI):
> >>
>
On Mon, Oct 7, 2024 at 6:41 PM Tom Lane wrote:
> I don't buy your argument that this case is so special that it
> warrants preserving disable_cost. I certainly didn't think it
> was special when I added it.
That's fair. I'm telling you what I think, not what you have to think. :-)
> There may b
Hi,
On 2024-10-08 18:11:39 +0200, Alvaro Herrera wrote:
> Oh and actually, we could change all these variables to be unsigned,
> since there's no use for negative inhcounts. The patch doesn't do that;
> it'd require changing the subtraction paths to use overflow-protected
> ops as well.
Unfortun
On Tue, Oct 8, 2024, at 03:48, Michael Paquier wrote:
> On Thu, Jun 13, 2024 at 07:34:30AM +0200, Joel Jacobson wrote:
>> Hmm, strange, the commitfest system didn't pick up the email with patch 0006
>> for some reason,
>> with message id 0c5a6b79-408c-4910-9b2e-4aa9a7b30...@app.fastmail.com
>>
>>
On Fri, Jul 5, 2024 at 12:47 PM Peter Geoghegan wrote:
> On HEAD, the following query requires 24 buffer hits (I'm getting a
> standard/forward index scan for this):
>
> select
> abalance
> from
> pgbench_accounts
> where
> aid in (1, 500, 1000, 1500, 2000, 3000) order by aid asc;
>
> Howeve
Alvaro Herrera writes:
> ... This is because ColumnDef->inhcount is a 32-bit int, but
> Form_pg_attribute->attinhcount is int16, so we didn't break the overflow
> test for ColumnDef inhcount, but attinhcount has overflowed during
> assignment.
Ugh ... somebody's ancient oversight there. Or maybe
On Tue, Oct 8, 2024 at 7:57 PM Julien Rouhaud wrote:
>
> Hi,
>
> I was looking at the CREATE FOREIGN TABLE documentation to see if IDENTITY
> columns were supported, and according to the doc they're not: only GENERATED
> ALWAYS AS ( expr ) STORED is supported.
>
> However, a quick test shows that
Hi,
On Tue, Oct 08, 2024 at 01:46:23PM +0900, Michael Paquier wrote:
> On Mon, Oct 07, 2024 at 09:54:21AM +, Bertrand Drouvot wrote:
> > On Fri, Sep 20, 2024 at 01:26:49PM +0900, Michael Paquier wrote:
> >> This would rely on the fact that we would use the ProcNumber for the
> >> dshash key, a
Hi,
On Tue, Oct 08, 2024 at 04:25:29PM +1100, Peter Smith wrote:
> Hi, here are some review comments for patch v11.
Thanks for looking at it!
> ==
> contrib/pg_logicalinspect/specs/logical_inspect.spec
>
> 1.
> nit - Add some missing spaces after commas (,) in the SQL.
Fine by me, done in
Per a review comment on the not-null constraint patch from Jian He, I
played a bit with the various inhcount variables in the tree, with this
simple test which creates a child table and 2^16+1 parents:
for i in `seq 1 $((2 ** 16+1))`; do echo "create table parent_$i (a int);";
done | psql
(echo
On Tue, 2024-10-08 at 18:12 +0300, Alena Rybakina wrote:
> > > However you are right that this display will not appear for all
> > > nodes that only contain a data collection procedure, such as Append,
> > > MergeAppend, Gather, etc. And I agree with you that we should
> > > information about it. I
On 07.10.2024 09:34, Guillaume Lelarge wrote:
We need granularity because we have granularity in the config. There
is pg_stat_database because it gives the whole picture and it is
easier to monitor. And then, there is pg_stat_statements to analyze
problematic statements. And finally there is pg
On 07.10.2024 03:41, Michael Paquier wrote:
On Mon, Oct 07, 2024 at 12:43:18AM +0300, Alena Rybakina wrote:
Maybe I'm not aware of the whole context of the thread and maybe my
questions will seem a bit stupid, but honestly
it's not entirely clear to me how this statistics will help to adjust the
On Tue, Oct 8, 2024 at 3:46 AM Antonin Houska wrote:
> Perhaps I understand now. I use getmail [2] to retrieve email messages from my
> Google account. What made me confused is that the getmail application,
> although installed on my workstation (and thus the bearer token it eventually
> gets cont
On 07.10.2024 19:02, Laurenz Albe wrote:
On Mon, 2024-10-07 at 10:17 +0300, Alena Rybakina wrote:
diff --git a/doc/src/sgml/perform.sgml b/doc/src/sgml/perform.sgml
index ff689b65245..db906841472 100644
--- a/doc/src/sgml/perform.sgml
+++ b/doc/src/sgml/perform.sgml
@@ -578,6 +578,28 @@ WHERE t
I took a look at v29-0006.
On Tue, Sep 17, 2024 at 05:02:49AM -0400, Corey Huinker wrote:
> From: Corey Huinker
> Date: Sat, 4 May 2024 04:52:38 -0400
> Subject: [PATCH v29 6/7] Add derivative flags dumpSchema, dumpData.
>
> User-set flags --schema-only and --data-only are often consulted by
> v
On Tue, Oct 08, 2024 at 01:19:52PM +0900, Michael Paquier wrote:
> On Tue, Oct 08, 2024 at 12:41:16PM +0900, Fujii Masao wrote:
>> One benefit of supporting something like pg_ls_summariesdir() is that
>> it allows us to view the last modification time of each WAL summary file
>> and estimate when t
Hi,
I was looking at the CREATE FOREIGN TABLE documentation to see if IDENTITY
columns were supported, and according to the doc they're not: only GENERATED
ALWAYS AS ( expr ) STORED is supported.
However, a quick test shows that this is supported (same as serial datatype),
and apparently behaves
Hi,
> I just glanced over this patch. Are you still planning on working on
> it? There's been no adjustments made since the last feedback you got
> in early August.
>
> Can you address Andrey's feedback on point #1?
>
> Also, for bytea_larger() and bytea_smaller(), I suggest copying what's
> been
On 08.10.2024 15:42, Fujii Masao wrote:
On 2024/09/30 12:26, Fujii Masao wrote:
In 0002.patch, I also modified the description of num_requested from
"Number of backend requested checkpoints" to remove "backend," as it can
be confusing since num_requested includes requests from sources other th
On Mon, Oct 7, 2024 at 5:06 PM jian he wrote:
> assume v40 is the latest version.
> in group_similar_or_args
> we can add a bool variable so
>
> boolmatched = false;
> foreach(lc, orargs)
> {
> if (match_index_to_operand(nonConstExpr, colnum, index))
> {
>
Hi, Jian!
Thank you for your feedback.
On Tue, Oct 8, 2024 at 8:12 AM jian he wrote:
>
> On Mon, Oct 7, 2024 at 10:06 PM jian he wrote:
> >
> > assume v40 is the latest version.
>
> make_bitmap_paths_for_or_group
> {
> /*
> * First, try to match the whole group to the one index.
>
Hi,
Le mar. 8 oct. 2024 à 09:29, Michael Paquier a écrit :
> On Mon, Oct 07, 2024 at 10:00:13AM +0200, Guillaume Lelarge wrote:
> > Le lun. 7 oct. 2024 à 02:18, Michael Paquier a
> écrit :
> >> I'd recommend to split that into more independent patches:
> >> - Introduce the two counters in EStat
Hi,
> I guess there are in fact two problems, not one.
>
> 1. Converting between bytea and integer types
> 2. Multibyte versions of get_byte() / set_byte()
>
> As you rightly pointed out, for (1) we just need to add missing casts.
> Here is the corresponding patch, v3-0001. Note that I couldn't re
On 10/8/24 04:05, Michael Paquier wrote:
> On Tue, Jul 30, 2024 at 11:05:56AM +0200, Tomas Vondra wrote:
>> I tried implementing this, see the attached 0002 patch that replaces the
>> fake LSN with an atomic counter in shared memory. It seems to work (more
>> testing needed), but I can't say I'm ve
On Tue, Oct 8, 2024 at 4:50 PM Richard Guo wrote:
>
> I ran into an "ERROR: variable not found in subplan target lists"
> error, which can be reproduced with the following query.
>
> create table t (a int primary key, b int);
> insert into t select i, i from generate_series(1, 10)i;
> analyze t;
On 2024-10-08 18:39, Fujii Masao wrote:
On 2024/10/07 21:51, torikoshia wrote:
While reviewing, I also noticed that the check for
"opts_out->binary && opts_out->on_error != COPY_ON_ERROR_STOP"
is similarly placed before setting the defaults, which might not
be correct. This check should probably
On 2024/09/30 12:26, Fujii Masao wrote:
In 0002.patch, I also modified the description of num_requested from
"Number of backend requested checkpoints" to remove "backend," as it can
be confusing since num_requested includes requests from sources other than
the backend. Thought?
Agreed. E.g. f
On Mon, 7 Oct 2024 15:45:54 -0400
Bruce Momjian wrote:
> On Mon, Sep 30, 2024 at 11:59:48AM +0200, Daniel Gustafsson wrote:
> > > On 30 Sep 2024, at 11:03, Tatsuo Ishii wrote:
> > >
> > I think there's an unnecessary underscore in config.sgml.
> > >
> > > I was wrong. The particular byte
Thanks Michael.
Em seg., 7 de out. de 2024 às 22:53, Michael Paquier
escreveu:
> On Tue, Jul 02, 2024 at 02:39:20PM -0300, Ranier Vilela wrote:
> > This is a series of patches to change styles, in assorted sources.
> > IMO, this improves a tiny bit and is worth trying.
> >
> > 1. Avoid dereferen
On 10/7/24 10:19, Guillaume Lelarge wrote:
I've done the split, but I didn't go any further than that.
Thank you Guillaume. I have done the rest of the reformatting
suggested by Michael but I decided to see If I have similar stuff
in my logging patch and refactor accordingly if needed before po
Hi Danile, Yugo,
>> On 8 Oct 2024, at 02:03, Tatsuo Ishii wrote:
>>> On Tue, 1 Oct 2024 22:20:55 +0900
>>> Yugo Nagata wrote:
>
>>> I've attached a updated patch.
>>> I added the comment to explain why Perl is used instead of grep or sed.
>>
>> Looks good to me. If there's no objection, I wil
I ran into an "ERROR: variable not found in subplan target lists"
error, which can be reproduced with the following query.
create table t (a int primary key, b int);
insert into t select i, i from generate_series(1, 10)i;
analyze t;
explain (costs off)
select 1 from t t1
left join
(t
On Mon, 7 Oct 2024 20:00:45 -0400
Bruce Momjian wrote:
> On Mon, Oct 7, 2024 at 07:25:11PM -0400, Bruce Momjian wrote:
> > > Yes. This change on CREATE INDEX was introduced by 2af07e2f7 together with
> > > other commands, but it was missed to be mentioned in the commit message
> > > although the
On Tue, Oct 8, 2024 at 3:38 PM Amit Kapila wrote:
>
> On Tue, Oct 8, 2024 at 2:25 PM shveta malik wrote:
> >
> > On Mon, Oct 7, 2024 at 4:03 PM vignesh C wrote:
> > >
> >
> > With parallel streaming as default, do you think there is a need to
> > increase the default for 'max_logical_replication
Jacob Champion wrote:
> On Mon, Sep 30, 2024 at 6:38 AM Antonin Houska wrote:
> >
> > Are you sure you can legitimately acquire the bearer token containing my
> > email
> > address?
>
> Yes. In general that's how OpenID-based "Sign in with "
> works. All those third-party services are running
On Mon, 7 Oct 2024 at 11:05, vignesh C wrote:
>
> Hi,
>
> By default, currently streaming of in-progress transactions for
> subscriptions is disabled. All transactions are fully decoded on the
> publisher before being sent to the subscriber. This approach can lead
> to increased latency and reduce
On Tue, Oct 8, 2024 at 2:25 PM shveta malik wrote:
>
> On Mon, Oct 7, 2024 at 4:03 PM vignesh C wrote:
> >
>
> With parallel streaming as default, do you think there is a need to
> increase the default for 'max_logical_replication_workers' as IIUC
> parallel workers are taken from the same pool.
Hello Noah,
04.10.2024 21:57, Noah Misch wrote:
That makes sense. Would you file this at
https://github.com/cpan-authors/IPC-Run/issues? I suppose that code should
become roughly:
do { $r = POSIX::read(...) } while (!defined($r) && $!{EINTR});
croak ... unless defined($r);
Just for r
On Wed, 31 Jul 2024 at 03:27, Masahiko Sawada wrote:
>
> On Wed, Jul 24, 2024 at 9:53 PM Amit Kapila wrote:
> >
> > On Wed, Jul 17, 2024 at 5:25 PM vignesh C wrote:
> > >
> > > On Wed, 17 Jul 2024 at 11:54, Amit Kapila wrote:
> > > >
> > > > On Tue, Jul 16, 2024 at 6:54 PM vignesh C wrote:
> >
On Tue, Oct 1, 2024 at 9:48 AM shveta malik wrote:
>
> On Mon, Sep 30, 2024 at 2:55 PM Peter Smith wrote:
> >
> > On Mon, Sep 30, 2024 at 4:29 PM shveta malik wrote:
> > >
> > > On Mon, Sep 30, 2024 at 11:04 AM Peter Smith
> > > wrote:
> > > >
> > > > On Mon, Sep 30, 2024 at 2:27 PM shveta mal
On Mon, Sep 30, 2024 at 11:59 AM shveta malik wrote:
>
> On Mon, Sep 30, 2024 at 11:04 AM Peter Smith wrote:
> >
> > On Mon, Sep 30, 2024 at 2:27 PM shveta malik wrote:
> > >
> > > On Fri, Sep 27, 2024 at 1:00 PM Peter Smith wrote:
> > ...
> > > >
> > > > 13. General - ordering of conflict_type
On 2024/10/07 21:51, torikoshia wrote:
While reviewing, I also noticed that the check for
"opts_out->binary && opts_out->on_error != COPY_ON_ERROR_STOP"
is similarly placed before setting the defaults, which might not
be correct. This check should probably be moved as well.
Additionally, the c
On Fri, Sep 27, 2024 at 1:00 PM Peter Smith wrote:
>
> Here are some review comments for v14-0001.
> ~~~
> 7.
> +ALTER SUBSCRIPTION name
> RESET CONFLICT RESOLVER FOR ( class="parameter">conflict_type)
>
> I can see that this matches the implementation, but I was wondering
> why don't you permit r
> On 8 Oct 2024, at 03:50, Erik Wienhold wrote:
>> Calling the import method of an unknown package produces a warning
>> [...]
>> It will also detect cases where a user passes an argument when using a
>> package that does not provide its own import
>> [...]
>
> Because we use fatal warnings, pgi
On 10/8/24 13:06, David Rowley wrote:
On Tue, 8 Oct 2024 at 18:47, Andrei Lepikhov wrote:
Thanks, I suppose CATALOG_VERSION_NO was the only reason for this fail.
Please leave the cat version bump out of your patch. It's a waste of
time and resource if you plan to post another patch every time
On Mon, Oct 7, 2024 at 4:03 PM vignesh C wrote:
>
With parallel streaming as default, do you think there is a need to
increase the default for 'max_logical_replication_workers' as IIUC
parallel workers are taken from the same pool.
thanks
Shveta
On Mon, Oct 7, 2024 at 7:39 AM Michael Paquier wrote:
> GOod point, this is confusing. The point is that having only
> stmt_location is not enough to detect where the element in the query
> you want to track is because it only points at its start location in
> the full query string. In an ideal
On Mon, Oct 7, 2024 at 3:22 PM Michael Paquier wrote:
>
> On Tue, Sep 10, 2024 at 05:11:13PM +1000, Peter Smith wrote:
> > I have rebased the two remaining patches. See v12 attached.
>
> I've looked over the patch set again, and applied 0002.
>
> 0001 could be more ambitious and more consistent, l
On Fri, Oct 4, 2024 at 9:11 PM Alvaro Herrera wrote:
>
> Here's v8 of this patch.
in AdjustNotNullInheritance
if (count > 0)
{
conform->coninhcount += count;
changed = true;
}
if (is_local)
{
conform->conislocal = true;
> On 8 Oct 2024, at 02:03, Tatsuo Ishii wrote:
>> On Tue, 1 Oct 2024 22:20:55 +0900
>> Yugo Nagata wrote:
>> I've attached a updated patch.
>> I added the comment to explain why Perl is used instead of grep or sed.
>
> Looks good to me. If there's no objection, I will commit this to
> master b
On Mon, Oct 07, 2024 at 10:00:13AM +0200, Guillaume Lelarge wrote:
> Le lun. 7 oct. 2024 à 02:18, Michael Paquier a écrit :
>> I'd recommend to split that into more independent patches:
>> - Introduce the two counters in EState with the incrementations done
>> in nodeGatherMerge.c and nodeGather.c
On Sun, Oct 6, 2024, at 15:12, Andrew Dunstan wrote:
> On 2024-10-04 Fr 12:19 PM, Joel Jacobson wrote:
>> 2. Avoid needing hacks like using E'\x01' as quoting char.
>>
>> Introduce QUOTE NONE and DELIMITER NONE,
>> to allow raw lines to be imported "as is" into a single text column.
>
> As I think
66 matches
Mail list logo
