Re: Forbid to DROP temp tables of other sessions

On Sat, 23 Nov 2024 at 21:13, Andrey M. Borodin wrote: > What if we say it's not a bug, but a feature. Will it break some contracts > with user or some functionality? An important thing to note here. We have to trade off an opportunity to significantly improve temp tables performance by removin

Re: POC, WIP: OR-clause support for indexes

On 11/25/24 14:08, Alexander Korotkov wrote: Hi, Richard! On Mon, Nov 25, 2024 at 8:28 AM Richard Guo wrote: On Thu, Nov 21, 2024 at 3:34 PM Alexander Korotkov wrote: I'm going to push this if no objections. Here is an Assert failure in match_orclause_to_indexcol. create table t (a int);

Re: per backend I/O statistics[

On Mon, Nov 25, 2024 at 07:12:56AM +, Bertrand Drouvot wrote: > Not sure here, could custom stats start incrementing before the database > system > is ready to accept connections? In theory, that could be possible. Like pg_stat_io currently, I am ready to assume that it likely won't matter m

Re: per backend I/O statistics

Hi, On Mon, Nov 25, 2024 at 10:06:44AM +0900, Michael Paquier wrote: > On Fri, Nov 22, 2024 at 07:49:58AM +, Bertrand Drouvot wrote: > > On Fri, Nov 22, 2024 at 10:36:29AM +0900, Michael Paquier wrote: > >> Hmm. created_entry only matters for pgstat_init_function_usage(). > >> All the other c

Re: POC, WIP: OR-clause support for indexes

Hi, Richard! On Mon, Nov 25, 2024 at 8:28 AM Richard Guo wrote: > On Thu, Nov 21, 2024 at 3:34 PM Alexander Korotkov > wrote: > > I'm going to push this if no objections. > > Here is an Assert failure in match_orclause_to_indexcol. > > create table t (a int); > create index on t (a); > > # expl

Re: POC, WIP: OR-clause support for indexes

On Thu, Nov 21, 2024 at 3:34 PM Alexander Korotkov wrote: > I'm going to push this if no objections. Here is an Assert failure in match_orclause_to_indexcol. create table t (a int); create index on t (a); # explain select * from t where a <= 0 or a <= 1; server closed the connection unexpectedl

Re: Consider pipeline implicit transaction as a transaction block

On Wed, Nov 20, 2024 at 06:03:12PM +0100, Anthonin Bonnefoy wrote: > 0001: This is a small bug I've stumbled upon. The query buffer is not > cleared on a backslash error. For example, "SELECT 1 \parse" would > fail due to a missing statement name but would leave "SELECT 1\n" in > the query buffer w

Re: Improve the error message for logical replication of regular column to generated column.

On Mon, Nov 25, 2024 at 8:50 AM Peter Smith wrote: > > 5. > As I reported above (#2), I think it is better to check for empty BMS > in the caller because then the code is easier to read. Also, you need > to comment on which of these 2 errors will take precedence because if > there are simultaneous

Re: Make COPY format extendable: Extract COPY TO format implementations

Hi, In <20241125.110620.313152541320718947@clear-code.com> "Re: Make COPY format extendable: Extract COPY TO format implementations" on Mon, 25 Nov 2024 11:06:20 +0900 (JST), Sutou Kouhei wrote: >> I've attached the v25 patches that squashed the minor changes I made >> in v24 and incorp

Re: UUID v7

HI Andrey M. Borodin It's not just mariadb, percona also implements the uuid plugin. https://docs.percona.com/percona-server/8.4/uuid-versions.html#functions-available-in-uuid_vx Thanks Andrey M. Borodin 于2024年11月23日周六 16:21写道： > > > > On 23 Nov 2024, at 10:58, Masahiko Sawada wrote: > >

Re: Introduce XID age and inactive timeout based replication slot invalidation

Hi Nisha, Here are my review comments for the patch v50-0001. == Commit message 1. In ReplicationSlotAcquire(), raise an error for invalid slots if caller specify error_if_invalid=true. /caller/the caller/ /specify/specifies/ == src/backend/replication/slot.c ReplicationSlotAcquire:

Re: Enhancing Memory Context Statistics Reporting

On Fri, Nov 22, 2024 at 6:33 PM Rahila Syed wrote: > > Hi, > >> How does the process know that the client backend has finished reading >> stats and it can be refreshed? What happens, if the next request for >> memory context stats comes before first requester has consumed the >> statistics it requ

Re: Skip collecting decoded changes of already-aborted transactions

Hi, Here are my review comments for patch v9-0001. These are only trivial nits for some code comments. Everything else looked good to me. == .../replication/logical/reorderbuffer.c ReorderBufferTruncateTXN: 1. + * The given transaction is marked as streamed if appropriate and the caller + *

Re: Add support for Tcl 9

Looks correct to me. TIPs 628[0] and 666[1] seem to be the proposals which added Tcl_Size and changed functions to use the type. Reviewed-by: Tristan Partin [0]: https://core.tcl-lang.org/tips/doc/trunk/tip/628.md [1]: https://core.tcl-lang.org/tips/doc/trunk/tip/666.md -- Tristan Partin Neon

Re: Support for NO INHERIT to INHERIT state change with named NOT NULL constraints

Thanks for the review comments. On Wed, Nov 20, 2024 at 9:13 AM jian he wrote: > On Thu, Nov 14, 2024 at 1:02 PM Suraj Kharage > wrote: > > > > Hi, > > > > Upstream commit 14e87ffa5c543b5f30ead7413084c25f7735039f added the > support for named NOT NULL constraints which are INHERIT by default. >

Re: Improve the error message for logical replication of regular column to generated column.

Hi Shubham, here are my review comments for patch v4-0001. == src/backend/replication/logical/relation.c logicalrep_report_missing_and_gen_attrs: 1. static void -logicalrep_report_missing_attrs(LogicalRepRelation *remoterel, - Bitmapset *missingatts) +logicalrep_report_missing_and_gen_attr

Re: Support for NO INHERIT to INHERIT state change with named NOT NULL constraints

-- Thanks & Regards, Suraj kharage, enterprisedb.com On Tue, Nov 19, 2024 at 6:52 PM jian he wrote: > On Fri, Nov 15, 2024 at 11:15 AM Robert Haas > wrote: > > > > On Thu, Nov 14, 2024 at 12:02 AM Suraj Kharage < > suraj.khar...@enterprisedb.com> wrote: > >>

Re: POC, WIP: OR-clause support for indexes

looking at it again. in match_orclause_to_indexcol /* Only the operator returning a boolean suits the transformation. */ if (get_op_rettype(opno) != BOOLOID) break; can change to if (subClause->opresulttype != BOOLOID) break; for saving some cycle

Re: Make COPY format extendable: Extract COPY TO format implementations

Hi, In "Re: Make COPY format extendable: Extract COPY TO format implementations" on Fri, 22 Nov 2024 13:01:06 -0800, Masahiko Sawada wrote: >> @@ -1237,7 +1219,7 @@ CopyReadLine(CopyFromState cstate, bool is_csv) >> /* >> * CopyReadLineText - inner loop of CopyReadLine for text mode >>

Re: Using Expanded Objects other than Arrays from plpgsql

On Tue, Nov 19, 2024 at 12:52 PM Michel Pelletier < pelletier.mic...@gmail.com> wrote: > On Tue, Nov 19, 2024 at 11:45 AM Tom Lane wrote: > >> Pavel Stehule writes: >> > another position can be src/test/modules - I think so your example is >> > "similar" to plsample >> >> Yeah. I think we've la

Re: Proper object locking for GRANT/REVOKE

On Fri, Nov 15, 2024 at 11:19:50AM +0100, Peter Eisentraut wrote: > On 11.11.24 08:53, Bertrand Drouvot wrote: > Thanks. I have applied your patch and then also mine with the appropriate > adjustments. commit d31bbfb wrote: > --- a/src/backend/catalog/aclchk.c > +++ b/src/backend/catalog/aclchk.

Re: per backend I/O statistics

On Fri, Nov 22, 2024 at 07:49:58AM +, Bertrand Drouvot wrote: > On Fri, Nov 22, 2024 at 10:36:29AM +0900, Michael Paquier wrote: >> Hmm. created_entry only matters for pgstat_init_function_usage(). >> All the other callers of pgstat_prep_pending_entry() pass a NULL >> value. > > I meant to s

Re: On non-Windows, hard depend on uselocale(3)

On Mon, Nov 25, 2024 at 1:43 PM Michael Paquier wrote: > On Sat, Nov 23, 2024 at 10:32:31AM +1300, Thomas Munro wrote: > > I realised that there is another aspect to this: it must be impossible > > to build PostgreSQL with the original MinGW/MSYS project by now. I > > don't understand the history

Re: On non-Windows, hard depend on uselocale(3)

On Sat, Nov 23, 2024 at 10:32:31AM +1300, Thomas Munro wrote: > I realised that there is another aspect to this: it must be impossible > to build PostgreSQL with the original MinGW/MSYS project by now. I > don't understand the history of the MinGW/MinGW-w64 fork, but if > they're both still live p

Re: Fix for Extra Parenthesis in pgbench progress message

Hi Fujii-san, > On 2024/11/08 11:47, Tatsuo Ishii wrote: >> I think you need to adjust >> fprintf(stderr, "%*c\r", chars - 1, ' '); /* Clear the current >> line */ >> to: >> fprintf(stderr, "%*c\r", chars, ' '); /* Clear the current >> line */ >> since now chars does

Re: Use or not record count on examples

On Sun, 24 Nov 2024 at 01:30, Marcos Pegoraro wrote: > There is no rule of when the number of records at the end of the lists should > be shown or not > Sometimes we show that line "(4 rows)", but sometimes not. > Should we have a standard for it ? Should we add them all or remove them all ? It

Re: Parallel CREATE INDEX for GIN indexes

On Tue, 8 Oct 2024 at 17:06, Tomas Vondra wrote: > > On 10/8/24 04:03, Michael Paquier wrote: > > > > _gin_parallel_build_main() is introduced in 0001. Please make sure to > > pass down a query ID. > > Thanks for the ping. Here's an updated patch doing that, and also fixing > a couple whitespace

Re: Missing INFO on client_min_messages

"David G. Johnston" writes: > On Sunday, November 24, 2024, Marcos Pegoraro wrote: >> If I try to set client_min_messages with a wrong value it raises an error >> and its hint is >> "Available values: debug5, debug4, debug3, debug2, debug1, log, notice, >> warning, error." >> Why is not INFO opti

Re: Missing INFO on client_min_messages

On Sunday, November 24, 2024, Marcos Pegoraro wrote: > If I try to set client_min_messages with a wrong value it raises an error > and its hint is > "Available values: debug5, debug4, debug3, debug2, debug1, log, notice, > warning, error." > > Why is not INFO option on this hint ? > The definiti

Re: Replace current implementations in crypt() and gen_salt() to OpenSSL

> On 23 Nov 2024, at 17:13, Joe Conway wrote: > I do wonder if the GUC should be PGC_POSTMASTER (as I had suggested it ought > to be in an earlier post) rather than PGC_SUSET (which was the way my posted > patch had it). But perhaps PGC_SUSET is sufficient, and it makes testing > easier. I co

Re: Reducing memory consumed by RestrictInfo list translations in partitionwise join planning

> On Thu, Oct 10, 2024 at 05:36:10PM GMT, Ashutosh Bapat wrote: > > 3. With just patch 0001 applied, planning time usually shows > degradation (column Q and X in planning time sheets) with or without > PWJ enabled. I first thought that it might be because of the increased > size of PlannerInfo. We

Missing INFO on client_min_messages

If I try to set client_min_messages with a wrong value it raises an error and its hint is "Available values: debug5, debug4, debug3, debug2, debug1, log, notice, warning, error." Why is not INFO option on this hint ? regards Marcos