Re: POC: enable logical decoding when wal_level = 'replica' without a server restart

2025-05-06 Thread Amit Kapila
On Thu, Apr 24, 2025 at 11:14 PM Masahiko Sawada wrote: > > On Thu, Apr 24, 2025 at 5:30 AM Amit Kapila wrote: > > > > On Wed, Apr 23, 2025 at 9:35 PM Masahiko Sawada > > wrote: > > > > > > On Wed, Apr 23, 2025 at 5:46 AM Amit Kapila > > > wrote: > > > > > > > > BTW, did we consider the idea

Re: MergeAppend could consider sorting cheapest child path

2025-05-06 Thread Alexander Pyhalov
Andrei Lepikhov писал(а) 2025-05-07 08:02: On 5/5/2025 15:56, Alexander Pyhalov wrote: Andrei Lepikhov писал(а) 2025-05-05 14:38: Also logic a bit differs if path is NULL. In get_cheapest_path_for_pathkeys_ext() we explicitly check for path being NULL, in get_cheapest_fractional_path_for_pathk

Re: Reduce "Var IS [NOT] NULL" quals during constant folding

2025-05-06 Thread Richard Guo
On Sat, May 3, 2025 at 7:48 PM Chengpeng Yan wrote: > I've been following the V4 patches (focusing on 1 and 2 for now): Patch 2's > preprocess_relation_rtes is a nice improvement for efficiently gathering > early catalog info like inh and attgenerated definitions in one pass. > > However, Patch

Re: disabled SSL log_like tests

2025-05-06 Thread Daniel Gustafsson
> On 7 May 2025, at 06:34, Tom Lane wrote: > > Thomas Munro writes: >> On Wed, May 7, 2025 at 1:18 PM Tom Lane wrote: >>> Anyone know anything about where to submit LibreSSL bugs? > >> I think it's done with sendbug on an OpenBSD box, or perhaps you can >> just write a normal email to the b...

Improve tab completion for COPY

2025-05-06 Thread torikoshia
Hi, I noticed that REJECT_LIMIT, an option available for COPY FROM, is not currently supported in psql's tab completion. Additionally, some options are only valid for COPY FROM or COPY TO, i.e. FREEZE, ON_ERROR, FORCE_QUOTE, but psql currently suggests them for both COPY FROM and COPY TO. As

Re: minor fix related to Auxiliary processes and IO workers

2025-05-06 Thread Cédric Villemain
On 07/05/2025 07:56, Michael Paquier wrote: On Wed, May 07, 2025 at 03:25:07AM +0200, Cédric Villemain wrote: Sure, modified this way. I have detected two more of these under NumProcSignalSlots and NumProcStateSlots. NUM_AUXILIARY_PROCS is adjusted in both cases with MAX_IO_WORKERS, which is

Re: PG 18 release notes draft committed

2025-05-06 Thread Richard Guo
On Fri, May 2, 2025 at 11:44 AM Bruce Momjian wrote: > > I have committd the first draft of the PG 18 release notes. > I will continue improving it until beta 1, and until the final release. > I will probably add markup in 1-3 weeks. Let the feedback begin. ;-) Thanks for working on these. I'

Re: minor fix related to Auxiliary processes and IO workers

2025-05-06 Thread Michael Paquier
On Wed, May 07, 2025 at 03:25:07AM +0200, Cédric Villemain wrote: > Sure, modified this way. I have detected two more of these under NumProcSignalSlots and NumProcStateSlots. NUM_AUXILIARY_PROCS is adjusted in both cases with MAX_IO_WORKERS, which is OK, but their comments were incorrect. Adjust

RE: Changing shared_buffers without restart

2025-05-06 Thread Jack Ng
> all the possible scenarios. But now I'm reworking it along the lines suggested > by Thomas, and will address those as well. Thanks! Thanks for the info, Dmitry. Just want to confirm my understanding of Thomas' suggestion and your discussions... I think the simpler and more portable solution goe

Re: MergeAppend could consider sorting cheapest child path

2025-05-06 Thread Andrei Lepikhov
On 5/5/2025 15:56, Alexander Pyhalov wrote: Andrei Lepikhov писал(а) 2025-05-05 14:38: Also logic a bit differs if path is NULL. In get_cheapest_path_for_pathkeys_ext() we explicitly check for path being NULL, in get_cheapest_fractional_path_for_pathkeys_ext() only after calculating sort cost.

Re: Fix slot synchronization with two_phase decoding enabled

2025-05-06 Thread shveta malik
On Mon, May 5, 2025 at 3:29 PM Nisha Moond wrote: > > Please find the v12 patch with above suggested changes. > Thanks for the patch. Few comments for doc changes: 1) func.sgml - pg_create_logical_replication_slot: +failover. The parameters twophase and +failover cannot be enabl

Re: disabled SSL log_like tests

2025-05-06 Thread Thomas Munro
On Wed, May 7, 2025 at 4:34 PM Tom Lane wrote: > Thanks, I'll look into reporting it tomorrow. In the meantime, > I couldn't help noticing that the backtraces went through > lib/libssl/tls13_legacy.c, which doesn't give a warm feeling > about how supported they think our usage is (and perhaps als

Incorrect calculation of path fraction value in MergeAppend

2025-05-06 Thread Andrei Lepikhov
Hi, Because there was no answer to the issue [1], I'll add it to the next commitfest. Feel free to reject it if my logic on choosing the merge append path is wrong. [1] https://www.postgresql.org/message-id/3ca271fa-ca5c-458c-8934-eb148622b...@gmail.com -- regards, Andrei Lepikhov

Re: disabled SSL log_like tests

2025-05-06 Thread Tom Lane
Thomas Munro writes: > On Wed, May 7, 2025 at 1:18 PM Tom Lane wrote: >> Anyone know anything about where to submit LibreSSL bugs? > I think it's done with sendbug on an OpenBSD box, or perhaps you can > just write a normal email to the b...@openbsd.org or > libre...@openbsd.org list, based on:

Re: regdatabase

2025-05-06 Thread Tom Lane
Nathan Bossart writes: > * Would anyone object if I put together some patches to add regdatabase? The original concept of the reg* types was to implement lookups for cases that are more complicated than "(SELECT oid FROM pg_foo WHERE fooname = 'whatever')". As an example, regprocedure would be s

Re: disabled SSL log_like tests

2025-05-06 Thread Thomas Munro
On Wed, May 7, 2025 at 1:18 PM Tom Lane wrote: > So it seems like this might be a simple oversight in > ssl_sigalg_pkey_ok(), which doesn't make any such correction: > > if (sigalg->key_type != EVP_PKEY_id(pkey)) > return 0; Nice detective work. > Anyone know anything abo

Re: PostgreSQL 18 Beta 1 release announcement draft

2025-05-06 Thread Jonathan S. Katz
On 5/6/25 9:15 AM, Álvaro Herrera wrote: On 2025-May-05, Jonathan S. Katz wrote: ### Other Highlights Starting with PostgreSQL 18, data checksums, which are used to validate the integrity of stored data, are now enabled by default on new PostgreSQL clusters. You can choose to disable this be

Re: PostgreSQL 18 Beta 1 release announcement draft

2025-05-06 Thread Jonathan S. Katz
On 5/6/25 11:55 AM, Andres Freund wrote: Hi, On 2025-05-05 15:07:01 -0400, Jonathan S. Katz wrote: ### Performance PostgreSQL 18 introduces an asynchronous I/O (AIO) subsystem using `io_uring` on Linux, which, when combined with direct I/O (DIO), lets PostgreSQL directly interface with storage

Re: PostgreSQL 18 Beta 1 release announcement draft

2025-05-06 Thread Jonathan S. Katz
On 5/6/25 11:17 AM, Nathan Bossart wrote: IMHO we should emphasize that MD5 password support will be removed in a future release and that users should migrate to something else soon. I'm imagining it'll still be at least a couple of years before I muster up the courage to actually propose remov

Re: Add time spent in posix_fadvise() in I/O read time ?

2025-05-06 Thread Cédric Villemain
On 19/03/2025 14:25, Frédéric Yhuel wrote: On 3/14/25 09:43, Frédéric Yhuel wrote: One thing I've noticed is that posix_fadvise(,,POSIX_FADV_WILLNEED) isn't always non-blocking on Linux. As Ted Ts'o explains in this old thread[1], it blocks when the request queue fills up. When posix_fadv

Re: PostgreSQL 18 Beta 1 release announcement draft

2025-05-06 Thread Andres Freund
Hi, On 2025-05-06 16:53:46 -0400, Bruce Momjian wrote: > On Tue, May 6, 2025 at 11:55:53AM -0400, Andres Freund wrote: > > On 2025-05-05 15:07:01 -0400, Jonathan S. Katz wrote: > > > ### Performance > > > > > > PostgreSQL 18 introduces an asynchronous I/O (AIO) subsystem using > > > `io_uring` on

Re: regdatabase

2025-05-06 Thread Nathan Bossart
On Wed, May 07, 2025 at 08:45:15AM +0900, Michael Paquier wrote: > For regdatabase, there would be at least two simplications related to > the dump of subscriptions, where we could switch the queries to the > new grammar for backend versions able to support the new grammar, > meaning that we could

Re: regdatabase

2025-05-06 Thread Nathan Bossart
On Wed, May 07, 2025 at 09:18:28AM +0900, Ian Lawrence Barwick wrote: > Hah, I put together a patch to implement just that a while back, but > then concluded > for some reason that it would likely be rejected so saved myself the > humiliation of > submitting it... > > Attaching patch for reference

Re: 2025-05-08 release announcement draft

2025-05-06 Thread Jonathan S. Katz
On 5/6/25 8:29 AM, Matthias van de Meent wrote: On Tue, 6 May 2025 at 05:32, Jonathan S. Katz wrote: Hi, Attached is the draft of the release announcement for the 2025-05-08 release. Please review for correctness and omissions. Please provide feedback no later than 2025-05-08 12:00 UTC. I

Allow database owners to CREATE EVENT TRIGGER

2025-05-06 Thread David G. Johnston
On Monday, April 28, 2025, Steve Chavez wrote: > > 1. Do `grant evtrig_owner to member with inherit false`, then `member` > will not be able to drop the event trigger. > I think they can still use set role… After getting my head around this, and re-reading what Tom said, I think you have the gr

Re: 2025-05-08 release announcement draft

2025-05-06 Thread Jonathan S. Katz
On 5/6/25 5:23 AM, jian he wrote: On Tue, May 6, 2025 at 11:32 AM Jonathan S. Katz wrote: Hi, Attached is the draft of the release announcement for the 2025-05-08 release. Please review for correctness and omissions. Please provide feedback no later than 2025-05-08 12:00 UTC. * Prevent fa

Re: PG 18 release notes draft committed

2025-05-06 Thread David Rowley
On Wed, 7 May 2025 at 13:17, Bruce Momjian wrote: > > On Wed, May 7, 2025 at 09:27:14AM +1200, David Rowley wrote: > > On Wed, 7 May 2025 at 07:44, Bruce Momjian wrote: > > A query such as: SELECT * FROM table_with_lots_of_partitions ORDER BY > > col; will plan much faster now. No joins there. >

Re: minor fix related to Auxiliary processes and IO workers

2025-05-06 Thread Cédric Villemain
On 07/05/2025 01:52, Michael Paquier wrote: On Tue, May 06, 2025 at 06:25:24PM +0200, Cédric Villemain wrote: @@ -353,7 +353,7 @@ typedef enum BackendType * Auxiliary processes. These have PGPROC entries, but they are not * attached to any particular database, and cannot run t

Re: disabled SSL log_like tests

2025-05-06 Thread Tom Lane
I wrote: > Yeah, I see that too. But I also see three failures in 002_scram.pl, > which presumably were there before e0f373ee. (Tested on OpenBSD 7.6 > and 7.7.) The buildfarm's OpenBSD animals haven't caught this > because they don't run this test suite :-(. I dug into this with gdb, and it se

Re: PG 18 release notes draft committed

2025-05-06 Thread Bruce Momjian
On Wed, May 7, 2025 at 09:27:14AM +1200, David Rowley wrote: > On Wed, 7 May 2025 at 07:44, Bruce Momjian wrote: > > I think what you are saying is that this has to do with partition > > processing of joins, but not the pruning process. I don't think a > > non-partition joins are likely to hit 3

Re: Allow database owners to CREATE EVENT TRIGGER

2025-05-06 Thread Steve Chavez
Isaac, > Can somebody remind me why triggers don't run as their owner in the first place? > It would make triggers way more useful, and eliminate the whole issue of trigger owners escalating to whomever tries to access the object on which the trigger is defined. Just noted this is already possibl

Re: regdatabase

2025-05-06 Thread Ian Lawrence Barwick
2025年5月7日(水) 4:29 Nathan Bossart : > > Every once in a while, I find myself wanting to use regdatabase for > something like current_database()::regdatabase, and I'm always surprised > when I inevitably rediscover that it doesn't exist. I only found one > reference to the idea in the archives [0].

Re: Adding skip scan (including MDAM style range skip scan) to nbtree

2025-05-06 Thread Mark Dilger
On Tue, May 6, 2025 at 3:01 PM Peter Geoghegan wrote: > > I plan to commit everything in the next couple of days, barring any > objections. > I have been using your two patches, one committed by you and the other committed locally to my working directory, since you posted them a few days ago. I

Re: Remove unnecessary "lmgr.h" in stat_utils.c

2025-05-06 Thread Michael Paquier
On Mon, May 05, 2025 at 04:33:20PM +0300, Ilia Evdokimov wrote: > While reviewing the import/export statistics, I noticed that relation > locking are handled via relation_open() and relation_close() in > stats_lock_check_privileges(), and no calls to other lock-manager routines > are actually used

Re: minor fix related to Auxiliary processes and IO workers

2025-05-06 Thread Michael Paquier
On Tue, May 06, 2025 at 06:25:24PM +0200, Cédric Villemain wrote: > @@ -353,7 +353,7 @@ typedef enum BackendType >* Auxiliary processes. These have PGPROC entries, but they are not >* attached to any particular database, and cannot run transactions or >* even take heavyweigh

Re: regdatabase

2025-05-06 Thread Michael Paquier
On Wed, May 07, 2025 at 07:28:02AM +0900, Tatsuo Ishii wrote: > I think regdatabase is a good idea. I've also found your reference from the lists of 2019 to be the only one referring to a regdatabase. If it means that I will type less by not having to do joins with pg_database, count me in. The

Re: queryId constant squashing does not support prepared statements

2025-05-06 Thread Michael Paquier
On Tue, May 06, 2025 at 01:32:48PM -0500, Sami Imseih wrote: > Without properly accounting for the boundaries of the list of expressions, > i.e., > the start and end positions of '(' and ')' or '[' and ']' and normalizing the > expressions in between, it will be very difficult for the normalizatio

Re: Large expressions in indexes can't be stored (non-TOASTable)

2025-05-06 Thread Michael Paquier
On Tue, May 06, 2025 at 11:41:49AM -0500, Nathan Bossart wrote: > I brought this up with the RMT, and everyone seemed okay with committing it > for v18. Cool, thanks for the update. > I can move it back to replorigin_create(). I don't have a strong opinion > here. I think that I would the check

Re: regdatabase

2025-05-06 Thread Tatsuo Ishii
> Every once in a while, I find myself wanting to use regdatabase for > something like current_database()::regdatabase, and I'm always surprised > when I inevitably rediscover that it doesn't exist. I only found one > reference to the idea in the archives [0]. So, I have two questions: > > * Is

Re: Adding skip scan (including MDAM style range skip scan) to nbtree

2025-05-06 Thread Peter Geoghegan
On Fri, May 2, 2025 at 3:04 PM Peter Geoghegan wrote: > I would like to commit the first patch later today, ahead of shipping > beta1. But the second patch won't make it into beta1. Committed the first patch last Friday. Attached is v2, whose 0002- bugfix patch is essentially unchanged compared

Prolonged truncation phase during vacuum on toast table with repeated interruptions by lock waiters and a proposed POC patch

2025-05-06 Thread Shayon Mukherjee
Hello hackers, I'd like to discuss an issue we observed where the truncation phase of autovacuum can become significantly prolonged on toast tables of busy systems due to repeated interruptions by lock waiters, leading to extended `AccessExclusiveLock` contention and impacting overall database & a

Re: PG 18 release notes draft committed

2025-05-06 Thread David Rowley
On Wed, 7 May 2025 at 07:44, Bruce Momjian wrote: > I think what you are saying is that this has to do with partition > processing of joins, but not the pruning process. I don't think a > non-partition joins are likely to hit 32 EquivalenceClasses. A query such as: SELECT * FROM table_with_lots_

Re: PG 18 release notes draft committed

2025-05-06 Thread Bruce Momjian
On Tue, May 6, 2025 at 10:13:36PM +0800, jian he wrote: > Add pg_dump options --with-schema, --with-data, and --with_statistics > (Jeff Davis) § > The negative versions of these options already existed. > > Add pg_dump option --sequence-data to dump sequence data that would > normally be excluded

Re: PostgreSQL 18 Beta 1 release announcement draft

2025-05-06 Thread Bruce Momjian
On Tue, May 6, 2025 at 11:55:53AM -0400, Andres Freund wrote: > Hi, > > On 2025-05-05 15:07:01 -0400, Jonathan S. Katz wrote: > > ### Performance > > > > PostgreSQL 18 introduces an asynchronous I/O (AIO) subsystem using > > `io_uring` on Linux, which, when combined with direct I/O (DIO), lets >

Re: PG 18 release notes draft committed

2025-05-06 Thread Bruce Momjian
On Tue, May 6, 2025 at 10:18:27PM +0800, jian he wrote: > Allow partitions to be pruned more efficienty (Ashutosh Bapat, Yuya > Watari, David Rowley) § § > typo, "efficienty" should be "efficiently"? Yes, fixed from other email report. My spellcheck filter was broken. -- Bruce Momjian

Re: PG 18 release notes draft committed

2025-05-06 Thread Bruce Momjian
On Tue, May 6, 2025 at 03:08:13PM +0900, Amit Langote wrote: > > I don't think most people would know what EquivalenceMember is, and even > > if they did, would they be able to connect it to an SQL query? > > Thanks for splitting these (cf847d634). I think the text for the > locking item should m

Re: queryId constant squashing does not support prepared statements

2025-05-06 Thread Sami Imseih
> > Without properly accounting for the boundaries of the list of expressions, > > i.e., > > the start and end positions of '(' and ')' or '[' and ']' and normalizing > > the > > expressions in between, it will be very difficult for the normalization to > > behave sanely. > > I don't think having

Re: POC: Parallel processing of indexes in autovacuum

2025-05-06 Thread Sami Imseih
> On Mon, May 5, 2025 at 5:21 PM Sami Imseih wrote: > > > > > >> On Sat, May 3, 2025 at 1:10 AM Daniil Davydov <3daniss...@gmail.com> wrote: > >> > > >> > On Sat, May 3, 2025 at 5:28 AM Masahiko Sawada > >> > wrote: > >> > > > >> > > > In current implementation, the leader process sends a signal

Re: PG 18 release notes draft committed

2025-05-06 Thread Bruce Momjian
On Tue, May 6, 2025 at 03:14:56PM +1200, David Rowley wrote: > On Tue, 6 May 2025 at 03:59, Bruce Momjian wrote: > > > > On Mon, May 5, 2025 at 09:42:10PM +1200, David Rowley wrote: > > > I agree that 88f55bc97 and d69d45a5a should be in their own item. > > > Likely no need to go into detail abo

Re: queryId constant squashing does not support prepared statements

2025-05-06 Thread Dmitry Dolgov
> On Tue, May 06, 2025 at 01:32:48PM GMT, Sami Imseih wrote: > > I also agree with Alvaro that this discussion doesn't justify a > > revert. If the pre-v18 behavior wasn't chiseled on stone tablets, > > the new behavior isn't either. We can improve it some more later. > > As I was looking further

regdatabase

2025-05-06 Thread Nathan Bossart
Every once in a while, I find myself wanting to use regdatabase for something like current_database()::regdatabase, and I'm always surprised when I inevitably rediscover that it doesn't exist. I only found one reference to the idea in the archives [0]. So, I have two questions: * Is there an eas

Re: queryId constant squashing does not support prepared statements

2025-05-06 Thread Sami Imseih
> I also agree with Alvaro that this discussion doesn't justify a > revert. If the pre-v18 behavior wasn't chiseled on stone tablets, > the new behavior isn't either. We can improve it some more later. As I was looking further into what we currently have in v18 and HEAD the normalization could b

Re: A thousand pg_commit_ts truncate attempts per second, two restarting autovacuum processes, and a explosive replication lag. Oh my.

2025-05-06 Thread Ian Axelrod
Thank you Laurenz, I figured there was a high chance this is an Aurora-specific issue. I do wonder if the replica lag itself is an Aurora-specific issue, though the replica-reconnect feature is definitely Aurora-specific. I will be in communication with AWS. On Tue, May 6, 2025 at 6:28 AM Laurenz

Re: [PoC] Federated Authn/z with OAUTHBEARER

2025-05-06 Thread Jacob Champion
On Sun, May 4, 2025 at 5:58 AM Wolfgang Walther wrote: > The only inconsistency I was able to find is the autoconf-generated > libpq.pc file, which has this: > >Requires.private: libssl, libcrypto libcurl Oh, I see what I did. Will fix, thanks. > I was only able to test the latter in an end-

Re: queryId constant squashing does not support prepared statements

2025-05-06 Thread Dmitry Dolgov
> On Tue, May 06, 2025 at 11:50:07PM GMT, Junwang Zhao wrote: > Would it make sense to rename `RecordConstLocation` to something like > `RecordExpressionLocation` instead? Yeah, naming is hard. RecordExpressionLocation is somehow more vague, but I see what you mean, maybe something along these lin

Re: Large expressions in indexes can't be stored (non-TOASTable)

2025-05-06 Thread Nathan Bossart
On Wed, Apr 30, 2025 at 09:57:46AM +0900, Michael Paquier wrote: > On Tue, Apr 29, 2025 at 02:01:54PM -0400, Tom Lane wrote: >> I'm inclined to argue that it's a bug fix and therefore still in-scope >> for v18. The fact that we can't back-patch such a change is all the >> more reason to not let it

Re: add --sequence-data to pg_dumpall

2025-05-06 Thread Nathan Bossart
On Wed, Apr 30, 2025 at 02:52:27PM -0500, Nathan Bossart wrote: > Since there's precedent, I'll plan on committing this in the next few days > unless someone objects. I've added the rest of the RMT to this thread, > too, just in case. I brought this up in the RMT meeting today, and everyone was f

minor fix related to Auxiliary processes and IO workers

2025-05-06 Thread Cédric Villemain
Hello Andres, I noticed a comment in "include/miscadmin.h" which might be need a fix: it states that there is a single auxiliary process of each kind running at once. However, with IO workers it's not true anymore I believe. See minor patch attached. --- Cédric Villemain +33 6 20 30 22 52 h

[PATCH] Fix references in comments, and sync up heap_page_is_all_visible() with heap_page_prune_and_freeze()

2025-05-06 Thread Gregory Burd
While working on [1] I found an outdated comment in heap_page_is_all_visible() and two other small fixes. 0001: Updates that comment so future authors know that this "stripped down function" should retain the logic in heap_page_prune_and_freeze(), not lazy_scan_prune() as was the case before 6d

Re: Small fixes needed by high-availability tools

2025-05-06 Thread Matthias van de Meent
On Fri, 2 May 2025 at 15:00, Andrey Borodin wrote: > > Hi hackers! > > I want to revive attempts to fix some old edge cases of physical quorum > replication. > > Please find attached draft patches that demonstrate ideas. These patches are > not actually proposed code changes, I rather want to ha

Re: PostgreSQL 18 Beta 1 release announcement draft

2025-05-06 Thread Andres Freund
Hi, On 2025-05-05 15:07:01 -0400, Jonathan S. Katz wrote: > ### Performance > > PostgreSQL 18 introduces an asynchronous I/O (AIO) subsystem using > `io_uring` on Linux, which, when combined with direct I/O (DIO), lets > PostgreSQL directly interface with storage interfaces. This new subsystem > g

Re: queryId constant squashing does not support prepared statements

2025-05-06 Thread Junwang Zhao
Hi Dmitry, On Sun, May 4, 2025 at 6:19 PM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > > On Thu, May 01, 2025 at 09:55:47PM GMT, Dmitry Dolgov wrote: > > > On Thu, May 01, 2025 at 09:29:13AM GMT, Michael Paquier wrote: > > > > > > I agree that the current solution we have in the tree feels inc

Re: doc pg_constraint.convalidated column description need update

2025-05-06 Thread Robert Treat
On Tue, May 6, 2025 at 4:49 AM jian he wrote: > > On Sat, May 3, 2025 at 11:42 PM Robert Treat wrote: > > As such, attached patch removes the above, and attempts some clean up > > of the documentation in ALTER TABLE to better clarify the behavior > > around valid/not valid, enforced/not enforced,

Re: PostgreSQL 18 Beta 1 release announcement draft

2025-05-06 Thread Nathan Bossart
On Mon, May 05, 2025 at 03:07:01PM -0400, Jonathan S. Katz wrote: > Before PostgreSQL 18, an important step after performing a major version > upgrade was to run the `ANALYZE` to generate statistics, which is a > critical component of helping PostgreSQL to select the most efficient > query plan. Ba

Re: PG 18 release notes draft committed

2025-05-06 Thread jian he
Allow partitions to be pruned more efficienty (Ashutosh Bapat, Yuya Watari, David Rowley) § § typo, "efficienty" should be "efficiently"?

Re: PG 18 release notes draft committed

2025-05-06 Thread jian he
On Fri, May 2, 2025 at 10:44 AM Bruce Momjian wrote: > > release-16: 206 > release-17: 182 > release-18: 209 > > I will continue improving it until beta 1, and until the final release. > I will probably add markup in 1-3 weeks. Let the feedback begin. ;-) > > You ca

Re: PostgreSQL 18 Beta 1 release announcement draft

2025-05-06 Thread Álvaro Herrera
On 2025-May-05, Jonathan S. Katz wrote: > ### Other Highlights > > Starting with PostgreSQL 18, data checksums, which are used to validate the > integrity of stored data, are now enabled by default on new PostgreSQL > clusters. You can choose to disable this behavior using the `initdb > --no-d

Re: 2025-05-08 release announcement draft

2025-05-06 Thread Matthias van de Meent
On Tue, 6 May 2025 at 05:32, Jonathan S. Katz wrote: > > Hi, > > Attached is the draft of the release announcement for the 2025-05-08 > release. Please review for correctness and omissions. > > Please provide feedback no later than 2025-05-08 12:00 UTC. I think this omits 459e7bf8e (aka 78cb2466f

Re: Add an option to skip loading missing publication to avoid logical replication failure

2025-05-06 Thread Amit Kapila
On Tue, May 6, 2025 at 3:33 PM Xuneng Zhou wrote: > > A clear benefit of addressing this in code is to ensure that the user sees > the log message, which can be valuable for trouble-shooting—even under race > conditions. > I don't think we can take that guarantee because if the Insert is concur

Re: A thousand pg_commit_ts truncate attempts per second, two restarting autovacuum processes, and a explosive replication lag. Oh my.

2025-05-06 Thread Laurenz Albe
On Mon, 2025-05-05 at 23:52 -0500, Ian Axelrod wrote: > This issue occurred on an AWS RDS Aurora PostgreSQL installation. Aurora is different from PostgreSQL. In particular, the query cancellation error you are showing does not occur in the PostgreSQL code base. So unless somebody who knows Auro

RE: Fix slot synchronization with two_phase decoding enabled

2025-05-06 Thread Zhijie Hou (Fujitsu)
On Mon, May 5, 2025 at 6:59 PM Amit Kapila wrote: > > On Sun, May 4, 2025 at 2:33 PM Masahiko Sawada > wrote: > > > > While I cannot be entirely certain of my analysis, I believe the root > > cause might be related to the backward movement of the confirmed_flush > > LSN. The following scenario se

Re: bug: virtual generated column can be partition key

2025-05-06 Thread Yura Sokolov
06.05.2025 13:31, jian he пишет: > On Tue, May 6, 2025 at 5:57 PM Yura Sokolov wrote: >> >> 21.04.2025 05:30, jian he пишет: >>> hi. >>> While trying to make the virtual generated column be part of the partition >>> key, >>> I found this bug. >>> it also influences the stored generated column, i

Re: bug: virtual generated column can be partition key

2025-05-06 Thread jian he
On Tue, May 6, 2025 at 5:57 PM Yura Sokolov wrote: > > 21.04.2025 05:30, jian he пишет: > > hi. > > While trying to make the virtual generated column be part of the partition > > key, > > I found this bug. > > it also influences the stored generated column, i added a test > > on generated_stored.

Re: Add an option to skip loading missing publication to avoid logical replication failure

2025-05-06 Thread Xuneng Zhou
Hi, A clear benefit of addressing this in code is to ensure that the user sees the log message, which can be valuable for trouble-shooting—even under race conditions. ereport(WARNING, errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),

Re: bug: virtual generated column can be partition key

2025-05-06 Thread Yura Sokolov
21.04.2025 05:30, jian he пишет: > hi. > While trying to make the virtual generated column be part of the partition > key, > I found this bug. > it also influences the stored generated column, i added a test > on generated_stored.sql. > > CREATE TABLE gtest_part_key ( > f1 date NOT NULL, f2 b

Re: RFC: Command Restrictions by INI file with Audit Logging (DROP/TRUNCATE/DELETE)

2025-05-06 Thread Daniel Gustafsson
> On 5 May 2025, at 23:37, Dagfinn Ilmari Mannsåker wrote: > Tom Lane writes: >> which for starters means you'd have to write your own parser. >> Something that might integrate better is JSON; we already have >> code for that, and use-cases such as backup manifest files. > > JSON isn't very hum

Re: 2025-05-08 release announcement draft

2025-05-06 Thread jian he
On Tue, May 6, 2025 at 11:32 AM Jonathan S. Katz wrote: > > Hi, > > Attached is the draft of the release announcement for the 2025-05-08 > release. Please review for correctness and omissions. > > Please provide feedback no later than 2025-05-08 12:00 UTC. > * Prevent failure in [`INSERT`](https:

Re: doc pg_constraint.convalidated column description need update

2025-05-06 Thread jian he
On Sat, May 3, 2025 at 11:42 PM Robert Treat wrote: > As such, attached patch removes the above, and attempts some clean up > of the documentation in ALTER TABLE to better clarify the behavior > around valid/not valid, enforced/not enforced, and how it affects > different constraints, with some ad

Re: encode/decode support for base64url

2025-05-06 Thread Pavel Seleznev
Hi, In the strings.sql file there is such code SELECT encode('\x69b73eff', 'base64'); -- Expected: abc+/w== In the strings.out file +SELECT encode('\x69b73eff', 'base64'); -- Expected: abc+/w== + encode +-- + abc+/w== +(1 row) + maybe you should remove the additional description of the e

Re: Changing shared_buffers without restart

2025-05-06 Thread Dmitry Dolgov
> On Tue, May 06, 2025 at 04:23:07AM GMT, Jack Ng wrote: > Thanks Dmitry. Right, the coordination mechanism in v4-0006 works as expected > in various tests (sorry, I misunderstood some details initially). Great, thanks for checking. > I also want to report a couple of minor issues found during t

Re: bug: virtual generated column can be partition key

2025-05-06 Thread jian he
I have added this thread and [1] into https://wiki.postgresql.org/wiki/PostgreSQL_18_Open_Items#Live_issues In case we've lost track of it. [1]: https://www.postgresql.org/message-id/CACJufxG5wLiATocRTaC%3Dz%2Bkw4mUaasC-50%2Bq9K%3DfOdAr3%3DOGRw%40mail.gmail.com

Re: Row pattern recognition

2025-05-06 Thread Tatsuo Ishii
>> Attached are the v30 patches, just adding a patch to change the >> default io_method parameter to sync, expecting this affects something >> to the recent CFbot failure. >> https://commitfest.postgresql.org/patch/4460/ >> https://cirrus-ci.com/task/6078653164945408 >> which is similar to: >> http

Re: POC: enable logical decoding when wal_level = 'replica' without a server restart

2025-05-06 Thread Bertrand Drouvot
Hi, On Mon, Apr 21, 2025 at 10:31:03AM -0700, Masahiko Sawada wrote: > I would like to discuss behavioral and user interface considerations. > > Upon further analysis of this patch regarding the conversion of > wal_level to a SIGHUP parameter, I find that supporting all > combinations of wal_leve