hi.
in src/backend/commands/policy.c, i found that
#include "access/htup.h"
#include "access/htup_details.h"
#include "catalog/catalog.h"
#include "nodes/pg_list.h"
#include "parser/parse_node.h"
#include "utils/array.h"
is not necessary "include", so I removed it.
we can also remove
#include "a
Hi,
On Tue, Oct 15, 2024 at 1:22 AM Jingtang Zhang wrote:
>
> I've been back to this patch for a while recently. I witness that if a WAL
> writer works fast, the already flushed WAL buffers will be zeroed out and
> re-initialized for future use by AdvanceXLInsertBuffer in
> XLogBackgroundFlush, s
Added to commitfest: https://commitfest.postgresql.org/patch/6056/
I'm having to carry this patch in all my development branches for now
or I can't build on one of my regular dev machines, so I'm quite keen
to get this into the tree soon and would back-patch to 16.
I gather no one else is affecte
On Sat, Sep 13, 2025 at 3:12 PM, Sophie Alpert wrote:
> And indeed, like I mentioned in my previous message, my isolation test
> `permutation tid1 tidsucceed2 c1 c2 read` from eval-plan-qual.spec in
> my patch will fail if Recheck were to return false in this case. Though
> somewhat contrived,
I quickly put together a patch for the stuff we've discussed in this
thread. WDYT?
--
nathan
>From 11289e1e69fc7c6fdbe5a73483efc2daf1197ec9 Mon Sep 17 00:00:00 2001
From: Nathan Bossart
Date: Mon, 8 Sep 2025 16:08:00 -0500
Subject: [PATCH v1 1/1] Fix shmem_startup_hook documentation.
---
doc/
On 9/12/25 2:18 PM, Masahiko Sawada wrote:
I found a typo;
s/gen_rand_uuid()/gen_random_uuid()/
Good catch - thanks!
Jonathan
OpenPGP_signature.asc
Description: OpenPGP digital signature
On Wed, Sep 10, 2025 at 3:41 PM Natalya Aksman wrote:
> Fantastic, the patch is working, it fixes our issue!
I pushed this patch just now.
Thanks
--
Peter Geoghegan
On Tue, Sep 9, 2025 at 10:18 PM, Chao Li wrote:
> No, that’s not true. If you extend David’s procedure and use 3 sessions to
> reproduce the problem, s1 update (0,1), s2 update (0,2) and s3 update (0,1)
> or (0,2), and trace the backend process of s3, you will see every time when
> TidRecheck(
Hi, Xuneng!
On Wed, Aug 27, 2025 at 6:54 PM Xuneng Zhou wrote:
> I did a rebase for the patch to v8 and incorporated a few changes:
>
> 1) Updated documentation, added new tests, and applied minor code
> adjustments based on prior review comments.
> 2) Tweaked the initialization of waitReplayLSNS
On Wed, Sep 3, 2025 at 2:25 AM Konstantin Knizhnik wrote:
> Do you suggest to replace `PageGetTempPage` with using local buffers?
> Or may be change `PageGetTempPage*` to accept parameter with provided
> local buffer?
I think that _bt_split could easily be switched over to using 2 local
PGAligned
On Tue, Jul 29, 2025 at 12:45 PM Oleg Tselebrovskiy
wrote:
> Thanks for your response!
>
> Your patch works with REL_17 & master, but not with REL_16, since there
> is no builtin provider
>
> So if we're going that route, for PostgreSQL 16 and older we could just
> use libc provider instead of bui
Tomas Vondra writes:
> On 9/10/25 22:35, Tom Lane wrote:
>> This is silently assuming that sizeof(SortItem) is a multiple of
>> alignof(Datum), which on a 32-bit-pointer platform is not true
>> any longer. We ought to MAXALIGN the two occurrences of
>> data->numrows * sizeof(SortItem).
> You're
On Fri, 2025-09-12 at 13:21 -0500, Nico Williams wrote:
> On Fri, Sep 12, 2025 at 10:11:59AM -0700, Jeff Davis wrote:
> > The name PG_UNICODE_FAST is meant to convey that it provides full
> > unicode semantics for case mapping and pattern matching, while also
> > being fast because it uses memcmp f
Robert Haas writes:
> But, I also can't commit either v4-0003 or v5-0003 or any variant
> thereof until we agree on what to do about 0001, and you're the
> holdout there.
Yeah, I owe you a review, hope to get to it over the weekend.
regards, tom lane
On 2025-Sep-12, Noah Misch wrote:
> The last argument gives the dump object on which the comment has a dependency.
> Since this is the case of a separately-dumped constraint, the comment needs to
> depend on that constraint (coninfo), not on the domain (tyinfo):
>
> -
From: Andrew kim
---
contrib/meson.build | 1 +
contrib/pg_checksum_bench/meson.build | 23 +
.../pg_checksum_bench--1.0.sql| 8 +
contrib/pg_checksum_bench/pg_checksum_bench.c | 34 +++
.../pg_checksum_bench.con
Hi Amit,
Really interesting proposal! I've been thinking through some of the
implementation challenges:
*On the memory side:* That hash table tracking RelationId and
ReplicaIdentity could get pretty hefty under load. Maybe bloom filters
could help with the initial screening? Also wondering
abo
> On Sep 11, 2025, at 9:36 PM, Michael Paquier wrote:
>
> On Thu, Sep 11, 2025 at 06:56:07AM -0400, Greg Burd wrote:
>> Just for reference I started this not to increase coverage, which is a good
>> goal just not the one I had. I was reviewing the API and considering some
>> changes based on ot
Hello Maxim!
On Thu, Sep 11, 2025 at 11:58 AM Maxim Orlov wrote:
>
> Once again, @ 8191e0c16a
Thank you for your work on this subject. Multixact members can really
grow much faster than multixact offsets, and avoiding wraparound just
here might make sense. At the same time, making multixact of
On Sat, Sep 13, 2025 at 2:32 AM Robert Haas wrote:
> We sort of got started down this path because, reviewing v4-0003,
> Richard commented that I might be able to sanity-check
> something-or-other about RTE_JOIN RTIs instead of just focusing on
> baserels. From there, this sub-thread has turned in
On Sat, Sep 13, 2025 at 12:08 AM Tom Lane wrote:
> After thinking about this for awhile, I believe that Richard and I
> each had half of the right solution ;-). Let me propose some new
> terminology in hopes of clarifying matters:
>
> * A join plan node "starts" an outer join if it performs the
>
On 13.09.2025 00:19, Tom Lane wrote:
Fixed (and tested) in the attached.
Great! Thank you.
> So that "else" action was unreachable, and the code failed
> to set "istemp" true for its own temp schema.
As for dropping my own temp schema, it's still a bit inconsistent (as it
was before):
Hi Amit,
On Fri, Sep 12, 2025 at 4:24 PM Amit Kapila wrote:
>
> On Fri, Sep 12, 2025 at 1:07 PM Ashutosh Sharma wrote:
> >
> > On Mon, Sep 8, 2025 at 9:52 AM Ashutosh Sharma
> > wrote:
> > >
> > > I think we can do that, since sync_skip_reason appears to be a
> > > descriptive metadata rather
On Fri, Sep 12, 2025 at 5:34 AM Richard Guo wrote:
> I really like this idea. Currently, aggtransspace represents an
> estimate of the transition state size provided by the aggregate
> definition. If it's set to zero, a default estimate based on the
> state data type is used. Negative values cu
Hi Hacker,
This is a follow up 991295f. I searched over the src/ and make all
ItemPointer arguments as const as much as possible.
I made clean build and no waring found. And "make check" also passes. I
will create a patch on CF to see if CI passes.
Best regards,
Chao Li (Evan)
--
On Sat, Sep 13, 2025 at 3:48 AM Robert Haas wrote:
> On Fri, Sep 12, 2025 at 5:34 AM Richard Guo wrote:
> > I really like this idea. Currently, aggtransspace represents an
> > estimate of the transition state size provided by the aggregate
> > definition. If it's set to zero, a default estimate
On Mon, Aug 25, 2025 at 3:47 PM Robert Haas wrote:
>
> 0001 is the core "private state" patch for PlannerGlobal, PlannerInfo,
> and RelOptInfo. It is unchanged since v2, and contains only the fix
> for memory context handling since v1. However, I've now tested it, and
> I think it's OK to commit,
On Tue, Jul 15, 2025 at 03:40:38PM +0200, Álvaro Herrera wrote:
> On 2025-Jul-15, jian he wrote:
> > we should let:
> > dumpConstraint handles dumping separate "NOT VALID" domain constraints along
> > with their comments.
> > dumpDomain: handles dumping "inlined" valid (not separate) domain
> > co
Hi Amit, Ashutosh,
On Fri, 12 Sept 2025 at 17:28, Ashutosh Sharma wrote:
>
> Hi Amit,
>
> On Fri, Sep 12, 2025 at 4:24 PM Amit Kapila wrote:
> >
> > On Fri, Sep 12, 2025 at 1:07 PM Ashutosh Sharma
> > wrote:
> > >
> > > On Mon, Sep 8, 2025 at 9:52 AM Ashutosh Sharma
> > > wrote:
> > > >
> >
29 matches
Mail list logo
