Fwd: Issue with logical replication slot during switchover

Hi, Here the generated v2 of the Patch. Thanks Fabrice On Mon, Sep 29, 2025 at 8:28 AM shveta malik wrote: > On Fri, Sep 26, 2025 at 9:52 PM Fabrice Chapuis > wrote: > > > > Hi Shveta, > > > > Here is the version 1 of the patch with corrections > > > > Thanks. We can bump the version to v2 n

Re: Suggestion to add --continue-client-on-abort option to pgbench

On Tue, 30 Sep 2025 13:46:11 +0900 Fujii Masao wrote: > On Tue, Sep 30, 2025 at 10:24 AM Yugo Nagata wrote: > > Fujii-san, thank you for committing the patch that fixes the assertion > > failure. > > I've attached the remaining patches so that cfbot stays green. > > Thanks for reattaching the

Re: GB18030-2022 Support in PostgreSQL

On Mon, Sep 29, 2025 at 5:36 PM Chao Li wrote: > “same file" was a mistake. windows-949-2000.ucm is a different file from > gb-18030-2000(2022).ucm. > > In theory, we don’t need to change UHC if our goal is to delete > gb-18030-2000.xml. That was my goal, yes. Let's stay focused on that and not

Re: POC: enable logical decoding when wal_level = 'replica' without a server restart

On Tue, Sep 30, 2025 at 7:28 AM Masahiko Sawada wrote: > > On Thu, Sep 25, 2025 at 10:43 PM shveta malik wrote: > > > > On Fri, Sep 26, 2025 at 12:46 AM Masahiko Sawada > > wrote: > > > > > > On Thu, Sep 25, 2025 at 4:57 AM shveta malik > > > wrote: > > > > > > > > On Tue, Sep 23, 2025 at 3:2

Re: [PATCH] Fix pg_rewind false positives caused by shutdown-only WAL

Dear Robert. With regard to the mail, I firstly apologise for the confusion created regarding authorship. The patch was developed as part of my work in my official email id and the patch was committed under my personal GitHub account during collaborative development. Going forward, I will make sur

Re: Fixing MSVC's inability to detect elog(ERROR) does not return

On 27.09.25 12:43, David Rowley wrote: On Wed, 17 Sept 2025 at 15:52, David Rowley wrote: Updated patch attached. Thanks for the review. Now pushed and awaiting buildfarm feedback. Cool, seems to work. I also tried it on CI by removing a few "silence compiler warning" lines. Quick foll

Re: pgstattuple "unexpected zero page" for gist and hash indexes

On Mon, Sep 29, 2025 at 9:03 AM Dilip Kumar wrote: > > I observed that pgstat_btree_page() incorporates the count of new > pages into its free space calculation[1]. Does it make sense to do the > same for hash and gist as well as we are leaning towards making these > consistent. > > [1] > if (Page

Re: Skipping schema changes in publication

On Mon, 29 Sept 2025 at 08:58, Peter Smith wrote: > > Hi Shlok, > > I was looking at the recent v24 changes. > > == > GENERAL. > > I saw that you modified the system view to add a new flag: > > + > + > + exceptcol bool > + > + > + True if a column list with E

Re: Support getrandom() for pg_strong_random() source

On Mon, Sep 29, 2025 at 11:01 PM Michael Paquier wrote: > > On Mon, Sep 29, 2025 at 03:15:37PM -0700, Jacob Champion wrote: > > I'm wary of letting unprivileged users switch this implementation. I > > think our developers should be allowed to treat the user as an > > adversary when developing feat

Re: Support getrandom() for pg_strong_random() source

On Mon, Sep 29, 2025 at 03:15:37PM -0700, Jacob Champion wrote: > I'm wary of letting unprivileged users switch this implementation. I > think our developers should be allowed to treat the user as an > adversary when developing features on top of pg_strong_random(), and > it doesn't make sense for

Re: [PATCH] Add tests for Bitmapset

On Tue, Sep 30, 2025 at 01:19:05PM +1300, David Rowley wrote: > NULL is a valid Bitmapset, so I don't really see the need to check for > an empty set before calling bms_free(). If those were removed, then > you'd not have to care about the coverage of that line. Yeah, we could just remove them as

Re: allow benign typedef redefinitions (C11)

Hello, I was thinking about your (Tom's) idea of having some sort of header inclusion policy. Our current situation is that cross-module inclusions are quite widespread and the dependencies can probably be seen as a tight web (modules probably being defined as our subdirectories inside src/includ

Re: Skipping schema changes in publication

On Sat, 27 Sept 2025 at 01:20, Shlok Kyal wrote: > > Thanks for reviewing the patch. > I have addressed the comments and attached the updated version. If all columns are excluded, we do not publish the changes. However, when a table has no columns, the data is still replicated. Should we make thi

Re: test_json_parser/002_inline is kind of slow

On Mon, Sep 29, 2025 at 8:11 AM Robert Haas wrote: > I don't have a clear explanation for that slowness either, but the > patch cuts down the runtime by 89% on my machine. Nice! I'll clean this up, and put a rewrite on the back burner for now. Thanks everyone for the testing, and thanks Andres fo

Re: Bypassing cursors in postgres_fdw to enable parallel plans

Hello hackers, I am back at this work with a rebased and revised patch. The new version is rebased and has a change in approach. Whenever we are using non-cursor mode, for the first cursor we are always saving the tuples in the tuplestore, this is because we do not have any means to know beforehan

Remove unused parameter form find_window_run_conditions()

Hi, Reading find_window_run_conditions() the RangeTableEntry *rte parameter is not being used by find_window_run_conditions() and check_and_push_window_quals(). The attached patch remove this parameter from both functions. The 4be9024d573 also remove unused parameter for both functions and after