Re: Implement waiting for wal lsn replay: reloaded

2025-11-01 Thread Xuneng Zhou
Hi, Alexander! On Thu, Oct 23, 2025 at 8:58 PM Xuneng Zhou wrote: > > Hi, > > On Thu, Oct 23, 2025 at 6:46 PM Alexander Korotkov > wrote: > > > > Hi! > > > > In Thu, Oct 16, 2025 at 10:12 AM Xuneng Zhou wrote: > > > On Wed, Oct 15, 2025 at 8:48 PM Xuneng Zhou wrote: > > > > > > > > Hi, > > >

Re: [PATCH] Add Windows support for backtrace_functions (MSVC only)

2025-11-01 Thread Bryan Green
On 11/1/2025 9:31 AM, Euler Taveira wrote: On Sat, Nov 1, 2025, at 1:40 AM, Bryan Green wrote: v5 patch attached, incorporating all of Euler's feedback with a caveat around unicode. Thanks for sharing another patch. Thanks for the continued review. v6 patch attached with your latest sugg

Re: [PG19-3 PATCH] Don't ignore passfile

2025-11-01 Thread Paul Ohlhauser
Did my previous two messages make sense to you guys? >

Re: Channel binding for post-quantum cryptography

2025-11-01 Thread Michael Paquier
On Fri, Oct 31, 2025 at 10:26:01AM +0100, Filip Janus wrote: > While fixing the actual issue will take some time, I’ve fixed the requested > test. > Since I’m still quite new to the PG community, would it make sense to > propose a patch that only adds the test? Yes, we could add a test that tracks

Re: [PATCH] Add error message for out-of-memory in passwordFromFile()

2025-11-01 Thread Michael Paquier
On Sat, Nov 01, 2025 at 04:49:02PM -0700, Joshua Shanks wrote: > The conn parameter is placed first, consistent with the object-oriented > convention used throughout libpq (see connectOptions1, > fillPGconn, store_conn_addrinfo, etc.). Sounds OK to me. Nice catch. It's probably not worth botheri

[PATCH] Add error message for out-of-memory in passwordFromFile()

2025-11-01 Thread Joshua Shanks
Hi, I noticed a XXX comment in fe-connect.c at line 8064 indicating that an error message would be nice when strdup() fails while reading the password file. Currently, passwordFromFile() silently returns NULL on allocation failure, leaving users without feedback on what went wrong. This patch add

Re: Improving the names generated for indexes on expressions

2025-11-01 Thread Tom Lane
[ Nobody has had any better ideas in 2 months, so back to this ... ] Robert Haas writes: > Do you think there's any way of doing this usefully while not > autogenerating names that require quoting, or is that a hopeless > endeavor? If it's hopeless, is it better to accept autogenerated names > th

Re: Optimize LISTEN/NOTIFY

2025-11-01 Thread Arseniy Mukhin
Hi, On Mon, Oct 27, 2025 at 2:25 AM Joel Jacobson wrote: > > On Sun, Oct 26, 2025, at 07:33, Joel Jacobson wrote: > > On Sun, Oct 26, 2025, at 05:11, Chao Li wrote: > >> I figured out a way to resolve the race condition for alt3: > >> > >> * add an awakening flag for every listener, this flag is

Re: [PATCH] Fix ALTER SYSTEM empty string bug for GUC_LIST_QUOTE parameters

2025-11-01 Thread Tom Lane
Andrei Klychkov writes: > Looks like the patch v5 resolves a long-standing limitation where there was > no SQL syntax to set a list-based GUC to an empty list. I like this > approach. Also the changes seem non-breaking. Thanks > 1. Would be great to have some explanations in docs about this new b

Re: Adding REPACK [concurrently]

2025-11-01 Thread Mihail Nikalayeu
Hello! On Fri, Oct 31, 2025 at 12:17 AM Alvaro Herrera wrote: > Here's a new installment of this series, v25, including the CONCURRENTLY > part, which required some conflict fixes on top of the much-changed > v24-0001 patch. > * cluster.c > * CLUSTER a table on an index. This is now also

Re: Unused variable in perl test

2025-11-01 Thread Tom Lane
Daniel Gustafsson writes: > On 24 Oct 2025, at 16:12, Daniil Davydov <[email protected]> wrote: >> There is an unused variable "backup_name" in >> test/recovery/t/006_logical_decoding.pl >> What about getting rid of it? > Seems to have been unused since introduced in d851bef2d60ff close to a d

Re: [PATCH] Add pg_get_type_ddl() to retrieve the CREATE TYPE statement

2025-11-01 Thread Philip Alger
Hi Chao, Appreciate you pulling it apart: > 1 > Here when you call LookupTypeName(), you give the last parameter > “missing_ok” a value of “false”, so that it would “ereport” inside > LookupTypeName(), so your manual check of “if (typeTup == NULL)” will never > be satisfied. > Yeah, I changed

Re: [PATCH] Fix LTREE subpath with negative offset

2025-11-01 Thread Tom Lane
Marcus Gartner writes: > subpath(ltree,offset,len) now correctly errors when given an offset less > than -n where n is the number of labels in the given ltree. A duplicate > block of code has been removed which allowed an offset as low as -2n. Nice catch ... as far as I can see from the git histo

Re: pg_plan_advice

2025-11-01 Thread Hannu Krosing
This weas recently shared in LinkedIn https://www.vldb.org/pvldb/vol18/p5126-bress.pdf For example it says that 31% of all queries are metadata queries, 78% have LIMIT, 20% of queries have 10+ joins, with 0.52% exceeding 100 joins. , 12% of expressions have depths between 11-100 levels, some excee

Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()

2025-11-01 Thread David E. Wheeler
On Oct 30, 2025, at 13:03, David E. Wheeler wrote: > On Oct 30, 2025, at 11:22, Mankirat Singh wrote: > >> We can put a note in the compliance check result for new STABLE >> branches - "no .abi-compliance-history file found", but keep the >> client status green? > > Yes, I think that’s the thi

Re: [PATCH] Add Windows support for backtrace_functions (MSVC only)

2025-11-01 Thread Euler Taveira
On Sat, Nov 1, 2025, at 1:40 AM, Bryan Green wrote: > v5 patch attached, incorporating all of Euler's feedback with a caveat > around unicode. > Thanks for sharing another patch. > The most interesting aspect turned out to be the encoding conversion for > symbol names and file paths. Initially I

Re: Missing parentheses

2025-11-01 Thread Marcos Pegoraro
Em sáb., 1 de nov. de 2025 às 11:29, Bruce Momjian escreveu: > > The PG 18 changes will appear once we rebuild the PG 18 docs as part of > the 18 minor release. The next PG 18 minor release is scheduled for > November 13th, 2025: > > The docs on master, which this patch was also applied on, is r

Re: Missing parentheses

2025-11-01 Thread Bruce Momjian
On Sat, Nov 1, 2025 at 10:51:15AM -0300, Marcos Pegoraro wrote: > Em qui., 25 de set. de 2025 às 12:14, Tom Lane escreveu: > > Will try to clean it up. > > > On Sep-25 Tom commited some changes on file \doc\src\sgml\func.sgml > but that commit did not change the correspondent HTML  > > Wh

Re: Missing parentheses

2025-11-01 Thread Marcos Pegoraro
Em qui., 25 de set. de 2025 às 12:14, Tom Lane escreveu: > Will try to clean it up. > On Sep-25 Tom commited some changes on file \doc\src\sgml\func.sgml but that commit did not change the correspondent HTML What needs to be done to be published ? regards Marcos

Re: contrib/sepgsql regression tests have been broken for months

2025-11-01 Thread Andrew Dunstan
On 2025-11-01 Sa 8:50 AM, Joe Conway wrote: On 10/31/25 15:48, Tom Lane wrote: Joe Conway writes: On 10/29/25 19:36, Tom Lane wrote: ... I think the new idea is to leave the module installed and active, which is kind of problematic if we want to also use TestSepgsql.pm in the back branches.

[PATCH] Fix LTREE subpath with negative offset

2025-11-01 Thread Marcus Gartner
subpath(ltree,offset,len) now correctly errors when given an offset less than -n where n is the number of labels in the given ltree. A duplicate block of code has been removed which allowed an offset as low as -2n. 0001-Fix-LTREE-subpath-with-negative-offset.patch Description: Binary data

Re: Adding REPACK [concurrently]

2025-11-01 Thread Sergei Kornilov
Hello! > but materialized views don't have bloat, nothing can be removed. REFRESH MATERIALIZED VIEW CONCURRENTLY does not replace relation completely but updates the relation using insert and delete queries (refresh_by_match_merge in src/backend/commands/matview.c) - so there may be bloat. reg

Re: contrib/sepgsql regression tests have been broken for months

2025-11-01 Thread Joe Conway
On 10/31/25 15:48, Tom Lane wrote: Joe Conway writes: On 10/29/25 19:36, Tom Lane wrote: ... I think the new idea is to leave the module installed and active, which is kind of problematic if we want to also use TestSepgsql.pm in the back branches. I suppose one solution is to create a new bu

Re: Adding REPACK [concurrently]

2025-11-01 Thread jian he
On Fri, Oct 31, 2025 at 7:17 AM Alvaro Herrera wrote: > > Hello, > > Here's a new installment of this series, v25, including the CONCURRENTLY > part, which required some conflict fixes on top of the much-changed > v24-0001 patch. > hi. if (params.options & CLUOPT_ANALYZE) ereport(ERRO

Obsolete comment in ExecScanReScan()

2025-11-01 Thread Etsuro Fujita
While working on a patch to add more test coverage for EPQ testing posted right before, I noticed $SUBJECT: /* * If an FDW or custom scan provider has replaced the join with a * scan, there are multiple RTIs; reset the epqScanDone flag for * all o

postgres_fdw: Add more test coverage for EvalPlanQual testing

2025-11-01 Thread Etsuro Fujita
Hi, In [1] it was pointed out that there is no test coverage for postgresRecheckForeignScan. So I would like to propose to add test cases to cover that function (and related core functions like ForeignRecheck), as promised in that thread. Please find attached a patch. (Note that commit 12609fba

Re: Improving tracking/processing of buildfarm test failures

2025-11-01 Thread Alexander Lakhin
Hello hackers, Please take a look at the October report on buildfarm failures: # SELECT br, COUNT(*) FROM failures WHERE dt >= '2025-10-01' AND  dt < '2025-11-01' GROUP BY br; REL_13_STABLE: 18 REL_14_STABLE: 9 REL_15_STABLE: 4 REL_16_STABLE: 8 REL_17_STABLE: 13 REL_18_STABLE: 66 master: 64 -- To