Re: DOCS - Clarify the publication 'publish_via_partition_root' default value.

On Wed, Dec 17, 2025 at 2:29 AM Peter Smith wrote: > > On Tue, Dec 16, 2025 at 7:39 PM Chao Li wrote: > > > > > > > > AFAIK, Chao's improved text is mostly good, except I think there might > > > be some nuances when there are multiple levels of partitioning. > > > > > > For example, maybe you nee

Re: Fix memory leak in gist_page_items() of pageinspect

Hi, On Mon, Dec 15, 2025 at 01:08:44PM +0900, Michael Paquier wrote: > While passing through, I have applied 0001. Out of curiosity, I searched for other mismatched index_open/relation_close pairs in the tree and found a few more with the help of [1]. They are fixed in the attached. Please not

Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur

Re: Tom Lane > src/test/regress/po/es.po | 159 +++ The Debian package builds are complaining that there is now a usr/share/locale/es/LC_MESSAGES/regress-19.mo file that needs sorting into one of the .deb packages. Since regress.so itself doesn't get insta

Re: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY

Hello! On Tue, Dec 16, 2025 at 3:48 AM Mihail Nikalayeu wrote: > First version of TAP-based test in attachment. I think we should not > hurry with push - let's make sure it really stable now. Second version - some issues fixed, added some log and diagnostic for the next fail. Mikhail. From f53

Re: Additional message in pg_terminate_backend

> On 13 Dec 2025, at 12:44, Roman Khapov wrote: > > Recently I started working on patch for adding additional message from admin > in pg_terminate_backend for one of our greenplum fork. The main idea is that > there must be > done little investigation every time you see 'FATAL: terminating

Re: Parallel Apply

On 16/12/25 12:35, Hayato Kuroda (Fujitsu) wrote: Dear hackers, I have been spending time for benchmarking the patch set. Here is an updated report. I apologise if my question is incorrect. But what about asynchronous replication? Does this method help to reduce lag? My case is a replica loc

RE: Improve logical replication usability when tables lack primary keys

On Tuesday, December 16, 2025 2:47 PM Chao Li wrote: > > On Dec 15, 2025, at 13:48, Amit Kapila wrote: > > > > So, without patch, there is no way we can silently replicate the > > UPDATE/DELETE. Ideally, users should alter the tables and make RI as > > FULL in such cases if they don't have PK for

Re: failed NUMA pages inquiry status: Operation not permitted

On 12/16/25 18:54, Christoph Berg wrote: > Re: Tomas Vondra >> 1) right after opening a connection, I get this >> >> test=# select numa_node, count(*) from pg_buffercache_numa group by 1; >> numa_node | count >> ---+--- >> 0 | 290 >> -2 | 32478 > > Does that mean

Re: apply_scanjoin_target_to_paths and partitionwise join

On Fri, Dec 5, 2025 at 11:48 PM Robert Haas wrote: > > On Wed, Dec 3, 2025 at 9:53 PM Richard Guo wrote: > > But I admit that I am unsure if this addresses > > any real problems, so the effort might not be justified. I agree that > > maybe we should just go ahead with your current patch and see

Re: Periodic authorization expiration checks using GoAway message

> To me that seems like a matter of policy and not protocol. (As long as > we come to some agreement on the semantics of what a client is and is > not allowed to do before reauthenticating.) It's great if this is configurable, as long as DBAs can choose both the immediate and graceful options. >

Re: Remaining dependency on setlocale()

On 12.12.25 21:11, Jeff Davis wrote: case '\xc7':    /* C with cedilla */ so the premise that "fuzzystrmatch is designed for ASCII" does not appear to be correct.  Needs more analysis. (But apparently it's not multibyte aware at all, so I don't know what to do about that.) I didn't notice

Re: Segmentation fault on proc exit after dshash_find_or_insert

Hi Amit, > /* > * Release any LWLocks we might be holding, before running callbacks > that > - * may detach the memory containing those locks. > + * may detach the memory containing those locks. Releasing all the > locks > + * ensures that any callbacks executed afterward w

RE: Improve pg_sync_replication_slots() to wait for primary to advance

On Monday, December 15, 2025 7:06 PM Amit Kapila wrote: > > On Fri, Dec 12, 2025 at 8:53 AM shveta malik > wrote: > > > > On Fri, Dec 12, 2025 at 5:35 AM Ajin Cherian wrote: > > > > > > > > > I have included these changes as well as comments by Chao. Attaching > > > v37 with the changes. > > >

Re: Proposal: Conflict log history table for Logical Replication

On Wed, Dec 17, 2025 at 3:29 PM Dilip Kumar wrote: > > On Wed, Dec 17, 2025 at 3:14 PM shveta malik wrote: > > > > I don’t think a user intentionally dropping information_schema and > > creating their own schema (with different definitions and tables) is a > > practical scenario. While it isn’t e

Re: pg_plan_advice

On Mon, Dec 15, 2025 at 9:06 PM Robert Haas wrote: > > Here's v7. [..] OK, so I've tested today from Your's branch directly, so I hope that was also v7. Given the following q20 query: SELECT s_name, s_address FROM supplier, nation WHERE s_suppkey in (SELECT ps_suppkey FROM partsupp

Re: [Proposal] Adding Log File Capability to pg_createsubscriber

On Tue, 16 Dec 2025 at 12:31, Hayato Kuroda (Fujitsu) wrote: > > Dear Gyan, > > +1 for the idea. This point has already been discussed since the initial > commit > [1], but it has left till now. I'm happy if you can take initiative. > Of course I can review your patches. > > Per my understanding,

Re: Periodic authorization expiration checks using GoAway message

Background process will help us to gain performance so as it will be seamless to users and user queries will not be impacted. Thanks & Best Regards, Ajit On Wed, 17 Dec 2025 at 01:52, Jacob Champion < [email protected]> wrote: > On Tue, Dec 16, 2025 at 1:15 AM Ajit Awekar > wrote:

Re: More const-marking cleanup

Hi, On Mon, Dec 08, 2025 at 07:43:34AM +, Bertrand Drouvot wrote: > That said I improved the script [1] so that: > > - It found one more (see the attached) I had another look and it seems to me that the one (src/port/getopt.c) reported and fixed in the attached of the previous email is the o

Re: Proposal: Conflict log history table for Logical Replication

On Wed, Dec 17, 2025 at 3:14 PM shveta malik wrote: > > I don’t think a user intentionally dropping information_schema and > creating their own schema (with different definitions and tables) is a > practical scenario. While it isn’t explicitly restricted, I don’t see > a strong need for it. OTOH,

Re: [PATCH] Fix severe performance regression with gettext 0.20+ on Windows

On 10.12.25 01:45, Bryan Green wrote: The attached patch takes a pragmatic approach: for gettext 0.20.1+, we avoid triggering the bug by using Windows locale format instead of calling IsoLocaleName(). This works because gettext 0.20.1+ internally converts the Windows format back to POSIX for cata

Re: Proposal: Conflict log history table for Logical Replication

On Wed, Dec 17, 2025 at 9:59 AM Dilip Kumar wrote: > > On Tue, Dec 16, 2025 at 10:33 AM shveta malik wrote: > > > The OID check may be unreliable, as mentioned in the comment. I tested > > this by dropping and recreating information_schema, and observed that > > after recreation it became eligibl

Re: Custom oauth validator options

> Overall, +1 that this limitation is real and worth discussing.I’ll plan to > send a patch shortly exploring option (b). Personally I would go with either (a) or (c), and I was planning to clean up / improve / share my (c) patch as a second attempt for this thread, if it didn't receive any repli

Re: Custom oauth validator options

> What kinds of parameters? Having a motivating use case would be > helpful; HBA isn't always as flexible as people assume and I want to > make sure that we can end with a usable feature. One issue we have is that some providers don't allow users to select what goes into the subject claim, but do

Re: Improve logical replication usability when tables lack primary keys

On Tue, Dec 16, 2025 at 4:59 PM Chao Li wrote: > > On Dec 15, 2025, at 13:48, Amit Kapila wrote: > > > So, without patch, there is no way we can silently replicate the > > UPDATE/DELETE. Ideally, users should alter the tables and make RI as > > FULL in such cases if they don't have PK for such t

Re: Buffer locking is special (hints, checksums, AIO writes)

On 03/12/2025 02:47, Andres Freund wrote: On 2025-11-25 11:54:00 -0500, Andres Freund wrote: Thanks a lot for that detailed review! A few questions and comments, before I try to address the comments in the next version. Here's that new new version, with the following changes - Some more micr

Re: Fix and improve allocation formulas

Hi, On Wed, Dec 17, 2025 at 05:19:33PM +0900, Michael Paquier wrote: > On Thu, Dec 11, 2025 at 01:27:56PM +, Bertrand Drouvot wrote: > diff --git a/src/bin/pg_verifybackup/pg_verifybackup.c > b/src/bin/pg_verifybackup/pg_verifybackup.c > index c9b24df7c05..1cd5fa791c0 100644 > --- a/src/bin/

Re: Replace is_publishable_class() with relispublishable column in pg_class

On Wed, Dec 17, 2025 at 12:37 PM Peter Smith wrote: > > Here is a completely different idea. This may solve the immediate > problem re the replication of the Conflict Log Table (CLT) at least... > > 0. AFAIK, anything named with a "pg_" prefix generally means that the > named thing is intended for

Re: Serverside SNI support in libpq

On 17/12/2025 11:03, Heikki Linnakangas wrote: On 12/12/2025 13:41, Daniel Gustafsson wrote: I wonder if the way forward is to do both?  Heikki has a good point that when working with pg_hosts.conf it should be clear from just that file what the final config will be, and in the previous version

Re: Serverside SNI support in libpq

On 12/12/2025 13:41, Daniel Gustafsson wrote: On Wed, Dec 3, 2025 at 1:57 AM Heikki Linnakangas wrote: Maybe. I'm not a big fan of magic-file-exist configurations Me neither. (I especially don't like the idea of ignoring a certificate+key setting that a user has taken the time to put into a

Re: SQL Property Graph Queries (SQL/PGQ)

On 17.12.25 06:32, Ashutosh Bapat wrote: On Mon, Dec 15, 2025 at 6:43 PM Ashutosh Bapat wrote: Rebased patches on the latest HEAD which required me to move graph_table.sql to another parallel group. Huh, the movement resulted in losing that test from parallel_schedule. Fixed in the attached

RE: Proposal: Cascade REPLICA IDENTITY changes to leaf partitions

On Wednesday, December 17, 2025 3:56 PM Chao Li wrote: > Thank you both for all your advice. Here comes my first implementation of > INHERIT in the attached v2 patch. > > On Wed, Dec 17, 2025 at 8:11 AM Euler Taveira > wrote: > > > I wondering if we use INHERIT as d

Re: Report bytes and transactions actually sent downtream

Hi, On Thu, Dec 11, 2025 at 10:29:42AM +0530, Ashutosh Bapat wrote: > Sorry for the delayed response. PFA the patch implementing the idea > discussed above. It relies on the output plugin callback to return > correct boolean but maintains the statistics in the core itself. Thanks for the new patc

Re: Fix possible 'unexpected data beyond EOF' on replica restart

On Wed, Dec 17, 2025 at 8:26 AM Amul Sul wrote: > Thanks for detailed reproducible steps, I can see the reported issue > and proposed patch fixes the same. Thanks for the review! > The deleted code you moved to mdtruncate() should be kept where it > was. We cannot ensure that every extension

DOC: Fix formatting of ALTER TABLE REPLICA IDENTITY documentation

Hi Hacker, While updating the documentation for patch [1], I noticed that the “ALTER TABLE … REPLICA IDENTITY” section has incorrect indentation, with a closing placed in the wrong location. This made the SGML structure a bit confusing to read. Since the SGML in this area is already fairly dense

Re: Segmentation fault on proc exit after dshash_find_or_insert

Hi Rahila, On Wed, Dec 17, 2025 at 3:57 PM Rahila Syed wrote: > > Hi Amit, > > >> >> Oops, forgot an #include. Fixed in the attached. >> > > Thank you for the updated patch and the detailed commit message. You have > explained the problem > quite well and the changes look good to me. Thanks fo

Re: Fix and improve allocation formulas

On Thu, Dec 11, 2025 at 01:27:56PM +, Bertrand Drouvot wrote: > It found two formulas that are technically correct, but using GBT_VARKEY and > char > are the semantically appropriate choices (see 0001 attached). Bertrand has just reminded me offline that this two have not been discussed, and

Re: [Proposal] Adding callback support for custom statistics kinds

On Wed, Dec 17, 2025 at 08:03:36AM +0100, Peter Eisentraut wrote: > So it seems to me that either the callbacks API needs some adjustments, or > this particular implementation of the callback function is incorrect. Hmm, you are right that this is not aligned. This can be improved with one change