Re: Optimize numeric.c mul_var() using the Karatsuba algorithm

2024-06-14 Thread Aaron Altman
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested This applies cleanly to master, builds and passes regression tests in my Win

Re: Optimize numeric.c mul_var() using the Karatsuba algorithm

2024-06-11 Thread Aaron Altman
ve some context around whether it would make sense to have conditions to choose other algorithms as well, or if this one is generally the best for what Postgres users are usually doing. Continuing with code review in any case.  Interested to hear more. Regards, Aaron Altman

Re: Fix grammar oddities in comments

2024-06-09 Thread Aaron Altman
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested Confirming linguistic correctness of changes, and lack of anything changed o