Re: ERROR: "ft1" is of the wrong type.

2021-06-30 Thread Ahsan Hadi
On Wed, Jun 30, 2021 at 5:56 AM Kyotaro Horiguchi wrote: > At Tue, 29 Jun 2021 20:13:14 +0000, ahsan hadi > wrote in > > The following review has been posted through the commitfest application: > > make installcheck-world: tested, passed > > Implements feature:

Re: ERROR: "ft1" is of the wrong type.

2021-06-29 Thread ahsan hadi
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested I have tested it with various object types and getting a

Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns

2021-05-08 Thread Ahsan Hadi
On Sat, May 8, 2021 at 8:17 AM Japin Li wrote: > > On Fri, 07 May 2021 at 19:50, ahsan hadi wrote: > > The following review has been posted through the commitfest application: > > make installcheck-world: tested, passed > > Implements feature: tested, p

Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns

2021-05-07 Thread ahsan hadi
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested I have also seen this error with logical replication using

Re: pg_dump new feature: exporting functions only. Bad or good idea ?

2021-04-29 Thread ahsan hadi
The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested Few minor comments : - The latest patch has some hunk failures

Re: Add session statistics to pg_stat_database

2020-10-16 Thread Ahsan Hadi
Hi Laurenz, I have applied the latest patch on master, all the regression test cases are passing and the implemented functionality is also looking fine. The point that I raised about idle connection not included is also addressed. thanks, Ahsan On Wed, Oct 14, 2020 at 2:28 PM Laurenz Albe

Re: Performing partition pruning using row value

2020-08-19 Thread ahsan hadi
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested I have performed testing of the patch with row comparison

Re: Add session statistics to pg_stat_database

2020-07-23 Thread Ahsan Hadi
On Wed, Jul 8, 2020 at 4:17 PM Laurenz Albe wrote: > Here is a patch that adds the following to pg_stat_database: > - number of connections > Is it expected behaviour to not count idle connections? The connection is included after it is aborted but not while it was idle. > - number of

Re: Transactions involving multiple postgres foreign servers, take 2

2020-07-23 Thread Ahsan Hadi
On Fri, Jul 17, 2020 at 9:56 PM Fujii Masao wrote: > > > On 2020/07/16 14:47, Masahiko Sawada wrote: > > On Tue, 14 Jul 2020 at 11:19, Fujii Masao > wrote: > >> > >> > >> > >> On 2020/07/14 9:08, Masahiro Ikeda wrote: > I've attached the latest version patches. I've incorporated the review

Re: Added tab completion for the missing options in copy statement

2020-07-07 Thread ahsan hadi
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested Tested the tab complete for copy command, it provides the tab

Re: Improving psql slash usage help message

2020-06-08 Thread ahsan hadi
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: not tested Spec compliant: not tested Documentation:tested, passed This small documentation patch makes the document more accurate for

Re: create partition table caused server crashed with self-referencing foreign key

2020-04-22 Thread Ahsan Hadi
On Wed, Apr 22, 2020 at 2:45 PM amul sul wrote: > > > On Wed, Apr 22, 2020 at 2:59 PM amul sul wrote: > >> >> >> On Wed, Apr 22, 2020 at 2:27 PM David Rowley >> wrote: >> >>> On Wed, 22 Apr 2020 at 20:11, amul sul wrote: >>> > >>> > On Wed, Apr 22, 2020 at 1:21 PM Rajkumar Raghuwanshi < >>>

Re: WIP/PoC for parallel backup

2020-04-21 Thread Ahsan Hadi
On Tue, Apr 21, 2020 at 4:50 PM Amit Kapila wrote: > On Tue, Apr 21, 2020 at 5:18 PM Amit Kapila > wrote: > > > > On Tue, Apr 21, 2020 at 1:00 PM Asif Rehman > wrote: > > > > > > I did some tests a while back, and here are the results. The tests > were done to simulate > > > a live database

Re: WIP/PoC for parallel backup

2020-04-15 Thread Ahsan Hadi
On Wed, 15 Apr 2020 at 1:49 AM, Robert Haas wrote: > On Tue, Apr 14, 2020 at 10:37 AM Asif Rehman > wrote: > > I forgot to make a check for no-manifest. Fixed. Attached is the updated > patch. > > +typedef struct > +{ > ... > +} BackupFile; > + > +typedef struct > +{ > ... > +} BackupState; > >

Re: 2pc leaks fds

2020-04-08 Thread Ahsan Hadi
I have tested with and without the commit from Andres using the pgbench script (below) provided in the initial email. pgbench -n -s 500 -c 4 -j 4 -T 10 -P1 -f pgbench-write-2pc.sql I am not getting the leak anymore, it seems to be holding up pretty well. On Wed, Apr 8, 2020 at 12:59 PM

Re: Internal key management system

2020-04-07 Thread Ahsan Hadi
Hi Bruce/Joe, In the last meeting we discussed the need for improving the documentation for KMS so it is easier to understand the interface. Cary from highgo had a go at doing that, please see the previous email on this thread from Cary and let us know if it looks good...? -- Ahsan On Wed, Apr

Re: WIP/PoC for parallel backup

2020-03-30 Thread Ahsan Hadi
On Mon, Mar 30, 2020 at 3:44 PM Rajkumar Raghuwanshi < rajkumar.raghuwan...@enterprisedb.com> wrote: > Thanks Asif, > > I have re-verified reported issue. expect standby backup, others are fixed. > Yes As Asif mentioned he is working on the standby issue and adding bandwidth throttling

Re: more ALTER .. DEPENDS ON EXTENSION fixes

2020-03-01 Thread Ahsan Hadi
On Sat, Feb 29, 2020 at 2:38 AM Alvaro Herrera wrote: > On 2020-Feb-28, ahsan hadi wrote: > > > > Tested the pg_dump patch for dumping "ALTER .. DEPENDS ON EXTENSION" in > case of indexes, functions, triggers etc. The "ALTER .. DEPENDS ON > EXTENSION"

Re: more ALTER .. DEPENDS ON EXTENSION fixes

2020-02-27 Thread ahsan hadi
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested Tested the pg_dump patch for dumping "ALTER .. DEPENDS ON

Re: DROP OWNED CASCADE vs Temp tables

2020-02-19 Thread ahsan hadi
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested I have tested the patch with REL_12_STABLE for the given error

Re: pg_restore crash when there is a failure before all child process is created

2020-01-31 Thread ahsan hadi
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: not tested Spec compliant: tested, passed Documentation:not tested I have applied tested both patches separately and ran regression

Re: pg_restore crash when there is a failure before all child process is created

2020-01-31 Thread Ahsan Hadi
: > vignesh C writes: > > On Wed, Jan 29, 2020 at 6:54 PM Ahsan Hadi wrote: > >> Can you share a test case or steps that you are using to reproduce this > issue? Are you reproducing this using a debugger? > > > I could reproduce with the following steps: > > Make

Re: Append with naive multiplexing of FDWs

2020-01-14 Thread Ahsan Hadi
Hi Hackers, Sharing the email below from Movead Li, I believe he wanted to share the benchmarking results as a response to this email thread but it started a new thread.. Here it is... " Hello I have tested the patch with a partition table with several foreign partitions living on seperate data

Re: Extension development

2019-11-12 Thread Ahsan Hadi
Hi Yonatan, You can follow this blog for creating your own extension in PostgreSQL.. https://www.highgo.ca/2019/10/01/a-guide-to-create-user-defined-extension-modules-to-postgres/ -- Ahsan On Tue, Nov 12, 2019 at 11:54 AM Yonatan Misgan wrote: > I am developed my own PostgreSQL extension for

Re: Proposal for syntax to support creation of partition tables when creating parent table

2019-09-25 Thread Ahsan Hadi
On Wed, Sep 25, 2019 at 8:53 PM Tom Lane wrote: > Muhammad Usama writes: > > I want to propose an extension to CREATE TABLE syntax to allow the > creation > > of partition tables along with its parent table using a single statement. > > TBH, I think this isn't a particularly good idea. It

Re: enhance SPI to support EXECUTE commands

2019-09-18 Thread Ahsan Hadi
I don't see much use for this because the documentation says that "server's execute command cannot be used directly within pl/pgsql function (and it is not needed). Within pl/pgsql you can execute update/delete commands using pl/pgsql EXECUTE command and get results like row_count using "get

Re: patch: psql - enforce constant width of last column

2019-09-18 Thread Ahsan Hadi
On Tue, Sep 17, 2019 at 8:16 PM Pavel Stehule wrote: > > > Ășt 17. 9. 2019 v 17:06 odesĂ­latel Ahsan Hadi > napsal: > >> Hi Pavel, >> >> I have been trying to reproduce the case of badly displaying last columns >> of a query result-set. I played around w

Re: patch: psql - enforce constant width of last column

2019-09-17 Thread Ahsan Hadi
Hi Pavel, I have been trying to reproduce the case of badly displaying last columns of a query result-set. I played around with the legal values for psql border variable but not able to find a case where last columns are badly displayed. Can you please share an example that I can use to reproduce

Re: Email to hackers for test coverage

2019-08-29 Thread Ahsan Hadi
On Wed, Aug 28, 2019 at 9:43 PM Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 2019-08-22 11:46, movead...@highgo.ca wrote: > > *1. src/include/utils/float.h:140* > > > > Analyze: > > This is an error report line when converting a big float8 value > > which a float4 can not

Re: WIP/PoC for parallel backup

2019-08-23 Thread Ahsan Hadi
On Fri, 23 Aug 2019 at 10:26 PM, Stephen Frost wrote: > Greetings, > > * Asif Rehman (asifr.reh...@gmail.com) wrote: > > On Fri, Aug 23, 2019 at 3:18 PM Asim R P wrote: > > > Interesting proposal. Bulk of the work in a backup is transferring > files > > > from source data directory to

Re: Email to hackers for test coverage

2019-08-23 Thread Ahsan Hadi
The subject of the email may be bit misleading however this is really good exercise to analyse the current code of Postgres regression suite using GCOV and then adding test cases incrementally to increase the test coverage. On Thu, 22 Aug 2019 at 2:46 PM, movead...@highgo.ca wrote: > Hello

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-08-19 Thread Ahsan Hadi
for everyone as we are dealing with multiple timezone but do let me know It is too bizarre for you and I will try to find another slot. I will share a zoom link for the meeting on the invite in due course. -- Ahsan On Mon, Aug 19, 2019 at 9:26 AM Ahsan Hadi wrote: > > > On Mon, 19 Aug 201

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-08-18 Thread Ahsan Hadi
On Mon, 19 Aug 2019 at 6:23 AM, Smith, Peter wrote: > > From: Ibrar Ahmed Sent: Sunday, 18 August 2019 > 2:43 AM > > +1 for voice call, bruce we usually have a weekly TDE call. I will > include you in > > If you don't mind, please also add me to that TDE call list. > Sure will do. >

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-08-17 Thread Ahsan Hadi
The current calendar entry for TDE weekly call will not work for EST timezone. I will change the invite so we can accommodate people from multiple time zones. Stay tuned. On Sun, 18 Aug 2019 at 2:29 AM, Sehrope Sarkuni wrote: > On Sat, Aug 17, 2019 at 12:43 PM Ibrar Ahmed > wrote: > >> +1

Re: BUG #15182: Canceling authentication due to timeout aka Denial of Service Attack

2018-08-01 Thread ahsan hadi
Hi Michael, Can you rebase the reindex-priv-93.patch, it is getting some hunk failures. patching file doc/src/sgml/ref/reindex.sgml Hunk #1 succeeded at 227 (offset 13 lines). patching file src/backend/commands/indexcmds.c Hunk #1 FAILED at 1873. 1 out of 1 hunk FAILED -- saving rejects to file