On 2/12/22 09:25, Tom Lane wrote:
I don't know that we'd go that far ... maybe if another bad problem
turns up. In the meantime, though, I do have a modest suggestion:
it would not be too hard to put some defenses in place against another
such bug. The faulty commit was in our tree for a month
On 2/11/22 15:57, Tom Lane wrote:
Possibly same issue I just fixed?
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=e5691cc9170bcd6c684715c2755d919c5a16fea2
Yeah, that does seem to fix my test cases. Thanks!
Any chance this will make it into minor releases sooner than
With yesterday’s release of PostgreSQL 11.15, 12.10, and 13.6
(presumably 10.20 and 14.2 as well), Zulip’s test suite started failing
with “variable not found in subplan target list” errors from PostgreSQL
on a table that has a PGroonga index. I found the following
reproduction recipe from a
On 1/9/22 13:04, Tom Lane wrote:
The only case that the v1 patch helps such a user for is if they
unset HOME or set it precisely to ''. If they set it to anything
else, it's still broken from their perspective. So I do not find
that that argument holds water.
Moreover, ISTM that the only
On 1/9/22 10:59, Tom Lane wrote:
Given the POSIX requirements, it's basically impossible to believe
that there are interesting cases where $HOME isn't set. Thus, it
seems to me that keeping the getpwuid calls will just mean carrying
untestable dead code, so we should simplify matters by ripping
On 10/20/21 04:55, Daniel Gustafsson wrote:
Is the proposed change portable across all linux/unix systems we support?
Reading aobut indicates that it's likely to be, but neither NetBSD nor FreeBSD
have the upthread referenced wording in their manpages.
Since the proposed change falls back to
On 10/19/21 01:34, Kyotaro Horiguchi wrote:
I tend to agree to this, but seeing ssh ignoring $HOME, I'm not sure
it's safe that we follow the variable at least when accessing
confidentiality(?) files. Since I don't understand the exact
reasoning for the ssh's behavior so it's just my humbole
ng
/etc/passwd as an added bonus.
The way I ran into this issue myself was in a test suite that runs on GitHub
Actions, which automatically sets HOME=/github/home.
Anders
From df9c435c759fffe77c9c92f70e7c095ffb6556ae Mon Sep 17 00:00:00 2001
From: Anders Kaseorg
Date: Thu, 14 Oct 2021 15:20:13
