On Mon, Nov 17, 2025 at 8:48 PM John Naylor wrote:
>
> On Tue, Nov 18, 2025 at 10:32 AM Andrew Kim wrote:
>
> > I've double-checked everything after applying the v9 checksum patches
> > and updating pg_filedump accordingly.
> > Following your suggestion, I removed
Hi John,
Thanks for taking the time to review the v9-0001 refactoring patch and
for setting the CF entry to Needs Review.
On Fri, Nov 14, 2025 at 3:34 AM John Naylor wrote:
>
> On Thu, Nov 6, 2025 at 6:50 AM Andrew Kim wrote:
> > The v9 patch series is attached.
>
> Thanks!
Hi John,
Thank you for reviewing and bringing this up regarding checksum architecture.
On Tue, Oct 28, 2025 at 7:50 PM John Naylor wrote:
>
> On Fri, Oct 24, 2025 at 2:49 PM Andrew Kim wrote:
> > The function signatures (pg_checksum_block, pg_checksum_page) remain
> &
Hi Oleg,
Thank you for the detailed review on v7 patch.
On Mon, Oct 20, 2025 at 8:05 AM Oleg Tselebrovskiy
wrote:
>
> Thanks for the new patch version!
>
> Another round of review:
>
> 1) I think that changes to contrib/pageinspect/rawpage.c should be in
> the main patch, not in the benchmark pa
2025 at 2:15 PM Andrew Kim wrote:
> >
> > Hi John,
> >
> > Thank you for your detailed and constructive feedback on the checksum
> > AVX2 optimization patch.
> > I've carefully addressed all of your concerns and am pleased to share
> > the updated V6 impl
and pg_checksum_block_avx2.
7. Documentation/CommentsResolved: Comprehensive documentation,
including the detailed FNV-1a algorithm comments, has been restored to
the portable implementation (pg_checksum_block_default).
Best regards,
Andrew Kim
On Fri, Oct 17, 2025 at 3:53 AM Oleg Tselebrovskiy
formance benefits of AVX2 optimization.
Please find the V6 patch attached. I welcome any additional feedback
you may have.
Best regards,
Andrew Kim
On Wed, Oct 1, 2025 at 10:26 PM John Naylor wrote:
>
> On Thu, Sep 25, 2025 at 4:50 AM Andrew Kim wrote:
> >
> > Thanks,
of the patchset, updated per your feedback.
Best regards,
Andrew Kim
On Tue, Sep 23, 2025 at 11:32 PM John Naylor wrote:
>
> On Thu, Sep 11, 2025 at 1:55 PM root wrote:
> > Thanks for the feedback. This is v5 of the patchset, updated following your
> > comments:
> >
> >
t tip of master and addressed the earlier review comments:
* Moved the function pointer definitions into src/port as suggested.
* Rebased cleanly on the current master branch.
Could someone take another look and share any further feedback?
Thanks a lot for your time and review,
Andrew Kim
