Re: Add PGDLLIMPORT to enable_hashagg

2018-02-21 Thread Brian Cloutier
On Wed, Feb 21, 2018 at 10:14 AM, Andres Freund wrote: > Could you take the relevant commit, backport it to the > relevant branches, resolve conflicts, make possibly appropriate > adaptions, and post? > The original commit touched some new variables and therefore didn't apply cleanly. Attached a

Re: Add PGDLLIMPORT to enable_hashagg

2018-02-16 Thread Brian Cloutier
On Fri, Feb 9, 2018 at 1:01 PM, Robert Haas wrote: > > Committed. Thanks for committing this! We forgot to ask though, could you please backport this patch to 10 and maybe even 9.6? As-is I don't think these variables will be available until PG 11.

Re: Add PGDLLIMPORT lines to some variables

2017-11-28 Thread Brian Cloutier
Sorry, I'm new to pg-hackers, so I'm not sure what the next step is. Do I submit this to commitfest? When submitting, do I submit multiple changes, one per branch this should be packported to?

Re: Add PGDLLIMPORT lines to some variables

2017-11-20 Thread Brian Cloutier
2017-11-16 23:59 GMT+01:00 Brian Cloutier : > >> Hello hackers, >> >> I'm porting Citus to Windows and found that we use some variables which >> PG doesn't export; here is a patch which adds PGDLLIMPORT declarations to >> those variables. This is unfortuna

Add PGDLLIMPORT lines to some variables

2017-11-16 Thread Brian Cloutier
ready have been done to quite a few other variables. From 3c412b4fee7e4343b070ea85ee8b29f3ec4cc244 Mon Sep 17 00:00:00 2001 From: Brian Cloutier Date: Tue, 31 Oct 2017 17:53:42 -0700 Subject: [PATCH] Add PGDLLIMPORT declarations to some variables On Windows, PGDLLIMPORT is required for varia