Re: SQL:2023 JSON simplified accessor support

2025-09-03 Thread Chao Li
> On Sep 2, 2025, at 10:59, Chao Li wrote: > > jsonbsubs doesn’t need to check is_slice flag as well, I will explain that in > my next email tougher with my new comments. Now jsonb_check_json_needed() loops over all indirections: static bool jsonb_check_jsonpath_needed(List

Re: SQL:2023 JSON simplified accessor support

2025-09-03 Thread Chao Li
refstate->upperindexnull[i] = true; + } + else { + sbsrefstate->upperprovided[i] = true; ``` This is also a nit comment about code format. “{" should be put to the next line of “else” according to other existing code. Best regards, -- C

Re: SQL:2023 JSON simplified accessor support

2025-09-03 Thread Chao Li
ndex [0] directly following the data column, regardless what indirections are followed, it’s by default lax mode. So, I think this is a design decision. Maybe I missed something from your previous design, but I don’t find anything about that from the commit comments. I feel this would be better aligned with 1) and 2). Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Fix pg_waldump to exit cleanly at end of WAL

2025-09-02 Thread Chao Li
he error message is kinda misleading and unnecessary. So I created a fix. >From the code comment in pg_waldump.c, the same change should be applied to pg_walinspect. If this patch is accepted, I will then work on pg_walinspect as well. Best regards, Chao Li (Evan) - HighG

Re: SQL:2023 JSON simplified accessor support

2025-09-02 Thread Chao Li
bscriptTransform(). That’s why I ended up suggesting removing “is_slice” from SubscriptTransform(). Does that sound reasonable? -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: SQL:2023 JSON simplified accessor support

2025-09-02 Thread Chao Li
> On Aug 29, 2025, at 15:22, Chao Li wrote: > > +static bool > +jsonb_check_jsonpath_needed(List *indirection) > +{ > + ListCell *lc; > + > + foreach(lc, indirection) > + { > + Node *accessor = lfirst(lc); > + > +

Re: Fix pg_waldump to exit cleanly at end of WAL

2025-09-02 Thread Chao Li
T [52426] LOG: redo done at 0/017AF398 system usage: CPU: user: 0.00 s, system: 0.00 s, elapsed: 0.00 s 2025-09-03 10:46:48.496 CST [52426] LOG: last completed transaction was at log time 2025-09-03 10:42:02.901807+08 ``` So, I guess xlogreader may return a different log message when xl_tot_le

Re: SQL:2023 JSON simplified accessor support

2025-09-02 Thread Chao Li
> On Sep 2, 2025, at 11:53, David G. Johnston > wrote: > > On Monday, September 1, 2025, Chao Li <mailto:li.evan.c...@gmail.com>> wrote: >> >> The last comment is about error message: >> >> ``` >> evantest=# select data.a from test_js

Re: SQL:2023 JSON simplified accessor support

2025-09-01 Thread Chao Li
> On Aug 27, 2025, at 15:26, Chao Li wrote: > > diff --git a/src/include/parser/parse_node.h b/src/include/parser/parse_node.h > index f7d07c84542..58a4b9df157 100644 > --- a/src/include/parser/parse_node.h > +++ b/src/include/parser/parse_node.h > @@ -361,7 +361,7 @@ e

Re: SQL:2023 JSON simplified accessor support

2025-09-01 Thread Chao Li
ew other comments. Let me raise them in a separate email. Regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: GB18030-2022 Support in PostgreSQL

2025-08-31 Thread Chao Li
> On Aug 18, 2025, at 16:50, Chao Li wrote: > > > Hi John, Any follow up on this patch? Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: allow benign typedef redefinitions (C11)

2025-08-31 Thread Chao Li
same way as HeapTuple like “typedef structure ParamListInfoData *ParamListInfo”. I tried that in my local and build still passed. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: Raw parse tree is not dumped to log

2025-08-31 Thread Chao Li
Hi Tatsuo san, Rebased v6 is attached. Chao Li (Evan) - HighGo Software Co., Ltd. https://www.highgo.com/ Tatsuo Ishii 于2025年9月1日周一 10:13写道: > Hi Chao Li, > > >> v5 patch looks good to me. If there's no objection, I plan to push the > >

Re: Fix an unnecessary cast calling elog in ExecHashJoinImpl

2025-08-31 Thread Chao Li
hj_JoinState is already int, so the cast seems unnecessary. > So I remove it in the attached patch. > > -- > Thanks, > Tender Wang > <0001-Fix-an-unnecessary-cast-calling-elog-in-ExecHashJoin.patch> Yes, hj_JoinState is of type int, so the type cast to int is not needed.

Re: [PATCH] Generate random dates/times in a specified range

2025-08-29 Thread Chao Li
e can make check_range_boundaries() “inline” as well. But a major problem is, I think we should bump CATALOG_VERSION_NO. Otherwise, running your code with an existing database, the new functions won’t work. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Trivial fix of code comment

2025-08-29 Thread Chao Li
Hi Hackers, Simple fix "commits" to "commits" in a test spec file. "make check" passed. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/ v1-0001-Update-comments-in-src-test-isolation-specs-eval-.patch Description: Binary data

Re: SQL:2023 JSON simplified accessor support

2025-08-29 Thread Chao Li
, but now it’s placed in a while loop, and every time this foreach needs to go through the entire indirection list, which are duplicated computation. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: Mark ItemPointer parameters as const in tuple/table lock functions

2025-08-28 Thread Chao Li
: error: assignment discards 'const' > qualifier from pointer target type [-Werror=discarded-qualifiers] > > I have fixed that and committed your patch. > -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: SQL:2023 JSON simplified accessor support

2025-08-28 Thread Chao Li
indirections to indices indirection first before transform indirections, so that the two SQLs will generate the same rewritten query tree, which would simplify the code logic of rewriting query tree and the planner. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: SQL:2023 JSON simplified accessor support

2025-08-28 Thread Chao Li
break; } if (pathlen == 0) ``` After the fix, let’s test again: ``` evantest=# select data[0:2][1] from test_jsonb_types; # good result data -- 2 (2 rows) evantest=# select (t.data)['con']['a'][0:1][0] from test_jsonb_types t; # good result data - {"b": {"c": {"d": 99}}} (2 rows) ``` Regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: Inconsistent update in the MERGE command

2025-08-27 Thread Chao Li
nk this fix makes sense. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: Mark ItemPointer parameters as const in tuple/table lock functions

2025-08-27 Thread Chao Li
Mail Archive always misses attachments sent by Apple Mail. Resending from the Gmail web client. Chao Li (Evan) - Highgo Software Co., Ltd. https://www.highgo.com/ Chao Li 于2025年8月28日周四 10:28写道: > > > On Aug 27, 2025, at 17:24, Peter Eisentraut wrote: > >

Re: Mark ItemPointer parameters as const in tuple/table lock functions

2025-08-27 Thread Chao Li
updated the patch to use “const ItemPointerData *” in the same way as ItemPointerGetBlockNumber().Attached is the v2 patch.Best regards, --Chao Li (Evan)HighGo Software Co., Ltd.https://www.highgo.com/ v2-0001-Mark-ItemPointer-parameters-as-const-in-tuple-tab.patch Description: Binary data

Re: Identifying function-lookup failures due to argument name mismatches

2025-08-27 Thread Chao Li
> On Aug 27, 2025, at 23:42, Peter Eisentraut wrote: > > On 25.08.25 04:43, Chao Li wrote: >> Can we avoid the duplication in a way like: >> ``` >> static int >> func_lookup_failure_details(int fgc_flags, List *argnames, bool proc_call) >> { &g

Mark ItemPointer parameters as const in tuple/table lock functions

2025-08-27 Thread Chao Li
intent and allow the compiler to enforce immutability. With this patch, build still passes, and "make check" also passes. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/ v1-0001-Mark-ItemPointer-parameters-as-const-in-tuple-tab.patch Description: Binary data

Re: SQL:2023 JSON simplified accessor support

2025-08-27 Thread Chao Li
change “if” to “while”. Regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: Fixes a trivial bug in dumped parse/query/plan trees

2025-08-26 Thread Chao Li
Retry again to attach the path file. Chao Li (Evan) - Highgo Software Co., Ltd. https://www.highgo.com/ Chao Li 于2025年8月27日周三 09:35写道: > > > On Aug 25, 2025, at 16:57, Chao Li wrote: > > > Resending the patch file. > > -- > Chao Li (Evan)

Re: Fixes a trivial bug in dumped parse/query/plan trees

2025-08-26 Thread Chao Li
On Aug 25, 2025, at 16:57, Chao Li wrote:Resending the patch file. --Chao Li (Evan)HighGo Software Co., Ltd.https://www.highgo.com/ v1-0001-Fixes-a-trivial-bug-in-dumped-parse-query-plan-tr.patch Description: Binary data

Re: Why CI doesn't run?

2025-08-26 Thread Chao Li
On Aug 27, 2025, at 09:23, David G. Johnston wrote:On Tue, Aug 26, 2025 at 6:05 PM Chao Li <li.evan.c...@gmail.com> wrote:Anyone has an idea why CI has not yet run against https://commitfest.postgresql.org/patch/5996/?Mail server didn't recognize your patch as an attachment (I can&#

Re: Making jsonb_agg() faster

2025-08-26 Thread Chao Li
ay size */ Can we do lazy allocation? Initially assume size = 0, only allocate memory when pushing the first element? This way, we won’t allocate memory for empty objects and arrays. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Why CI doesn't run?

2025-08-26 Thread Chao Li
Hi Hacker, Anyone has an idea why CI has not yet run against https://commitfest.postgresql.org/patch/5996/? Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Optimize JsonbContainerTypeName by reordering type checks

2025-08-25 Thread Chao Li
array   3 | "hello world"                | string   4 | 12345                        | number   5 | true                         | boolean   6 | null                         | null (6 rows) ``` Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/ From 1468ca2a0bc8b3769cf5cd3ca5

Re: Making jsonb_agg() faster

2025-08-25 Thread Chao Li
t(&it, &val, true); Assert(tok == WJB_VALUE); - memset(&ps, 0, sizeof(ps)); + //memset(&ps, 0, sizeof(ps)); pushJsonbValue(&ps, WJB_BEGIN_OBJECT, NULL); Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: Fixes a trivial bug in dumped parse/query/plan trees

2025-08-25 Thread Chao Li
ormat similar to that used for Lists, that is "<>" for a NULL pointer or "(item item item)" otherwise. Also retool the code to not have so many copies of the identical logic. It mentioned “(item item item)”, not a whitespace in front of the first item. Best regard

Re: Fixes a trivial bug in dumped parse/query/plan trees

2025-08-24 Thread Chao Li
d normalization of such values. > Are you suggesting add a test case to this patch? Can you please be more specific? Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: disallow alter individual column if partition key contains wholerow reference

2025-08-24 Thread Chao Li
reference, then every * column is implicitly part of the expression. Set used_in_expr to true * unconditionally. */ Best reagards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: Identifying function-lookup failures due to argument name mismatches

2025-08-24 Thread Chao Li
uot;procedure" : "function"; /* if (proc_call) return errdetail("There is no procedure of that name."); else return errdetail("There is no function of that name."); */ return errdetail("There is no %s of that name.", func_kind); ``` Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: minor refactor on src/test/modules/test_ddl_deparse/sql/alter_table.sql

2025-08-24 Thread Chao Li
ve ALTER TABLE ALTER COLUMN SET EXPRESSION, > so I added a test on it. > I confirm “make check” passed with this patch. -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Fixes a trivial bug in dumped parse/query/plan trees

2025-08-24 Thread Chao Li
regards, --Chao Li (Evan)HighGo Software Co., Ltd.https://www.highgo.com/ v1-0001-Fixes-a-trivial-bug-in-dumped-parse-query-plan-tr.patch Description: Binary data

Re: Add OID descriptions to dumped parse/query/plan trees

2025-08-24 Thread Chao Li
> On Aug 22, 2025, at 22:10, Tom Lane wrote: > > Chao Li writes: >> When reading dumped parse/query/plan trees, sometime we want to know >> what exact type/operator/function an OID stands for. I just added a new >> feature that will add some OID descripti

Re: Remove unneeded cast in heap_xlog_lock.

2025-08-22 Thread Chao Li
#L1083-L1121 > > -- > Best regards, > Kirill Reshke > As there are only 76 occurrences, I think using one commit to clean up the unnecessary cast is worthwhile. -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Add OID descriptions to dumped parse/query/plan trees

2025-08-22 Thread Chao Li
      :indexqual (          {OPEXPR          :opno 521 # operator >(integer,integer)          :opfuncid 147 # function int4gt(integer,integer)          :opresulttype 16 # type boolean          :opretset false          :opcollid 0 ``` The patch file is attached. Best regards, -- Chao Li (E

Re: Remove unneeded cast in heap_xlog_lock.

2025-08-21 Thread Chao Li
and the receiving variable “page” is of “Page” type as well, so the cast is not needed. -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: Fix replica identity checks for MERGE command on published table.

2025-08-21 Thread Chao Li
Hi Zhijie, > On Aug 21, 2025, at 11:41, Zhijie Hou (Fujitsu) > wrote: > > > Thanks for working on the patch. I tested it locally, and it worked for me properly. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Remove redundant assignment in CreateWorkExprContext

2025-08-20 Thread Chao Li
regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/ From 5b5462398117acd0203e760b7bf18c4ff616cf81 Mon Sep 17 00:00:00 2001 From: "Chao Li (Evan)" Date: Thu, 21 Aug 2025 11:35:18 +0800 Subject: [PATCH v1] Remove redundant assignemnt in CreateWorkExprC

Re: Remove redundant assignment of a variable in function AlterPublicationTables

2025-08-20 Thread Chao Li
function, the bug will lead to a consistent result. So, I think it’s a good practice to always initiate a value before passing its pointer to a function. -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: Remove redundant assignment of a variable in function AlterPublicationTables

2025-08-20 Thread Chao Li
ther functions with its pointer, in this specific case, compilers won’t be able to do much optimization on “isnull”. It still needs to allocate “isnull” on stack and assign “true” to it at runtime. But anyway, that’s a tiny cost that we don’t need to worry about. -- Chao Li (Evan) HighGo Software C

Re: Remove traces of long in dynahash.c

2025-08-20 Thread Chao Li
gesting. > > Any comments from others? > -- > Michael I don’t want to block you. Unless others have the same comment about naming, you can go ahead and move forward. I agree further refactoring can belong to a separate commit. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: Remove redundant assignment of a variable in function AlterPublicationTables

2025-08-20 Thread Chao Li
ns, yes, “isnull” will always be assigned. But how about if someone incidentally changed a subsequent function and moved an assignment? I think giving an initial value is a good habit without much performance burden. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: Remove traces of long in dynahash.c

2025-08-20 Thread Chao Li
gt; the signedness but we could just cap the maximum at > (PG_UINT{32,64}_MAX / 2), I guess, with two new routines like: > uint64 pg_nextpower2_64_max(uint64 num); > uint32 pg_prevpower2_32_max(uint32 num); > I wonder if we can keep the same naming style to make the new function name

Re: UPDATE with invalid domain constraint

2025-08-19 Thread Chao Li
487 has MemSet typeentry to all 0. + if (IsA(node, Var)) + { + Node*result; + result = ConvertVarToCoerceToDomain((Var *) node); + + old_tle->expr = (Expr *) result; + } Should we also set node = result? Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: Organize working memory under per-PlanState context

2025-08-19 Thread Chao Li
, if the node has no work mem yet, then it will automatically create workmem for the node. Will that lead to unneeded workmem creation? If workmem is null, that means workmem is not used, thus not exceeding limit. -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: Raw parse tree is not dumped to log

2025-08-19 Thread Chao Li
> On Aug 20, 2025, at 09:25, Tatsuo Ishii wrote: >> > v5 patch looks good to me. If there's no objection, I plan to push the > patch in early September. > Hi Tatsuo san, Thank you much very for your support. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: Identifying function-lookup failures due to argument name mismatches

2025-08-19 Thread Chao Li
ore details. I traced this problem today, and I agree that making FuncnameGetCandidates to pass out some information should be right direction to go. When there are multiple matches, I think we can find the best match by considering argument names/types, default values. If there are still multiple b

Re: New commitfest app release on August 19th

2025-08-19 Thread Chao Li
any email link or attachment link. -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: Remove traces of long in dynahash.c

2025-08-18 Thread Chao Li
worry about registering hash_seq_search scans, Looks like a bad auto replacement: “no longer”, here “long" should be kept. -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: Enhance Makefiles to rebuild objects on map file changes

2025-08-18 Thread Chao Li
Nothing to be done for `generated-headers'. /Library/Developer/CommandLineTools/usr/bin/make -C nodes generated-header-symlinks make[2]: Nothing to be done for `generated-header-symlinks'. /Library/Developer/CommandLineTools/usr/bin/make -C utils generated-header-symlinks /Library/Developer/CommandLineTools/usr/bin/make -C adt jsonpath_gram.h make[3]: `jsonpath_gram.h' is up to date. ``` -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: Improve hash join's handling of tuples with null join keys

2025-08-18 Thread Chao Li
t; tuples that (probably) don't have null join keys. The fact that you > could cram it in with not very many lines of code does not mean that > the result will be understandable or maintainable --- and certainly, > hash join is on the hairy edge of being too complicated already. > &

Re: Raw parse tree is not dumped to log

2025-08-18 Thread Chao Li
"debug_print_raw_parse" is "on". Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/ From a2501a6cb70a9bb198163acbdef043290fd85b53 Mon Sep 17 00:00:00 2001 From: "Chao Li (HighGo Inc.)" Date: Thu, 31 Jul 2025 17:02:32 +0800 Subject: [PATCH v5] Add

Re: Improve hash join's handling of tuples with null join keys

2025-08-17 Thread Chao Li
> On Aug 16, 2025, at 00:52, Tom Lane wrote: > > Chao Li writes: >> With this patch, “isnull” now becomes true because of the change of strict >> op. Then the outer null join key tuple must be stored in a tuplestore. When >> an outer table contains a lot of nul

Re: Raw parse tree is not dumped to log

2025-08-17 Thread Chao Li
I can use a separate commit to add "unlikely". Best regards, -- Chao Li (Evan) -- HighGo Software Inc. https://www.highgo.com/ From bef138c16e78c815bb653db37a01c28cd024abd5 Mon Sep 17 00:00:00 2001 From: "Chao Li (HighGo Inc.)" Date: Thu, 31 Ju

Clarify comment in _bt_set_startikey

2025-08-15 Thread Chao Li
Hi Hackers, While reviewing the code, I found the original comment difficult to follow, so I am trying to rephrase it for clarity. Regards, Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/From d4bfb58e2904c919f0891643142fc87069a2c69d Mon Sep 17 00:00:00

Re: Adding support for Row Compares to nbtree startikey optimization

2025-08-14 Thread Chao Li
> On Aug 15, 2025, at 14:37, Chao Li wrote: > > When subkey->sk_attno <= firstchangingattnum, if first is not satisfied, then > last should not be satisfied either, so we can skip check last. Sorry for a typo, "subkey->sk_attno <= firstchangingattnum”

Re: Adding support for Row Compares to nbtree startikey optimization

2025-08-14 Thread Chao Li
I tested the patch. Basically all of my test cases passed. Just a few small comments: + if (subkey->sk_attno > firstchangingattnum) /* >, not >= */ + break; Can we enhance the comment to something like ">, not >= because first

Re: Make pgoutput documentation easier to find

2025-08-14 Thread Chao Li
tested again. Now this patch looks good to me. BTW, in the pushed commit, when you add me as a reviewer, would you please use my company email address: "Chao Li ". Thanks a lot. The new status of this patch is: Ready for Committer

Re: Make pgoutput documentation easier to find

2025-08-13 Thread Chao Li
I applied the batch and built the html docs. I tested that all hyperlinks worked for me. There are a few nit comments about wording: diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 593f784b69d..4516650983d 100644 --- a/doc/src/sgml/logicaldecoding.sgml +

Re: Improve hash join's handling of tuples with null join keys

2025-08-13 Thread Chao Li
> On Aug 13, 2025, at 17:16, Chao Li wrote: > > I downloaded the patch and tested all join types: inner, left, right, full, > semi and anti. Basically my tests all passed. However, I didn't test any case > of parallel query. > > I have two nit comments: > &

Re: Improve hash join's handling of tuples with null join keys

2025-08-13 Thread Chao Li
I downloaded the patch and tested all join types: inner, left, right, full, semi and anti. Basically my tests all passed. However, I didn't test any case of parallel query. I have two nit comments: 1. In hashjoin.h, line 76-78, the added comment says "(In the unlikely but supported case of a n

Re: GB18030-2022 Support in PostgreSQL

2025-08-13 Thread Chao Li
On 2025/8/13 15:20, Chao Li wrote: Sounds good. Let me recreate the patch. Attached is the new patch. It downloads the UCM file in make: ``` Unicode % make gb18030_to_utf8.map wget -O gb-18030-2000.ucm --no-use-server-timestamps https://raw.githubusercontent.com/unicode-org/icu-data

Re: GB18030-2022 Support in PostgreSQL

2025-08-13 Thread Chao Li
2022) but we can consider that later. For now let's leave the > XML file alone. > Sounds good. Let me recreate the patch. Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: Enhance Makefiles to rebuild objects on map file changes

2025-08-12 Thread Chao Li
is “plain/text” now in “Archives”. Regards, Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: GB18030-2022 Support in PostgreSQL

2025-08-11 Thread Chao Li
ING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THE DATA FILES OR SOFTWARE. Unicode and the Unicode logo are trademarks of Unicode, Inc. in the United States and other countries. A

Re: Patch 1 of GB18030-2022 support

2025-08-11 Thread Chao Li
minimum changes to map files. I would prefer option 2 or 3, and slightly more keen on 3. What do you think? Best regards, Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: GB18030-2022 Support in PostgreSQL

2025-08-11 Thread Chao Li
e implied to me that the patch added something not in the > upstream file. > I will update the commit message in the new patch. Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: GB18030-2022 Support in PostgreSQL

2025-08-11 Thread Chao Li
are no longer required by the new standard, but are > retained in this patch for compatibility" > > How is that done? The 9 mappings are not changed between 2000.ucm and 2022.ucm. For example, GB18030 code 0xFD9C is one of the 9 not-required code, but the mapping: \xFD\x9C

Enhance Makefiles to rebuild objects on map file changes

2025-08-05 Thread Chao Li
again without map file change# nothing re-compiled Chao Li (Evan)HighGo Infra. Software Inc.https://www.highgo.com/ v1-0001-Enhance-Makefiles-to-rebuild-objects-on-map-file-.patch Description: Binary data

Re: Enhance Makefiles to rebuild objects on map file changes

2025-08-05 Thread Chao Li
It looks weird. From https://www.postgresql.org/message-id/1CA8625F-AA41-4ED2-B60F-E28AC71F37DC%40highgo.com, I don’t see the attachment of the patch file. However, the email in my Inbox has the attachment.Try to resend the attachment. Chao Li (Evan)HighGo Infra. Software

Re: Fixed a minor typo in code comment

2025-08-05 Thread Chao Li
I am fine with that, and thanks for the v2 patch. Chao Li (Evan) HighGo Infra. Software Inc. https://www.highgo.com/ > On Aug 6, 2025, at 12:11, Fujii Masao wrote: > > On Wed, Aug 6, 2025 at 8:11 AM Chao Li wrote: >> >> Hi, >> >> I d

Re: Raw parse tree is not dumped to log

2025-08-05 Thread Chao Li
Updated the patch to v3 version. Chao Li (Evan) -- HighGo Software Inc. https://www.highgo.com/ Chao Li 于2025年8月5日周二 14:25写道: > CommitFests patch created: https://commitfest.postgresql.org/patch/5946/ > > 2025年8月4日 16:17,Chao Li 写道: > > I just noti

Fixed a minor typo in code comment

2025-08-05 Thread Chao Li
Hi,I didn’t intend to modify the module, but noticed the typo while searching through the code. Submitting a patch to correct it.I ran a basic test of “make check” and the test passed. v1-0001-Fix-a-minor-typo-in-code-comment.patch Description: Binary data Chao Li (Evan

Re: Raw parse tree is not dumped to log

2025-08-04 Thread Chao Li
CommitFests patch created: https://commitfest.postgresql.org/patch/5946/ > 2025年8月4日 16:17,Chao Li 写道: > > I just noticed that my IDE auto formatted guc_tables.c, which generated a lot > of unnecessary diffs. Recreated the patch, and attach the v2 version. >

Re: GB18030-2022 Support in PostgreSQL

2025-08-04 Thread Chao Li
ease note may recommend the tools. Regards, Chao Li (Evan) -- HighGo Infra. Software Inc. https://www.highgo.com/

Re: Raw parse tree is not dumped to log

2025-08-04 Thread Chao Li
I just noticed that my IDE auto formatted guc_tables.c, which generated a lot of unnecessary diffs. Recreated the patch, and attach the v2 version. Chao Li (Evan) -- HighGo Software Inc. https://www.highgo.com/ Chao Li 于2025年8月4日周一 15:57写道: > Oh, I forget

Re: Raw parse tree is not dumped to log

2025-08-04 Thread Chao Li
Oh, I forget to attached the patch file, here comes it. Chao Li (Evan) -- HighGo Software Inc. https://www.highgo.com/ Chao Li 于2025年8月4日周一 15:53写道: > I was reviewing some patches today, and during debugging the patches, I > wanted to view raw parse tree, so

Re: Raw parse tree is not dumped to log

2025-08-04 Thread Chao Li
ion is that, if start "postgres -d 3", it originally only turn on debug_print_parse, now it will turn on debug_print_raw_parse as well, which potentially make people who don't want raw parse tree unhappy. Maybe use "-d 5" or not turning on debug_print_raw_parse at all by "-d&quo

Re: A little cosmetic to convert_VALUES_to_ANY()

2025-08-03 Thread Chao Li
I tested this patch locally and it works for me. However I doubt if it really improve performance. The original code "contain_volatile_functions((Node *) rte->values_lists)" recursively work through rte-values_list, and this patch move contain_volatile_functions() into the for loop, and checks

Re: Trivial patch to fix a typo

2025-08-02 Thread Chao Li
Hi Michael, Thank you so much for your help. I am new to PG development, I'll keep learning. :) Chao Li (Evan) -- HighGo Software Inc. https://www.highgo.com/ Michael Paquier 于2025年8月2日周六 18:55写道: > On Fri, Aug 01, 2025 at 03:16:18PM +0800, Chao Li wrote

Re: When creating index, why pointing to old version of tuple

2025-08-01 Thread Chao Li
This explanation sounds reasonable to me. I didn't mean to "optimize" the logic, I was just trying to understand the behavior. Chao Li (Evan) -- HighGo Software Inc. https://www.highgo.com/ David G. Johnston 于2025年8月1日周五 15:50写道: > On Friday, Au

Re: Raw parse tree is not dumped to log

2025-08-01 Thread Chao Li
raw parse tree, turning on a flag once is much more convenient than typing a command in the debugger for every trace. I will wait to see if Tom still objects to adding that. I will not make the code change unless I see a hint of "go". Chao Li (Evan) -- H

Re: Trivial patch to fix a typo

2025-08-01 Thread Chao Li
Ah ... Good to learn. Attached v2 updated the out file as well, now the test passed: $ make check ... # All 229 tests passed. Thanks a lot. Chao Li (Evan) -- HighGo Software Inc. https://www.highgo.com/ Michael Paquier 于2025年8月1日周五 15:04写道: > On Fri, Aug 01, 2

Re: When creating index, why pointing to old version of tuple

2025-08-01 Thread Chao Li
> But what if the table already has an index? I have tested that, if I create the index first, then update the tuple, the index entry will only point to the new version of data. That's why my question was specifically about creating the index after updating the tuple. Chao

Trivial patch to fix a typo

2025-07-31 Thread Chao Li
Hi Committers, I happened to catch this typo while reading the regression test code, so submitting a fix. As the typo is in the code comment, no test needs to run. Best regards, Chao Li (Evan) -- HighGo Software Inc. https://www.highgo.com/ v1-0001-Fixed-a-typo-in

Re: When creating index, why pointing to old version of tuple

2025-07-31 Thread Chao Li
try. Chao Li (Evan) -- HighGo Software Inc. https://www.highgo.com/ Tender Wang 于2025年8月1日周五 14:37写道: > > > Chao Li 于2025年8月1日周五 14:16写道: > >> Hi Community, >> >> Let me use a small example to demonstrate my observation. >> >>

When creating index, why pointing to old version of tuple

2025-07-31 Thread Chao Li
ansactions and in-progress transactions won't see the newly created index. So, it should be ok for the index to point to the newest version of tuple version that is visible to the index. Can anyone please explain me about that? Thanks and regards, Chao Li (Evan) -- HighGo Software Inc. https://www.highgo.com/

Raw parse tree is not dumped to log

2025-07-31 Thread Chao Li
irm with the community if it's intentional to not dump raw parse tree? If we really don't want to dump raw parse tree again "debug_print_parse", are you ok to add a new option "debug_print_raw_parse"? Chao Li (Evan) -- HighGo Software Inc. https://www.highgo.com/

Re: Should --enable-debug set CFLAGS to -O0 instead of -O2?

2025-07-31 Thread Chao Li
My bad. You are right, the last -O will work. Then I think I get a solution to my original problem. Thanks again for your help. Chao Li (Evan) -- HighGo Software Inc. https://www.highgo.com/ Tom Lane 于2025年8月1日周五 12:07写道: > Chao Li writes: > > Thank

Re: Should --enable-debug set CFLAGS to -O0 instead of -O2?

2025-07-31 Thread Chao Li
Hi Tom, Thanks for the explanation. W.R.T the PROFILE variable, I tried: # ./configure --enable-debug # PROFILE="-O0" make As a result, both "-O2" and "-O0" presented to gcc. In that case, I believe "-O0" will be ignored by gcc. Did yo

Should --enable-debug set CFLAGS to -O0 instead of -O2?

2025-07-31 Thread Chao Li
mode, don't use -O if test "$enable_debug" != yes; then CFLAGS="-O" fi fi For GCC, we need to use "-O0" for best debugging experience. Why here always uses "-O2" for GCC regardless debugging? If confirmed a bug, I'd like a submit a patch to fix that. Thanks, Chao Li (Evan) HighGo Inc.

Re: Cannot login CommitFests due to cool-off period

2025-07-31 Thread Chao Li
No worries. I am in now. Chao Li 于2025年8月1日周五 08:19写道: > Hi CommitFests maintainers, > > I logged in to the PostgreSQL site via my Google account a couple of > days ago, and I still cannot log in to CommitFests. The error I got is: > > ``` > > The site you

Re: [PATCH v1] Trivial: ignore IDE-specific files (.vscode/)

2025-07-31 Thread Chao Li
Hi David, I see. That was my first submission. I have a few more patches to submit, your suggestion really helps. Chao Li (Evan) David G. Johnston 于2025年8月1日周五 10:25写道: > On Thu, Jul 31, 2025 at 7:15 PM Chao Li wrote: > >> Thanks a lot for the comment, then please discar

  1   2   >