Re: libpq environment variables in the server

2019-01-27 Thread Dmitry Igrishin
пн, 21 янв. 2019 г. в 13:42, Peter Eisentraut : > > When libpq is loaded in the server (libpqwalreceiver, dblink, > postgres_fdw), it may use libpq environment variables set in the > postmaster environment for connection parameter defaults. I have > noticed that this has some confusing effects in

Re: proposal: plpgsql pragma statement

2018-12-05 Thread Dmitry Igrishin
вт, 4 дек. 2018 г. в 20:13, Pavel Stehule : > > Hi > > I wrote plpgsql_check https://github.com/okbob/plpgsql_check. > > It is working well, but because it does static analyse only, sometimes it can > produces false alarms or it should to stop a analyse, because there are not > necessary data. >

Re: Usability fail with psql's \dp command

2018-07-28 Thread Dmitry Igrishin
> > > What do people think of printing "Default" if the ACL is null? > > Alternatively, since the state with an empty ACL is certainly > the unusual case, maybe we should mark that specially, perhaps > by printing "None" or "No privileges". Old problem. +1.

psql's meta command \d is broken as of 12 beta2.

2019-08-05 Thread Dmitry Igrishin
Hi, Sorry if this report is duplicate but there is no column relhasoids in pg_catalog.pg_class required by the underlying query of the \d meta command of psql.

Re: psql's meta command \d is broken as of 12 beta2.

2019-08-05 Thread Dmitry Igrishin
пн, 5 авг. 2019 г. в 14:42, Pavel Stehule : > > Hi > > > po 5. 8. 2019 v 13:35 odesílatel Dmitry Igrishin napsal: >> >> Hi, >> >> Sorry if this report is duplicate but there is no column relhasoids in >> pg_catalog.pg_class required by the under

Small patch to fix build on Windows

2019-08-06 Thread Dmitry Igrishin
Hi, The attached self-documented patch fixes build on Windows in case when path to Python has embedded spaces. diff --git a/src/tools/msvc/Mkvcbuild.pm b/src/tools/msvc/Mkvcbuild.pm index d1d0aed07e..76834f5188 100644 --- a/src/tools/msvc/Mkvcbuild.pm +++ b/src/tools/msvc/Mkvcbuild.pm @@ -495,7 +4

Re: Small patch to fix build on Windows

2019-08-07 Thread Dmitry Igrishin
ср, 7 авг. 2019 г. в 11:29, Kyotaro Horiguchi : > > Hi, > > At Tue, 6 Aug 2019 22:50:14 +0300, Dmitry Igrishin wrote > in > > The attached self-documented patch fixes build on Windows in case when > > path to Python has embedded spaces. > > - $solution

Re: Small patch to fix build on Windows

2019-08-07 Thread Dmitry Igrishin
ср, 7 авг. 2019 г. в 15:33, Juan José Santamaría Flecha : > > On Wed, Aug 7, 2019 at 11:11 AM Dmitry Igrishin wrote: > > > > ср, 7 авг. 2019 г. в 11:29, Kyotaro Horiguchi : > > > > > > Solution.pm has the following line: > > > > > > &g

Re: Small patch to fix build on Windows

2019-08-08 Thread Dmitry Igrishin
чт, 8 авг. 2019 г. в 06:18, Kyotaro Horiguchi : > > Hello. > > At Wed, 7 Aug 2019 12:14:48 +0300, Dmitry Igrishin wrote > in > > > -if ($lib =~ m/\s/) > > > -{ > > > -$lib = '"' . $lib . """; > > >

Re: Small patch to fix build on Windows

2019-08-08 Thread Dmitry Igrishin
> > As for the replace comment, I'm not > > sure it is needed since I think quoting is not the task for > > AddLibrary/AddIncludeDir in the first place (and AddIncludeDir > > doesn't have the same comment). The attached 3rd version of the patch contains no comment in AddLibrary(). Sorry, forgot to

Re: Small patch to fix build on Windows

2019-08-08 Thread Dmitry Igrishin
чт, 8 авг. 2019 г. в 20:07, Alvaro Herrera : > > On 2019-Aug-08, Dmitry Igrishin wrote: > > > my $prefixcmd = > > - $solution->{options}->{python} . "\\python -c > > \"$pythonprog\""; > > + "

Re: Small patch to fix build on Windows

2019-08-08 Thread Dmitry Igrishin
пт, 9 авг. 2019 г. в 05:45, Michael Paquier : > > On Thu, Aug 08, 2019 at 10:46:07PM +0300, Dmitry Igrishin wrote: > > This looks nice for a Perl hacker :-). As for me, it looks unusual and > > a bit confusing. I never > > programmed in Perl, but I was able to quic

Re: Small patch to fix build on Windows

2019-08-09 Thread Dmitry Igrishin
пт, 9 авг. 2019 г. в 10:23, Kyotaro Horiguchi : > > At Fri, 9 Aug 2019 09:56:27 +0300, Dmitry Igrishin wrote > in > > пт, 9 авг. 2019 г. в 05:45, Michael Paquier : > > > > > > On Thu, Aug 08, 2019 at 10:46:07PM +0300, Dmitry Igrishin wrote: > > > >

Re: Small patch to fix build on Windows

2019-08-13 Thread Dmitry Igrishin
вт, 13 авг. 2019 г. в 06:19, Michael Paquier : > > On Fri, Aug 09, 2019 at 11:21:52AM +0300, Dmitry Igrishin wrote: > > Personally I don't care. I used || notation only in order to be > > consistent, since this notation is already used in Solution.pm. If > > this consi

Re: libpq environment variables in the server

2019-01-27 Thread Dmitry Igrishin
пн, 21 янв. 2019 г. в 13:42, Peter Eisentraut : > > When libpq is loaded in the server (libpqwalreceiver, dblink, > postgres_fdw), it may use libpq environment variables set in the > postmaster environment for connection parameter defaults. I have > noticed that this has some confusing effects in

Re: proposal: plpgsql pragma statement

2018-12-05 Thread Dmitry Igrishin
вт, 4 дек. 2018 г. в 20:13, Pavel Stehule : > > Hi > > I wrote plpgsql_check https://github.com/okbob/plpgsql_check. > > It is working well, but because it does static analyse only, sometimes it can > produces false alarms or it should to stop a analyse, because there are not > necessary data. >

psql's meta command \d is broken as of 12 beta2.

2019-08-05 Thread Dmitry Igrishin
Hi, Sorry if this report is duplicate but there is no column relhasoids in pg_catalog.pg_class required by the underlying query of the \d meta command of psql.

Re: psql's meta command \d is broken as of 12 beta2.

2019-08-05 Thread Dmitry Igrishin
пн, 5 авг. 2019 г. в 14:42, Pavel Stehule : > > Hi > > > po 5. 8. 2019 v 13:35 odesílatel Dmitry Igrishin napsal: >> >> Hi, >> >> Sorry if this report is duplicate but there is no column relhasoids in >> pg_catalog.pg_class required by the under

Small patch to fix build on Windows

2019-08-06 Thread Dmitry Igrishin
Hi, The attached self-documented patch fixes build on Windows in case when path to Python has embedded spaces. diff --git a/src/tools/msvc/Mkvcbuild.pm b/src/tools/msvc/Mkvcbuild.pm index d1d0aed07e..76834f5188 100644 --- a/src/tools/msvc/Mkvcbuild.pm +++ b/src/tools/msvc/Mkvcbuild.pm @@ -495,7 +4

Re: Small patch to fix build on Windows

2019-08-07 Thread Dmitry Igrishin
ср, 7 авг. 2019 г. в 11:29, Kyotaro Horiguchi : > > Hi, > > At Tue, 6 Aug 2019 22:50:14 +0300, Dmitry Igrishin wrote > in > > The attached self-documented patch fixes build on Windows in case when > > path to Python has embedded spaces. > > - $solution

Re: Small patch to fix build on Windows

2019-08-07 Thread Dmitry Igrishin
ср, 7 авг. 2019 г. в 15:33, Juan José Santamaría Flecha : > > On Wed, Aug 7, 2019 at 11:11 AM Dmitry Igrishin wrote: > > > > ср, 7 авг. 2019 г. в 11:29, Kyotaro Horiguchi : > > > > > > Solution.pm has the following line: > > > > > > &g

Re: Small patch to fix build on Windows

2019-08-08 Thread Dmitry Igrishin
чт, 8 авг. 2019 г. в 06:18, Kyotaro Horiguchi : > > Hello. > > At Wed, 7 Aug 2019 12:14:48 +0300, Dmitry Igrishin wrote > in > > > -if ($lib =~ m/\s/) > > > -{ > > > -$lib = '"' . $lib . """; > > >

Re: Small patch to fix build on Windows

2019-08-08 Thread Dmitry Igrishin
> > As for the replace comment, I'm not > > sure it is needed since I think quoting is not the task for > > AddLibrary/AddIncludeDir in the first place (and AddIncludeDir > > doesn't have the same comment). The attached 3rd version of the patch contains no comment in AddLibrary(). Sorry, forgot to

Re: Small patch to fix build on Windows

2019-08-08 Thread Dmitry Igrishin
чт, 8 авг. 2019 г. в 20:07, Alvaro Herrera : > > On 2019-Aug-08, Dmitry Igrishin wrote: > > > my $prefixcmd = > > - $solution->{options}->{python} . "\\python -c > > \"$pythonprog\""; > > + "

Re: Small patch to fix build on Windows

2019-08-08 Thread Dmitry Igrishin
пт, 9 авг. 2019 г. в 05:45, Michael Paquier : > > On Thu, Aug 08, 2019 at 10:46:07PM +0300, Dmitry Igrishin wrote: > > This looks nice for a Perl hacker :-). As for me, it looks unusual and > > a bit confusing. I never > > programmed in Perl, but I was able to quic

Re: Small patch to fix build on Windows

2019-08-09 Thread Dmitry Igrishin
пт, 9 авг. 2019 г. в 10:23, Kyotaro Horiguchi : > > At Fri, 9 Aug 2019 09:56:27 +0300, Dmitry Igrishin wrote > in > > пт, 9 авг. 2019 г. в 05:45, Michael Paquier : > > > > > > On Thu, Aug 08, 2019 at 10:46:07PM +0300, Dmitry Igrishin wrote: > > > >

Re: Small patch to fix build on Windows

2019-08-13 Thread Dmitry Igrishin
вт, 13 авг. 2019 г. в 06:19, Michael Paquier : > > On Fri, Aug 09, 2019 at 11:21:52AM +0300, Dmitry Igrishin wrote: > > Personally I don't care. I used || notation only in order to be > > consistent, since this notation is already used in Solution.pm. If > > this consi

Re: Usability fail with psql's \dp command

2018-07-28 Thread Dmitry Igrishin
> > > What do people think of printing "Default" if the ACL is null? > > Alternatively, since the state with an empty ACL is certainly > the unusual case, maybe we should mark that specially, perhaps > by printing "None" or "No privileges". Old problem. +1.

Re: Building PostgreSQL extensions on Windows

2020-06-12 Thread Dmitry Igrishin
Hi David, No pain with CMake. It's pretty easy to use it in Windows for PostgreSQL extensions. Example, https://github.com/dmitigr/pgnso On Fri, 12 Jun 2020, 01:43 David Rowley, wrote: > Hi, > > I've heard from a few people that building PostgreSQL extensions on > Windows is a bit of a pain. I

Is it memory leak or not?

2020-02-10 Thread Dmitry Igrishin
Hello, Maybe I'm wrong, but anychar_typmodin() of src/backend/utils/adt/varchar.c of PostgreSQL 12.1 does not pfree()s the memory allocated by ArrayGetIntegerTypmods(). Probably, I'm missing something. Could anybody please clarify on that? Thanks!

Re: Is it memory leak or not?

2020-02-10 Thread Dmitry Igrishin
On Mon, 10 Feb 2020, 18:59 Tom Lane, wrote: > Dmitry Igrishin writes: > > Maybe I'm wrong, but anychar_typmodin() of > > src/backend/utils/adt/varchar.c of PostgreSQL 12.1 does not pfree()s > > the memory allocated by ArrayGetIntegerTypmods(). Probably, I'm >