Re: old_snapshot: add test for coverage

On Mon, Aug 8, 2022 at 2:37 PM Tom Lane wrote: > > Dong Wook Lee writes: > > I wrote a test of the old_snapshot extension for coverage. > > Hmm, does this really provide any meaningful coverage? The test > sure looks like it's not doing much. Previously written tests

Re: pg_basebackup: add test about zstd compress option

> The only thing that I can think of would be if $decompress_program > --test were failing, but actually trying to decompress succeeded. I > would be inclined to dismiss that particular scenario as not important > enough to be worth the additional CPU cycles. When I wrote this test, it was just to

Re: Improve tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE

On Fri, Oct 28, 2022 at 12:08 AM vignesh C wrote: > > Hi, > > Tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE action was > missing, this patch adds the tab completion for the same. > > Regards, > Vignesh Hi, I applied your patch and did some tests. Is it okay not to consider SET and RESET com

Re: pgstattuple: add test for coverage

> Which indeed is the case, e.g. on 32bit systems it fails: > > https://cirrus-ci.com/task/4619535222308864?logs=test_world_32#L253 > > https://api.cirrus-ci.com/v1/artifact/task/4619535222308864/testrun/build-32/testrun/pgstattuple/regress/regression.diffs > > table_len | tuple_count | tuple_len

Re: add test to psql for coverage with --help, \e option, encoding option

I confirmed that I missed the patch file. And the current code is different from when I wrote the patch, so I don't think my patch will be meaningful anymore. On Sat, Sep 3, 2022 at 6:08 PM Dong Wook Lee wrote: > > Hi hackers, > I try to add to psql test about --help, \e, and the e

add test to psql for coverage with --help, \e option, encoding option

Hi hackers, I try to add to psql test about --help, \e, and the encoding option. --- Regards, DongWook Lee.

vacuumlo: add test to vacuumlo for test coverage

Hi hackers, I write a tiny patch about vacuumlo to improve test coverage. I hope my work is meaningful. --- Regards, DongWook Lee. v1_add_test_to_vacuumlo.patch Description: Binary data

Re: add test: pg_rowlocks extension

On Fri, Sep 2, 2022 at 4:07 AM Tom Lane wrote: > Pushed with some revisions. Notably, I didn't see any point in > repeating each test case four times, so I trimmed it down to once > per case. I checked it. Thank you for correcting it in a better way.

pg_checksum: add test for coverage

Hi, I add a tiny test to pg_checksum for coverage. I checked it improve test coverage 77.9% -> 87.7%. --- Regards, DongWook Lee. v1_add_test_to_pg_checksum.patch Description: Binary data

Re: pg_basebackup: add test about zstd compress option

On Tue, Aug 23, 2022 at 11:37 AM Michael Paquier wrote: > It seems to me that checking that the contents generated are valid is > equally necessary. We do that with zlib with gzip --test, and you > could use ${ZSTD} in the context of this test. Thank you for the good points. I supplemented the

pg_basebackup: add test about zstd compress option

Hi hackers, I checked the test code not to test the zstd option, then added it. I hope my patch will help us to ensure safety of the test. --- Regards, DongWook Lee. v1_add_test_pg_basebackup.patch Description: Binary data

pg_waldump: add test for coverage

Hi Hackers, I wrote a test for coverage. Unfortunately, it seems to take quite a while to run the test. I want to improve these execution times, but I don't know exactly what to do. Therefore, I want to hear feedback from many people. --- Regards, Dong Wook Lee v1_add_test_pg_waldump.

xml2: add test for coverage

Hi, hackers I made a small patch for xml2 to improve test coverage. However, there was a problem using the functions below. - xpath_number - xpath_bool - xpath_nodeset - xpath_list Do you have any advice on how to use this function correctly? It would also be good to add an example of using the f

old_snapshot: add test for coverage

Hi hackers, I wrote a test of the old_snapshot extension for coverage. I hope that this is written correctly. before: 0% after: 100% --- regards, Lee Dong Wook. v1_add_test_oldsnapshot.patch Description: Binary data

Re: pgstattuple: add test for coverage

Tom Lane writes: > I do not think it's a great idea to create random dependencies > between modules like the pgstattuple -> bloom dependency you > casually added here. I agree with your option. Is there no problem with selecting all the columns during SELECT statements? I thought there might be

Re: add test: pg_rowlocks extension

I modified my previous patch by reflecting the feedback. and I wrote most of the queries for the test after looking at the file below. - ref: (https://github.com/postgres/postgres/blob/master/src/test/isolation/specs/tuplelock-conflict.spec) The coverage of the test is approximately 81.5%. If t

Re: add test: pg_rowlocks extension

2022년 7월 31일 (일) 오전 6:32, Tom Lane 님이 작성: > > Dong Wook Lee writes: > > I just wrote test about pg_rowlocks extension. > > I added sql and spec test for locking state. > > I think this could be cut down quite a bit. Do we really need > both a SQL test and an isolation

pgstattuple: add test for coverage

Hi, hackers I added some SQL statements to improve test coverage. As data was inserted, the expected file changed. So should I change all `select *` for a stable expected result? And it's the coverage change as I add 50.6% -> 78.7% --- regards, Lee Dong Wook v1_add_test_pgstattuple.patch Descrip

Re: pg_buffercache: add sql test

I've been missing what I have to add to the .gitignore file when I write the test. I will refer to it when I write the test code from now on. Thank you. 2022년 7월 31일 (일) 오전 4:39, Tom Lane 님이 작성: > > Dong Wook Lee writes: > > I just wrote a test code for the `pg_buffercache

Re: Add test of pg_prewarm extenion

2022년 8월 1일 (월) 오후 11:33, Dong Wook Lee 님이 작성: > > Thank you for letting me know. > I edited my patch with `wait_for_log()`. > > 2022년 8월 1일 (월) 오후 6:55, Julien Rouhaud 님이 작성: > > > > On Mon, Aug 1, 2022 at 5:16 PM Dong Wook Lee wrote: > > > > > > >

Re: Add test of pg_prewarm extenion

Thank you for letting me know. I edited my patch with `wait_for_log()`. 2022년 8월 1일 (월) 오후 6:55, Julien Rouhaud 님이 작성: > > On Mon, Aug 1, 2022 at 5:16 PM Dong Wook Lee wrote: > > > > > Keep in mind also that the logfile accumulates over stops and > > > restarts.

pg_waldump got an error with waldump file generated by initdb

Hi, hackers I don't know if this is an error. when I do ./initdb -D ../data and execute pg_waldump like this, In the last part I got an error. ``` ./pg_waldump ../data/pg_wal/00010001 ``` pg_waldump: error: error in WAL record at 0/140: invalid record length at 0/1499A08: w

Re: doc: pg_prewarm add configuration example

On 22/06/29 03:57오후, Jacob Champion wrote: > On 6/18/22 01:55, Dong Wook Lee wrote: > > Hi hackers, > > > > I thought it would be nice to have an configuration example of the > > pg_prewarm extension. > > Therefore, I have written an example of a basic conf

add test: pg_rowlocks extension

Hi Hackers, I just wrote test about pg_rowlocks extension. I added sql and spec test for locking state. --- Regards DongWook Lee diff --git a/contrib/pgrowlocks/Makefile b/contrib/pgrowlocks/Makefile index 294c05dd0f..128f345b7e 100644 --- a/contrib/pgrowlocks/Makefile +++ b/contrib/pgrowlocks/Ma

Add test of pg_prewarm extenion

Hi hackers, I wrote a test for pg_prewarm extension. and I wrote it with the aim of improving test coverage, and feedback is always welcome. --- Regards DongWook Lee diff --git a/contrib/pg_prewarm/Makefile b/contrib/pg_prewarm/Makefile index b13ac3c813..617ac8e09b 100644 --- a/contrib/pg_prewar

Re: Add TAP test for auth_delay extension

On 22/06/18 12:07오후, Michael Paquier wrote: > On Sat, Jun 18, 2022 at 11:06:02AM +0900, Dong Wook Lee wrote: > > I have written a test for the auth_delay extension before, > > but if it is okay, can you review it? > > +# check enter wrong password > +my $t0 = [gettimeofd

doc: pg_prewarm add configuration example

Hi hackers, I thought it would be nice to have an configuration example of the pg_prewarm extension. Therefore, I have written an example of a basic configuration. --- Regards, DongWook Lee diff --git a/doc/src/sgml/pgprewarm.sgml b/doc/src/sgml/pgprewarm.sgml index 4e68812250..754a21a076

Re: Add TAP test for auth_delay extension

2022년 6월 7일 (화) 오후 6:32, Dong Wook Lee 님이 작성: > > Hi Hackers, > I just wrote a test for `auth_delay` extension. > It's a test which confirms whether there is a delay for a second when > you enter the wrong password. > I sent an email using mutt, but I have a pr

Re: Add TAP test for auth_delay extension

Hi Hackers, I just wrote a test for `auth_delay` extension. It's a test which confirms whether there is a delay for a second when you enter the wrong password. I sent an email using mutt, but I have a problem and sent it again. --- Regards, Dong Wook Lee.

Re: pg_buffercache: add sql test

I removed it on your advice. Thanks. 2022년 6월 7일 (화) 오전 2:04, Stephen Frost 님이 작성: > > Greetings, > > * Daniel Gustafsson (dan...@yesql.se) wrote: > > > On 6 Jun 2022, at 15:30, Dong Wook Lee wrote: > > > > > I just wrote a test code for the `pg_buffercach

pg_buffercache: add sql test

Hi, hackers I just wrote a test code for the `pg_buffercache` extension which doesn't not have test code. I wrote the sql query to ensure that the buffer cache results are the same when `make installcheck` is performed. --- regards Lee Dong Wook. 0001_add_test_pg_buffercache.patch Description: B

Re: Add pg_freespacemap extension sql test

2022년 3월 20일 (일) 03:13, Fabrízio de Royes Mello 님이 작성: > > > On Sat, Mar 19, 2022 at 1:18 PM Dong Wook Lee wrote: > > > > > Well, my guess is that you basically just care about being able to > > > detect if there is free space in the map or not, which goes down t

Re: Add pg_freespacemap extension sql test

> Well, my guess is that you basically just care about being able to > detect if there is free space in the map or not, which goes down to > detecting if pg_freespace() returns 0 or a number strictly higher than > 0, so wouldn't it be enough to stick some > 0 in your test queries? I edited the pre

Re: Add pg_freespacemap extension sql test

2022년 3월 11일 (금) 오후 2:51, Michael Paquier 님이 작성: > > On Wed, Mar 09, 2022 at 08:13:15PM +0900, Dong Wook Lee wrote: > > I agree with you, but I have no good idea how to deal with it. > > Well, my guess is that you basically just care about being able to > detect if there is

Re: Add pg_freespacemap extension sql test

2022년 3월 9일 (수) 오전 1:19, Tom Lane 님이 작성: > Dong Wook Lee writes: > > [ 0001_add_test_pg_fsm.patch ] > > I think having some coverage here would be great, but I'm concerned that > this patch doesn't look very portable. Aren't the numbers liable to > chan

Re: Add pg_freespacemap extension sql test

That's right, so I attached the correct file again. 2022년 3월 8일 (화) 오후 11:45, Justin Pryzby 님이 작성: > On Tue, Mar 08, 2022 at 11:39:08PM +0900, Dong Wook Lee wrote: > > Hi, > > I just added some tests for the pg_freespacemap extension because the > test > > cove

Re: Add pg_freespacemap extension sql test

I'm sorry for attaching the wrong patch file. 2022년 3월 8일 (화) 오후 11:39, Dong Wook Lee 님이 작성: > Hi, > I just added some tests for the pg_freespacemap extension because the test > coverage was 0 percent. > But I don't know if I did it correctly. > > -

Add pg_freespacemap extension sql test

Hi, I just added some tests for the pg_freespacemap extension because the test coverage was 0 percent. But I don't know if I did it correctly. --- Regards Lee Dong Wook 0001_add_link_fsm.patch Description: Binary data

pg_stat_statements: remove redundant function call in pg_stat_statements_internal

Hi, I found some redundant function calls in pg_stat_statements.c/pg_stat_statements_internal(), There is no need to call GetUserId() again because the value was previously obtained. so I propose a patch to fix it. --- a/contrib/pg_stat_statements/pg_stat_statements.c +++ b/contrib/pg_stat_statem

Re: Print warning when I execute my own extension function

now I found a bug in this code. I found the code of this part below is wrong ``` char *buffer = palloc(7 * sizeof(char)); >> unsigned int offset = sizeof(buffer); // wrong buffer[--offset] = '\0'; /* here */ ``` Thank you for replying 2022년 2월 20일 (일) 오후 11:51, Dong Wook Lee 님이

Re: Print warning when I execute my own extension function

t like this? ``` char *buffer = palloc(7 * sizeof(char)); unsigned int offset = sizeof(buffer); > buffer[--offset] = '\0'; /* here */ ``` 2022년 2월 20일 (일) 오후 7:29, Julien Rouhaud 님이 작성: > > Hi, > > On Sun, Feb 20, 2022 at 07:23:56PM +0900, Dong Wook Lee wrote: > >

Print warning when I execute my own extension function

ning means and how I can fix it. Thanks Dong Wook Lee.

Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)

Yes, now I understand it. Thank you for letting me know about that. Thanks. 2022년 2월 10일 (목) 00:39, Ranier Vilela 님이 작성: > > Em qua., 9 de fev. de 2022 às 11:34, Dong Wook Lee > escreveu: > >> Hi, >> >> I've applied your patch. I think it's reasonable. &

Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)

Oops, I realized that I made a mistake in my patch and now I have corrected it. 2022년 2월 9일 (수) 오후 11:33, Dong Wook Lee 님이 작성: > > Hi, > > I've applied your patch. I think it's reasonable. > but IMHO It looks more complicated to read because of many conditions > in i

Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)

Hi, I've applied your patch. I think it's reasonable. but IMHO It looks more complicated to read because of many conditions in if statement. so what about just moving up if-statement? Thanks. Dong Wook Lee 2022년 2월 9일 (수) 오후 7:56, Ranier Vilela 님이 작성: > > Hi, > > I

Re: Add tap test for --extra-float-digits option

> That's more of an habit to look around, find similar patterns and the > check if these are covered. > > I have applied your patch, and you may want to be careful about a > couple of things: > - Please avoid top-posting on the mailing lists: > https://en.wikipedia.org/wiki/Posting_style#Top-postin

Re: Add tap test for --extra-float-digits option

Oh, now I understand. and I added a test of --row-per-insert option. I'd better find more options missing test 2020년 6월 12일 (금) 오후 4:04, Michael Paquier 님이 작성: > On Fri, Jun 12, 2020 at 02:30:35PM +0900, Dong Wook Lee wrote: > > Thank you for your response > > Do you mean

Add tap test for --extra-float-digits option

Hi hackers! I added tap test code for pg_dump --extra-float-digits option because it hadn't tested it. There was no problem when writing test code and running TAP tests. 0001-Add-tap-test-for-extra-float-digits-option.patch Description: Binary data

TAP tests not enabled in pg_dump

I want to execute some testing code but I conflict against error. Please tell me how to fix it :) Environment: = OSX: 10.14.6 postgresql: version 13 current development In postgresql/src/bin/pg_dump dir I command below $ make check