> the thing is stable, I'll try to backpatch it. This works on my own
> > dev machines with VS 2015 and 2019, but who knows what hides in the
> > shadows...
>
> The buildfarm did not have much to say, so backpatched down to 9.4,
> adjusting things on the way.
Thanks Michael.
Regards,
Haribabu Kommi
On Mon, 3 Jun 2019 at 16:32, Haribabu Kommi
wrote:
>
>
> On Thu, Apr 11, 2019 at 9:13 AM Haribabu Kommi
> wrote:
>
>> I fixed all the comments that you have raised above and attached the
>> updated
>> patches.
>>
>
> Rebased patches are attach
On Thu, 27 Jun 2019 at 17:28, Michael Paquier wrote:
> On Wed, Jun 26, 2019 at 10:29:05PM +1000, Haribabu Kommi wrote:
> > Thanks for the review. Yes, that patch applies till 9.5, it is my mistake
> > in naming the patch.
>
> I have been able to finally set up an environ
On Wed, 5 Jun 2019 at 17:22, Juan José Santamaría Flecha <
juanjo.santama...@gmail.com> wrote:
>
> On Wed, May 29, 2019 at 10:30 AM Haribabu Kommi
> wrote:
>
>>
>> Updated patches are attached.
>>
>>
> All patches apply, build and pass tests. The patc
ase the command fails.
>
Thanks for the details steps to reproduce the bug, I am also able to
reproduce the problem.
> Fix:
> The patch has the fix for the above issue:
>
> Let me know your opinion on this.
>
Thanks for the patch and it fixes the problem.
Regards,
Haribabu Kommi
Fujitsu Australia
On Thu, Apr 11, 2019 at 9:13 AM Haribabu Kommi
wrote:
> I fixed all the comments that you have raised above and attached the
> updated
> patches.
>
Rebased patches are attached.
Regards,
Haribabu Kommi
Fujitsu Australia
0001-New-pg_basebackup-g-option-to-control-the-grou
yScan supports to return a partial composite type,
> it needs similar infrastructure that can be used for a better composite
> type support on columnar storage.
>
There is another issue related to the columnar store that needs targeted
columns for projection from the scan is discussed in zedstore [1].
Projecting all columns from a columnar store is quite expensive than
the row store.
[1] -
https://www.postgresql.org/message-id/CALfoeivu-n5o8Juz9wW%2BkTjnis6_%2BrfMf%2BzOTky1LiTVk-ZFjA%40mail.gmail.com
Regards,
Haribabu Kommi
Fujitsu Australia
On Mon, May 27, 2019 at 8:14 PM Juan José Santamaría Flecha <
juanjo.santama...@gmail.com> wrote:
>
> On Thu, May 23, 2019 at 3:44 AM Haribabu Kommi
> wrote:
>
>>
>> Updated patches are attached for all branches.
>>
>>
> I have gone through all patch
rned value be '14.20' for Visual Studio 2019?
>
Yes, that will be good to return Visual Studio 2019, updated.
Updated patches are attached for all branches.
Regards,
Haribabu Kommi
Fujitsu Australia
0001-Support-building-with-visual-studio-2019_HEAD.patch
Description: Binary d
On Tue, May 21, 2019 at 8:17 AM Andres Freund wrote:
>
>
>Add command to create
>new table types (Haribabu Kommi, Andres Freund, Álvaro Herrera,
>Dimitri Dolgov)
>
>
> A few points:
>
> 1) Is this really source code, given
pages.
Definitely this approach does't work for full instance encryption.
Any opinions/comments/problems in evaluating the encryption with an
extesnion
approach?
Regards,
Haribabu Kommi
Fujitsu Australia
view easier,
> but
> first I'd like to hear if anything is seriously wrong about this
> design. Thanks.
>
I didn't check the code, but it is good to combine all the 3 page read
functions
into one instead of spreading the logic.
Regards,
Haribabu Kommi
Fujitsu Australia
about adding the new functions
> in postgres.c like RecoveryConflictInterrupt()?
>
>
> (7) 0008
> + if (pid != 0)
> + {
> + (void) SendProcSignal(pid, reason,
> procvxid.backendId);
> + }
>
> The braces
> this fix?
> >
>
> Pushed.
>
Thanks Amit.
Will look into it further to handle all the internally generated
transactions.
Regards,
Haribabu Kommi
Fujitsu Australia
ccess
> > methods (i.e. the default_table_access_method GUC and the USING clause
> > for CREATE TABLE etc), adds a basic chapter about the table access
> > method interface, and adds a note to storage.sgml that it's contents
> > don't necessarily apply for non-builtin AMs.
> >
&
On Wed, Mar 27, 2019 at 11:42 AM Haribabu Kommi
wrote:
>
> On Wed, Mar 27, 2019 at 3:03 AM Andrew Dunstan <
> andrew.duns...@2ndquadrant.com> wrote:
>
>>
>> On 3/20/19 8:36 PM, Haribabu Kommi wrote:
>> > Hi Hackers,
>> >
>> > Here I atta
ainly a bit crummy.
>
I got the same doubt when i looked into some of the UNDO patches
where it tries to modify the core code to add UNDO specific WAL types.
Different AM's may need different set of operations to be WAL logged,
so it may be better for the AM's to register their own types?
Regards,
Haribabu Kommi
Fujitsu Australia
On Thu, Apr 4, 2019 at 3:29 PM Amit Kapila wrote:
> On Wed, Apr 3, 2019 at 10:45 AM Haribabu Kommi
> wrote:
> >
> > Thanks for the review.
> >
> > While changing the approach to use the is_parallel_worker_flag, I thought
> > that the rest of the stats are
oblem.
>From understanding of the thread discussion,
+1 by:
Michael Paquier
Robert Haas
Haribabu Kommi
-1 by:
Magnus Hagander
Peter Eisentraut
Does any one want to weigh their opinion on this patch to consider best
option for controlling the existing standby data directory permissions.
Regards,
Haribabu Kommi
Fujitsu Australia
On Wed, Apr 3, 2019 at 1:59 PM Amit Kapila wrote:
> On Thu, Mar 28, 2019 at 11:43 AM Haribabu Kommi
> wrote:
> >
> > On Wed, Mar 27, 2019 at 11:27 PM Amit Kapila
> wrote:
> >>
> >> On Wed, Mar 27, 2019 at 6:53 AM Haribabu Kommi <
> kommi.harib...@
On Tue, Apr 2, 2019 at 11:53 AM Andres Freund wrote:
> Hi,
>
> On 2019-04-02 11:39:57 +1100, Haribabu Kommi wrote:
> > > What made you rename indexam.sgml to am.sgml, instead of creating a
> > > separate tableam.sgml? Seems easier to just have a separate file?
>
On Tue, Apr 2, 2019 at 10:18 AM Andres Freund wrote:
> Hi,
>
> On 2019-03-16 23:21:31 +1100, Haribabu Kommi wrote:
> > updated patches are attached.
>
> Now that nearly all of the tableam patches are committed (with the
> exception of the copy.c changes which are for
version
> bump.
>
> It seems possible that some other AM might want to generalize the
> prefetch logic from heapam.c, but I think it's fair to defer that until
> such an AM wants to do so
>
As I see that your are fixing some typos of the code that is committed,
I just wan
on variable, I see a
lot of code addition just
for this variable, is this worth it?
[1] -
https://www.postgresql.org/message-id/2239254.dtfY1H9x0t%40hammer.magicstack.net
Regards,
Haribabu Kommi
Fujitsu Australia
From aa812716104b3fbd787dae4483341894c9e5ed9a Mon Sep 17 00:00:00 2001
From: Hari Bab
On Wed, Mar 27, 2019 at 11:27 PM Amit Kapila
wrote:
> On Wed, Mar 27, 2019 at 6:53 AM Haribabu Kommi
> wrote:
> > On Tue, Mar 26, 2019 at 9:08 PM Amit Kapila
> wrote:
> >>
> >> As part of this thread, maybe we can
> >> just fix the ca
On Wed, Mar 27, 2019 at 1:31 AM Masahiko Sawada
wrote:
> On Tue, Mar 26, 2019 at 10:19 AM Haribabu Kommi
> wrote:
> >
> >
> > + for (i = 0; i < nindexes; i++)
> > + {
> > + LVIndStats *s = &(copied_indstats[i]);
> > +
> > + if (s->updat
On Tue, Mar 26, 2019 at 9:08 PM Amit Kapila wrote:
> On Mon, Mar 25, 2019 at 6:55 PM Haribabu Kommi
> wrote:
> >
> >
> > Thanks to everyone for their opinions and suggestions to improve.
> >
> > Without parallel workers, there aren't many internal impl
On Wed, Mar 27, 2019 at 3:03 AM Andrew Dunstan <
andrew.duns...@2ndquadrant.com> wrote:
>
> On 3/20/19 8:36 PM, Haribabu Kommi wrote:
> > Hi Hackers,
> >
> > Here I attached a patch that supports building of PostgreSQL with VS
> 2019.
> > VS 2019 is going
On Tue, Mar 26, 2019 at 1:27 PM Michael Paquier wrote:
> On Sun, Mar 24, 2019 at 10:30:47PM +1100, Haribabu Kommi wrote:
> > With the above additional options, the pg_basebackup is able to control
> > the access permissions of the backup files, but when it comes to tar mode
> &
parallel vacuum can
work, so just setting the above parameters doesn't stop the parallel
workers, user must
pass the PARALLEL option also. So mentioning that also will be helpful
later when we
start supporting it or some one who is reading the code can understand.
Regards,
Haribabu Kommi
Fujitsu Australia
y transactions information.
How about adding additional two columns that provides all the internal
and background worker transactions into that column?
Regards,
Haribabu Kommi
Fujitsu Australia
On Fri, Mar 22, 2019 at 6:07 PM Haribabu Kommi
wrote:
>
> On Fri, Mar 22, 2019 at 7:32 AM Haribabu Kommi
> wrote:
>
>>
>> On Fri, Mar 22, 2019 at 6:57 AM Robert Haas
>> wrote:
>>
>>> On Thu, Mar 21, 2019 at 2:26 AM Haribabu Kommi
>>> w
On Sun, Mar 24, 2019 at 11:16 PM Michael Paquier
wrote:
> On Fri, Mar 22, 2019 at 01:01:44PM +0900, Michael Paquier wrote:
> > On Fri, Mar 22, 2019 at 02:35:41PM +1100, Haribabu Kommi wrote:
> > > Thanks for the correction. Yes, that is correct and it works fine.
> &g
On Sat, Mar 23, 2019 at 2:23 AM Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 2019-03-22 05:00, Michael Paquier wrote:
> > On Fri, Mar 22, 2019 at 02:45:24PM +1100, Haribabu Kommi wrote:
> >> How about letting the pg_basebackup to decide group permiss
On Fri, Mar 22, 2019 at 7:32 AM Haribabu Kommi
wrote:
>
> On Fri, Mar 22, 2019 at 6:57 AM Robert Haas wrote:
>
>> On Thu, Mar 21, 2019 at 2:26 AM Haribabu Kommi
>> wrote:
>> > Based on the above new options that can be added to
>> target_session_attrs,
>
directory permissions.
Default - permissions are same as primary
--allow-group-access - standby directory have group access permissions
--no-group--access - standby directory doesn't have group permissions
The last two options behave irrespective of the primary directory
permissions.
opinions?
Regards,
Haribabu Kommi
Fujitsu Australia
On Fri, Mar 22, 2019 at 12:24 PM Michael Paquier
wrote:
> On Thu, Mar 21, 2019 at 12:52:14PM +1100, Haribabu Kommi wrote:
> > Earlier attached patch is wrong.
>
> - oumask = umask(pg_file_create_mode);
> + oumask = umask(pg_mode_mask);
> Indeed that was wrong.
>
&g
On Fri, Mar 22, 2019 at 6:57 AM Robert Haas wrote:
> On Thu, Mar 21, 2019 at 2:26 AM Haribabu Kommi
> wrote:
> > Based on the above new options that can be added to target_session_attrs,
> >
> > primary - it is just an alias to the read-write option.
> > standby,
On Thu, Mar 21, 2019 at 3:02 AM Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 2019-03-19 08:34, Haribabu Kommi wrote:
> > How about the following change?
> >
> > pg_basebackup --> copies the contents of the src directory (with group
> > acc
eTupleOk, but also probably a
> s/TableTuple/TableMod/
>
> - I'll probably move TUPLE_LOCK_FLAG_LOCK_* into tableam.h
>
> - two more passes through the patch
>
Thanks for the corrections.
> On 2019-03-21 15:07:04 +1100, Haribabu Kommi wrote:
> > As you are modifyin
e options should check whether server is
running in recovery mode or not
instead of checking whether server accepts read-only connections or not?
Regards,
Haribabu Kommi
Fujitsu Australia
On Wed, Mar 20, 2019 at 7:38 PM Amit Kapila wrote:
> On Sun, Feb 10, 2019 at 10:54 AM Haribabu Kommi
> wrote:
> > On Sat, Feb 9, 2019 at 4:07 PM Amit Kapila
> wrote:
> >>
> >> I don't think so. It seems to me that we should consider it as a
> >>
t;Name",
CASE amtype WHEN 'i' THEN 'Index' WHEN 't' THEN 'Table' END AS
"Type"
FROM pg_catalog.pg_am ...
Anyone feels that it requires a separate query for servers < 12?
Regards,
Haribabu Kommi
Fujitsu Australia
0001-dA-to-show-Table-type-access-method.patch
Description: Binary data
On Sat, Mar 16, 2019 at 5:43 PM Haribabu Kommi
wrote:
>
>
> On Sat, Mar 9, 2019 at 2:13 PM Andres Freund wrote:
>
>> Hi,
>>
>> While 0001 is pretty bulky, the interesting bits concentrate on a
>> comparatively small area. I'd appreciate if somebody coul
On Thu, Mar 21, 2019 at 12:41 PM Haribabu Kommi
wrote:
>
> On Wed, Mar 20, 2019 at 4:33 PM Michael Paquier
> wrote:
>
>> And actually it seems to me that you have a race condition in that
>> stuff. I think that you had better use umask(), then fopen, and then
>>
#x27;s not actually the case for 9.5 and 9.4 if
> you don't back-patch f2ab389 further down.
>
The commit f2ab389 is later back-patch to version till 9.3 in commit
19acfd65.
I guess that building the windows installer for all the versions using the
same
visual studio is may be the reaso
On Wed, Mar 20, 2019 at 4:33 PM Michael Paquier wrote:
> On Fri, Mar 15, 2019 at 06:51:37PM +1100, Haribabu Kommi wrote:
> > IMO, this update is just a recommendation to the user, and sometimes it
> is
> > still possible that there may be strict permissions for the log file
the supported branches are possible to
compile with VS 2017.
comments?
Regards,
Haribabu Kommi
Fujitsu Australia
0001-Support-building-with-visual-studio-2019.patch
Description: Binary data
On Tue, Mar 19, 2019 at 6:47 PM Jamison, Kirk
wrote:
> Hi Hari-san,
>
>
>
> On Sunday, February 10, 2019 2:25 PM (GMT+9), Haribabu Kommi wrote:
>
> > I try to fix it by adding a check for parallel worker or not and based
> on it
>
> > count them into stats. P
ommit from pg_stat_database where datname =
> 'postgres';
> xact_commit
> -
> 161
> (1 row)
>
Thanks for the test and confirmation.
Regards,
Haribabu Kommi
Fujitsu Australia
oup-access --> copies the contents of the src
directory
(with no group access) even for the root directory.
So the default behavior works for many people, others that needs restrict
behavior
can use the new option.
Regards,
Haribabu Kommi
Fujitsu Australia
ed TableTupleUpdated
> #define HeapTupleDeleted TableTupleDeleted
> #define HeapTupleBeingUpdated TableTupleBeingModified
> #define HeapTupleWouldBlock TableTupleWouldBlock
>
> in heapam.h (whereas the above is in tableam.h), for backward
> compat. But I'm not sure it's worth it.
>
These old macros are pretty much used in the internal code, and I doubt
that any one depends directly on those macros. I vote for removal of
these backward compatibility macros.
Regards,
Haribabu Kommi
Fujitsu Australia
On Mon, Mar 18, 2019 at 1:58 PM Masahiko Sawada
wrote:
> On Tue, Feb 26, 2019 at 7:20 PM Masahiko Sawada
> wrote:
> >
> > On Tue, Feb 26, 2019 at 1:35 PM Haribabu Kommi
> wrote:
> > >
> > > On Thu, Feb 14, 2019 at 9:17 PM Masahiko Sawada
> wrote:
>
On Thu, Feb 28, 2019 at 1:00 PM Tsunakawa, Takayuki <
tsunakawa.ta...@jp.fujitsu.com> wrote:
> From: Haribabu Kommi [mailto:kommi.harib...@gmail.com]
> > Attached are the updated patches.
>
> Thanks, all look fixed.
>
>
> > The target_server_type option yet to
once.
And I reviewed the 0002 patch, which is a pretty simple and it can be
committed.
Regards,
Haribabu Kommi
Fujitsu Australia
0001-table-access-methods-typos-correction.patch
Description: Binary data
On Tue, Mar 12, 2019 at 5:03 PM Michael Paquier wrote:
> On Tue, Feb 26, 2019 at 12:22:53PM +1100, Haribabu Kommi wrote:
> > I checked the code why the current_logfiles is not implemented as
> > shared memory and found that the current syslogger doesn't attach to
> >
On Fri, Mar 15, 2019 at 10:33 AM Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 2019-03-09 02:19, Haribabu Kommi wrote:
> > Yes, I agree that it may be a problem if the existing data directory
> > permissions
> > are 0700 to changing it to 0750. But
On Sat, Mar 9, 2019 at 2:18 PM Andres Freund wrote:
> Hi,
>
> On 2019-03-09 11:03:21 +1100, Haribabu Kommi wrote:
> > Here I attached the rebased patches that I shared earlier. I am adding
> the
> > comments to explain the API's in the code, will share those patches
t fails, and also the files inside the data folder follows the
permissions of the
upstream data directory.
usually production systems follows same permissions are of upstream, I don't
see a problem in following the same for development environment also?
comments?
Regards,
Haribabu Kommi
Fujitsu Australia
test patch series in the COPY command.
I am not sure whether the problem is with the reduce of tableOid patch
problem,
Will check it and correct the problem.
Regards,
Haribabu Kommi
Fujitsu Australia
0010-Table-access-method-API-explanation.patch
Description: Binary data
0001-Reduce-the-use-of
On Mon, Mar 4, 2019 at 3:23 PM Kyotaro HORIGUCHI <
horiguchi.kyot...@lab.ntt.co.jp> wrote:
> Hello.
>
> At Tue, 6 Nov 2018 15:53:37 +1100, Haribabu Kommi <
> kommi.harib...@gmail.com> wrote in <
> cajrrpgcxzi4z_sttnuuvyoaw+sadk7+cjgypuf7ao43vujl...@mail.gmail.com&g
be
preferred if not explicitly specified the access method during the table
creation.
This discussion raises a point that, in case if the user wants to change the
access method of a table later once it is created, currently there is no
option.
currently there are no other alternative table access methods that are
available
for the user to switch, but definitely it may be required later.
I will provide a patch to alter the access method of a table for v13.
Regards,
Haribabu Kommi
Fujitsu Australia
WAL needs to be encrypted, so this should
be
done at the WAL insertion not at WAL write to disk, because some entries are
not encrypted and some not. Or may be something like encrypting entire WAL
even if one object is set for encryption.
Regards,
Haribabu Kommi
Fujitsu Australia
ations. I also
thought of implementing our own smgr implementation to support transparent
data encryption on the disk based on tablespace mapping.
Regards,
Haribabu Kommi
Fujitsu Australia
ach of these conditions are redundant. It
> would be better to remove them for readability. This also applies to the
> following part:
>
> + if (((strncmp(val, "on", 2) == 0)
> &&
> +
> (conn->requested_session_ty
On Wed, Feb 27, 2019 at 11:10 AM Andres Freund wrote:
> Hi,
>
> On 2019-01-21 10:32:37 +1100, Haribabu Kommi wrote:
> > I am not able to remove the complete t_tableOid from HeapTuple,
> > because of its use in triggers, as the slot is not available in triggers
> &
with 0 parallel workers
patch - 613ms with 2 parallel workers
patch - 735ms with 4 parallel workers
patch - 679ms with 6 parallel workers
Regards,
Haribabu Kommi
Fujitsu Australia
On Mon, Feb 4, 2019 at 12:16 PM Haribabu Kommi
wrote:
>
> And regarding current_logfiles permissions, I feel this file should have
> permissions of data directory files as it is present in the data directory
> whether it stores the information of log file, until this file is
On Thu, Feb 14, 2019 at 9:17 PM Masahiko Sawada
wrote:
> On Wed, Feb 13, 2019 at 9:32 PM Haribabu Kommi
> wrote:
> >
> >
> > On Sat, Feb 9, 2019 at 11:47 PM Masahiko Sawada
> wrote:
> >>
> >> On Tue, Feb 5, 2019 at 12:14 PM Harib
On Wed, Feb 20, 2019 at 7:40 PM Magnus Hagander wrote:
>
> On Wed, Feb 20, 2019 at 5:17 AM Haribabu Kommi
> wrote:
>
>>
>> On Fri, Feb 15, 2019 at 10:15 AM Michael Paquier
>> wrote:
>>
>>> On Thu, Feb 14, 2019 at 11:21:19PM +1100, Haribabu Kommi
On Fri, Feb 22, 2019 at 3:22 PM Michael Paquier wrote:
> On Fri, Feb 22, 2019 at 11:33:17AM +1100, Haribabu Kommi wrote:
> > During the development of another feature, I found that same local
> > variables are declared twice.
> > IMO, there is no need of again declarin
On Fri, Feb 22, 2019 at 5:47 PM Tsunakawa, Takayuki <
tsunakawa.ta...@jp.fujitsu.com> wrote:
> From: Haribabu Kommi [mailto:kommi.harib...@gmail.com]
> Here I attached first set of patches that implemented the prefer-read
> option
> > after reporting the transaction_read_only
On Thu, Feb 14, 2019 at 1:04 PM Tsunakawa, Takayuki <
tsunakawa.ta...@jp.fujitsu.com> wrote:
> From: Haribabu Kommi [mailto:kommi.harib...@gmail.com]
> > No. It's not good if the user has to be bothered by
> > default_transaction_read_only when he
Hi Hackers,
During the development of another feature, I found that same local
variables are declared twice.
IMO, there is no need of again declaring the local variables. Patch
attached.
Regards,
Haribabu Kommi
Fujitsu Australia
0001-Removal-of-duplicate-local-variable-declaration.patch
On Fri, Feb 15, 2019 at 10:15 AM Michael Paquier
wrote:
> On Thu, Feb 14, 2019 at 11:21:19PM +1100, Haribabu Kommi wrote:
> > On Thu, Feb 14, 2019 at 8:57 PM Magnus Hagander
> wrote:
> >> I think it could be argued that neither initdb *or* pg_basebackup should
> >>
On Tue, Nov 27, 2018 at 4:59 PM Amit Langote
wrote:
> Hi,
>
> On 2018/11/02 9:17, Haribabu Kommi wrote:
> > Here I attached the cumulative fixes of the patches, new API additions
> for
> > zheap and
> > basic outline of the documentation.
>
> I've read t
On Mon, Feb 4, 2019 at 2:31 PM Haribabu Kommi
wrote:
>
> On Tue, Jan 22, 2019 at 1:43 PM Haribabu Kommi
> wrote:
>
>>
>>
>> OK. I will work on the doc changes.
>>
>
> Sorry for the delay.
>
> Attached a draft patch of doc and comments changes tha
On Thu, Feb 14, 2019 at 8:57 PM Magnus Hagander wrote:
> On Thu, Feb 14, 2019 at 9:10 AM Michael Paquier
> wrote:
>
>> On Thu, Feb 14, 2019 at 06:34:07PM +1100, Haribabu Kommi wrote:
>> > we have an application that is used to create the data directory with
>>
On Thu, Feb 14, 2019 at 3:04 PM Michael Paquier wrote:
> On Wed, Feb 13, 2019 at 06:42:36PM +1100, Haribabu Kommi wrote:
> > This should back-patch till 11 where the group access is introduced.
> > Because of lack of complaints, I agree with you that there is no need of
> &g
On Fri, Feb 8, 2019 at 8:16 PM Tsunakawa, Takayuki <
tsunakawa.ta...@jp.fujitsu.com> wrote:
> From: Haribabu Kommi [mailto:kommi.harib...@gmail.com]
> > target_session_attrs checks for the default_transaction_readonly or not?
>
> PG 11 uses transaction_read_only, not default
On Sat, Feb 9, 2019 at 11:47 PM Masahiko Sawada
wrote:
> On Tue, Feb 5, 2019 at 12:14 PM Haribabu Kommi
> wrote:
> >
> >
> > On Fri, Feb 1, 2019 at 8:19 AM Masahiko Sawada
> wrote:
> >>
> >>
> >> The passing stats = NULL to amvacuumcleanu
On Wed, Feb 13, 2019 at 12:42 PM Michael Paquier
wrote:
> On Tue, Feb 12, 2019 at 06:03:37PM +1100, Haribabu Kommi wrote:
> > During the testing allow group access permissions on the standby database
> > directory, one of my colleague found the issue, that pg_basebackup
>
sions. This problem was
present for a long time, (I think from the time the pg_basebackup was
introduced).
Attached patch fixes the problem similar like initdb by changing the
permissions of the data
directory to the required permissions.
Regards,
Haribabu Kommi
Fujitsu Australia
0001-pg_baseb
On Sat, Feb 9, 2019 at 4:07 PM Amit Kapila wrote:
> On Fri, Feb 8, 2019 at 6:55 AM Haribabu Kommi
> wrote:
> >
> > On Thu, Feb 7, 2019 at 9:31 PM Haribabu Kommi
> wrote:
> >>
> >>
> >> This is because of larger xact_commit value than
On Thu, Feb 7, 2019 at 9:31 PM Haribabu Kommi
wrote:
> Hi Hackers,
>
> Does increase in Transaction commits per second means good query
> performance?
> Why I asked this question is, many monitoring tools display that number of
> transactions
> per second in the dashboa
?
Regards,
Haribabu Kommi
Fujitsu Australia
On Mon, Jan 21, 2019 at 5:48 PM Tsunakawa, Takayuki <
tsunakawa.ta...@jp.fujitsu.com> wrote:
> From: Haribabu Kommi [mailto:kommi.harib...@gmail.com]
> > Thanks for finding out the problem, how about the following way of
> checking
> > for prefer-read/p
e &&
rettup != trigdata->tg_trigtuple)
rettup = SPI_copytuple(rettup);
we need to take care of these also before switch to a context?
>
Regards,
Haribabu Kommi
Fujitsu Australia
On Fri, Feb 1, 2019 at 8:19 AM Masahiko Sawada
wrote:
> On Wed, Jan 30, 2019 at 2:06 AM Haribabu Kommi
> wrote:
> >
> >
> >
> >
> > + * Before starting parallel index vacuum and parallel cleanup index we
> launch
> > + * parallel workers. All p
On Tue, Jan 22, 2019 at 1:43 PM Haribabu Kommi
wrote:
>
>
> OK. I will work on the doc changes.
>
Sorry for the delay.
Attached a draft patch of doc and comments changes that I worked upon.
Currently I added comments to the callbacks that are present in the
TableAmRoutine
str
a directory files as it is present in the data directory
whether it stores the information of log file, until this file is completely
removed with another approach to store the log file details.
I am not sure whether this has been already discussed or not? How about
using shared memory to store the
POSIX-style group permissions.
>
> Fine for me. Anybody else has an opinion to offer?
>
+1 to the above changes. Thanks for working on it.
Regards,
Haribabu Kommi
Fujitsu Australia
act on the microsoft
windows, so I feel it should be better to write the same in initdb docs?
need a patch?
Regards,
Haribabu Kommi
Fujitsu Australia
to add NodeTag for the above structure? Because this structure is
part of VacuumStmt structure.
+vacuumdb will require background
workers,
+so make sure your
+ setting is more than one.
removing vacuumdb and changing it as "This option will ..."?
I will continue the testing of this patch and share the details.
Regards,
Haribabu Kommi
Fujitsu Australia
On Fri, Jan 18, 2019 at 11:42 PM Masahiko Sawada
wrote:
> On Fri, Jan 18, 2019 at 10:38 AM Haribabu Kommi
> wrote:
> >
> >
> > On Tue, Jan 15, 2019 at 6:00 PM Masahiko Sawada
> wrote:
> >>
> >>
> >> Rebased.
> >
> >
On Tue, Jan 22, 2019 at 12:15 PM Andres Freund wrote:
> Hi,
>
> Thanks!
>
> On 2019-01-22 11:51:57 +1100, Haribabu Kommi wrote:
> > Attached the patch for removal of scan_update_snapshot
> > and also the rebased patch of reduction in use of t_tableOid.
>
> I'
to have high-level docs in sgml, but then do all the
> per-callback docs in tableam.h.
>
OK, I will update the sgml docs accordingly.
Index AM has per callback docs in the sgml, refactor them also?
Regards,
Haribabu Kommi
Fujitsu Australia
0002-Removal-of-scan_update_snapshot.patch
Description: Binary data
0001-Reduce-the-use-of-HeapTuple-t_tableOid.patch
Description: Binary data
On Tue, Jan 15, 2019 at 6:05 PM Andres Freund wrote:
> Hi,
>
> On 2019-01-15 18:02:38 +1100, Haribabu Kommi wrote:
> > On Tue, Dec 11, 2018 at 1:13 PM Andres Freund
> wrote:
> >
> > > Hi,
> > >
> > > On 2018-11-26 17:55:57 -0800, Andres Freund
quot;
>
Thanks for finding out the problem, how about the following way of checking
for prefer-read/prefer-standby.
1. (default_transaction_read_only = true and recovery = true)
2. If none of the host satisfies the above scenario, then recovery = true
3. Last check is for default_transaction_read_only = true
Regards,
Haribabu Kommi
Fujitsu Australia
ction_read_only = true
any -- Nothing to be verified
I feel above verifications can cover for both physical and logical
replication.
we can decide what type of options that we can support? and also if we
don't want to rely on default_transaction_read_only user settable parameter,
we can add a new parameter that cannot be changed only with server restart?
Regards,
Haribabu Kommi
Fujitsu Australia
1 - 100 of 247 matches
Mail list logo
