uot; (address "127.0.0.1") at port "5430".
Protocol Version: 3
SSL Connection: no
GSSAPI Authenticated: no
Client Encoding: UTF8
Server Encoding: UTF8
Session User: hunaid
Backend PID: 163816
I have also edited the documentation and added it to the patch. Plea
ing or trailing spaces, like
' XIV' or 'MC '? Should we trim the spaces, or would it be better to throw
an error in such cases?
I have tested the changes and would appreciate any suggestions for
improvement. I will update the docs and regressions in the next version of
patch.
Regards,
Hunaid Sohail
v1-0001-Add-RN-rn-support-for-to_number-function.patch
Description: Binary data
itted the patch on Aug 30 because I read that new patches should be
submitted in CF with "Open" status.
> On Fri, Aug 30, 2024 at 12:22 AM Hunaid Sohail
> wrote:
> >While looking at formatting.c file, I noticed a TODO about "add support
> for roman number to standard nu
Looking forward to your feedback.
Regards,
Hunaid Sohail
On Tue, Sep 3, 2024 at 8:47 PM Maciek Sakrejda wrote:
> On Tue, Sep 3, 2024 at 6:29 AM Hunaid Sohail wrote:
> > I submitted the patch on Aug 30 because I read that new patches should
> be submitted in CF with "Open" stat
N') AS roman
> FROM generate_series(1, 3999) AS i
> ) SELECT bool_and(to_number(roman, 'RN') = i) FROM rows;
>
> bool_and
> --
> t
> ```
>
I also noticed there are no tests for to_char roman format. The test you
provided covers roman format in both to_char and to_number. I will add it.
Thank you.
Regards,
Hunaid Sohail
>> SELECT i, to_char(i, 'FMRN') AS roman
>> FROM generate_series(1, 3999) AS i
>> ) SELECT bool_and(to_number(roman, 'RN') = i) FROM rows;
>>
>> bool_and
>> --
>> t
>> ```
>>
>
>
I have added this test
