Re: FDW pushdown of non-collated functions

Hi Ashutosh, Le ven. 6 oct. 2023 à 14:16, Ashutosh Bapat a écrit : > Hi Jean-Christophe, > > On Fri, Sep 8, 2023 at 11:30 PM Jean-Christophe Arnu > wrote: > > > > Maybe we could add another condition to the first if statement in order > to allow a “no-collation” func

Re: FDW pushdown of non-collated functions

Dear Hackers, I figured out this email was sent at release time. The worst time to ask for thoughts on a subject IMHO. Anyway, I hope this email will pop the topic over the stack! Thank you! Le ven. 8 sept. 2023 à 16:41, Jean-Christophe Arnu a écrit : > Dear hackers, > > I recen

FDW pushdown of non-collated functions

_SAFE || fe->inputcollid != inner_cxt.collation) return false; I don’t presume this patch is free from side effects or fits all use-cases. A patch (tiny) is attached to this email. This patch works against master/head at the time of writing. Thank you for any thoughts. --

Re: Empty string in lexeme for tsvector

Thank you Tom for your review. Le mer. 29 sept. 2021 à 21:36, Tom Lane a écrit : > Jean-Christophe Arnu writes: > > [ empty_string_in_tsvector_v4.patch ] > > I looked through this patch a bit. I don't agree with adding > these new error conditions to tsvector_s

Re: Empty string in lexeme for tsvector

Le dim. 26 sept. 2021 à 22:41, Jean-Christophe Arnu a écrit : > > > Le dim. 26 sept. 2021 à 15:55, Artur Zakirov a écrit : > >> Nice catch! The patch looks good to me. >> Can you also add a more general test case: >> >> =# SELECT $$'' '1' '2'$$::tsvector;

Re: Empty string in lexeme for tsvector

vector; > > Thank you, Artur for spotting this test. It is now included into this patch. -- Jean-Christophe Arnu diff --git a/src/backend/utils/adt/tsvector_op.c b/src/backend/utils/adt/tsvector_op.c index 9236ebcc8f..00f80ffcbc 100644 --- a/src/backend/utils/adt/tsvector_op.c +++ b/s

Re: Empty string in lexeme for tsvector

to do (prevent further processing on lexemes as soon as possible) but I might omit something. Regards Jean-Christophe Arnu diff --git a/src/backend/utils/adt/tsvector_op.c b/src/backend/utils/adt/tsvector_op.c index 9236ebcc8f..00f80ffcbc 100644 --- a/src/backend/utils/adt/tsvector_op.c +++ b/src/backen

Empty string in lexeme for tsvector

ression tests. Patch applies along head/master and 14_RC1. Comments are more than welcome! Thank you, -- Jean-Christophe Arnu diff --git a/src/backend/utils/adt/tsvector_op.c b/src/backend/utils/adt/tsvector_op.c index 9236ebcc8f..5a33e1bb10 100644 --- a/src/backend/utils/adt/tsvector_op.c +++ b/s

Re: PITR on DROP DATABASE, deleting of the database directory despite the recovery_target_time set before.

. And give some examples on this. Maybe we could add some documentation in the xlog explanation and a warning in the recovery_target_time and xid in guc doc ? If there are better places in the docs let us know. Thanks -- Jean-Christophe Arnu

Re: wal_dump output on CREATE DATABASE

Le mar. 20 nov. 2018 à 13:34, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> a écrit : > On 16/11/2018 17:28, Jean-Christophe Arnu wrote: > > On the other hand, there's a consensus not to go further than the > > initial patch. > > I have committed your original

Re: wal_dump output on CREATE DATABASE

re's some different format. Anyway, I handle all of them (I hope so) in my processing script. So keeping the things just as they are (out of the initial COPY patch that should be applied *to me*) is no problem for me. On the other hand, there's a consensus not to go further than the initial patch. -- Jean-Christophe Arnu

Re: wal_dump output on CREATE DATABASE

nt to perform these changes or not. If the A/B/C notation is to be generalized, it would be worth document it in the SGML file. If not, the first patch provided should be enough. Regards -- Jean-Christophe Arnu

Re: wal_dump output on CREATE DATABASE

Le lun. 5 nov. 2018 à 15:37, Jean-Christophe Arnu a écrit : > > > Le dim. 4 nov. 2018 à 18:01, Jean-Christophe Arnu a > écrit : > >> Le ven. 2 nov. 2018 à 08:37, Peter Eisentraut < >> peter.eisentr...@2ndquadrant.com> a écrit : >> >>>

Re: wal_dump output on CREATE DATABASE

Le dim. 4 nov. 2018 à 18:01, Jean-Christophe Arnu a écrit : > Le ven. 2 nov. 2018 à 08:37, Peter Eisentraut < > peter.eisentr...@2ndquadrant.com> a écrit : > >> On 26/10/2018 15:53, Jean-Christophe Arnu wrote: >> > Exemple on CREATE DATABASE (without defining a

Re: wal_dump output on CREATE DATABASE

Le ven. 2 nov. 2018 à 08:37, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> a écrit : > On 26/10/2018 15:53, Jean-Christophe Arnu wrote: > > Exemple on CREATE DATABASE (without defining a template database) : > > rmgr: Databaselen (rec/tot): 42/42, tx:

wal_dump output on CREATE DATABASE

didn't do the things the right way, I would appreciate some help from a kind mentor. I'll put the patch for the next commitfest. Thank you, -- Jean-Christophe Arnu diff --git a/src/backend/access/rmgrdesc/dbasedesc.c b/src/backend/access/rmgrdesc/dbasedesc.c index 39e26d7ed4..7ee120f1d9 100644 --- a/s