Re: CREATE INDEX CONCURRENTLY on partitioned index

rom 4ba360eaaac5e1ac169d41c26cf6213b0c6a2432 Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Sat, 6 Jun 2020 17:42:23 -0500 Subject: [PATCH] Allow CREATE INDEX CONCURRENTLY on partitioned table Note, this effectively reverts 050098b14, so take care to not reintroduce the bug it fixed. --- doc/

Re: Add LZ4 compression in pg_dump

er one. Further action will be taken then > as needed. On Sun, Nov 06, 2022 at 02:53:12PM +, gkokola...@pm.me wrote: > On Wed, Nov 2, 2022 at 14:28, Justin Pryzby wrote: > > Checking if you'll be able to submit new patches soon ? > > Thank you for checking up. Expect new

Re: CI and test improvements

On Sat, Nov 19, 2022 at 01:18:54PM -0800, Andres Freund wrote: > > Also, if CompilerWarnings doesn't depend on Linux, that means those two > > tasks will normally start and run simultaneously, which means a single > > branch will use all 8 of the linux CPUs available from cirrus. Is that > > inten

Re: CI and test improvements

On Sun, Oct 02, 2022 at 01:52:01PM -0700, Andres Freund wrote: > > +# To avoid unnecessarily spinning up a lot of VMs / containers for entirely > +# broken commits, have a very minimal test that all others depend on. > +task: > + name: SanityCheck Maybe this should be named 00-SanityCheck, so i

Re: allowing for control over SET ROLE

On Fri, Nov 18, 2022 at 04:19:15PM -0500, Robert Haas wrote: > On Fri, Nov 18, 2022 at 1:50 PM Erik Rijkers wrote: > > In grant.sgml, > > > >'actualy permisions' > > > > looks a bit unorthodox. > > Fixed that, and the other mistake Álvaro spotted, and also bumped > catversion because I forgot

Re: fix stats_fetch_consistency value in postgresql.conf.sample

@cfbot: re-rebased again >From e1f0940e7682052b2ec9d58c361f56630aa1742e Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Tue, 19 Jul 2022 08:31:56 -0500 Subject: [PATCH 1/2] pg_settings_get_flags(): add DEFAULT_COMPILE and DEFAULT_INITDB .. for settings which vary by ./configure or platf

Re: Allow single table VACUUM in transaction block

On Wed, Nov 16, 2022 at 05:14:07PM -0500, Greg Stark wrote: > I think this requesting autovacuum worker should be a distinct > command. Or at least an explicit option to vacuum. +1. I was going to suggest VACUUM (NOWAIT) .. -- Justin

Re: Introduce "log_connection_stages" setting.

On Tue, Nov 08, 2022 at 07:30:38PM +0100, Sergey Dudoladov wrote: > +Logs reception of a connection. At this point a connection > has been received, but no further work has been done: receipt > +Logs the original identity that an authentication method > employs to identify a use

Re: CI and test improvements

On Wed, Nov 16, 2022 at 08:08:32PM -0800, Andres Freund wrote: > I also don't like my "cores_script". Not quite sure yet how to do that > more cleanly. I don't know which is cleaner: ls /core* && mv /tmp/core* /tmp/cores find / -maxdepth 1 -type f -name 'core*' -print0 | xargs -r0 mv -vt

Re: CI and test improvements

e -z": On Tue, Oct 18, 2022 at 12:09:30PM -0500, Justin Pryzby wrote: > I realized that ccache -z clears out not only the global stats, but the > per-file cache stats (from which the global stats are derived) - which > obviously makes the cache work poorly. -- Justin

Re: pg_upgrade test failure

On Tue, Nov 08, 2022 at 01:16:09AM +1300, Thomas Munro wrote: > So [1] on its own didn't fix this. My next guess is that the attached > might help. I took the liberty of adding a CF entry for this https://commitfest.postgresql.org/41/4011/ And afterwards figured I could be a little bit wasteful

Re: [PATCH] Support % wildcard in extension upgrade filenames

Note that the patch is passing tests when using autoconf build but failing for meson builds. http://cfbot.cputube.org/sandro-santilli.html I imagine you need to make the corresponding change to ./meson.build that you made to ./Makefile. https://wiki.postgresql.org/wiki/Meson_for_patch_authors ht

Re: libpq compression (part 2)

On Mon, Nov 14, 2022 at 07:44:24PM -0800, Andrey Borodin wrote: > patchset needs a heavy rebase. If no one shows up to fix it I'll do Despite what its git timestamp says, this is based on the most recent patch from January, which I've had floating around since then. It needed to be rebased over a

Re: Documentation for building with meson

On Wed, Nov 16, 2022 at 10:52:35AM +0900, Ian Lawrence Barwick wrote: > 2022年10月20日(木) 11:43 Justin Pryzby : > > > > On Wed, Oct 19, 2022 at 11:35:10AM -0700, samay sharma wrote: > > > Creating a new thread focussed on adding docs for building Postgres with > > >

Re: Vacuumdb --force-index-cleanup option not available in postgres 12.9

On Tue, Nov 15, 2022 at 03:40:58PM +, Karthik Jagadish (kjagadis) wrote: > Thanks Justin for prompt response. Could you please provide the full email > for pgsql-user? pgsql-u...@postgresql.org > is not working Of course, I intended to say pgsql-gene...@list

Re: Vacuumdb --force-index-cleanup option not available in postgres 12.9

On Tue, Nov 15, 2022 at 02:45:37PM +, Karthik Jagadish (kjagadis) wrote: > Hi, > > In the postgres document we notice that the --force-index-cleanup option is > available in PostgreSQL server 12 and Later. We have postgres db running on > 12.9 but we don’t see this option. > > https://www.p

Re: [RFC] building postgres with meson - v12

On Sun, Aug 28, 2022 at 01:37:41PM -0700, Andres Freund wrote: > > You're running tap tests via a python script. There's no problem with > > that, but it's different from what's done by the existing makefiles. > > I was able to remove the python indirection - maybe that's better to > > talk about

Re: Add sub-transaction overflow status in pg_stat_activity

On Mon, Nov 14, 2022 at 10:09:57AM -0500, Robert Haas wrote: > On Mon, Mar 21, 2022 at 7:45 PM Andres Freund wrote: > > > It feels to me like far too much effort is being invested in fundamentally > > > the wrong direction here. If the subxact overflow business is causing > > > real-world perform

Re: CI and test improvements

On Fri, Nov 04, 2022 at 06:59:46PM -0700, Andres Freund wrote: > Hi, > > On 2022-11-04 18:54:12 -0500, Justin Pryzby wrote: > > Subject: [PATCH 1/8] meson: PROVE is not required > > Subject: [PATCH 3/8] meson: rename 'main' tasks to 'regress' and '

Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL

On Wed, Nov 09, 2022 at 02:37:29PM -0600, David Christensen wrote: > On Wed, Nov 9, 2022 at 2:08 PM David Christensen > wrote: > > Justin sez: > > > I was wondering if there's any reason to do "CREATE DATABASE". The vast > > > majority of TAP tests don't. > > > > > > $ git grep -ho 'safe_psql[^

Re: New strategies for freezing, advancing relfrozenxid early

Note that this fails under -fsanitize=align Subject: [PATCH v5 2/6] Teach VACUUM to use visibility map snapshot. performing post-bootstrap initialization ... ../src/backend/access/heap/visibilitymap.c:482:38: runtime error: load of misaligned address 0x5559e1352424 for type 'uint64', which requi

Re: Reducing the WAL overhead of freezing in VACUUM by deduplicating per-tuple freeze plans

On Thu, Nov 10, 2022 at 04:48:17PM -0800, Peter Geoghegan wrote: > On Tue, Sep 20, 2022 at 3:12 PM Peter Geoghegan wrote: > > Attached is v2, which I'm just posting to keep CFTester happy. No real > > changes here. > > Attached is v3. I'd like to move forward with commit soon. I'll do so > in the

Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL

On Wed, Nov 09, 2022 at 06:00:40PM +0530, Bharath Rupireddy wrote: > On Wed, Nov 9, 2022 at 5:08 AM David Christensen > wrote: > > > > Enclosed is v6, which squashes your refactor and adds the additional > > recent suggestions. > > Thanks for working on this feature. Here are some comments for n

Re: Cygwin cleanup

On Thu, Oct 20, 2022 at 10:40:40PM -0500, Justin Pryzby wrote: > On Thu, Aug 04, 2022 at 04:16:06PM +1200, Thomas Munro wrote: > > On Thu, Aug 4, 2022 at 3:38 PM Justin Pryzby wrote: > > > [train wreck] > > > > Oh my, so I'm getting the impression we might

Re: Crash in BRIN minmax-multi indexes

On Mon, Oct 03, 2022 at 10:29:38PM +0200, Tomas Vondra wrote: > I'll get this fixed in a couple days. Considering the benign nature of > this issue (unnecessary assert) I'm not going to rush. Is this still an outstanding issue ? -- Justin

Re: Commit fest 2022-11

On Thu, Nov 03, 2022 at 07:43:03PM -0500, Justin Pryzby wrote: > On Thu, Nov 03, 2022 at 11:33:57AM +0900, Ian Lawrence Barwick wrote: > > 2022年11月2日(水) 19:10 Greg Stark : > > > On Tue, 1 Nov 2022 at 06:56, Michael Paquier wrote: > > > > > > > Two people sho

Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL

$lo_lsn_bk, + 'verify file-based LSN precedes block-based one'); + + # stash checksum for later comparisons + $checksums{$file} = $checksum; +} + +# verify filename formats matches w/--fixup-fpi +for my $fullpath (glob "$tmp_folder/fixup/*") +{ + my $file = File::Basename::b

Re: Improve logging when using Huge Pages

On Sun, Nov 06, 2022 at 02:04:29PM +0700, John Naylor wrote: > On Thu, Nov 3, 2022 at 8:11 AM Thomas Munro wrote: > > > > I wonder if the problem here is that people are reluctant to add noise > > to every starting system. There are people who have not configured > > their system and don't want

Re: explain_regress, explain(MACHINE), and default to explain(BUFFERS) (was: BUFFERS enabled by default in EXPLAIN (ANALYZE))

On Fri, Nov 04, 2022 at 11:46:03AM +0100, Laurenz Albe wrote: > "explain_regress" reduces the EXPLAIN options you need for regression tests. > This is somewhat useful, but not a big win. Also, it will make backpatching > regression tests slightly harder for the next 5 years. But it doesn't cause

Re: CI and test improvements

On Sat, Sep 10, 2022 at 03:05:42PM -0500, Justin Pryzby wrote: > On Sun, Aug 28, 2022 at 02:28:02PM -0700, Andres Freund wrote: > > On 2022-08-28 12:10:29 -0500, Justin Pryzby wrote: > > > On Sun, Aug 28, 2022 at 09:07:52AM -0700, Andres Freund wrote: > > > > >

Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL

On Fri, Nov 04, 2022 at 09:16:29AM -0500, David Christensen wrote: > On Nov 4, 2022, at 9:02 AM, Justin Pryzby wrote: > > On Fri, Nov 04, 2022 at 11:52:59AM +0900, Ian Lawrence Barwick wrote: > >> 2022年5月3日(火) 8:45 David Christensen : > >>> > >>> ...

Re: Draft back-branch release notes are up

(Richard Guo, Justin Pryzby) This can also happen with inheritance tables. + Add missing guards for NULL connection pointer Maybe should be NULL or NULL ? -- Justin

Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL

On Fri, Nov 04, 2022 at 11:52:59AM +0900, Ian Lawrence Barwick wrote: > 2022年5月3日(火) 8:45 David Christensen : > > > > ...and pushing a couple fixups pointed out by cfbot, so here's v4. > > cfbot reports the patch no longer applies [1]. As CommitFest 2022-11 is > currently underway, this would be a

Re: proposal: possibility to read dumped table's name from file

On Fri, Nov 04, 2022 at 07:59:01PM +0800, Julien Rouhaud wrote: > On Thu, Nov 03, 2022 at 10:22:15PM +0100, Pavel Stehule wrote: > > čt 3. 11. 2022 v 5:09 odesílatel Julien Rouhaud napsal: > > updated patch attached > > > > big thanks for these comments and tips > > Thanks for the updated patch!

Re: Commit fest 2022-11

On Thu, Nov 03, 2022 at 11:33:57AM +0900, Ian Lawrence Barwick wrote: > 2022年11月2日(水) 19:10 Greg Stark : > > > > On Tue, 1 Nov 2022 at 06:56, Michael Paquier wrote: > > > > > Two people showing up to help is really great, thanks! I'll be around > > > as well this month, so I'll do my share of pat

Re: Fix proposal for comparaison bugs in PostgreSQL::Version

On Tue, Jun 28, 2022 at 06:17:40PM -0400, Andrew Dunstan wrote: > Nice catch, but this looks like massive overkill. I think we can very > simply fix the test in just a few lines of code, instead of a 190 line > fix and a 130 line TAP test. > > It was never intended to be able to compare markers li

Re: pg15 inherited stats expressions: cache lookup failed for statistics object

On Tue, Nov 01, 2022 at 02:35:43PM -0400, Tom Lane wrote: > Justin Pryzby writes: > > I added a CF entry and marked RFC. > > This should be included in v15.1. > > Right, done. Thanks. Yesterday, I realized that the bug was exposed here after we accidentally recreated

Re: Add LZ4 compression in pg_dump

Checking if you'll be able to submit new patches soon ?

Re: Make ON_ERROR_STOP stop on shell script failure

On Fri, Sep 16, 2022 at 03:55:33PM +0900, bt22nakamorit wrote: > Hi, > > """\set ON_ERROR_STOP on""" stops any subsequent incoming query that comes > after an error of an SQL, but does not stop after a shell script ran by > """\! """ returning values other than 0, -1, or 127, which > suggests a fa

Re: Glossary and initdb definition work for "superuser" and database/cluster

On Tue, Nov 01, 2022 at 03:47:15PM -0700, David G. Johnston wrote: > Hey, > > Recent threads have pointed out some long-standing doc language in initdb > that could be made more precise, especially in light of the relatively > recent addition of a glossary. Toward this end I'm attaching a patch t

Re: warn if GUC set to an invalid shared library

On Mon, Oct 31, 2022 at 08:31:20AM -0500, Justin Pryzby wrote: > On Sun, Oct 30, 2022 at 04:12:33PM -0700, Maciek Sakrejda wrote: > > On Sat, Oct 29, 2022 at 10:40 AM Justin Pryzby wrote: > > > On Fri, Sep 02, 2022 at 05:24:58PM -0500, Justin Pryzby wrote: > > >

Re: Direct I/O

On Tue, Nov 01, 2022 at 08:36:18PM +1300, Thomas Munro wrote: > Hi, > > Here is a patch to allow PostgreSQL to use $SUBJECT. It is from the > AIO patch-set[1]. It adds three new settings, defaulting to off: > > io_data_direct = whether to use O_DIRECT for main data files > io_wal_direct = .

Re: pg15 inherited stats expressions: cache lookup failed for statistics object

On Tue, Nov 01, 2022 at 05:33:24PM +0800, Richard Guo wrote: > On Mon, Oct 31, 2022 at 1:33 PM Michael Paquier wrote: > > > On Mon, Oct 31, 2022 at 01:12:09PM +0800, Richard Guo wrote: > > > BTW, I noticed a micro-optimization opportunity in examine_variable that > > > we can fetch the RangeTblEn

Re: pg_upgrade allows itself to be run twice

On Tue, Nov 01, 2022 at 01:54:35PM +0100, Peter Eisentraut wrote: > On 07.07.22 08:22, Justin Pryzby wrote: > > > This one comes from NextOID in the control data file after a fresh > > > initdb, and GetNewObjectId() would enforce that in a postmaster > > > environ

Re: heapgettup refactoring

FYI: [18:51:54.707] ../src/backend/access/heap/heapam.c(720): warning C4098: 'heapgettup': 'void' function returning a value [18:51:54.707] ../src/backend/access/heap/heapam.c(850): warning C4098: 'heapgettup_pagemode': 'void' function returning a value For some reason, MSVC is the only one to

Re: warn if GUC set to an invalid shared library

On Sun, Oct 30, 2022 at 04:12:33PM -0700, Maciek Sakrejda wrote: > On Sat, Oct 29, 2022 at 10:40 AM Justin Pryzby wrote: > > > > On Fri, Sep 02, 2022 at 05:24:58PM -0500, Justin Pryzby wrote: > > > It caused no issue when I changed: > > > > > >

pg15 inherited stats expressions: cache lookup failed for statistics object

postgres=# \set QUIET CREATE TABLE stxdinp (i int, j int) PARTITION BY RANGE(i); CREATE TABLE stxdinp1 PARTITION OF stxdinp FOR VALUES FROM (1)TO(10); INSERT INTO stxdinp SELECT generate_series(1,9)a; CREATE STATISTICS stxdp ON i,j FROM stxdinp; ANALYZE stxdinp; explain SELECT i, j, COUNT(1) FROM

Re: warn if GUC set to an invalid shared library

On Fri, Sep 02, 2022 at 05:24:58PM -0500, Justin Pryzby wrote: > It caused no issue when I changed: > > /* Check that it's acceptable for the indicated > parameter */ > if (!parse_and_validate_value

Re: explain_regress, explain(MACHINE), and default to explain(BUFFERS) (was: BUFFERS enabled by default in EXPLAIN (ANALYZE))

On Tue, Oct 25, 2022 at 03:49:14PM +0200, Laurenz Albe wrote: > On Thu, 2022-10-20 at 21:09 -0500, Justin Pryzby wrote: > > Rebased. > > I had a look at the patch set. Thanks for looking > @@ -2288,6 +2288,7 @@ regression_main(int argc, char *argv[], > fputs(&

Re: psql: Add command to use extended query protocol

On Fri, Oct 28, 2022 at 08:52:51AM +0200, Peter Eisentraut wrote: > Perhaps this would also be useful for general psql scripting. +1 It makes great sense to that psql would support it (I've suggested to a few people over the last few years to do that using pygres, lacking an easier way). I wonde

Re: Make mesage at end-of-recovery less scary.

rebased >From 67ce65038ae6a7d5b023b7472df9f9ca9835d5f5 Mon Sep 17 00:00:00 2001 From: Kyotaro Horiguchi Date: Thu, 7 Jul 2022 11:51:45 +0900 Subject: [PATCH] Make End-Of-Recovery error less scary When recovery in any type ends, we see a bit scary error message like "invalid record length" that su

Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*)

gt; src/backend/utils/adt/genfile.c > > /* Ignore anything but regular files */ > > if (!S_ISREG(attrib.st_mode)) > > continue; > > +1, that's worth fixing. @cfbot: rebased on eddc128be. >From f641f63a1ff3efd90a3831927c758636cc82d

Re: Allow single table VACUUM in transaction block

On Thu, Oct 27, 2022 at 10:31:31AM +0100, Simon Riggs wrote: > Allows both ANALYZE and vacuum of toast tables, but not VACUUM FULL. Maybe I misunderstood what you meant: you said "not VACUUM FULL", but with your patch, that works: postgres=# begin; VACUUM FULL pg_class; commit; BEGIN VACUUM COMMI

Re: GUC values - recommended way to declare the C variables?

On Thu, Oct 27, 2022 at 11:33:48AM +0900, Michael Paquier wrote: > On Wed, Oct 26, 2022 at 09:14:37PM -0500, Justin Pryzby wrote: > > It seems like you're reviewing the previous version of the patch, rather > > than the one attached to the message you responded to (which doesn

Re: GUC values - recommended way to declare the C variables?

On Thu, Oct 27, 2022 at 11:06:56AM +0900, Michael Paquier wrote: > On Wed, Oct 26, 2022 at 06:31:56PM +1100, Peter Smith wrote: > > I re-checked all the GUC C vars which your patch flags as > > GUC_DEFAULT_COMPILE. For some of them, where it was not any trouble, I > > made the C var assignment use

Re: GUC values - recommended way to declare the C variables?

+#ifdef USE_ASSERT_CHECKING + sanity_check_GUC_C_var(hentry->gucvar); +#endif => You can conditionally define that as an empty function so #ifdefs aren't needed in the caller: void sanity_check_GUC_C_var() { #ifdef USE_ASSERT_CHECKING ... #endif } + /* Skip checking f

Re: fix stats_fetch_consistency value in postgresql.conf.sample

On Mon, Sep 26, 2022 at 05:29:58PM +0900, Kyotaro Horiguchi wrote: > At Sat, 17 Sep 2022 23:53:07 -0500, Justin Pryzby > wrote in > > This is an alternative implementation, which still relies on adding the > > GUC_DYNAMIC, flag but doesn't require adding a new, sql-acc

Re: [patch] Have psql's \d+ indicate foreign partitions

On Mon, Oct 24, 2022 at 09:44:18PM +0900, Ian Lawrence Barwick wrote: > Recently I have been working a lot with partitioned tables which contain a mix > of local and foreign partitions, and find it would be very useful to be able > to > easily obtain an overview of which partitions are foreign and

Re: parse partition strategy string in gram.y

On Fri, Oct 21, 2022 at 06:22:44PM +0800, Japin Li wrote: > Is there any way to get the regression tests diffs from Cirrus CI? > I did not find the diffs in [1]. > > [1] https://cirrus-ci.com/build/4721735111540736 They're called "main". I'm planning on submitting a patch to rename it to "regress

Re: Cygwin cleanup

On Thu, Aug 04, 2022 at 04:16:06PM +1200, Thomas Munro wrote: > On Thu, Aug 4, 2022 at 3:38 PM Justin Pryzby wrote: > > [train wreck] > > Oh my, so I'm getting the impression we might actually be totally > unstable on Cygwin. Which surprises me because ... wait a minu

Re: explain_regress, explain(MACHINE), and default to explain(BUFFERS) (was: BUFFERS enabled by default in EXPLAIN (ANALYZE))

Rebased. BTW, I think it may be that the GUC should be marked PGDLLIMPORT ? >From 12a605ca84bf21439e4ae51cc3f3a891b3cb4989 Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Sat, 22 Feb 2020 21:17:10 -0600 Subject: [PATCH 1/7] Add GUC: explain_regress This changes the defaults for explain

Re: ccache, MSVC, and meson

Note that ccache 4.7 was released (and also uploaded to chocolatey). That supports depend mode with MSVC. PCH made cache misses a lot less slow. However, I still haven't found anyt way to improve compilation speed much on cirrusci... -- Justin

Re: GUC values - recommended way to declare the C variables?

On Thu, Oct 20, 2022 at 11:56:58AM +1100, Peter Smith wrote: > Patch 0002 adds a sanity-check function called by > InitializeGUCOptions, as suggested by Tom [2]. This is to ensure that > the GUC C variable initial values are sensible and/or have not gone > stale compared with the compiled-in defaul

Re: Documentation for building with meson

On Wed, Oct 19, 2022 at 11:35:10AM -0700, samay sharma wrote: > Creating a new thread focussed on adding docs for building Postgres with > meson. This is a spinoff from the original thread [1] and I've attempted to > address all the feedback provided there in the attached patch. > > Please let me

Re: [RFC] building postgres with meson - v13

> From 680ff3f7b4da1dbf21d0c7cd87af9bb5ee8b230c Mon Sep 17 00:00:00 2001 > From: Andres Freund > Date: Wed, 21 Sep 2022 20:36:36 -0700 > Subject: [PATCH v17 01/23] meson: ci: wip: move compilerwarnings task to meson > > --- > .cirrus.yml| 92 +-

Re: pg_upgrade test failure

On Tue, Oct 18, 2022 at 01:06:15PM +0900, Michael Paquier wrote: > On Tue, Oct 18, 2022 at 09:47:37AM +1300, Thomas Munro wrote: > > * Server 2019, as used on CI, still uses the traditional NT semantics > > (unlink is asynchronous, when all handles closes) > > * the fix I proposed has the right eff

Re: pub/sub - specifying optional parameters without values.

On Fri, Oct 14, 2022 at 07:54:37PM +1100, Peter Smith wrote: > Hi hackers. > > This post is about parameter default values. Specifically. it's about > the CREATE PUBLICATION and CREATE SUBSCRIPTION syntax, although the > same issue might apply to other commands I am unaware of... The same thing s

Re: shadow variables - pg15 edition

On Tue, Oct 04, 2022 at 02:27:09PM +1300, David Rowley wrote: > On Tue, 30 Aug 2022 at 17:44, Justin Pryzby wrote: > > Would you check if any of these changes are good enough ? > > I looked through v5.txt and modified it so that the fix for the shadow > warnings are m

Re: PostgreSQL 15 GA release date

On Mon, Oct 03, 2022 at 09:05:34AM -0300, Ranier Vilela wrote: > >Please let us know if you have any questions. We're excited that we are > >very close to officially releasing PostgreSQL 15. > Hi, forgive my ignorance. > What are the rules for a commit to be included in the release notes? > Does it

Re: CI and test improvements

On Sun, Oct 02, 2022 at 02:54:21PM -0700, Andres Freund wrote: > the clang-only memory sanitizer there (if it works on freebsd)... Have you looked at this much ? I think it'll require a bunch of exclusions, right ? -- Justin

Re: [RFC] building postgres with meson - v13

On Sun, Oct 02, 2022 at 01:38:37PM -0500, Justin Pryzby wrote: > On Sun, Oct 02, 2022 at 11:05:30AM -0700, Andres Freund wrote: > > > Also, you wrote "rm -fr build" between building for gcc and clang, but > > > since they run in an "always" block, it&#

Re: CI and test improvements

On Sun, Oct 02, 2022 at 01:52:01PM -0700, Andres Freund wrote: > Hi, > > On 2022-10-01 18:36:41 -0700, Andres Freund wrote: > > I am wondering if we should instead introduce a new "quickcheck" task that > > just compiles and runs maybe one test and have *all* other tests depend on > > that. Wasti

Re: [RFC] building postgres with meson - v13

On Sun, Oct 02, 2022 at 11:05:30AM -0700, Andres Freund wrote: > > Also, you wrote "rm -fr build" between building for gcc and clang, but > > since they run in an "always" block, it'd be better to use separate > > dirs, to allow seeing logs for the the all (failed) tasks, in case the > > last one s

Re: [RFC] building postgres with meson - v13

On Mon, Sep 26, 2022 at 06:19:51PM -0700, Andres Freund wrote: > From 680ff3f7b4da1dbf21d0c7cd87af9bb5ee8b230c Mon Sep 17 00:00:00 2001 > From: Andres Freund > Date: Wed, 21 Sep 2022 20:36:36 -0700 > Subject: [PATCH v17 01/23] meson: ci: wip: move compilerwarnings task to meson This patch isn't f

Re: CI and test improvements

On Sat, Oct 01, 2022 at 05:45:01PM -0700, Andres Freund wrote: > Hi, > > On 2022-09-10 15:05:42 -0500, Justin Pryzby wrote: > > From 4ed5eb427de4508a4c3422e60891b45c8512814a Mon Sep 17 00:00:00 2001 > > From: Justin Pryzby > > Date: Sun, 3 Apr 2022 00:10:20 -050

Re: longfin and tamandua aren't too happy but I'm not sure why

On Sat, Oct 01, 2022 at 03:15:14PM -0700, Andres Freund wrote: > On 2022-10-01 11:14:20 -0500, Justin Pryzby wrote: > > (I still suggest my patches to run all tests using vcregress. The number of > > people who remember that, for v15, cirrusci runs incomplete tests is > > pr

Re: longfin and tamandua aren't too happy but I'm not sure why

On Wed, Sep 28, 2022 at 08:45:31PM -0700, Andres Freund wrote: > Hi, > > On 2022-09-28 21:22:26 +0200, Alvaro Herrera wrote: > > I have an additional, unrelated complaint about CI, which is that we > > don't have anything for past branches. I have a partial hack(*), but > > I wish we had somethin

Re: EINTR in ftruncate()

On Wed, Aug 17, 2022 at 07:51:34AM +1200, Thomas Munro wrote: > Here's a draft patch that adds a minimal sigaction() implementation > for Windows. It doesn't implement stuff we're not using, for sample > sa_sigaction functions, but it has the sa_mask feature so we can > harmonize the stuff that I

Re: longfin and tamandua aren't too happy but I'm not sure why

On Tue, Sep 27, 2022 at 02:55:18PM -0400, Robert Haas wrote: > Both animals are running with -fsanitize=alignment and it's not > difficult to believe that the commit mentioned above could have > introduced an alignment problem where we didn't have one before, but > without a stack backtrace I don't

Re: pgsql: Increase width of RelFileNumbers from 32 bits to 56 bits.

On Tue, Sep 27, 2022 at 03:12:56PM -0400, Robert Haas wrote: > On Tue, Sep 27, 2022 at 2:51 PM Justin Pryzby wrote: > > This seems to be breaking cfbot: > > https://cirrus-ci.com/github/postgresql-cfbot/postgresql > > > > For example: > > https://cirrus-ci.com/tas

Re: add checkpoint stats of snapshot and mapping files of pg_logical dir

On Sun, Sep 25, 2022 at 04:50:54PM -0400, Hamid Akhtar wrote: > On Sun, 28 Aug 2022 at 17:30, Nathan Bossart wrote: > > > On Thu, Aug 25, 2022 at 10:12:00AM +0530, Bharath Rupireddy wrote: > > > Please review the v12 patch attached. > > > > LGTM. I've marked this as ready-for-committer. > > > >

Re: First draft of the PG 15 release notes

o). I see a > few other places where Bruce left notes about things that need more > clarification. I'm just finishing a pass of "update for subsequent > commits", and then I'll start on copy-editing. Some possible changes for your consideration. + S

Re: Fix typos in code comments

On Mon, Sep 19, 2022 at 06:10:00AM -0500, Justin Pryzby wrote: > On Mon, Sep 19, 2022 at 11:05:24AM +0800, Zhang Mingli wrote: > > Good catch. There is a similar typo in doc, runtime.sgml. > > ```using TLS protocols enabled by by setting the parameter``` > > That one should

Re: CI and test improvements

On Sun, Aug 28, 2022 at 02:28:02PM -0700, Andres Freund wrote: > > > > @@ -71,8 +69,6 @@ task: > > > > fingerprint_key: ccache/freebsd > > > > reupload_on_changes: true > > > > > > > > - # Workaround around performance issues due to 32KB block size > > > > - repartition_script: src/tool

Re: pg_basebackup's --gzip switch misbehaves

On Thu, Sep 22, 2022 at 10:25:11AM +0900, Michael Paquier wrote: > On Wed, Sep 21, 2022 at 07:31:48PM -0500, Justin Pryzby wrote: > > I think at some point (maybe before releasing 1.3.4) the range was > > increased to very large(small), negative levels. It's possible to q

Re: pg_basebackup's --gzip switch misbehaves

On Tue, Sep 13, 2022 at 04:13:20PM +0900, Michael Paquier wrote: > diff --git a/src/common/compression.c b/src/common/compression.c > index da3c291c0f..ac26287d54 100644 > --- a/src/common/compression.c > +++ b/src/common/compression.c > @@ -249,36 +299,49 @@ expect_integer_value(char *keyword, cha

Re: [RFC] building postgres with meson - v13

On Wed, Sep 21, 2022 at 09:46:30AM -0700, Andres Freund wrote: > I think we should: > > - convert windows to build with ninja - it builds faster, runs all tests, > parallelizes tests. That means that msbuild based builds don't have coverage > via CI / cfbot, but we don't currently have the res

Re: Add 64-bit XIDs into PostgreSQL 15

On Tue, Sep 20, 2022 at 03:37:47PM +0800, Zhang Mingli wrote: > I want to have a look at these patches, but apply on master failed: Yeah, it's likely to break every week or more often. You have a few options: 0) resolve the conflict yourself; 1) apply the patch to the commit that the authors se

Re: pg_upgrade test failure

On Mon, Sep 19, 2022 at 02:32:17PM -0700, Andres Freund wrote: > Hi, > > After my last rebase of the meson tree I encountered the following test > failure: > > https://cirrus-ci.com/task/5532444261613568 > > [20:23:04.171] - 8< > -

Re: Fix typos in code comments

On Mon, Sep 19, 2022 at 02:44:12AM +, houzj.f...@fujitsu.com wrote: > While working on some other patches, I found serval typos(duplicate words and > incorrect function name reference) in the code comments. Here is a small patch > to fix them. Thanks. On Mon, Sep 19, 2022 at 11:05:24AM +0800,

Re: fix stats_fetch_consistency value in postgresql.conf.sample

This is an alternative implementation, which still relies on adding the GUC_DYNAMIC, flag but doesn't require adding a new, sql-accessible function to convert the GUC to a pretty/human display value. >From 25ee6d6ed23ff273e622551fd033c8d086953fe5 Mon Sep 17 00:00:00 2001 From: Justin Pryz

Re: Make mesage at end-of-recovery less scary.

@cfbot: rebased over adb466150, which did the same thing as one of the hunks in xlogreader.c. >From c4069bb7181b68d742d2025567f859e69d24f513 Mon Sep 17 00:00:00 2001 From: Kyotaro Horiguchi Date: Thu, 7 Jul 2022 11:51:45 +0900 Subject: [PATCH] Make End-Of-Recovery error less scary When recovery i

Re: Background writer and checkpointer in crash recovery

I don't know that this warrants an Opened Item, but I think some fix ought to be applied to v15, whether that happens this week or next month.

Re: failing to build preproc.c on solaris with sun studio

On Thu, Sep 15, 2022 at 04:53:09PM +1200, Thomas Munro wrote: > Not sure it's OK to put random junk in ccache's directory, and in any > case we'd certainly want to teach it to trim itself before doing that > on CI... > I suppose a version good enough to live in src/tools would need to > trim the c

Re: failing to build preproc.c on solaris with sun studio

On Wed, Sep 14, 2022 at 03:08:06PM +1200, Thomas Munro wrote: > On Wed, Sep 14, 2022 at 10:23 AM Thomas Munro wrote: > > Given the simplicity of this case, though, I suppose we could > > have a little not-very-general shell/python/whatever wrapper script -- > > just compute a checksum of the input

Re: Background writer and checkpointer in crash recovery

On Tue, Sep 13, 2022 at 01:32:11PM +0900, Michael Paquier wrote: > On Mon, Sep 12, 2022 at 09:13:11PM -0500, Justin Pryzby wrote: > > Like this, maybe. > > > > It's similar to what I suggested to consider backpatching here: > > https://www.postgresql.org/m

Re: Background writer and checkpointer in crash recovery

On Sun, Sep 11, 2022 at 07:54:43PM -0500, Justin Pryzby wrote: > On Tue, Aug 03, 2021 at 02:19:22PM +1200, Thomas Munro wrote: > > On Tue, Aug 3, 2021 at 9:52 AM Thomas Munro wrote: > > > On Tue, Aug 3, 2021 at 1:17 AM Robert Haas wrote: > > > > That's great.

Re: fix stats_fetch_consistency value in postgresql.conf.sample

Hi, Checking if you're planning to work on this patch still ? On Thu, Jul 28, 2022 at 05:27:34PM -0500, Justin Pryzby wrote: > Note that this can currently exposes internal elog() errors to users: > > postgres=# select pg_normalize_config_value('log_min_messages',&#x

Re: pg15b4: FailedAssertion("TransactionIdIsValid(xmax)

On Mon, Sep 12, 2022 at 11:53:14AM +0900, Michael Paquier wrote: > On Mon, Sep 12, 2022 at 02:34:48PM +1200, Thomas Munro wrote: > > On Mon, Sep 12, 2022 at 2:27 PM Justin Pryzby wrote: > >> Yeah ... I just realized that I've already forgotten the relevant > &g

Re: PostgreSQL 15 release announcement draft

On Tue, Sep 13, 2022 at 08:17:27AM +1200, David Rowley wrote: > > certain operating systems, PostgreSQL 15 supports the ability to > > [prefetch WAL file > > contents](https://www.postgresql.org/docs/15/runtime-config-wal.html#GUC-RECOVERY-PREFETCH) > > I think "ability to prefetch WAL file conte

<    1   2   3   4   5   6   7   8   9   10   >