On Sun, Jun 12, 2022 at 10:05:59AM -0400, Jim Popovitch wrote:
> We are seeing connection failures when using "sslmode=require" on forked
> connections. Attached is example code that makes 2 passes. The first pass
> uses "sslmode=disable" and the second uses "sslmode=require". The first
> pass
On Mon, May 30, 2022 at 05:27:19PM +0900, Kyotaro Horiguchi wrote:
> At Sat, 28 May 2022 13:22:45 -0700, Andres Freund wrote
> in
> > Hi,
> >
> > On 2022-05-26 16:27:53 +0900, Kyotaro Horiguchi wrote:
> > > It could be in SQL, but *I* prefer to use perl for this, since it
> > > allows me to
Rebased
>From 4d88986706e334e2dccc6f576139342c102033f8 Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Tue, 13 Jul 2021 21:25:48 -0500
Subject: [PATCH 1/4] Add pg_am_size(), pg_namespace_size() ..
See also: 358a897fa, 528ac10c7
---
src/backend/utils/adt/dbsize.c |
On Wed, Jun 08, 2022 at 10:55:29AM +0900, Michael Paquier wrote:
> And applied, to take care of this open item.
Shouldn't this wait for the buildfarm to be updated again ?
--
Justin
On Mon, Jun 06, 2022 at 03:42:31PM +1000, Peter Smith wrote:
> I noticed the patch "0001-language-fixes-on-HEAD-from-Justin.patch" says:
>
> @@ -11673,7 +11673,7 @@
>prosrc => 'pg_show_replication_origin_status' },
>
> # publications
> -{ oid => '6119', descr => 'get information of tables
tather => rather
is charge => in charge
On Mon, Jun 06, 2022 at 01:17:52PM +0900, Michael Paquier wrote:
> but something like %Y%m%d_%H%M%S.%03d (3-digit ms for last part) would
On Tue, Jun 07, 2022 at 08:30:47AM +0900, Michael Paquier wrote:
> I would reduce the format to be MMDDTHHMMSS_ms
On Mon, Jun 06, 2022 at 04:50:55PM +, Jean Landercy - BEEODIVERSITY wrote:
> Dear Justin,
>
> Thank you for your quick reply.
> Unfortunately, the server having this issue is an Azure Flexible Server.
> Upgrades are managed by Azure, I will have to wait until they release the
> version 13.7.
On Mon, Jun 06, 2022 at 07:43:53PM +0200, Daniel Gustafsson wrote:
> > On 6 Jun 2022, at 06:17, Michael Paquier wrote:
> > On Mon, Jun 06, 2022 at 02:38:03AM +0200, Daniel Gustafsson wrote:
> >> On 5 Jun 2022, at 11:19, Michael Paquier wrote:
>
> >>> I have been toying with the idea of a
On Mon, Jun 06, 2022 at 09:34:24AM +, Jean Landercy - BEEODIVERSITY wrote:
> Faulty setup is about:
>
> SELECT version();
>
> -- PostgreSQL 13.6 on x86_64-pc-linux-gnu, compiled by gcc (Ubuntu
> 7.5.0-3ubuntu1~18.04) 7.5.0, 64-bit
Please check if the problem occurs in v13.7
On Tue, Apr 12, 2022 at 11:19:40AM -0400, Tom Lane wrote:
> "Jonathan S. Katz" writes:
> > On 4/11/22 4:11 PM, Tom Lane wrote:
> >> This idea does somewhat address my unhappiness upthread about printing
> >> values with source = 'internal', but I see that it gets confused by
> >> some GUCs with
On Fri, Jun 03, 2022 at 10:28:37AM -0500, Justin Pryzby wrote:
> Maybe this should actually call vacuum_delay_point(), like
> compute_scalar_stats().
I think vacuum_delay_point() would be wrong for these cases, since they don't
call "fetchfunc()", like the other
On Sat, Jun 04, 2022 at 06:48:19PM +0900, Michael Paquier wrote:
> I would suggest the attached patch then, to add a --check command in
> the test suite, with a change to clean up the logs when --check is
> used without --retain.
This doesn't address one of the problems that I already enumerated.
On Sat, Jun 04, 2022 at 12:13:19PM +0900, Michael Paquier wrote:
> On Fri, Jun 03, 2022 at 06:55:28PM +0200, Daniel Gustafsson wrote:
> > On 3 Jun 2022, at 18:26, Tom Lane wrote:
> >> How about inserting an additional level of subdirectory?
> >>
> >> pg_upgrade_output.d/20220603122528/foo.log
>
On Mon, May 09, 2022 at 09:11:37AM -0400, Robert Haas wrote:
> On Sun, May 8, 2022 at 11:36 PM Tom Lane wrote:
> > Michael Paquier writes:
> > > How long can the backend remain unresponsive? I don't think that
> > > anybody would object to the addition of some CHECK_FOR_INTERRUPTS() in
> > >
On Fri, Jun 03, 2022 at 02:01:18PM +0200, Daniel Gustafsson wrote:
> > On 3 Jun 2022, at 13:19, tushar wrote:
>
> > This behavior was not there in earlier released versions, i guess.
> > Is it expected behavior now onwards?
>
> That's an unfortunate side effect which AFAICT was overlooked in
forking: <20220302205058.gj15...@telsasoft.com>: Re: Adding CI to our tree
On Wed, Mar 02, 2022 at 02:50:58PM -0600, Justin Pryzby wrote:
> BTW (regarding the last patch), I just noticed that -Og optimization can cause
> warnings with gcc-4.8.5-39.el7.x86_64.
>
> be-fsst
On Wed, May 18, 2022 at 03:08:32AM +0200, Erik Rijkers wrote:
> funcs.sgml has
>
> 42 <@ '{[1,7)}'::int4multirange
>
> and calls it true. The attached fixes that.
>
> Included are two more changes where actual output differs a bit from what
> the doc examples show.
This patch is RFC but
On Wed, Jun 01, 2022 at 12:56:55PM +0200, Peter Eisentraut wrote:
> On 31.05.22 22:06, Justin Pryzby wrote:
> > On Wed, May 18, 2022 at 11:57:15AM -0500, Justin Pryzby wrote:
> > > I prefer my original, but the most important thing is to include the link
> > > at
>
On Wed, May 18, 2022 at 11:57:15AM -0500, Justin Pryzby wrote:
> I prefer my original, but the most important thing is to include the link at
> *somewhere*.
Any other opinions ?
-world.
commit 4dc465207517c4b69a1f2b657a8ad0700c08e34c
Author: Justin Pryzby
Date: Sat May 28 22:32:58 2022 -0500
libpq tests were not being run
See also:
ac25173cdbc40b310a7e72d9557c45a699f1f7b3
6b04abdfc5e0653542ac5d586e639185a8c61a39
diff --git a/GNUmakefile.in b/GNUmakefile.in
index 2352fc117
e72 Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Wed, 25 May 2022 21:53:22 -0500
Subject: [PATCH 01/19] cirrus/windows: add compiler_warnings_script
I'm not sure how to write this test in windows shell; it's also not easy to
write it in posix sh, since windows shell is somehow
On Fri, May 27, 2022 at 11:17:00AM +0530, Amit Kapila wrote:
> On Tue, May 24, 2022 at 11:03 AM houzj.f...@fujitsu.com
> wrote:
> >
> > On Friday, May 20, 2022 11:06 AM Amit Kapila
> > wrote:
> >
> > Thanks for pointing it out. Here is the new version patch which add this
> > version check.
>
On Tue, May 24, 2022 at 12:57:02AM -0400, Jeff Janes wrote:
> I have some belated feedback. I was excited to try this on Windows (I don't
> have a build system for that)
This is unrelated to beta1, but someone (Thomas Munro?) had the idea to allow
retrieving the windows binaries built by cirrus
On Fri, May 27, 2022 at 05:43:04AM +0900, Michael Paquier wrote:
> On Thu, May 26, 2022 at 04:36:47PM +0200, Peter Eisentraut wrote:
> > I chose TESTOUTDIR because it corresponds to the tmp_check directory, so
> > that the output files of the pg_upgrade run are removed when the test
> > artifacts
Maybe consider removing this workaround? The original problem report indicated
that it didn't affect later versions:
src/backend/optimizer/path/costsize.c: /* This apparently-useless variable
dodges a compiler bug in VS2013: */
I'm not sure if it's worth removing this one, though:
On Sun, May 22, 2022 at 06:26:06PM -0500, Justin Pryzby wrote:
> ccache 4.6.1 was released which allows compiling postgres
4.6.1 is now in choco. This is required to use with the current msbuild
process.
> But with the existing build system, it's no faster anyway, I guess due to poor
On Tue, May 24, 2022 at 09:48:17PM -0700, Andres Freund wrote:
> > And when I pass /Oy- to "avoid omitting" frame pointers, several tests
> > crash...
>
> Huh. Do you get a backtrace containing anything remotely meaningful?
They are interesting, but maybe not meaningful.
I tested a bunch of
On Thu, May 26, 2022 at 11:10:18AM +0900, Kyotaro Horiguchi wrote:
> Yeah, "boot_val" is appropreate here. And I noticed that pg_settings
> has the "unit" field. I'll try using them.
I wrote this in guc.sql, which seems promising, but it needs to be rewritten in
check_guc.pl to access
t;inheritance child" when it also
*does* apply to declarative partitioning.
>From 499fdd3ab35e6a152ae2cada934dfd7df48e7e10 Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Mon, 25 Apr 2022 14:59:12 -0500
Subject: [PATCH] doc: avoid saying "inheritence" when it applies to
pa
On Wed, May 25, 2022 at 01:08:12AM +, Shinoda, Noriyoshi (PN Japan FSIP)
wrote:
> Hi hackers,
> Thanks to all the developers. The attached patch updates the manual for the
> pg_stats_ext and pg_stats_ext_exprs view.
> The current pg_stats_ext/pg_stats_ext_exprs view manual are missing the
>
On Tue, May 24, 2022 at 01:30:39PM -0700, Andres Freund wrote:
> > As I recall, CC='ccache cl.exe' didn't work because it didn't attempt to do
> > any
> > argument splitting.
>
> I tried it, and it works for me when building with ninja (compiling with
> cl.exe). I assume you are using msbuild?
On Tue, May 24, 2022 at 12:30:59PM -0700, Andres Freund wrote:
> Hi,
>
> On 2022-05-22 18:26:06 -0500, Justin Pryzby wrote:
> > forking: <20220307191054.n5enrlf6kdn7z...@alap3.anarazel.de>
> >
> > An update.
> >
> > ccache 4.6.1 was released wh
forking: <20220307191054.n5enrlf6kdn7z...@alap3.anarazel.de>
An update.
ccache 4.6.1 was released which allows compiling postgres
I submitted a request to update the package in chocolatey.
But with the existing build system, it's no faster anyway, I guess due to poor
use of parallelism.
It looks like the docs weren't updated in 6f6b99d13 for v11.
The docs also seem to omit "FOR VALUES" literal.
And don't define partition_bound_spec (which I didn't fix here).
diff --git a/doc/src/sgml/ref/create_foreign_table.sgml
b/doc/src/sgml/ref/create_foreign_table.sgml
index
On Fri, Apr 22, 2022 at 11:37:29AM +0700, John Naylor wrote:
> On Fri, Apr 22, 2022 at 11:13 AM David Rowley wrote:
> >
> > On Thu, 21 Apr 2022 at 19:09, John Naylor
> > wrote:
> > > I intend to commit David's v2 fix next week, unless there are
> > > objections, or unless he beats me to it.
> >
./tmp_install/usr/local/pgsql/bin/postgres -D ./src/test/regress/tmp_check/data
-c min_dynamic_shared_memory=1MB
TRAP: FailedAssertion("val > base", File:
"../../../../src/include/utils/relptr.h", Line: 67, PID: 21912)
> + same level are considerd to be siblings,
considered
> +PostgreSQL specific functions detailed in
postgresql hyphen specific (as in the original)
These would all be easier to read with commas:
+expression is NULL an
+If WITH UNIQUE is specified the
+If the
On Thu, May 19, 2022 at 10:33:13AM +0530, Amit Kapila wrote:
> I have committed the first patch after fixing this part. It seems Tom
> is not very happy doing this after beta-1 [1]. The reason we get this
> information via this view (and underlying function) is that it
> simplifies the queries on
Thanks for copying me.
I didn't look closely yet, but this comment is wrong:
+ * Since these have no storage the tablespace can be updated with a simple
On Tue, May 17, 2022 at 02:54:28PM -0400, Robert Haas wrote:
> I don't particularly have anything against adding Zstandard
> compression here, but I wonder whether there's any rush. If we decide
> not to add this now, we can always change our minds and add it later,
> but if we decide to add it
On Wed, May 18, 2022 at 06:42:38PM +0200, Alvaro Herrera wrote:
> On 2022-May-11, Justin Pryzby wrote:
>
> > I suggest to reference the mvcc docs from the merge docs, or to make the
> > merge
> > docs themselves include the referenced information.
> >
>
On Wed, May 11, 2022 at 11:33:50AM -0500, Justin Pryzby wrote:
> I suggest to reference the mvcc docs from the merge docs, or to make the merge
> docs themselves include the referenced information.
No comments here ?
> Also, EXPLAIN output currently looks like this:
>
> | Merge
On Tue, May 17, 2022 at 07:52:30PM -0300, Ranier Vilela wrote:
> I found, I believe, a serious problem of incorrect usage of the memset api.
> Historically, people have relied on using memset or MemSet, using the
> variable name as an argument for the sizeof.
> While it works correctly, for
On Tue, May 17, 2022 at 08:58:14AM -0500, Jonathan S. Katz wrote:
> PostgreSQL 15 adds [more regular expression
> functions](https://www.postgresql.org/docs/15/functions-matching.html#FUNCTIONS-POSIX-REGEXP),
> including `regexp_count` , `regexp_instr`, `regexp_like`, and `regexp_substr`.
> the
On Mon, May 16, 2022 at 05:41:08PM +0200, Alvaro Herrera wrote:
> On 2022-May-10, Bruce Momjian wrote:
>
> > I have completed the first draft of the PG 15 release notes and you can
> > see the results here:
> >
> > https://momjian.us/pgsql_docs/release-15.html
>
> Just to be clear --
On Sat, May 14, 2022 at 02:52:35PM -0400, Jonathan S. Katz wrote:
> PostgreSQL 15 is made generally available, thouh some details of the release
> can
though
> a SQL standard command for conditionally perform write operations (`INSERT`,
performing
> he
On Fri, May 06, 2022 at 09:50:26PM +0530, Bharath Rupireddy wrote:
> It seems like that's not the case because postgres will not remove future WAL
> files even after max_wal_size is reduced,
In the past, I've had to generate synthetic write traffic and checkpoints to
get WAL to shrink. +1 to
On Fri, May 13, 2022 at 06:16:23PM +0800, Japin Li wrote:
> I had an incident on my Postgres 14 that queries hung in wait event
> IPC / MessageQueueInternal, MessageQueueReceive. It likes [1],
> however, it doesn't have any discussions.
If the process is still running, or if the problem recurs,
On Wed, May 11, 2022 at 05:23:27PM +0200, Alvaro Herrera wrote:
> As I understand it, the point of using a ring is to throttle performance
> for bulk operations such as vacuum. I'm not sure why we would want to
> throttle either MERGE or INSERT; it seems to me that we should want them
> to go as
I suggest to reference the mvcc docs from the merge docs, or to make the merge
docs themselves include the referenced information.
diff --git a/doc/src/sgml/mvcc.sgml b/doc/src/sgml/mvcc.sgml
index 341fea524a1..4446e1c484e 100644
--- a/doc/src/sgml/mvcc.sgml
+++ b/doc/src/sgml/mvcc.sgml
@@ -425,7
Should it use it ?
It occured to me to ask when reading Bruce's release notes, which say:
| [MERGE] is similar to INSERT ... ON CONFLICT but more batch-oriented.
Currently, INSERT *never* uses bistate - even INSERT SELECT.
INSERTing 10k tuples will dirty 10k buffers - not limited to the size of
On Wed, May 11, 2022 at 12:39:41PM +1200, David Rowley wrote:
> I think the sort improvements done in v15 are worth a mention under
> General Performance. The commits for this were 91e9e89dc, 40af10b57
> and 697492434. I've been running a few benchmarks between v14 and v15
> over the past few
94a97cff Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Mon, 18 Apr 2022 10:13:09 -0500
Subject: [PATCH v2022051001 1/2] doc: ANDed and ORed
---
doc/src/sgml/indexam.sgml | 2 +-
doc/src/sgml/indices.sgml | 4 ++--
doc/src/sgml/logical-replication.sgml | 2 +-
3 file
| Remove incorrect duplicate partition tables in system view
pg_publication_tables (Hou Zhijie)
should say "partitions" ?
"Do not show partitions whose parents are also published" (is that accurate?)
| Allow system and TOAST B-tree indexes to efficiently store duplicates (Peter
Geoghegan)
|
On Tue, May 10, 2022 at 04:18:10PM -0400, Bruce Momjian wrote:
> > | Add the LZ4 compression method to pg_receivewal (Georgios Kokolatos)
> > | This is enabled via --compression-method=lz4 and requires binaries to be
> > built using --with-lz4.
> > | Redesign pg_receivewal's compression options
parents. This changes to also collect stats for the "SELECT
> > FROM tbl*" case. See also: 20220204214103.gt23...@telsasoft.com.
>
> Agreed, reworded. Can you check you like my new wording?
Now it says:
| Allow extended statistics to record statistics for a parent with a
lt has always been to treat NULL indexed values as
distinct, but this can now be changed by creating constraints and indexes using
UNIQUE NULLS NOT DISTINCT.
should not say default, since it wasn't previously configurable.
"The previous behavior was ..."
| Have extended statistics track stat
On Tue, May 03, 2022 at 02:13:18PM +1200, David Rowley wrote:
> I'm wishing I put the initial hash table size and the final hash table
> size in EXPLAIN + EXPLAIN ANALYZE now. Perhaps it's not too late for
> v15 to do that so that it might help us figure things out in the
> future.
On Fri, May
On Mon, May 09, 2022 at 11:37:35AM -0400, Jonathan S. Katz wrote:
> @@ -473,27 +473,25 @@ OPTIONS (ADD password_required 'false');
> parallel_commit (boolean)
>
>
> - This option controls whether postgres_fdw commits
> - remote (sub)transactions opened on a foreign
Restarting a large instance took twice as long as I expected due to not
checking interrupts in (at least) statext_ndistinct_build. Long enough that I
attached (and was able to attach) a debugger to verify, which I think is too
long. I think it could cause issues for an high-availability cluster
On Sun, May 08, 2022 at 08:44:51PM +, David Fetter wrote:
> CREATE TABLE postgres_log
> (
> - log_time timestamp(3) with time zone,
> + log_time timestamp(6) with time zone,
Please also update the corresponding thing in doc/src/sgml/file-fdw.sgml
It looks like the patch I suggested to
On Wed, May 04, 2022 at 08:32:51AM -0700, David G. Johnston wrote:
> Hey,
>
> Is there a thread I'm not finding where the upcoming JSON function
> documentation is being made reasonably usable after doubling its size with
> all the new JSON Table features that we've added? If nothing else, the
>
On Sun, May 01, 2022 at 10:23:18PM +0900, Michael Paquier wrote:
> On Sun, May 01, 2022 at 01:07:06AM -0700, Noah Misch wrote:
> > My annual audit for executables missing Windows icons turned up these:
> >
> > pginstall/bin/testclient.exe
> > pginstall/bin/uri-regress.exe
> >
> >
st for those three defines.
What about adding RELCACHE_FORCE_RELEASE, too ?
Even with that, macos is only ~1min slower.
https://cirrus-ci.com/task/5456727205216256
commit 53480b8db63b5cd2476142e28ed3f9fe8480f9f3
Author: Justin Pryzby
Date: Thu Apr 14 06:27:07 2022 -0500
cirr
On Wed, Apr 20, 2022 at 11:32:08PM +0200, Alvaro Herrera wrote:
> On 2022-Apr-19, Alvaro Herrera wrote:
>
> > I propose we standardize on Zstd everywhere.
> > Users can look it up if they're really interested.
>
> So the attached.
>
> There are other uses of zstd, but those are referring to
>
On Wed, Apr 20, 2022 at 10:38:46AM -0700, Nathan Bossart wrote:
> > +void
> > +check_objfilter(VacObjectFilter curr_objfilter, VacObjectFilter
> > curr_option)
> > +{
> > + switch (curr_option)
> > + {
> > + case OBJFILTER_NONE:
> > + break;
> > + case
On Tue, Apr 19, 2022 at 10:00:01AM -0400, Robert Haas wrote:
> (A) This is a new feature. Wait for v16.
> (B) This is a bug fix. Commit it now and back-patch to v14.
> (C) This is a cleanup that is OK to put into v15 even after feature
> freeze but since it is a behavior change we shouldn't
On Tue, Apr 19, 2022 at 02:39:12PM +0200, Mats Taraldsvik wrote:
> I'm re-trying this email here, as there were no answers in the psql-general
> list. Hope that's ok. (please cc me when answering as I'm not subscribed
> (yet) )
-hackers is for development and bug reports, so this isn't the right
of any interest, I had done this differently a while back.
This probably doesn't apply except on top of some other patches, but you get
the idea.
commit 923f8a1c2cbea35cb01d1599caa2a81e3186181c
Author: Justin Pryzby
Date: Mon Feb 28 01:31:10 2022 -0600
f!
ci-os-only: windows
diff
On Fri, Apr 15, 2022 at 05:16:44PM +0800, Richard Guo wrote:
> Not related to this topic but I noticed another problem from the plan.
> Note the first Sort node which is to unique-ify the result of the UNION.
> Why cannot we re-arrange the sort keys from (a, b, c) to (a, c, b) so
> that we can
On Thu, Apr 14, 2022 at 09:39:42AM +1200, David Rowley wrote:
> On Thu, 14 Apr 2022 at 05:40, Justin Pryzby wrote:
> > There's (only) a few remaining.
>
> I've pushed 0001 and 0002 of the 3rd batch of patches. I left 0003 as
Thanks
> I just didn't feel it was a meaningful
On Wed, Mar 30, 2022 at 05:58:24PM +0900, Kyotaro Horiguchi wrote:
> I'm not still confident on this, but it should be better than the v1.
+Andres as this seems to be related to 277692220.
I added it as an Opened Item.
s match what I pushed.
There were no changes - I had resent the patches that removed blank lines so it
was apparent that they were "outstanding" / under discussion.
There's (only) a few remaining.
>From 543b9d77763da814cf1a99938252eb16a0a7d131 Mon Sep 17 00:00:00 2001
From: Justin P
On Thu, Sep 30, 2021 at 12:49:36PM +0900, Michael Paquier wrote:
> On Wed, Sep 29, 2021 at 07:43:41PM -0500, Justin Pryzby wrote:
> > Forking this thread in which Thomas implemented syncfs for the startup
> > process
> > (61752afb2).
> > https://www.postgresql.or
On Wed, Apr 13, 2022 at 03:50:15PM +0900, Michael Paquier wrote:
>
> > That dates to a556549d7 (see also cbe24a6dd8 for an earlier commit in
> > CLUSTER
> > itself). The reason was to avoid blocking if an unprivileged user runs
> > VACUUM
> > FULL which would try to lock things (including
On Mon, Apr 11, 2022 at 11:54:11AM -0400, Andrew Dunstan wrote:
> >> BTW, the documentation references look a little like OIDs...
> >> Does someone already have an SNMP-based doc browser ?
> >> | For details, see Section 9.16.3.4.2.
> >
> > I already had a couple of these items on my list but I
oned table wasn't supported before, nothing weird
will happen to someone who upgrades to v15 unless they elect to use the new
feature. As this seems to be POLA, it doesn't even need to be documented. ?
>From 19c02209dfbcbf73494e1e6d3ca0db50f64dc5fd Mon Sep 17 00:00:00 2001
From: Justin Pryzby
D
On Tue, Apr 05, 2022 at 05:14:09PM -0400, Greg Stark wrote:
> This is not passing regression tests due to some details of the plan
> output - marking Waiting on Author:
It's unstable due to parallel workers.
I'm not sure what the usual workarounds here.
Maybe set parallel_leader_participation=no
: Add ALTER
SUBSCRIPTION ... SKIP).
>From 98778834b8c762a6cd76d8680191a7c866397d8b Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Wed, 16 Feb 2022 21:07:53 -0600
Subject: [PATCH 01/13] doc: Remove 'synchronized' from --no-sync
Since it would be more accurate to say "unsynch
On Sun, Apr 10, 2022 at 07:43:48PM +0900, Etsuro Fujita wrote:
> On Sat, Apr 9, 2022 at 1:58 AM Etsuro Fujita wrote:
> > On Fri, Apr 8, 2022 at 9:43 PM Justin Pryzby wrote:
> > > This patch seems to be causing the planner to crash.
> > > Here's a
In docs and comments. Mostly for v15.
Maybe Fabien will want to comment on the pgbench one.
>From b1fb6d9bae1b0d69a30d59e65ed4f5a10f4141da Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Tue, 25 Jan 2022 10:47:55 -0600
Subject: [PATCH 01/19] doc: database SYSTEM si
On Sun, Apr 10, 2022 at 08:30:39PM +0200, Pavel Stehule wrote:
> I am sending fresh rebased patch + separation to more patches. This split
> is initial, and can be changed later
The 0001 patch requires this, but it's not included until 0003.
src/include/commands/session_variable.h
Each patch
I mentioned most/all of these ideas for cfbot at some point. I'm writing them
now so other people know about them and they're in once place.
- Keep the original patch series and commit messages, rather than squishing
them into a single commit with cfbot's own commit messages. Maybe append an
On Fri, Apr 08, 2022 at 12:55:04PM +, webmas...@postgresql.org wrote:
> The following patches that you follow, directly or indirectly,
> have received updates in the PostgreSQL commitfest app:
>
>
> Function to log backtrace of postgres processes
> https://commitfest.postgresql.org/38/2863/
On Fri, Apr 08, 2022 at 09:00:36PM -0400, Robert Haas wrote:
> > I think there might be another problem. The man page for rename() seems to
> > indicate that overwriting an existing file also introduces a window where
> > the old and new path are hard links to the same file. This isn't a problem
On Thu, Apr 07, 2022 at 10:10:21AM -0700, Andres Freund wrote:
> Hi,
>
> On 2022-04-06 11:03:37 -0400, Andrew Dunstan wrote:
> > On 3/30/22 20:26, Andres Freund wrote:
> > > Could you try using dash to invoke configure here, and whether it makes
> > > configure faster?
> > I got weird failures
On Wed, Apr 06, 2022 at 03:58:29PM +0900, Etsuro Fujita wrote:
> I have committed the patch after modifying it as such. (I think we
> can improve these later, if necessary.)
This patch seems to be causing the planner to crash.
Here's a query reduced from sqlsmith.
| explain SELECT 1 FROM
On Thu, Mar 31, 2022 at 04:25:58PM -0400, Andrew Dunstan wrote:
> No code chunks left, only a documentation patch which should land
Documentation review for a6baa4bad.
> Construct a JSON the provided strings:
a JSON what ?
*from* the provided strings ?
> Construct a JSON from the provided
On Thu, Apr 07, 2022 at 10:26:18PM -0400, Robert Haas wrote:
> + pg_log_error("improper relation name (too many dotted names):
> %s", pattern);
>
> Come to think of it, maybe the error text there could stand some
> bikeshedding, but AFAICS
AFAICT the error text deliberately
On Wed, Apr 06, 2022 at 07:43:42PM +0200, Gilles Darold wrote:
> Thanks for the review, all these changes are available in new version v6
> of the patch and attached here.
This is failing in CI (except on macos, which is strangely passing).
http://cfbot.cputube.org/gilles-darold.html
I noticed some typos.
diff --git a/src/backend/utils/adt/jsonb_selfuncs.c
b/src/backend/utils/adt/jsonb_selfuncs.c
index f5520f88a1d..d98cd7020a1 100644
--- a/src/backend/utils/adt/jsonb_selfuncs.c
+++ b/src/backend/utils/adt/jsonb_selfuncs.c
@@ -1342,7 +1342,7 @@
Some typos I found before the patch was reverted.
diff --git a/doc/src/sgml/logicaldecoding.sgml
b/doc/src/sgml/logicaldecoding.sgml
index a6ea6ff3fcf..d4bd8d41c4b 100644
--- a/doc/src/sgml/logicaldecoding.sgml
+++ b/doc/src/sgml/logicaldecoding.sgml
@@ -834,9 +834,8 @@ typedef void
On Wed, Apr 06, 2022 at 11:02:54PM -0400, Tom Lane wrote:
> "Jonathan S. Katz" writes:
> > +1 for \dconf
>
> Here's a draft patch using \dconf. No tests or docs yet.
The patch as written is a thin layer around pg_settings.
SHOW and current_setting() translate to human units, which is
a similar issue last year.
On Thu, Apr 08, 2021 at 10:37:04PM -0500, Justin Pryzby wrote:
> --- a/doc/src/sgml/wal.sgml
> +++ b/doc/src/sgml/wal.sgml
> @@ -816,9 +816,7 @@
> prefetching mechanism is most likely to be effective on systems
> with full_page_writes set t
On Thu, Apr 07, 2022 at 01:37:57PM +0200, Frédéric Yhuel wrote:
> Maybe something along this line? (patch attached)
Some language fixes.
I didn't verify the behavior, but +1 to document the practical consequences.
I guess this is why someone invented REINDEX CONCURRENTLY.
> From
On Wed, Apr 06, 2022 at 12:27:34PM -0700, Andres Freund wrote:
> > > + next use of statistical information will cause a new snapshot to be
> > > built
> > > + or accessed statistics to be cached.
> >
> > I believe this should be an "and", not an "or". (next access builds both a
> > new
ture patch adding wrappers for smgrwrite(), smgrextend(), and
smgrimmedsync() would provide a good location to call pgstat_inc_ioop()
for unbuffered IO and avoid regressions for future users of these
functions.
Author: Melanie Plageman
Reviewed-by: Justin Pryzby
Discussion: https://www.postgre
On Sat, Apr 02, 2022 at 07:11:47PM +0200, Alvaro Herrera wrote:
> Thanks, pushed.
Thank you for revisiting it, and thanks to Zhihong Yu for earlier review.
I'll look into your outstanding questions later this week.
--
Justin
On Sat, Apr 02, 2022 at 06:41:30PM +0700, John Naylor wrote:
> On Sat, Apr 2, 2022 at 5:27 PM Thomas Munro wrote:
> > Reproduced locally, using the same few lines from the cluster.sql
> > test. I'll try to dig more tomorrow...
>
> Thanks! Unfortunately I can't reproduce locally with clang
convinced that the latest changes have affected the patch in a positive
> way. I'll be pleased to hear your thoughts on this.
>From 0dec500a0ed934d5d2038cb087ba6a605cafcdef Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Thu, 15 Apr 2021 11:55:09 -0500
Subject: [PATCH 1/2] explain.c: refactor
701 - 800 of 2601 matches
Mail list logo
