Tab completion for GRANT MAINTAIN

2023-04-18 Thread Ken Kato
Hi hackers, I found that GRANT MAINTAIN is not tab-completed with ON, so here is a patch. Best wishes, -- Ken Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATIONdiff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c index

Re: Add last_vacuum_index_scans in pg_stat_all_tables

2022-10-03 Thread Ken Kato
The problem is that you're not closing the Thank you for the reviews and comments. I closed the so that the problem should be fixed now. Regards, -- Ken Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATIONdiff --git a/doc/src

Re: Add last_vacuum_index_scans in pg_stat_all_tables

2022-09-15 Thread Ken Kato
Regression is failing on all platforms; please correct that and resubmit the patch. Hi, Thank you for the review! I fixed it and resubmitting the patch. Regards, -- Ken Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATIONdiff --git a/doc/src

Re: pg_stat_wal: tracking the compression effect

2022-08-29 Thread Ken Kato
On 2022-08-27 16:48, Bharath Rupireddy wrote: On Fri, Aug 26, 2022 at 8:39 AM Kyotaro Horiguchi wrote: At Fri, 26 Aug 2022 11:55:27 +0900 (JST), Kyotaro Horiguchi wrote in > At Thu, 25 Aug 2022 16:04:50 +0900, Ken Kato wrote in > > Accumulating the values, which indicates how m

pg_stat_wal: tracking the compression effect

2022-08-25 Thread Ken Kato
space is saved by each compression (size before compression - size after compression), and keep track of how many times compression has happened. So that one can know how much space is saved on average. What do you think? Regards, -- Ken Kato Advanced Computing Technology Center Research and

Re: Add last_vacuum_index_scans in pg_stat_all_tables

2022-07-15 Thread Ken Kato
/autovacuum. Regards, -- Ken Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION

Add last_vacuum_index_scans in pg_stat_all_tables

2022-07-04 Thread Ken Kato
limitation of stats collector. Statistics are now stored in shared memory, so we got more rooms to store statistics. I think this statistics is still valuable for some people, so I am proposing this again. Best wishes, -- Ken Kato Advanced Computing Technology Center Research and Development

Re: [PATCH] Add min() and max() aggregate functions for xid8

2022-02-08 Thread Ken Kato
value in the test. Therefore, I think min_max_aggregates_for_xid8_v4.patch is the best one to go. Best wishes, -- Ken Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION

Re: [PATCH] Add min() and max() aggregate functions for xid8

2022-02-08 Thread Ken Kato
e how strict coding conventions are, but the following line is over 80 characters. +insert into xid8_t1 values ('0'), ('010'), ('42'), ('0x'), ('-1'); Therefore, I made a patch which removed ('010') just to fit in 80 chara

Re: [PATCH] Add min() and max() aggregate functions for xid8

2022-02-07 Thread Ken Kato
xid8, '42'::xid8, and '-1'::xid8 in addition to '0'::xid8 and '0x'::xid8 just to have more varieties. Best wishes, -- Ken Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATIONdiff --git a/doc/src

Re: [PATCH] Add min() and max() aggregate functions for xid8

2022-02-04 Thread Ken Kato
mistake. This is the updated one. Best wishes -- Ken Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATIONdiff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml index 8754f2f89b..1b064b4feb 100644 --- a/doc/src/sgml/func.sgml +++ b/doc/sr

[PATCH] Add min() and max() aggregate functions for xid8

2022-02-02 Thread Ken Kato
Hi hackers, Unlike xid, xid8 increases monotonically and cannot be reused. This trait makes it possible to support min() and max() aggregate functions for xid8. I thought they would be useful for monitoring. So I made a patch for this. Best wishes, -- Ken Kato Advanced Computing Technology

[PATCH] DROP tab completion

2021-11-29 Thread Ken Kato
. Best wishes, -- Ken Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATIONdiff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c index 630026da2f..2f412ca3db 100644 --- a/src/bin/psql/tab-complete.c +++ b/src/bin/psql/tab-complete.c

Re: [PATCH] ALTER tab completion

2021-11-26 Thread Ken Kato
chi-san, that should be COMPLETE_WITH_CS() to keep these completions in lower case. That's what it's for. I used COMPLETE_WITH_CS instead of COMPLETE_WITH. Best wishes, -- Ken Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATIONdiff --git

[PATCH] ALTER tab completion

2021-11-25 Thread Ken Kato
TRANSFORM: no doc for ALTER TRANSFORM, so I excluded TRANSFORM from ALTER tab completion I made a patch for this, so please have a look. Best wishes, -- Ken Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATIONdiff --git a/src/bin/psql/tab

Re: CREATE tab completion

2021-11-18 Thread Ken Kato
the status to"committed" in Commitfest 2022-01. https://commitfest.postgresql.org/36/3418/ Best wishes, -- Ken Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION

Re: CREATE tab completion

2021-11-17 Thread Ken Kato
f them. For this part, I did the following: + else if (TailMatches("CREATE", "SEQUENCE", MatchAny, "AS") || + TailMatches("CREATE", "TEMP|TEMPORARY", "SEQUENCE", MatchAny, "AS")) + COMPLETE_WITH(&q

CREATE tab completion

2021-11-16 Thread Ken Kato
AS -CREATE TRANSFORM : missing after FOR I made a patch for this, so please have a look. Best wishes, -- Ken Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATIONdiff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c index 4f724e4428

[PATCH] pg_stat_statements Configuration Parameters Documentation

2021-11-07 Thread Ken Kato
Hi, Configuration parameters for pg_stat_statements were not in the index, so I added them just like auto_explain configuration parameters. Best wishes, -- Ken Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATIONdiff --git a/doc/src/sgml

Re: [PATCH] Added TRANSFORM FOR for COMMENT tab completion

2021-11-04 Thread Ken Kato
Hi, I found unnecessary line deletion in my previous patch, so I made a minor update for that. -- Best wishes, Ken Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATIONdiff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c index

Re: [PATCH] Added TRANSFORM FOR for COMMENT tab completion

2021-11-04 Thread Ken Kato
aQuery Query_for_list_of_text_search_configurations = { We already have Query_for_list_of_ts_configurations in tab-complete.c. Do we really need both queries? Or we can drop either of them? Thank you for pointing out! I didn't notice that there already exists Query_for_list_of_ts_conf

Re: [PATCH] Added TRANSFORM FOR for COMMENT tab completion

2021-10-15 Thread Ken Kato
th CLASS and FAMILY. Also, I updated TEXT SEARCH. It completes object names for each one of CONFIGURATION, DICTIONARY, PARSER, and TEMPLATE. -- Best wishes, Ken Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATIONdiff --git a/src/bin/psql/tab-comple