On Tue, Aug 16, 2022 at 2:32 PM Masahiko Sawada wrote:
>
> On Tue, Aug 16, 2022 at 2:31 PM Amit Kapila wrote:
> >
> > On Tue, Aug 16, 2022 at 10:56 AM Masahiko Sawada
> > wrote:
> > >
> > > On Tue, Aug 16, 2022 at 2:08 PM Amit Kapila
> > >
On Tue, Aug 16, 2022 at 2:31 PM Amit Kapila wrote:
>
> On Tue, Aug 16, 2022 at 10:56 AM Masahiko Sawada
> wrote:
> >
> > On Tue, Aug 16, 2022 at 2:08 PM Amit Kapila wrote:
> > >
> > > On Tue, Aug 16, 2022 at 9:28 AM Andrey Borodin
> > > wrote:
e backpatched.
Regards,
[1]
https://www.postgresql.org/message-id/CAD21AoD%2BaNfLje%2B9JOqWbTiq1GL4BOp9_f7FxLADm8rS8cDhCQ%40mail.gmail.com
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
On Fri, Jul 22, 2022 at 10:43 AM Masahiko Sawada wrote:
>
> On Tue, Jul 19, 2022 at 1:30 PM John Naylor
> wrote:
> >
> >
> >
> > On Tue, Jul 19, 2022 at 9:11 AM Masahiko Sawada
> > wrote:
> >
> > > I’d like to keep the first version simp
Sorry for the late reply.
On Thu, Jul 28, 2022 at 4:29 PM Kyotaro Horiguchi
wrote:
>
> At Thu, 28 Jul 2022 15:53:33 +0900, Masahiko Sawada
> wrote in
> > >
> > Do you mean that both could be true at the same time? If I read
> > GetRunningTransactionData() correctl
ttached is a patch addressing this. This was added in 14, so we should
> backpatch to that version.
+1
The patch looks good to me.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
On Thu, Aug 11, 2022 at 3:10 PM Amit Kapila wrote:
>
> On Mon, Aug 8, 2022 at 9:34 AM Amit Kapila wrote:
> >
> > On Wed, Aug 3, 2022 at 1:20 PM Masahiko Sawada
> > wrote:
> > >
> > >
> > > Oops, thanks for pointing it out. I've fixed it a
expensive.
I think that for non-USE_SSE2 builds, there is no additional overhead
as all assertion-related code in pg_lfind32 depends on USE_SSE2.
> I'll look around to see if there are any
> other suitable candidates.
As you proposed, having a test module for that seems to be a good
ide
On Tue, Aug 9, 2022 at 11:24 AM John Naylor
wrote:
>
> On Tue, Aug 9, 2022 at 8:58 AM Masahiko Sawada wrote:
> > I found that there are two .c and .h files whose identification in the
> > header comment doesn't match its actual path.
>
> > The attached small patc
bout that. This is done in v9.
>
> > Aside from that, I plan to commit this
> > week unless there is further bikeshedding.
>
> Great, thanks.
The patch looks good to me. One minor point is:
+ * IDENTIFICATION
+ * src/port/pg_lfind.h
The path doesn't match to the actual file path, src/include/port/pg_lfind.h.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
src/fe_utils/cancel.c has:
* src/fe-utils/cancel.c
*
*
The attached small patch fixes them.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
v1-0001-Fix-unmatched-file-identifications.patch
Descri
ne'? I think that using origin =
'none' doesn't necessarily mean using bi-directional (or N-way)
replication. Even when using uni-directional logical replication with
two nodes, they may use origin = 'none'. Therefore, it seems to me
that this feature works only for a narrow situation and has false
positives.
Since it has been the user's responsibility not to try to make the
data inconsistent by the initial table sync, I think that it might be
sufficient if we note the risk in the documentation.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
re is a typo in the commit message:
s/hepler/helper/
The rest looks good to me.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
On Wed, Aug 3, 2022 at 1:51 PM Amit Kapila wrote:
>
> On Sat, Jul 30, 2022 at 12:25 PM Amit Kapila wrote:
> >
> > On Thu, Jul 28, 2022 at 6:37 AM Masahiko Sawada
> > wrote:
> > >
> > > On Wed, Jul 27, 2022 at 7:08 PM shiy.f...@fujitsu.com
> > >
On Tue, Aug 2, 2022 at 5:31 PM shiy.f...@fujitsu.com
wrote:
>
> On Mon, Aug 1, 2022 10:31 PM Amit Kapila wrote:
> >
> > On Mon, Aug 1, 2022 at 7:46 AM Masahiko Sawada
> > wrote:
> > >
> > > On Fri, Jul 29, 2022 at 3:45 PM Amit Kapila
> > wrote:
&
all CloseTransientFile()
before erroring out in SnapBuildSerialize(). I think it's better to
keep it consistent with nearby codes in this patch. I think if we
prefer the style of closing the file by ereport(ERROR), it should be
done for all of them in a separate patch.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
On Thu, Jul 28, 2022 at 8:57 PM Amit Kapila wrote:
>
> On Thu, Jul 28, 2022 at 3:23 PM Amit Kapila wrote:
> >
> > On Tue, Jul 26, 2022 at 1:22 PM Masahiko Sawada
> > wrote:
> > >
> > > Okay, I've attached an updated patch that does the above
On Thu, Jul 28, 2022 at 4:13 PM Amit Kapila wrote:
>
> On Thu, Jul 28, 2022 at 11:56 AM Masahiko Sawada
> wrote:
> >
> > On Thu, Jul 28, 2022 at 12:21 PM Amit Kapila
> > wrote:
> > >
> > > On Thu, Jul 28, 2022 at 7:18 AM Masahiko Sawada
> >
gInfoString(buf, "; subxid overflowed");
>
Do you mean that both could be true at the same time? If I read
GetRunningTransactionData() correctly, that doesn't happen.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
() an
On Thu, Jul 28, 2022 at 12:21 PM Amit Kapila wrote:
>
> On Thu, Jul 28, 2022 at 7:18 AM Masahiko Sawada wrote:
> >
> > On Wed, Jul 27, 2022 at 8:33 PM Amit Kapila wrote:
> > >
> >
> > > I have changed accordingly in the attached
> > >
On Thu, Jul 21, 2022 at 10:13 PM Ashutosh Bapat
wrote:
>
> Hi
>
> On Thu, Jul 21, 2022 at 6:44 AM Masahiko Sawada wrote:
> >
> > Hi,
> >
> > I realized that standby_desc_running_xacts() in standbydesc.c doesn't
> > describe subtransacti
On Wed, Jul 27, 2022 at 8:33 PM Amit Kapila wrote:
>
> On Mon, Jul 25, 2022 at 11:26 AM Masahiko Sawada
> wrote:
> >
> > On Mon, Jul 25, 2022 at 10:45 AM Masahiko Sawada
> > wrote:
> >
> > I've attached the patch for REl15 that I forgot.
> &
On Wed, Jul 27, 2022 at 8:54 PM Amit Kapila wrote:
>
> On Tue, Jul 26, 2022 at 1:12 PM Masahiko Sawada wrote:
> >
> > On Tue, Jul 26, 2022 at 2:01 PM Amit Kapila wrote:
> > >
> > > 2.
> > > +# wait for the replication to catchup i
On Wed, Jul 27, 2022 at 7:08 PM shiy.f...@fujitsu.com
wrote:
>
> On Tue, Jul 26, 2022 3:42 PM Masahiko Sawada wrote:
> >
> > I've attached an updated patch as well as a patch to remove duplicated
> > waits in 007_ddl.pl.
> >
>
> Thanks for your patch. H
On Tue, Jul 26, 2022 at 2:18 PM Amit Kapila wrote:
>
> On Tue, Jul 26, 2022 at 7:00 AM Masahiko Sawada wrote:
> >
> > On Mon, Jul 25, 2022 at 7:57 PM shiy.f...@fujitsu.com
> > wrote:
> > >
> > > Hi,
> > >
> > > I did some performanc
On Tue, Jul 26, 2022 at 2:01 PM Amit Kapila wrote:
>
> On Tue, Jul 26, 2022 at 7:07 AM Masahiko Sawada wrote:
> >
> > Hi,
> >
> > In tap tests for logical replication, we have the following code in many
> > places:
> >
> > $node_publisher-&g
wait for all subscriptions to
synchronize data. The attached patch introduce a new function
wait_for_subscription_sync(). With this function, we can replace the
above code with this one function as follows:
$node_subscriber->wait_for_subscription_sync($node_publisher, 'tap_sub');
Regard
and then return from that function
before doing bearch() if the parsed->xinfo doesn't have
XACT_XINFO_HAS_INVALS. That would save calling bsearch() for
non-catalog-modifying transactions. Is it worth trying?
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
On Mon, Jul 25, 2022 at 10:45 AM Masahiko Sawada wrote:
>
> On Sat, Jul 23, 2022 at 8:32 PM Amit Kapila wrote:
> >
> > On Fri, Jul 22, 2022 at 11:48 AM Masahiko Sawada
> > wrote:
> > >
> > > On Wed, Jul 20, 2022 at 5:50 PM Amit Kapila
> > >
On Wed, Jul 20, 2022 at 5:50 PM Amit Kapila wrote:
>
> On Wed, Jul 20, 2022 at 1:28 PM Masahiko Sawada wrote:
> >
> > On Wed, Jul 20, 2022 at 2:19 PM Amit Kapila wrote:
> > >
> > > On Wed, Jul 20, 2022 at 9:01 AM Masahiko Sawada
> > > wrote
x27;slot_creation_error'
-
-slot_name|slot_type|active
--+-+--
-(0 rows)
-
Regards,
[1]
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=fairywren&dt=2022-04-11%2021%3A04%3A15&stg=test-decoding-check
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
On Tue, Jul 19, 2022 at 1:30 PM John Naylor
wrote:
>
>
>
> On Tue, Jul 19, 2022 at 9:11 AM Masahiko Sawada wrote:
>
> > I’d like to keep the first version simple. We can improve it and add
> > more optimizations later. Using radix tree for vacuum TID storage
&
On Thu, Jul 21, 2022 at 4:29 PM Kyotaro Horiguchi
wrote:
>
> At Thu, 21 Jul 2022 11:21:09 +0900, Fujii Masao
> wrote in
> >
> >
> > On 2022/07/21 10:13, Masahiko Sawada wrote:
> > > Hi,
> > > I realized that standby_desc_running_xacts() in standb
s: 1048; 1
subxacts: 1049
Please review it.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
0001-Improve-description-of-XLOG_RUNNING_XACTS.patch
Description: Binary data
On Wed, Jul 20, 2022 at 2:19 PM Amit Kapila wrote:
>
> On Wed, Jul 20, 2022 at 9:01 AM Masahiko Sawada wrote:
> >
> > On Wed, Jul 20, 2022 at 12:11 PM Amit Kapila
> > wrote:
> > >
> > > On Tue, Jul 19, 2022 at 7:28 PM Masahiko Sawada
> > >
On Wed, Jul 20, 2022 at 4:16 PM Kyotaro Horiguchi
wrote:
>
> At Wed, 20 Jul 2022 10:58:16 +0900, Masahiko Sawada
> wrote in
> > On Wed, Jul 20, 2022 at 9:58 AM Kyotaro Horiguchi
> > wrote:
> > > Mmm. the patch changed that behavior. AllocateSnapshotBuilder always
(buf + PG_AD_LEN, encr, encrlen);
317 *(int64 *) (buf + PG_AD_LEN + encrlen) =
pg_hton64(PG_AD_LEN * 8);
318
319 if (!EVP_DigestSignInit(evp_md_ctx, NULL, md, NULL, pkey))
(lldb) p encrlen
(int) $0 = -12
(lldb)
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
On Wed, Jul 20, 2022 at 12:11 PM Amit Kapila wrote:
>
> On Tue, Jul 19, 2022 at 7:28 PM Masahiko Sawada wrote:
> >
> > On Tue, Jul 19, 2022 at 9:25 PM Amit Kapila wrote:
> > >
> > > On Tue, Jul 19, 2022 at 1:10 PM Masahiko Sawada
> > > wrote:
>
On Wed, Jul 20, 2022 at 9:58 AM Kyotaro Horiguchi
wrote:
>
> At Tue, 19 Jul 2022 17:31:07 +0900, Masahiko Sawada
> wrote in
> > On Tue, Jul 19, 2022 at 4:35 PM Kyotaro Horiguchi
> > wrote:
> > > At Tue, 19 Jul 2022 10:17:15 +0530, Amit Kapila
> > &g
On Tue, Jul 19, 2022 at 9:25 PM Amit Kapila wrote:
>
> On Tue, Jul 19, 2022 at 1:10 PM Masahiko Sawada wrote:
> >
> > On Mon, Jul 18, 2022 at 8:49 PM Amit Kapila wrote:
> > >
> > > On Sun, Jul 17, 2022 at 6:29 PM Masahiko Sawada
> > > wrote:
&g
s) is not what should be checked here. The
> assert just requires that catchange_txns and catchange_ntxns are
> consistent so it should be checked just after dlist_empty.. I think.
>
If we want to check if catchange_txns and catchange_ntxns are
consistent, should we check (xcnt == rb->catchange_ntxns) as well, no?
This function requires the caller to use rb->catchange_ntxns as the
length of the returned array. I think this assertion ensures that the
actual length of the array is consistent with the length we
pre-calculated.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
On Tue, Jul 19, 2022 at 4:28 PM osumi.takami...@fujitsu.com
wrote:
>
> On Sunday, July 17, 2022 9:59 PM Masahiko Sawada
> wrote:
> > I've attached patches for all supported branches including the master.
> Hi,
>
>
> Minor comments for REL14.
>
> (1) Th
On Mon, Jul 18, 2022 at 8:49 PM Amit Kapila wrote:
>
> On Sun, Jul 17, 2022 at 6:29 PM Masahiko Sawada wrote:
> >
> > On Fri, Jul 15, 2022 at 3:32 PM shiy.f...@fujitsu.com
> > wrote:
> > >
> >
> > I've attached patches for all supported bran
On Tue, Jul 19, 2022 at 1:47 PM Amit Kapila wrote:
>
> On Tue, Jul 19, 2022 at 6:34 AM Masahiko Sawada wrote:
> >
> > On Mon, Jul 18, 2022 at 1:12 PM Amit Kapila wrote:
> > >
> > > On Fri, Jul 15, 2022 at 8:09 PM Masahiko Sawada
> > > wrote:
>
On Thu, Jul 14, 2022 at 1:17 PM John Naylor
wrote:
>
> On Tue, Jul 12, 2022 at 8:16 AM Masahiko Sawada wrote:
>
> > > > I think that at this stage it's better to define the design first. For
> > > > example, key size and value size, and these sizes are fi
On Mon, Jul 18, 2022 at 12:28 PM shiy.f...@fujitsu.com
wrote:
>
> On Fri, Jul 15, 2022 10:39 PM Masahiko Sawada wrote:
> >
> > This patch should have the fix for the issue that Shi yu reported. Shi
> > yu, could you please test it again with this patch?
> >
>
>
On Mon, Jul 18, 2022 at 1:12 PM Amit Kapila wrote:
>
> On Fri, Jul 15, 2022 at 8:09 PM Masahiko Sawada wrote:
> >
> > This patch should have the fix for the issue that Shi yu reported. Shi
> > yu, could you please test it again with this patch?
> >
>
> Can
On Fri, Jul 15, 2022 at 3:32 PM shiy.f...@fujitsu.com
wrote:
>
> On Mon, Jul 11, 2022 9:54 PM Masahiko Sawada wrote:
> >
> > I've attached an updated patch, please review it.
> >
>
> Thanks for your patch. Here are some comments for the REL14-v1 patch.
>
>
On Fri, Jul 15, 2022 at 10:43 PM osumi.takami...@fujitsu.com
wrote:
>
> On Thursday, July 14, 2022 10:31 AM Masahiko Sawada
> wrote:
> > I've attached an updated patch that incorporated comments from Amit and Shi.
> Hi,
>
>
> Minor comments for v4.
Thank you fo
On Thu, Jul 14, 2022 at 12:06 PM Masahiko Sawada wrote:
>
> On Thu, Jul 14, 2022 at 11:16 AM shiy.f...@fujitsu.com
> wrote:
> >
> > On Tue, Jul 12, 2022 5:23 PM Masahiko Sawada wrote:
> > >
> > > On Tue, Jul 12, 2022 at 5:58 PM shiy.f...@fujitsu.com
&g
On Thu, Jul 14, 2022 at 11:16 AM shiy.f...@fujitsu.com
wrote:
>
> On Tue, Jul 12, 2022 5:23 PM Masahiko Sawada wrote:
> >
> > On Tue, Jul 12, 2022 at 5:58 PM shiy.f...@fujitsu.com
> > wrote:
> > >
> > > It happened when executing the followin
On Tue, Jul 12, 2022 at 12:40 PM shiy.f...@fujitsu.com
wrote:
>
> On Tue, Jul 12, 2022 8:49 AM Masahiko Sawada wrote:
> >
> > I've attached an updated patch.
> >
> > While trying this idea, I noticed there is no API to get the length of
> > dlist, as we d
On Tue, Jul 12, 2022 at 5:52 PM Amit Kapila wrote:
>
> On Tue, Jul 12, 2022 at 1:13 PM Masahiko Sawada wrote:
> >
> > On Tue, Jul 12, 2022 at 3:25 PM Amit Kapila wrote:
> > >
> > > On Tue, Jul 12, 2022 at 11:38 AM Masahiko Sawada
> > > wrote:
>
On Tue, Jul 12, 2022 at 7:59 PM Amit Kapila wrote:
>
> On Tue, Jul 12, 2022 at 2:53 PM Masahiko Sawada wrote:
> >
> > On Tue, Jul 12, 2022 at 5:58 PM shiy.f...@fujitsu.com
> > wrote:
> > >
> > >
> > > It happened when executing the fo
On Tue, Jul 12, 2022 at 5:58 PM shiy.f...@fujitsu.com
wrote:
>
> On Tue, Jul 12, 2022 8:49 AM Masahiko Sawada wrote:
> >
> > I've attached an updated patch.
> >
>
> Hi,
>
> I met a segmentation fault in test_decoding test after applying the patch for
On Tue, Jul 12, 2022 at 3:25 PM Amit Kapila wrote:
>
> On Tue, Jul 12, 2022 at 11:38 AM Masahiko Sawada
> wrote:
> >
> > On Tue, Jul 12, 2022 at 10:28 AM Masahiko Sawada
> > wrote:
> > >
> > >
> > > I'm doing benchmark tests and will
On Tue, Jul 12, 2022 at 10:28 AM Masahiko Sawada wrote:
>
> On Tue, Jul 12, 2022 at 9:48 AM Masahiko Sawada wrote:
> >
> > On Fri, Jul 8, 2022 at 8:20 PM Masahiko Sawada
> > wrote:
> > >
> > > On Fri, Jul 8, 2022 at 5:59 PM Amit Kapila
> > &g
On Tue, Jul 12, 2022 at 9:48 AM Masahiko Sawada wrote:
>
> On Fri, Jul 8, 2022 at 8:20 PM Masahiko Sawada wrote:
> >
> > On Fri, Jul 8, 2022 at 5:59 PM Amit Kapila wrote:
> > >
> > > On Fri, Jul 8, 2022 at 12:46 PM Masahiko Sawada
> > > wrote:
&
On Fri, Jul 8, 2022 at 3:43 PM John Naylor wrote:
>
> On Fri, Jul 8, 2022 at 9:10 AM Masahiko Sawada wrote:
>
> > I guess that the tree height is affected by where garbages are, right?
> > For example, even if all garbage in the table is concentrated in
> > 0.5GB, if
On Fri, Jul 8, 2022 at 8:20 PM Masahiko Sawada wrote:
>
> On Fri, Jul 8, 2022 at 5:59 PM Amit Kapila wrote:
> >
> > On Fri, Jul 8, 2022 at 12:46 PM Masahiko Sawada
> > wrote:
> > >
> > > On Fri, Jul 8, 2022 at 3:27 PM Amit Kapila
> &
On Wed, Jul 6, 2022 at 3:01 PM Amit Kapila wrote:
>
> On Wed, Jul 6, 2022 at 7:38 AM Masahiko Sawada wrote:
> >
> > I'll post a new version patch in the next email with replying to other
> > comments.
> >
>
> Okay, thanks for wor
On Fri, Jul 8, 2022 at 5:59 PM Amit Kapila wrote:
>
> On Fri, Jul 8, 2022 at 12:46 PM Masahiko Sawada wrote:
> >
> > On Fri, Jul 8, 2022 at 3:27 PM Amit Kapila wrote:
> > >
> >
> > > 1.
> > > In ReorderBufferGetCatalogChangesXacts
On Fri, Jul 8, 2022 at 3:27 PM Amit Kapila wrote:
>
> On Fri, Jul 8, 2022 at 6:45 AM Masahiko Sawada wrote:
> >
> > On Thu, Jul 7, 2022 at 3:40 PM Amit Kapila wrote:
> > >
> > > On Thu, Jul 7, 2022 at 8:21 AM Masahiko Sawada
> > > wrote:
>
On Tue, Jul 5, 2022 at 5:49 PM John Naylor wrote:
>
> On Mon, Jul 4, 2022 at 12:07 PM Masahiko Sawada wrote:
>
> > > Looking at the node stats, and then your benchmark code, I think key
> > > construction is a major influence, maybe more than node type. The
> &
On Thu, Jul 7, 2022 at 3:40 PM Amit Kapila wrote:
>
> On Thu, Jul 7, 2022 at 8:21 AM Masahiko Sawada wrote:
> >
> > On Wed, Jul 6, 2022 at 5:55 PM Amit Kapila wrote:
> > >
> > > On Wed, Jul 6, 2022 at 12:19 PM Masahiko Sawada
> > > wrote:
> &
On Wed, Jul 6, 2022 at 5:55 PM Amit Kapila wrote:
>
> On Wed, Jul 6, 2022 at 12:19 PM Masahiko Sawada wrote:
> >
> > On Tue, Jul 5, 2022 at 8:00 PM Amit Kapila wrote:
> > >
> > > 2. Are we anytime removing transaction ids from catchanges->xip array?
&
On Thu, Jul 7, 2022 at 1:28 AM Andres Freund wrote:
>
> On 2022-07-05 14:52:45 -0700, Andres Freund wrote:
> > On 2022-07-04 11:01:01 +0900, Masahiko Sawada wrote:
> > > I've attached the patch, fix_drop_subscriptions_stats.patch, to fix it.
> >
> > LGTM. Unl
On Thu, Jul 7, 2022 at 12:53 AM Andres Freund wrote:
>
> Hi,
>
> On 2022-07-06 11:41:46 +0900, Masahiko Sawada wrote:
> > diff --git a/src/test/regress/sql/subscription.sql
> > b/src/test/regress/sql/subscription.sql
> > index 74c38ead5d..6a46956f6e 100644
On Tue, Jul 5, 2022 at 5:09 PM Andres Freund wrote:
>
> Hi,
>
> On 2022-07-05 16:33:17 +0900, Masahiko Sawada wrote:
> > On Tue, Jul 5, 2022 at 6:18 AM Andres Freund wrote:
> > A datum value is convenient to represent both a pointer and a value so
> > I used it to
On Tue, Jul 5, 2022 at 8:00 PM Amit Kapila wrote:
>
> On Mon, Jul 4, 2022 at 6:12 PM Amit Kapila wrote:
> >
> > On Mon, May 30, 2022 at 11:13 AM Masahiko Sawada
> > wrote:
> > >
> > > I've attached three POC patches:
> > >
> >
&g
On Wed, Jul 6, 2022 at 10:48 AM Andres Freund wrote:
>
> On 2022-07-06 10:25:02 +0900, Masahiko Sawada wrote:
> > > I think most of this could just be pgstat_reset_entry().
> >
> > I think pgstat_reset_entry() doesn't work for this case as it skips
> > r
On Mon, Jul 4, 2022 at 9:42 PM Amit Kapila wrote:
>
> On Mon, May 30, 2022 at 11:13 AM Masahiko Sawada
> wrote:
> >
> > I've attached three POC patches:
> >
>
> I think it will be a good idea if you can add a short commit message
> at least to say which
On Wed, Jul 6, 2022 at 6:52 AM Andres Freund wrote:
>
> Hi,
>
> On 2022-07-04 11:01:01 +0900, Masahiko Sawada wrote:
> > I've attached the patch, fix_drop_subscriptions_stats.patch, to fix it.
>
> LGTM. Unless somebody sees a reason not to, I'm planni
On Tue, Jul 5, 2022 at 7:00 AM Andres Freund wrote:
>
> Hi,
>
> On 2022-06-28 15:24:11 +0900, Masahiko Sawada wrote:
> > In both test cases, There is not much difference between using AVX2
> > and SSE2. The more mode types, the more time it takes for loading the
> >
On Tue, Jul 5, 2022 at 6:18 AM Andres Freund wrote:
>
> Hi,
>
> On 2022-06-16 13:56:55 +0900, Masahiko Sawada wrote:
> > diff --git a/src/backend/lib/radixtree.c b/src/backend/lib/radixtree.c
> > new file mode 100644
> > index 00..bf87f932fd
> > ---
On Mon, Jul 4, 2022 at 2:07 PM Masahiko Sawada wrote:
>
> On Tue, Jun 28, 2022 at 10:10 PM John Naylor
> wrote:
> >
> > On Tue, Jun 28, 2022 at 1:24 PM Masahiko Sawada
> > wrote:
> > >
> > > > I
> > > > suspect other optimizations wou
On Tue, Jun 28, 2022 at 10:10 PM John Naylor
wrote:
>
> On Tue, Jun 28, 2022 at 1:24 PM Masahiko Sawada wrote:
> >
> > > I
> > > suspect other optimizations would be worth a lot more than using AVX2:
> > > - collapsing inner nodes
> > > - taking c
On Sat, Jul 2, 2022 at 9:52 AM Masahiko Sawada wrote:
>
>
>
> On Sat, Jul 2, 2022 at 2:53 Andres Freund wrote:
>>
>> Hi,
>>
>> On 2022-07-01 16:08:48 +0900, Masahiko Sawada wrote:
>> > Yes, my point is that it may be misleading that the subscription
On Sat, Jul 2, 2022 at 2:53 Andres Freund wrote:
> Hi,
>
> On 2022-07-01 16:08:48 +0900, Masahiko Sawada wrote:
> > Yes, my point is that it may be misleading that the subscription stats
> > are created when a subscription is created.
>
> I think it's import
On Fri, Jul 1, 2022 at 3:01 PM Amit Kapila wrote:
>
> On Fri, Jul 1, 2022 at 7:12 AM Masahiko Sawada wrote:
> >
> > On Wed, Mar 16, 2022 at 11:34 PM Masahiko Sawada
> > wrote:
> > >
> >
> > While looking at this issue again, I realized there seems t
o this for pg_backup_start(). Thought? I included
> the code to disallow that in the attached patch.
+1
@@ -233,6 +233,12 @@ perform_base_backup(basebackup_options *opt, bbsink *sink)
StringInfo labelfile;
StringInfo tblspc_map_file;
backup_manifest_info manifest;
+ SessionBackupState status = get_backup_status();
+
+ if (status == SESSION_BACKUP_RUNNING)
+ ereport(ERROR,
+ (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
+errmsg("a backup is already in progress in this session")));
I think we can move it to the beginning of SendBaseBackup() so we can
avoid bbsink initialization and cleanup in the error case.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
Hi,
On Wed, Mar 16, 2022 at 11:34 PM Masahiko Sawada wrote:
>
> On Wed, Mar 16, 2022 at 8:51 PM Amit Kapila wrote:
> >
> > On Tue, Mar 15, 2022 at 10:09 AM Masahiko Sawada
> > wrote:
> > >
> > > On Tue, Mar 15, 2022 at 3:34 AM Melanie Plageman
&g
Hi,
On Tue, Feb 1, 2022 at 11:58 AM Masahiko Sawada wrote:
>
> On Fri, Jun 11, 2021 at 10:19 AM Andres Freund wrote:
> >
> > Hi,
> >
> > On 2021-06-10 16:42:01 +0300, Anastasia Lubennikova wrote:
> > > Cool. Thank you for working on that!
> > >
Hi,
On Mon, Jun 27, 2022 at 8:12 PM John Naylor
wrote:
>
> On Mon, Jun 20, 2022 at 7:57 AM Masahiko Sawada wrote:
>
> [v3 patch]
>
> Hi Masahiko,
>
> Since there are new files, and they are pretty large, I've attached
> most specific review comments and question
On Fri, Jun 24, 2022 at 2:12 PM Andrey Lepikhov
wrote:
>
> Moved from the pgsql-bugs mailing list [1].
>
> On 6/23/22 07:03, Masahiko Sawada wrote:
> > Hi,
> >
> > On Sat, Jun 4, 2022 at 4:03 AM Andrey Lepikhov
> > wrote:
> >>
> >&g
On Thu, Jun 23, 2022 at 7:00 PM Amit Kapila wrote:
>
> On Wed, Jun 22, 2022 at 11:09 AM Masahiko Sawada
> wrote:
> >
> > I've attached a WIP patch for adding regression tests for DDL deparse.
> > The patch can be applied on
> > v9-0001-Functions-to-d
"tab_rowfilter_partitioned" has finished
>
> From the Log, I can see it query the target table before the table sync is
> over. So, I think the reason is that we didn't wait for table sync to
> finish after refreshing the publication. Sorry for not catching that
> ealier. Here is a patch to fix it.
+1
The patch looks good to me.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
d seek WAL records from backward but it could take a quite long
time.
Regards,
[1] https://github.com/MasahikoSawada/pgtools/tree/master/page_repair
[2]
https://www.postgresql.org/message-id/CAOBaU_aVvMjQn%3Dge5qPiJOPMmOj5%3Dii3st5Q0Y%2BWuLML5sR17w%40mail.gmail.com
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
On Wed, Jun 22, 2022 at 3:29 PM Drouvot, Bertrand wrote:
>
> Hi hackers,
>
> I think there's a missing reference to pgstat_replslot.c in pgstat.c.
>
> Attached a tiny patch to fix it.
+1
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
s to define the event trigger to deparse
DDLs, run the regression tests, load the deparsed DDLs to another
database cluster, dump both databases, and compare the dumps. Since
the patch doesn't support deparsing all DDLs and there is a bug[2],
the attached regression test does CREATE TABLE and some A
On Mon, Jun 6, 2022 at 11:42 PM Robert Haas wrote:
>
> On Thu, May 26, 2022 at 11:43 AM Masahiko Sawada
> wrote:
> > Another idea I came up with is that we can wait for all index vacuums
> > to finish while checking and updating the progress informatio
Hi,
On Thu, Jun 16, 2022 at 4:30 PM John Naylor
wrote:
>
> On Thu, Jun 16, 2022 at 11:57 AM Masahiko Sawada
> wrote:
> > I've attached an updated version patch that changes the configure
> > script. I'm still studying how to support AVX2 on msvc build. Also,
On Thu, Jun 16, 2022 at 2:27 AM Robert Haas wrote:
>
> On Tue, Jun 14, 2022 at 3:54 AM Masahiko Sawada wrote:
> > > AFAICS, we could do that by:
> > >
> > > 1. De-supporting platforms that have this problem, or
> > > 2. Introducing new typalign va
On Wed, May 25, 2022 at 11:48 AM Masahiko Sawada wrote:
>
> On Tue, May 10, 2022 at 6:58 PM John Naylor
> wrote:
> >
> > On Tue, May 10, 2022 at 8:52 AM Masahiko Sawada
> > wrote:
> > >
> > > Overall, radix tree implementations have good numbers
On Tue, Jun 14, 2022 at 3:57 PM Amit Kapila wrote:
>
> On Mon, Jun 13, 2022 at 8:29 AM Masahiko Sawada wrote:
> >
> > On Tue, Jun 7, 2022 at 9:32 PM Amit Kapila wrote:
> > >
> > > On Mon, May 30, 2022 at 11:13 AM Masahiko Sawada
> > > wrote:
>
rcing values that are sometimes 4-byte aligned and
> sometimes 8-byte aligned to be 8-byte alignment on all platforms
Introducing new typalign values seems a good idea to me as it's more
future-proof. Will this item be for PG16, right? The main concern
seems that what this test case enforces would be nuisance when
introducing a new system catalog or a new column to the existing
catalog but given we're in post PG15-beta1 it is unlikely to happen in
PG15.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
On Tue, Jun 7, 2022 at 9:32 PM Amit Kapila wrote:
>
> On Mon, May 30, 2022 at 11:13 AM Masahiko Sawada
> wrote:
> >
> > On Wed, May 25, 2022 at 12:11 PM Masahiko Sawada
> > wrote:
> > >
> >
> > poc_add_regression_tests.patch adds regression
ery page and used not only by vacuum such as analyze,
but it seems to be worth trying.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
t; have more origins per subscription but it is quite possible that I am
> missing something and there are problems due to which we can't use
> that approach.
I prefer the first idea as it's simpler than the second one. I don't
see any concurrency problem so far unless I'm not missing something.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
s should be rare and I think it's OK even if it happens,
> > we'll find out
> > why and fix it.
> >
>
> FWIW, both these cases could be handled with the deparsing approach,
> and the handling related to the drop of multiple tables where only a
> few are published is already done in the last POC patch shared by Ajin
> [1].
>
Right. So I'm inclined to think that deparsing approach is better from
this point as well as the point mentioned by Álvaro before[1].
Regards,
[1]
https://www.postgresql.org/message-id/202204081134.6tcmf5cxl3sz%40alvherre.pgsql
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
801 - 900 of 2389 matches
Mail list logo