On Sun, Oct 17, 2021 at 10:29:24AM -0400, Tom Lane wrote:
> mp39...@gmail.com writes:
> > We might be in situation when we have "just enough" semaphores in the
> > system limit to start but previously crashed unexpectedly, in that case
> > we won't be able to start again - semget() will return ENOS
On Sun, Oct 17, 2021 at 10:52:38AM -0400, Tom Lane wrote:
> Mikhail writes:
> > On Sun, Oct 17, 2021 at 10:29:24AM -0400, Tom Lane wrote:
> >> AFAICS, this patch could be disastrous. What if the semaphore in
> >> question belongs to some other postmaster?
>
On Mon, Oct 18, 2021 at 10:07:40AM +1300, Thomas Munro wrote:
> On Mon, Oct 18, 2021 at 4:49 AM Mikhail wrote:
> > The logic works - the initial call to semget() in
> > InternalIpcSemaphoreCreate returns -1 and errno is set to ENOSPC - I
> > tested the patch on OpenBSD
On Fri, Oct 22, 2021 at 03:43:00PM -0400, Tom Lane wrote:
> Mikhail writes:
> > In your patch I've removed testing for 5.x versions, because official
> > releases are supported only for one year, no need to worry about them.
>
> Official support or no, we have OpenBS
On Fri, Oct 22, 2021 at 09:00:31PM -0400, Tom Lane wrote:
> I tried this on an OpenBSD 6.0 image I had handy. The good news is
> that it works, and I can successfully start the postmaster with a lot
> of semaphores (I tried with max_connections=1) without any special
> system configuration. T
On Sun, Oct 17, 2021 at 10:52:38AM -0400, Tom Lane wrote:
> I am, however, concerned that this'll just trade off one hazard for
> another. Instead of a risk of failing with ENOSPC (which the DBA
> can fix), we'll have a risk of kneecapping some other process at
> random (which the DBA can do nothi
On Sun, Oct 17, 2021 at 10:29:24AM -0400, Tom Lane wrote:
> Also, you haven't explained why the existing (and much safer) recycling
> logic in IpcSemaphoreCreate doesn't solve your problem.
I think I'll drop the diffs, you're right that current proven logic need
not to be changed for such rare cor
;ve seen a thread that memory leaks are allowed in initdb, because it is a
short-lived process. Obviously they are not allowed in the database server.
Are memory leaks allowed in the psql tool?
Regards,
Mikhail
allback from resowner.h be more
appropriate for this use case? I only see that being used for
OpenSSL-related resources at the moment.
Thanks,
Mikhail
nch is
attached.
[1] - https://svace.pages.ispras.ru/svace-website/en/
--
best regards,
Mikhail A. Gribkov
e-mail: youzh...@gmail.com
*http://www.flickr.com/photos/youzhick/albums
<http://www.flickr.com/photos/youzhick/albums>*
http://www.strava.com/athletes/5085772
phone: +7(916)604-71
along with the fresh rebase on master.
--
best regards,
Mikhail A. Gribkov
e-mail: youzh...@gmail.com
*http://www.flickr.com/photos/youzhick/albums
<http://www.flickr.com/photos/youzhick/albums>*
http://www.strava.com/athletes/5085772
phone: +7(916)604-71-12
Telegram: @youzhick
On Th
assed without problems
>> build doc passed without problems
>> I think so tests are now enough
>>
>> I'll mark this patch as ready for committer
>>
>
> Unfortunately, I forgot one important point. There are not any tests
> related to backup.
>
> I
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
Hi Daniel,
I have reviewed the patch and I liked it (well I
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, failed
Documentation:tested, passed
Hi Christoph,
The patch have a potential, although I have to
er message."
Looks to me that FlushErrorState() should be inserted before this ereport.
Shouldn't it?
--
best regards,
Mikhail A. Gribkov
Cing to Peter Eisentraut, whose patch originally introduced these returns.
Peter, will such a patch work somehow against your initial idea?
--
best regards,
Mikhail A. Gribkov
e-mail: youzh...@gmail.com
*http://www.flickr.com/photos/youzhick/albums
<http://www.flickr.com/photos/youzhi
%2BawtBOESXG5Grfg%40mail.gmail.com
--
best regards,
Mikhail A. Gribkov
e-mail: youzh...@gmail.com
*http://www.flickr.com/photos/youzhick/albums
<http://www.flickr.com/photos/youzhick/albums>*
http://www.strava.com/athletes/5085772
phone: +7(916)604-71-12
Telegram: @youzhick
>
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
I like it now.
* The patch does what it intends to do;
* The
later than normally and affects logins count for on-login
trigger test. Thus I had to split event_trigger and oidjoins tests into
separate parallel groups. I'll post this as an independent patch then.
--
best regards,
Mikhail A. Gribkov
e-mail: youzh...@gmail.com
*http://www.flickr.com/p
hould be splitted into separate paralell schedule groups. This is exactly
what the proposed (attached) patch is doing.
What do you think?
--
best regards,
Mikhail A. Gribkov
e-mail: youzh...@gmail.com
v001_avoid_race_condition_for_event_trigger_test.patch
Description: Binary data
Hi Alexander,
>> Thank you for catching it. Please, post this.
Just for a more complete picture of the final state here.
I have posted the described fix (for avoiding race condition in the tests)
separately:
https://commitfest.postgresql.org/45/4616/
--
best regards,
Mikhail A. Grib
;ve seen a thread that memory leaks are allowed in initdb, because it is a
short-lived process. Obviously they are not allowed in the database server.
Are memory leaks allowed in the psql tool?
Regards,
Mikhail
allback from resowner.h be more
appropriate for this use case? I only see that being used for
OpenSSL-related resources at the moment.
Thanks,
Mikhail
controlling GUC.
--
best regards,
Mikhail A. Gribkov
On Fri, Nov 4, 2022 at 3:58 AM Ian Lawrence Barwick
wrote:
> 2022年11月4日(金) 5:23 Daniel Gustafsson :
> >
> > > On 20 Sep 2022, at 16:10, Daniel Gustafsson wrote:
> >
> > > Since the original authors seem
bserved level of performance drop is
acceptable.
--
best regards,
Mikhail A. Gribkov
e-mail: youzh...@gmail.com
*http://www.flickr.com/photos/youzhick/albums
<http://www.flickr.com/photos/youzhick/albums>*
http://www.strava.com/athletes/5085772
phone: +7(916)6
Hi Nikita,
> Mikhail, I've checked the patch and previous discussion,
> the condition mentioned earlier is still actual:
Thanks for pointing this out! My bad, I forgot to fix the documentation
example.
Attached v34 has this issue fixed, as well as a couple other problems with
the e
two cases of if-else one-liners.
--
best regards,
Mikhail A. Gribkov
e-mail: youzh...@gmail.com
*http://www.flickr.com/photos/youzhick/albums
<http://www.flickr.com/photos/youzhick/albums>*
http://www.strava.com/athletes/5085772
phone: +7(916)604-71-12
Telegram: @youzhick
On Sat,
king those incompatible with current PostgreSQL decoding code.
All patch is doing is making a note of a leading minus and negates pg_tm
components along with fractional seconds. No other behavior change is
introduced.
--
Mikhail
From c1d96252ebd727b205e1ee66f34f8b564eb05c00 Mon Sep 17 00:00:00 2001
Fro
0 days as: -P120D.
| ...
| P-1347M is not allowed although -P1347M is allowed
`
Note that the second example explicitly contradicts currently allowed PG
syntax. I presume if the standard was clear, there would be no such
ambiguity.
Not that I'm trying to introduce drastic changes, but to make PostgreSQL
to be somewhat more friendly to what it can accept directly without
dancing around.
--
Mikhail
ow things are and we do not want to break anything. And, second, in
many cases client software can read either format. That is why I thought
it would be a trivial change. No output changes.
--
Mikhail
| EXAMPLE 10 '-P-5WT-18H30M', duration in reverse, "go back five weeks,
eighteen hours but thirty minutes
| ahead", is equivalent to 'P5WT18H-30M', "go ahead five weeks, eighteen hours,
but thirty minutes back".
|
| NOTE The exact duration for some time scale components can be known only when
placed on the actual
| time scale, see D.2.
`
On a side note, it also defines (4.4.2) exponential values, but I guess
we can pass on those for now.
--
Mikhail
ched the patch as an attachment to this email. The documentation
builds correctly without any lint errors after applying the patch locally.
This is my first time contributing, so let me know if there is anything
else I should do (add to commitfest etc).
Cheers!
Mikhail Dobrinin
jsonb-docs-v1.
RMs[2] that still need to be patched and current situation contradicts
documentation[1].
Footnotes:
[1] https://www.postgresql.org/docs/devel/ddl-generated-columns.html
[2] https://github.com/rails/rails/pull/39368#issuecomment-670351379
--
Mikhail
From d606c4f952a6080dff6fb621ea034bfce2865f7b Mo
est application
Here is the backlink https://commitfest.postgresql.org/29/2681/
--
Mikhail
v2-0001-Test-DEFAULT-in-VALUES-RTE-for-generated-columns.patch
Description: tests
v2-0002-Allow-DEFAULT-in-VALUES-RTE-for-generated-columns.patch
Description: changeset
asl.h"
^~~~
I think the new fe-auth-sasl.h file should be installed too.
Correction proposal in the attached file (but I'm not sure that fix of
Install.pm is correct).
Regards, Mikhail A. Kulagin
PostgresPro
missing_fe-auth-sasl.h.patch
Description: Binary data
I am not sure what is the proper fix for the issue, but I at least suggest
to disable this test when building with thread sanitizer:
https://github.com/conan-io/conan-center-index/pull/6472/files#diff-b8639f81e30f36c8ba29a0878f1ef4d9f1552293bc9098ebb9b429ddb1f0935f
-
Best regards, Mikhail Matrosov
on a particular library.
I am not aware of the release cadence of libpq.
Anyway, I am very glad there is swift feedback from you guys and I am
looking forward to your comments on the proper way to fix the issue!
-
Best regards, Mikhail Matrosov
Hi hackers,
As not much preliminary interest seem to be here, I'm sending the patch to
the upcoming commitfest
--
best regards,
Mikhail A. Gribkov
On Sat, Jun 17, 2023 at 12:51 AM Mikhail Gribkov wrote:
> Hi hackers,
>
> In modern versions of Postgres the dollar sign is a
2023-07-06 14:10:17.171 MSK [22431] STATEMENT: select wait_type_event from
pg_stat_activity ;
ERROR: column "wait_type_event" does not exist
LINE 1: select wait_type_event from pg_stat_activity ;
--
best regards,
Mikhail A. Gribkov
e-mail: youzh...@gmail.com
*http://www.flickr.com/pho
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, failed
Documentation:tested, failed
Hello Arne,
The goal of supporting words-switching hints sou
good to go, although you need to fix code formatting.
At least the char*-definition and opening "{" brackets are conspicuous.
Maybe there are more: it is worth running pgindend tool.
And it would be much more convenient to work with your patch if every next
version file will have a unique
://www.postgresql.org/message-id/CAMEv5_vg4aJOoUC74XJm%2B5B7%2BTF1nT-Yhtg%2BawtBOESXG5Grfg%40mail.gmail.com
--
best regards,
Mikhail A. Gribkov
e-mail: youzh...@gmail.com
*http://www.flickr.com/photos/youzhick/albums
<http://www.flickr.com/photos/youzhick/albums>*
http://www.strava.com/athletes/5085772
pho
s not done before. Maybe, there
are some special considerations I am not aware of, and the patch will break
something?
What would you say?
--
best regards,
Mikhail A. Gribkov
v001_fix_dollar_names_tab_complete.patch
Description: Binary data
Hi Gregory,
Thanks for the note. The problem was that the patch was not aware of
yesterday Tom Lane's changes in the test.
It's fixed now: the attached v39 patch contains the updated version along
with the freshest rebase on master branch.
--
best regards,
Mikhail A. Gribkov
e-m
44 matches
Mail list logo