Re: [bug+patch] Inserting DEFAULT into generated columns from VALUES RTE

2020-08-14 Thread Mikhail Titov
Previously submitted patch got somehow trailing spaces mangled on the way out. This is an attempt to use application/octet-stream MIME instead of text/x-patch to preserve those for regression tests. On Thu, Aug 13, 2020 at 12:11 AM, Pavel Stehule wrote: > please, assign your patch to commitfest

[bug+patch] Inserting DEFAULT into generated columns from VALUES RTE

2020-08-12 Thread Mikhail Titov
17 00:00:00 2001 From: Mikhail Titov Date: Wed, 12 Aug 2020 22:42:37 -0500 Subject: [PATCH 1/2] Test DEFAULT in VALUES RTE for generated columns --- src/test/regress/expected/generated.out | 9 + src/test/regress/expected/identity.out | 13 + src/test/regress/sql

Re: [PATCH] Leading minus for negative time interval in ISO 8601

2020-06-09 Thread Mikhail Titov
On Wed, Jun 3, 2020 at 11:25 PM, Tom Lane wrote: > ... > Maybe we should just take the position that negative intervals aren't > standardized, and if you want to transport them using ISO format then > you first need to lobby ISO to fix that. Apparently ISO did "fix" this. I managed to get a

Re: [PATCH] Leading minus for negative time interval in ISO 8601

2020-06-03 Thread Mikhail Titov
> ... >> Umm, did you see any indication that they intend to allow "-" /anywhere/ >> in a time interval (with the exception of between year and month, month >> and day in the alternate form, as simple delimiters, not as minus? >> (Maybe you did; I'm looking at a publicly-accessible 2016 draft.) >

Re: [PATCH] Leading minus for negative time interval in ISO 8601

2020-06-03 Thread Mikhail Titov
On Wed, Jun 3, 2020 at 9:46 PM, Tom Lane wrote: > ... > ISTM that if the standard intended to allow that, it'd be pretty > clear. I looked through the 8601 spec just now, and I can't see any > indication whatever that they intend to allow "-" before P. To be fair, I do not have an access to

[PATCH] Leading minus for negative time interval in ISO 8601

2020-06-03 Thread Mikhail Titov
incompatible with current PostgreSQL decoding code. All patch is doing is making a note of a leading minus and negates pg_tm components along with fractional seconds. No other behavior change is introduced. -- Mikhail From c1d96252ebd727b205e1ee66f34f8b564eb05c00 Mon Sep 17 00:00:00 2001 From: Mikhail