On Fri, Jul 25, 2025 at 1:58 PM Japin Li wrote:
>
> On Wed, 23 Jul 2025 at 14:07, Peter Smith wrote:
> > On Tue, Jul 22, 2025 at 8:12 PM Japin Li wrote:
> > ...
...
> >>
> >> Or is it by design that users are unable to read the internal relations?
> >&g
On Wed, Jul 23, 2025 at 2:12 PM Peter Smith wrote:
>
> On Wed, Jul 23, 2025 at 1:58 PM Japin Li wrote:
> >
> > After some investigation, I found that the VACUUM assertion failures were
> > caused by an uninitialized HeapTupleFreeze structure. PFA.
> >
>
> H
if
> +
> +#ifdef __sparc__
> +char *dir_name = "base/" PG_TEMP_FILES_DIR;
> +#endif
>
> I think it's also possible to use the second format on Windows.
> And what happens if neither WIN32 nor __sparc__ are defined?
>
Modified in v15.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
On Thu, Jul 24, 2025 at 2:18 AM Bruce Momjian wrote:
>
> On Mon, Jun 23, 2025 at 10:29:50AM +1000, Peter Smith wrote:
> > Hi,
> >
> > I am looking for some guidelines/recommended SGML tags to use when
> > referring in the PG documentation to any user-defined
On Wed, Jul 23, 2025 at 1:58 PM Japin Li wrote:
>
>
> Hi, Peter
>
> On Tue, 22 Jul 2025 at 17:46, Peter Smith wrote:
> > Hi.
> >
> > Here are the latest v14 patches.
> >
> > Changes include:
> >
> > PATCH 0002.
> > - Fixes the
itely are not meant to tamper with them.
The REFRESH that you attempted should have caused a more graceful error, like:
ERROR: extension "vci" prohibits this operation on view
"vci_016482_0_d"
So, thanks for reporting that the ERROR failed. Investigating...
==
Kind Regards,
Peter Smith.
Fujitsu Australia
On Tue, Jul 22, 2025 at 3:36 PM Michael Paquier wrote:
>
> On Thu, Jul 17, 2025 at 01:34:42PM +0800, Japin Li wrote:
> > On Wed, 16 Jul 2025 at 10:08, Peter Smith wrote:
> >> What's going on there? Is it just an accidentally missing "/* can be
> >> NUL
only -- I did not try it).
Note there is a typo in the commit message:
/Defination/Definition/
==
Kind Regards,
Peter Smith.
Fujitsu Australia
ter
test should give more explanation to say what is the expected result
and why.
~
10b.
How does "ALTER PUBLICATION tap_pub_col SET
(publish_generated_columns)" even work? I thought the
"pubish_generated_columns" is an enum but you did not specify any enum
value here (???)
~~~
11.
+ 'check publication(publish_generated_columns as false) with
generated columns and EXCEPT'
Hmm. I thought there is no such thing as "publish_generated_columns as
false", and also the EXCEPT should say 'EXCEPT (column-list)'
~~~
12.
I wonder if there should be another boundary condition test case as follows:
- have some table with cols a,b,c.
- create a publication 'EXCEPT (a,b,c)', so you don't publish anything at all.
- then ALTER the TABLE to add a column 'd'.
- now the publication should publish only 'd'.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
cols and the EXCEPT
+CREATE UNIQUE INDEX pub_test_except1_a_idx ON pub_test_except1 (a);
+ALTER TABLE pub_test_except1 REPLICA IDENTITY USING INDEX
pub_test_except1_a_idx;
+UPDATE pub_test_except1 SET a = 3 WHERE a = 1;
+
That comment doesn't make sense. Missing words?
==
.../t/036_rep_changes_except_table.pl
15.
(I haven't reviewed this file in detail yet, but here is a general comment)
I know this patch currently lives in the same thread as all the EXCEPT
TABLE stuff, but that seems just happenstance to me. IMO, this is a
separate enhancement that just shares the keyword EXCEPT. So, I felt
it should have quite separate tests too.
e.g. How about: 037_rep_changes_except_collist.pl
==
[1]
https://www.postgresql.org/message-id/CANhcyEW2LK4diNeCG862DE40yQoV3VAgf59kXUq2TuR8fnw5vQ%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
xAmRoutine
[1].
What's going on there? Is it just an accidentally missing "/* can be
NULL */" comment?
Same also in the documentation... [2]
==
[1] https://github.com/postgres/postgres/blob/master/src/include/access/amapi.h
[2] https://www.postgresql.org/docs/devel/index-api.htm
r it's always non-negative. Did I
> miss
> anything?
>
Yeah, I don't see warnings in my build environment, but OTOH we are
aware there are a number of compiler warnings that are reported by the
cfbot [1]. That one you cited above is just another one of them.
Addressing all the cfbot compiler warnings in patch 0002 is certainly
on the to-do list.
==
[1] https://cirrus-ci.com/task/5631634596167680
Kind Regards,
Peter Smith.
Fujitsu Australia
size, improving the PostgreSQL core interface, and
fixing bugs. Rewriting or optimising the logic will have to wait.
> 5.
> Typo in README.
> - Each extent can have its own independent compression dictionary or all
> extents can share a comon dictionary
> --> s/comon/common/g
>
Fixed.
~~~
Please see the updated README that I attached in the previous post.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
appropriate offset can be found using the
extent ID as the offset-array index. I’ve reworded this in the README
to be clearer.
>
> d) EXPLAIN ANALYSE -->EXPLAIN ANALYZE
Fixed.
~~~
Please see the updated README.
==
[1] slides -
https://www.pgevents.ca/events/pgconfdev2025/sessions/session/292/slides/98/A%20journey%20toward%20the%20columnar%20data%20store%20.pdf
Kind Regards,
Peter Smith.
Fujitsu Australia
README
Description: Binary data
Shveta.
Thanks for your README questions and typo reports. I will try to
address those soon.
Regarding your reported VACUUM exception, I believe this is the same
issue that was previously reported by Japin Li [1].
==
[1]
https://www.postgresql.org/message-id/SY8P300MB0442BEC3F5CF432F0121ACC4B642A%40SY8P300MB0442.AUSP300.PROD.OUTLOOK.COM
Kind Regards,
Peter Smith.
Fujitsu Australia
s had previously also been reported by Tomas [1].
Upon investigation, I found that this was master code from 10 years
ago (back when this VCI patch was implemented). The master code has
moved on since then and removed this macro [2], but this VCI patch did
not...
I'll try to address this for the next patchset.
==
[1]
https://www.postgresql.org/message-id/a748aa6b-c7e6-4d02-a590-ab404d590448%40vondra.me
[2]
https://github.com/postgres/postgres/commit/8023b5827fbada6815ce269db4f3373ac77ec7c3
Kind Regards,
Peter Smith.
Fujitsu Australia
be defined in
> the extension.
>
Fixed in v11-0001
==
Kind Regards,
Peter Smith.
Fujitsu Australia
> EOF
>
Hi Japin,
Thank you for your interest in VCI and for reporting the problem.
We are working to get this patch into a better shape; this vaccum
issue has been added to our list of things to fix. Thanks also for
your script - using it, I reproduced the same TRAP that you reported.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
On Tue, Jul 1, 2025 at 6:29 PM Peter Eisentraut wrote:
>
> On 16.01.25 06:38, Peter Smith wrote:
> > On Thu, Jan 16, 2025 at 3:26 PM Tom Lane wrote:
> >>
> >> Peter Smith writes:
> >>> During some recent reviews, I came across some comments ment
Options change
> with an extensible solution using "contrib/bloom" as guidance.
> (Timur suggests that this also unused code anyway. Investigating...)
>
Fixed (removed) in v10.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
On Tue, Jul 1, 2025 at 1:17 PM Peter Smith wrote:
>
> On Sat, Jun 28, 2025 at 12:24 AM Timur Magomedov
> wrote:
> ...
> > Thanks for updates.
> > I was trying to move some code from Postgres core patch to contrib/vci.
> > Started with moving VCI option
the original patch devs and, if
correct, I will address this in a future patch version.
==
Kind Regards,
Peter Smith.
Fujitsu Australia.
Hi Shlok,
One more thing, I noticed there is no tab-completion code yet for this
new EXCEPT (column_list) syntax.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
EPT
col-list, then it is ok
~
19b.
IMO, some index names could be better:
CREATE UNIQUE INDEX pub_test_except1_a_idx ON pub_test_except1 (a, c);
How about 'pub_test_except1_ac_idx'?
~~~
20.
+DROP PUBLICATION testpub_except;
+DROP TABLE pub_test_except1;
+DROP TABLE pub_sch1.pub_test_except2;
Add a "cleanup" comment.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
, then I feel
that at least we have to put more qualifications in the description to
say that column lists must not be specified when using DROP.
==
[1] https://www.postgresql.org/docs/devel/sql-alterpublication.html
Kind Regards,
Peter Smith.
Fujitsu Australia
at the strcmp?
~~~
21.
- if (strcmp(prexcept, "t") == 0)
+ if (strcmp(prexcept, "t") == 0 && PQgetisnull(res, i, i_prattrs))
simple_ptr_list_append(&exceptinfo, &pubrinfo[j]);
Why not assign pubrinfo[j].pubexcept earlier so you don't have to
repeat the strcmp? Same also for the PQgetisnull(res, i,
i_prattrs))...
~~~
22. dumpPublicationTable
if (pubrinfo->pubrattrs)
- appendPQExpBuffer(query, " (%s)", pubrinfo->pubrattrs);
+ {
+ if (pubrinfo->pubexcept)
+ appendPQExpBuffer(query, " EXCEPT (%s)", pubrinfo->pubrattrs);
+ else
+ appendPQExpBuffer(query, " (%s)", pubrinfo->pubrattrs);
+ }
SUGGESTION
{
if (pubrinfo->pubexcept)
appendPQExpBuffer(query, " EXCEPT");
appendPQExpBuffer(query, " (%s)", pubrinfo->pubrattrs);
}
==
Kind Regards,
Peter Smith.
Fujitsu Australia
e differences. IIUC, then I hope later to
fix the safe_types, and then also fix the vci_supported_func_table[]
based on the result of that SQL script.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
t that you just follow nearby code
> (as you are already doing). I plan to raise another thread to ask what
> are the guidelines for this sort of markup which is currently used
> inconsistently in different places.
>
FYI - I created a new thread asking this markup question [1].
==
[1]
https://www.postgresql.org/message-id/CAHut%2BPvtf24r%2BbdPgBind84dBLPvgNL7aB%2B%3DHxAUupdPuo2gRg%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
My AI tool says the following.
PostgreSQL documentation typically uses:
for specific, concrete names
for generic placeholders
for system objects and data types
TBH, this seemed like good advice to me... however there are quite a
few examples not following that.
Thoughts?
==
Kind
lidate the 'excluded columns' list and ensure the columns
+ * are all valid to exclude from publication. Checks for and raises an
+ * ERROR for any unknown columns, system columns, duplicate columns, or
+ * generated columns.
+ *
Why can't you exclude generated columns?
e.g. Maybe
On Tue, Jun 10, 2025 at 6:02 PM Peter Smith wrote:
>
> Hi Timur.
>
> On Wed, Jun 4, 2025 at 11:47 PM Timur Magomedov
> wrote:
> >
> > Hello Peter,
> >
> > I've tried running VCI, the idea looks great to me. Thank you and
> > Iwata-san for working
ous other slightly reworded --clean-something variants were
> > tossed around.
> >
> > Peter Smith raised the concern that "clean" is not an established term
> > and it should by something based on "drop" instead.
> >
> > And then later, this was no
for columns security_pin:
+
+CREATE PUBLICATION users_safe FOR TABLE users EXCEPT (security_pin);
+
+
8a.
Same review comment as previously -- Those tags don't seem correct.
e.g. "users" and "security_pin" are not (???).
Again, are all the other existing tags also
es/commit/626df47ad9db809dc8f93330175ab95b75914721
Kind Regards,
Peter Smith.
Fujitsu Australia
(see
> discussion [2]).
> Can we use leave TupleHashEntryData as is and make new VCI-specific
> struct that contains TupleHashEntryData member and an additional
> pointer or make VCI use TupleHashEntryGetAdditional()?
>
Thanks for the report. This is fixed in v6.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
ion will resume in the next cycle. However, if no
> consumer is configured, it is advisable to manually advance the slot
> on the primary using pg_logical_slot_get_changes or
> pg_logical_slot_get_binary_changes, allowing synchronization to
> proceed.
>
> Let me know what you think of above?
>
Phrases like "... it is recommended..." and "... intended for testing
and debugging .. " and "... should be used with caution." and "... it
is advisable to..." seem like indicators that parts of the above
description should be using SGML markup such as or
or instead of just plain text.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
the name of the
subscription option; it might also be the name of an internal
structure member or catalog column name. Furthermore, when you are
referring to the option name I think it ought to be double-quoted for
clarity.
But, unless you are referring specifically to the option/field/column
then IMO it should say two-phase (with the dash).
e.g. The "two_phase" option enables two-phase mode.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
Tomas.
Attached is the first version of the README, intended to address the
points above.
For convenience, I’ve included it as a separate file, but the plan is
to integrate it into the 0002 patch in the next update.
Please let me know if you have any feedback or suggestions for
improving the content.
==
Kind Regards,
Peter Smith.
Fujitsu Australia.
README-20250610
Description: Binary data
s versions are next posted.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
ostgreSQL. These
VCI patches originated from an older forked source, so it seems this
reversion was inadvertently introduced during the rebasing process.
We’ll aim to correct this in a future patch.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
Hi,
There seems to be some unexpected ">" here:
"E.1.3.7.3. Logical Replication Applications>"
==
Kind Regards,
Peter Smith.
Fujitsu Australia
tion
"sub1" - batch #1 = 100 attempted, 97 succeeded, 3 mismatched, 150
remaining
LOG: Logical replication sequence synchronization for subscription
"sub1" - batch #2 = 100 attempted, 95 succeeded, 5 mismatched, 50
remaining
LOG: Logical replication sequence synchronization for subsc
ECT. Since it fixes
nothing I assumed you just commented the SELECT prompts for
consistency with the other ones, right?
==
Kind Regards,
Peter Smith.
Fujitsu Australia
le =~ qr/Filtering change for relation "insert_only_table"/,
+ 'delete for relation insert_only_table is filtered');
==
Kind Regards,
Peter Smith.
Fujitsu Australia
" multiple times.
SUGGESTION
"Logical replication sequence synchronization for subscription \"%s\"
- total unsynchronized: %d; batch #%d = %d attempted, %d succeeded, %d
mismatched"
==
Kind Regards,
Peter Smith.
Fujitsu Australia
eeded to say "of course" here.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
On Mon, Apr 28, 2025 at 7:51 PM Amit Kapila wrote:
>
> On Mon, Apr 28, 2025 at 8:08 AM Peter Smith wrote:
> >
> > On Wed, Apr 23, 2025 at 10:33 AM David G. Johnston
> > wrote:
> > ...
> > > In the column list I would stick to mentioning what cannot be spec
stand why it was put there in the first place.
Anyway, PSA patch v2.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
v2-0001-DOCS-create-publication-for-table.patch
Description: Binary data
. e.g. what's the point
of gathering publisher sequence lists and setting INIT states for
them, etc, when it won't synchronise anything because copy_data=false?
Everything will be synchronised later anyway when the user does
REFRESH PUBLICATION SEQUENCES.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
:
trailing whitespace.
*
warning: 1 line adds whitespace errors.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
ilure time'.
Those details belong at a lower level -- here, it is better to be more
generic.
SUGGESTION:
/* This is a clean exit, so no need for any sequence failure logic. */
==
Kind Regards,
Peter Smith.
Fujitsu Australia
d functions do.
~
4b.
I felt that all the SyncXXX functions exposed from syncutils.c should
be grouped together, and maybe even with a comment like /* from
syncutils.c */
==
Kind Regards,
Peter Smith.
Fujitsu Australia
theses.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
Hi Ajin.
Here are some v17-0003 review comments (aka some v16-0003 comments
that were not yet addressed or rejected)
On Fri, Apr 11, 2025 at 4:05 PM Peter Smith wrote:
...
> ==
> Commit message
>
> 2. missing commit message
Not yet addressed.
> ~~~
>
> 8.
> # In
eady be assigned in both the *if* and the *else* blocks. So, why is
it being overwritten again outside that if/else?
==
Kind Regards,
Peter Smith.
Fujitsu Australia
uded in
this case only if publish_generated_columns is set to stored.
I've attached a patch to implement this suggested wording.
Thoughts?
==
[1]
https://www.postgresql.org/docs/devel/sql-createpublication.html#SQL-CREATEPUBLICATION-PARAMS-FOR-TABLE
Kind Regards,
Peter Smith.
Fujitsu Australia
v1-00
->try_to_filter_change = entry->filterable;
+ return entry->filterable;
+ }
+
Bad indentation.
==
src/include/replication/reorderbuffer.h
3.
+extern bool ReorderBufferCanFilterChanges(ReorderBuffer *rb);
+
Why is this extern here? This function is not implemented in patch 0001.
==
Kind Regar
cussed (earlier in this thread)
changes that are not in this v3* patch set. They haven't been
forgotten; I'll revisit those later after the above (simpler) changes
are dealt with.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
v3-0004-DOCS-pg_waldump.-Some-option-tags-are-wrong-s
ight, I have changed that.
PS REPLY 17/4
Yes, the error message, but also I thought 'tblinfo' var and
FindTableByOid function name should refer to relations instead of
tables?
==
Kind Regards,
Peter Smith.
Fujitsu Australia
fferences between the publisher and the subscriber,
+ which might occur when copy_data = true.
+
ditto previous review comment #6.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
copy_data)
12.
+
+ See
+ for recommendations on how to handle any warnings about
differences in
+ the sequence definition between the publisher and the subscriber,
+ which might occur when copy_data = true.
+
Ditto my previous review comment #10.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
~~
29.
+# Check - newly published sequence values are not updated
+$result = $node_subscriber->safe_psql(
+ 'postgres', qq(
+ SELECT last_value, log_cnt, is_called FROM regress_s4;
+));
+is($result, '1|0|f',
+ 'REFRESH PUBLICATION will sync newly published sequence');
+
(This is the copy_data=false test)
29a.
Maybe it is good here also to show the sequence value at the publisher
to see if it is different.
~
29b.
The message 'REFRESH PUBLICATION will sync newly published sequence'
seems wrong because the values are NOT synced when copy_data=false
==
Kind Regards,
Peter Smith.
Fujitsu Australia
)
{
elm->last = next; /* last returned number */
elm->last_valid = true;
error: patch failed: src/backend/commands/sequence.c:994
error: src/backend/commands/sequence.c: patch does not apply
==
Kind Regards,
Peter Smith.
Fujitsu Australia
#x27;t this same code already done a few lines above in the same
function? Maybe I misread something.
======
src/test/regress/sql/publication.sql
5.
+-- check that describe sequence lists all publications the sequence belongs to
Might be clearer to say: "lists both" instead of "lists all"
==
Kind Regards,
Peter Smith.
Fujitsu Australia
32 | t
+(1 row)
+
I think 32 may seem like a surprising value to anybody reading these
results. Perhaps it will help if there can be a comment for this .sql
test to explain why this is the expected value.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
8b.
Change the comment or rearrange the tests so they are in the same
order as described
~
8c.
Looking at the expected logs I wondered if it might be nicer for the
pgoutput_filter_change doing this logging to also emit the relation
name.
~~~
9.
+$node_subscriber->safe_psql('postgres', "DROP SUBSCRIPTION sub_all");
+$node_subscriber->safe_psql('postgres', "DROP SUBSCRIPTION sub_insert_only");
+$node_subscriber->safe_psql('postgres', "DROP SUBSCRIPTION sub_delete_only");
+
9a.
You could combine all those DDL
~
9b.
Add some simple comment like "# cleanup"
~
9c.
Any reason why you dropped the subscriptions but not the publications?
==
Kind Regards,
Peter Smith.
Fujitsu Australia
d be able
to filter INSERTS but not filter DELETES even for the same relation.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
r names might be:
entry->filterable
rb->try_to_filter_change
Also these explanations/distinctions need to be made more clearly in
the commit message and/of file head comments, as well as where those
members are defined.
==
Kind Regards,
Peter Smith.
Fujitsu Australia.
==
[1] https://www.postgresql.org/docs/current/logical-replication-col-lists.html
[2]
https://www.postgresql.org/message-id/flat/CAH2L28vddB_NFdRVpuyRBJEBWjz4BSyTB%3D_ektNRH8NJ1jf95g%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
Relation() to see list of relations that are not
+ * decoded by the reorderbuffer.
/to see list of relations/to see the kinds of relation/
==
Kind Regards,
Peter Smith.
Fujitsu Australia
On Wed, Apr 9, 2025 at 8:08 PM Amit Kapila wrote:
>
> On Wed, Apr 9, 2025 at 7:48 AM Peter Smith wrote:
> >
> > I was looking at the recent push for the pg_createsubscription "--all"
> > option [1], because I was absent for several weeks prior.
> >
> &g
gt; it, but the main patch can be committed even without this.
>
I've created a separate thread [1] to continue the discussion about
the synopsis.
==
[1]
https://www.postgresql.org/message-id/CAHut%2BPueY_DyuBy6SuvJev2DWJVGtg%3D9WG9WXvYQDJu39gV6TQ%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
till works)
==
[1]
https://www.postgresql.org/message-id/CAHut%2BPuyBsOJTSygus2-yp60sw_phwYQ-JyC%2BU6fCBMos9x2LA%40mail.gmail.com
[2]
https://www.postgresql.org/message-id/CAHv8RjKU24jCHR2fOHocmdSTqhu7ige5UQsUQMkaTZniLc9DbA%40mail.gmail.com
[3]
https://github.com/postgres/postgres/commit/f
s part of the --all description to the
Note/Prerequisites section. (see #1c)
0003. Fixes to code comments. (see #2)
==
[1]
https://github.com/postgres/postgres/commit/fb2ea12f42b9453853be043b8ed107e136e1ccb7
[2] https://www.postgresql.org/docs/current/app-vacuumdb.html
Kind Regards,
Pete
needs to be balanced
by a call to the other function: parallel_vacuum_end_work_phase.
~~~
12.
+static void
+parallel_vacuum_end_worke_phase(ParallelVacuumState *pvs)
Typo (worke)
==
[1]
https://www.postgresql.org/message-id/CAHut%2BPs9yTGk2TWdjgLQEzGfPTWafKT0H-Q6WvYh5UKNW0pCvQ%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
05 PM Peter Smith wrote:
>
> ==
> src/backend/access/table/tableamapi.c
>
> 2.
> Assert(routine->relation_vacuum != NULL);
> + Assert(routine->parallel_vacuum_compute_workers != NULL);
> Assert(routine->scan_analyze_next_block != NULL);
>
> Is it better
dry-run"
~~~
Please find attached a small patch that implements all these changes.
==
[1]
https://www.postgresql.org/message-id/CAKFQuwbaYnSBc5fgHsoFLW_cUq2u466-3ZpkA%2Bu1Z%3D-medNgwg%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
v1-0001-improvements-for-remove-option-documentation.patch
Description: Binary data
On Thu, Apr 3, 2025 at 10:26 AM Andres Freund wrote:
>
> Hi,
>
> On 2025-04-03 09:58:30 +1100, Peter Smith wrote:
> > I saw that a new errhint_internal() function was recently committed
> > [1]. I had also posted above asking about this same missing function a
> > mo
lict type split into two, something like
'insert_multiple_conflicts' and 'update_multiple_conflicts'?
==
[1]
https://github.com/postgres/postgres/commit/73eba5004a06a744b6b8570e42432b9e9f75997b
Kind Regards,
Peter Smith.
Fujitsu Australia
gresql.org/message-id/CAHut%2BPtDHRif49G%2BbzspOGspETym5oKseD13v0tcBJXWUrTx9A%40mail.gmail.com
[3] https://www.postgresql.org/message-id/547688.1738630459%40sss.pgh.pa.us
Kind Regards,
Peter Smith.
Fujitsu Australia
Thanks for pushing.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
On Mon, Mar 17, 2025 at 1:50 PM Robert Haas wrote:
>
> On Sun, Mar 16, 2025 at 7:38 PM Peter Smith wrote:
> > If I understand correctly, the summary is:
> > - Tom: +1 for "TOAST table", but changing all the combined forms is
> > maybe not worth the effort.
>
ould be the
best choice in some cases but probably there are many dozens of
candidates so getting consensus on all of those rewrites will be like
herding cats.
Meanwhile, I've moved this CF entry into the next commitfest, because
I don't see how this thread can get resolved by the end of the month.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
Thanks for pushing it.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
on('\x5678'::bytea in '\x1234567890'::bytea) → 3
==
[1] https://www.postgresql.org/docs/17/functions-binarystring.html
Kind Regards,
Peter Smith.
Fujitsu Australia
On Sat, Mar 15, 2025 at 4:52 PM Peter Smith wrote:
>
> On Fri, Mar 14, 2025 at 5:39 PM David G. Johnston
> wrote:
> >
> > On Tuesday, March 11, 2025, Peter Smith wrote:
> >>
> >>
> >> Choice 3. Implement some option that has an argument saying w
On Fri, Mar 14, 2025 at 5:39 PM David G. Johnston
wrote:
>
> On Tuesday, March 11, 2025, Peter Smith wrote:
>>
>>
>> Choice 3. Implement some option that has an argument saying what to delete
>>
>> Implement an option that takes some argument saying wha
time permits I'll try to help you get some of the ("needs review")
threads moving by checking the simple ones first.
Kind Regards,
Peter Smith.
On Wed, Mar 12, 2025 at 3:18 AM David G. Johnston
wrote:
>
> On Thu, Dec 12, 2024 at 8:25 PM Peter Smith wrote:
>>
>> [1] initdb [option...] [ --pgdata | -D ] directory
>> [2] pg_archivecleanup [option...] archivelocation oldestkeptwalfile
>> [3] pg_checksum
2025 at 8:37 PM Nisha Moond wrote:
>
> On Mon, Feb 24, 2025 at 7:39 AM Peter Smith wrote:
> >
> > Hi Nisha.
> >
> > Some review comments for patch v1-0001
> >
> > ==
> > GENERAL
> >
> > 1.
> > This may be a
On Tue, Mar 11, 2025 at 11:32 AM David G. Johnston
wrote:
>
> On Mon, Mar 10, 2025 at 5:00 PM Peter Smith wrote:
>>
>> Hi Shubham.
>>
>> Some review comments for patch v16-0001.
>>
>> ==
>> doc/src/sgml/ref/pg_createsubscriber.sgml
>&
ot specified, a generated name is assigned
to the subscription name.
SUGGEST: If this --subscription is not specified, a generated name is
assigned to the subscription name.
==
[1]
https://www.postgresql.org/message-id/flat/CAHv8RjKhA%3D_h5vAbozzJ1Opnv%3DKXYQHQ-fJyaMfqfRqPpnC2bA%40mail.gmail.com
[2]
https://www.postgresql.org/message-id/flat/CAHut%2BPv%2B96CykSY6-uLKZWaa6to9x1DurmyJh8Jmu1_1P7hp4Q%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
laces, e.g. function cleanup_objects_atexit, this caused
unnecessary code bloat. IMO this function is crying out for a local
variable to simplify the code again.
Please see the attached patch that implements this suggestion.
==
Kind Regards,
Peter Smith
Fujitsu Australia
v1-0001-Add-cleanup_objects_at
e new feature so please separate
them into a different prerequisite patch so we can just focus on what
changes were made just for --drop-all-publications. I know you already
said you are working on it [1-#7], but multiple patch versions have
been posted since you said that.
==
[1] v13 review
https://www.postgresql.org/message-id/CAHv8RjKmf5bAcgTmGToWSn_Fx%2BO2y8qCiLScBXvBTD0D5gX2sw%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
frozen_pages = 0;
+ scan_data->rel_pages = orig_rel_pages = RelationGetNumberOfBlocks(rel);
+ vacrel->scan_data = scan_data;
/* dead_items_alloc allocates vacrel->dead_items later on */
That comment about dead_items_alloc seems misplaced now because it is
grouped with all the scan_data stuff.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
nal parallel vacuum callbacks need
to exist, or none.
(this same issue is repeated in multiple places).
==
[1] https://www.postgresql.org/docs/devel/sql-vacuum.html
Kind Regards,
Peter Smith.
Fujitsu Australia
void function, but introduce another parameter
'nworkers_index_p', similar to 'nworkers_table_p'?
==
Kind Regards,
Peter Smith.
Fujitsu Australia
ared->work_item == PV_WORK_ITEM_COLLECT_DEAD_ITEMS)"
~~~
12.
+ if (pvs.shared->work_item == PV_WORK_ITEM_COLLECT_DEAD_ITEMS)
+ {
+ /* Scan the table to collect dead items */
+ parallel_vacuum_process_table(&pvs, state);
+ }
+ else
+ {
+ Assert(pvs.shared->work_item == PV_WORK_IT
==
Kind Regards,
Peter Smith.
Fujitsu Australia
on.
~~~
6.
+/*
+ * Perform a parallel vacuums scan to collect dead items.
+ */
6a.
"Perform" or "Execute"?
The comment should match the one in the fwd declaration of this function.
6b.
Typo "vacuums"
==
Kind Regards,
Peter Smith.
Fujitsu Australia
1 - 100 of 1545 matches
Mail list logo
