Re: Add minimal C example and SQL registration example for custom table access methods.

2024-10-07 Thread Phil Eaton
Glad to hear it. Thank you! On Mon, Oct 7, 2024 at 2:50 AM Michael Paquier wrote: > > On Fri, May 24, 2024 at 03:59:08PM -0300, Fabrízio de Royes Mello wrote: > > Nice... LGTM! > > I have noticed that this was still in the CF. After fixing a couple > of inconsistencies in the markups and the na

Re: Add minimal C example and SQL registration example for custom table access methods.

2024-05-24 Thread Phil Eaton
> I think this should say something more like "Here is how an extension > SQL script might create a table access method handler". Fair point. It is referred to elsewhere [0] in docs as a "script file", so I've done that. > Shouldn't "mem_tableam_handler" be "my_tableam_handler"? Sorry about that

Re: Add minimal C example and SQL registration example for custom table access methods.

2024-05-14 Thread Phil Eaton
> I took a look at this patch and I don't think this is a very good > idea, No problem! I've dropped the v2 code additions and stuck with the v1 attempt plus feedback. Thank you! Phil v3-0001-Add-minimal-C-example-and-SQL-registration-exampl.patch Description: Binary data

Re: Add minimal C example and SQL registration example for custom table access methods.

2024-05-03 Thread Phil Eaton
> > > There is a previous patch [1] around the same topic. What about joining > > efforts on pointing these documentation changes to the proposed test module? > > > > [1] https://commitfest.postgresql.org/46/4588/ > > Looking over this thread, I see that it was mo