RE: Multivariate MCV list vs. statistics target

2020-03-17 Thread Shinoda, Noriyoshi (PN Japan A&PS Delivery)
Hello, I found a missing column description in the pg_statistic_ext catalog document for this new feature. The attached patch adds a description of the 'stxstattarget' column to pg_statistic_ext catalog's document. If there is a better explanation, please correct it. Regards, Noriyoshi Shinoda

RE: Multivariate MCV list vs. statistics target

2020-03-18 Thread Shinoda, Noriyoshi (PN Japan A&PS Delivery)
agree? Thank you for your comment. I agree with the text you suggested. Regards, Noriyoshi Shinoda -Original Message- From: Tomas Vondra [mailto:tomas.von...@2ndquadrant.com] Sent: Wednesday, March 18, 2020 9:36 PM To: Shinoda, Noriyoshi (PN Japan A&PS Delivery) Cc: Alvaro

RE: SLRU statistics

2020-04-01 Thread Shinoda, Noriyoshi (PN Japan A&PS Delivery)
Hi, Thank you for developing great features. The attached patch is a small fix to the committed documentation for the data type name of blks_hit column. Best regards, Noriyoshi Shinoda -Original Message- From: Tomas Vondra [mailto:tomas.von...@2ndquadrant.com] Sent: Thursday, April 2,

RE: pg_validatebackup -> pg_verifybackup?

2020-04-12 Thread Shinoda, Noriyoshi (PN Japan A&PS Delivery)
Hi, Sorry this email is not a discussion about word selection. Since part of the manual had left pg_validatebackup in commit dbc60c5593f26dc777a3be032bff4fb4eab1ddd1. I've attached a patch to fix this. Regards, Noriyoshi Shinoda -Original Message- From: Tom Lane [mailto:t...@sss.pgh.pa.

RE: Resetting spilled txn statistics in pg_stat_replication

2020-10-12 Thread Shinoda, Noriyoshi (PN Japan A&PS Delivery)
Hi, thank you for the awesome feature. As it may have been discussed, I think the 'name' column in pg_stat_replication_slots is more consistent with the column name and data type matched to the pg_replication_slots catalog. The attached patch changes the name and data type of the 'name' column t

RE: Resetting spilled txn statistics in pg_stat_replication

2020-10-12 Thread Shinoda, Noriyoshi (PN Japan A&PS Delivery)
, Noriyoshi (PN Japan A&PS Delivery) Cc: Amit Kapila ; Dilip Kumar ; Magnus Hagander ; Tomas Vondra ; PostgreSQL Hackers ; Ajin Cherian Subject: Re: Resetting spilled txn statistics in pg_stat_replication On Mon, 12 Oct 2020 at 18:29, Shinoda, Noriyoshi (PN Japan A&PS Delivery) wrote: >

RE: Resetting spilled txn statistics in pg_stat_replication

2020-10-13 Thread Shinoda, Noriyoshi (PN Japan A&PS Delivery)
anges only the column names and macros. Regards, Noriyoshi Shinoda -Original Message- From: Masahiko Sawada [mailto:masahiko.saw...@2ndquadrant.com] Sent: Tuesday, October 13, 2020 9:11 AM To: Shinoda, Noriyoshi (PN Japan A&PS Delivery) Cc: Amit Kapila ; Dilip Kumar ; Magnus Hagan

RE: Resetting spilled txn statistics in pg_stat_replication

2020-10-18 Thread Shinoda, Noriyoshi (PN Japan A&PS Delivery)
gards, Noriyoshi Shinoda -Original Message- From: Amit Kapila [mailto:amit.kapil...@gmail.com] Sent: Thursday, October 15, 2020 5:52 PM To: Masahiko Sawada Cc: Shinoda, Noriyoshi (PN Japan A&PS Delivery) ; Dilip Kumar ; Magnus Hagander ; Tomas Vondra ; PostgreSQL Hackers ; Ajin Cherian Subjec

RE: Resetting spilled txn statistics in pg_stat_replication

2020-10-20 Thread Shinoda, Noriyoshi (PN Japan A&PS Delivery)
uesday, October 20, 2020 9:24 PM To: Amit Kapila Cc: Shinoda, Noriyoshi (PN Japan A&PS Delivery) ; Dilip Kumar ; Magnus Hagander ; Tomas Vondra ; PostgreSQL Hackers ; Ajin Cherian Subject: Re: Resetting spilled txn statistics in pg_stat_replication On Tue, 20 Oct 2020 at 20:11, Amit Kapila wro

RE: Online checksums verification in the backend

2020-10-28 Thread Shinoda, Noriyoshi (PN Japan A&PS Delivery)
Hi, I have tested this great feature in the latest commit environment on Red Hat Enterprise Linux 7.8. I modified a few blocks in a relation file to raise a checksum error. When I executed the pg_relation_check_pages function, the backend terminated abnormally. The attached file is the operatio

RE: REINDEX CONCURRENTLY 2.0

2019-03-29 Thread Shinoda, Noriyoshi (PN Japan A&PS Delivery)
Hi hackers, I tried this great feature for partition index. The first time the REINDEX TABLE CONCURRENTLY statement is executed to the partition, then an error occurs. The second run succeeds but leaves an index with an INVALID status. I think this is not the desired behaviour. # TEST postgres

RE: pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side

2020-03-02 Thread Shinoda, Noriyoshi (PN Japan A&PS Delivery)
Hi, Thank you for developing good features. The attached patch is a small fix to the committed documentation. This patch fixes the description literal for the backup_streamed column. Regards, Noriyoshi Shinoda -Original Message- From: Fujii Masao [mailto:masao.fu...@oss.nttdata.com] S

[DOC] Fix for the missing pg_stat_progress_cluster view phase column value

2019-10-25 Thread Shinoda, Noriyoshi (PN Japan A&PS Delivery)
Hi, I found a missing column value in the pg_stat_progress_cluster view document. I read the src/backend/catalog/system_views.sql file, there seems to be a possibility that 'writing new heap' is output in the 'phase' column. The attached patch adds a description of the 'writing new heap' value o

RE: [DOC] Fix for the missing pg_stat_progress_cluster view phase column value

2019-10-28 Thread Shinoda, Noriyoshi (PN Japan A&PS Delivery)
2019 2:27 PM To: Shinoda, Noriyoshi (PN Japan A&PS Delivery) Cc: pgsql-hackers@lists.postgresql.org Subject: Re: [DOC] Fix for the missing pg_stat_progress_cluster view phase column value At Sat, 26 Oct 2019 05:13:49 +, "Shinoda, Noriyoshi (PN Japan A&PS Delivery)

psql small improvement patch

2019-12-07 Thread Shinoda, Noriyoshi (PN Japan A&PS Delivery)
Hi, Hackers. I propose a small improvement to the psql command. Currently, psql's help/quit/exit command needs to start from the first position of the prompt. For example, if you write a command after a space, the continuation prompt (PROMPT2) is displayed. --- postgres=> \set PROMPT2 'continue=

RE: psql small improvement patch

2019-12-07 Thread Shinoda, Noriyoshi (PN Japan A&PS Delivery)
Thank you very much for your comments. I seem to have thought easily. I will reconsider. Regards. -Original Message- From: Mark Dilger [mailto:hornschnor...@gmail.com] Sent: Sunday, December 8, 2019 12:20 AM To: Shinoda, Noriyoshi (PN Japan A&PS Delivery) ; pgsql-hac