On Thu, Aug 14, 2025 at 9:20 PM Kirill Reshke wrote:
>
> On Thu, 14 Aug 2025 at 16:13, Shinya Kato wrote:
>
> > This patch introduces a mode column to provide this visibility. The
> > possible values are:
> > - normal: A standard, user-initiated VACUUM or a regular
fully triggered the failsafe condition and the view reported
the correct mode. However, I found this test to be somewhat flaky in
my environment and decided not to add it to the patch to avoid
introducing a potentially unstable test into the tree.
Thought?
--
Best regards,
Shinya Kato
NTT OSS Center
oanalyze_min_duration = 0
Additionally, I removed the above setting from the test files in
src/test/modules/xid_wraparound/t/ (001_emergency_vacuum.pl,
002_limits.pl, 003_wraparounds.pl). The reason is that these tests
check for autovacuum logs, not autoanalyze logs. You can run the test
with the following command:
make check -C src/test/modules/xid_wraparound PG_TEST_EXTRA='xid_wraparound'
--
Best regards,
Shinya Kato
NTT OSS Center
v4-0001-Add-log_autoanalyze_min_duration.patch
Description: Binary data
On Wed, Aug 13, 2025 at 5:52 PM Shinya Kato wrote:
> > > I also noticed that ALTER SYSTEM RESET tab completes with all variables,
> > > not just ones that have been set with ALTER SYSTEM. Getting this right
> > > is a bit more complicated, since the only
On Wed, Aug 13, 2025 at 3:56 PM Shinya Kato wrote:
>
> On Sat, Aug 9, 2025 at 7:55 AM Dagfinn Ilmari Mannsåker
> wrote:
> >
> > Shinya Kato writes:
> >
> > > On Fri, Aug 1, 2025 at 2:16 AM Dagfinn Ilmari Mannsåker
> > > wrote:
> > >>
&
On Sat, Aug 9, 2025 at 7:37 AM Andres Freund wrote:
>
> Hi,
>
> On 2025-08-08 13:18:39 +0900, Shinya Kato wrote:
> > I would like to propose a series of patches that enhance the behavior
> > of various statistics reset functions by making them return the reset
> > t
On Sat, Aug 9, 2025 at 7:55 AM Dagfinn Ilmari Mannsåker
wrote:
>
> Shinya Kato writes:
>
> > On Fri, Aug 1, 2025 at 2:16 AM Dagfinn Ilmari Mannsåker
> > wrote:
> >>
> >> Dagfinn Ilmari Mannsåker writes:
> >>
> >> > I just notic
On Tue, Aug 12, 2025 at 4:25 PM Shinya Kato wrote:
> > + * However, SIMD optimization cannot be applied in the following
> > cases:
> > + * - Inside quoted fields, where escape sequences and closing
> > quotes
> > + * require sequential
On Thu, Aug 7, 2025 at 8:15 PM Nazir Bilal Yavuz wrote:
>
> Hi,
>
> Thank you for working on this!
>
> On Thu, 7 Aug 2025 at 04:49, Shinya Kato wrote:
> >
> > Hi hackers,
> >
> > I have implemented SIMD optimization for the COPY FROM (FORMAT {csv,
>
On Fri, Aug 8, 2025 at 5:06 PM Michael Paquier wrote:
>
> On Fri, Aug 08, 2025 at 01:18:39PM +0900, Shinya Kato wrote:
> > The following functions have been modified to return a TIMESTAMP WITH
> > TIME ZONE value indicating when the statistics were reset:
&
=dc9f8a798307244d791b71f666f50de319799e7c
--
Best regards,
Shinya Kato
NTT OSS Center
v1-0001-Make-pg_stat_reset-return-the-reset-time.patch
Description: Binary data
v1-0002-Make-pg_stat_reset_shared-return-the-reset-time.patch
Description: Binary data
v1-0003-Make-pg_stat_reset_single_table_counters
#x27;%s')"
I think the context IN ('user', 'superuser') condition is redundant
here. If a parameter's source is 'session', its context must be either
'user' or 'superuser'. Therefore, the source = 'session' check alone
should be sufficient.
--
Best regards,
Shinya Kato
NTT OSS Center
Therefore, I think it is better to just add "Also, the backup type is set."
> > (or similar) to the end of the comment block.
> >
> > That said, I'm not a native English speaker, so if no one else sees a
> > problem,
> > I'm fine with it.
>
> Agreed. I've changed the comment and pushed the patch.
>
> Regards,
>
> --
> Masahiko Sawada
> Amazon Web Services: https://aws.amazon.com
Thanks for pushing it!
--
Best regards,
Shinya Kato
NTT OSS Center
On Sat, Aug 2, 2025 at 8:12 AM Masahiko Sawada wrote:
>
> On Tue, Jul 22, 2025 at 2:42 AM Shinya Kato wrote:
> >
> > On Tue, Jul 22, 2025 at 6:06 PM Yugo Nagata wrote:
> > >
> > > On Tue, 22 Jul 2025 17:48:35 +0900
> > > Shinya Kato wrote:
>
On Tue, Jul 22, 2025 at 6:06 PM Yugo Nagata wrote:
>
> On Tue, 22 Jul 2025 17:48:35 +0900
> Shinya Kato wrote:
>
> > Hi hackers,
> >
> > Starting with PostgreSQL 17, pg_basebackup supports incremental
> > backups. However, the pg_stat_progress_basebackup
While
this information is available in pg_stat_activity, the backup type is
important for monitoring the progress of pg_basebackup, and including
it directly in the progress view would be very useful.
Thoughts?
--
Best regards,
Shinya Kato
NTT OSS Center
v1-0001-Add-back
nk it's better to declare structs at the top of the file. What do
you think?
I'm still not sure how to use read_stream, so I don't have any
comments on read_stream at this time.
--
Best regards,
Shinya Kato
NTT OSS Center
On Thu, Jul 3, 2025 at 3:32 PM Fujii Masao wrote:
>
>
>
> On 2025/07/03 11:08, Shinya Kato wrote:
> > On Wed, Jul 2, 2025 at 4:48 PM Fujii Masao
> > wrote:
> >
> >>>> Regarding the documentation, how about explicitly stating that when
> >&g
is set to..." is repeated three times in the
> current text.
> For the second and third instances, we could simplify it to just "if set
> to...".
Agreed. However, for the sake of symmetry between "On output" and "On
input" and to maintain clarity between
On Mon, Jun 23, 2025 at 4:24 PM Shinya Kato wrote:
>
> On Wed, Jun 11, 2025 at 1:49 PM Shinya Kato wrote:
>>
>> On Thu, Jun 5, 2025 at 3:53 AM Sami Imseih wrote:
>>>
>>> > Approach 2:
>>> > - log_autovacuum_min_duration: Changed beh
ew. The change looks good to me, too. A new
patch is attached.
> Regarding the documentation, how about explicitly stating that when MATCH is
> specified, only
> the first line is skipped? While this may seem obvious, it’s worth
> clarifying, as the semantics
> of the HEADER option have become a bit more complex with this change.
Agreed. I have updated the documentation as follows:
+ lines are discarded. If the option is set to MATCH,
+ the number and names of the columns in the header line must exactly
+ match those of the table and, in order, after which the header line is
+ discarded; otherwise an error is raised. The MATCH
--
Best regards,
Shinya Kato
NTT OSS Center
v4-0001-Add-support-for-multi-line-header-skipping-in-COP.patch
Description: Binary data
On Fri, Jun 27, 2025 at 12:03 AM Fujii Masao
wrote:
>
>
> On 2025/06/26 19:12, Shinya Kato wrote:
> > On Thu, Jun 26, 2025 at 4:36 PM Fujii Masao <mailto:masao.fu...@oss.nttdata.com>> wrote:
> >
> > On 2025/06/26 14:35, Shinya Kato wrote:
> >
On Thu, Jun 26, 2025 at 4:36 PM Fujii Masao
wrote:
> On 2025/06/26 14:35, Shinya Kato wrote:
> >
> > > > So it seems better for you to implement the patch at first and then
> > > > check the performance overhead etc if necessary.
> > >
> > &g
oaded
and will not return an error. This is the same behavior as specifying
HEADER true for a CSV file that has zero rows.
And I will add this patch for the next CF.
Thoughts?
--
Best regards,
Shinya Kato
NTT OSS Center
v1-0001-Add-support-for-multi-line-header-skipping-in-COP.patch
Description: Binary data
On Wed, Jun 11, 2025 at 1:49 PM Shinya Kato wrote:
> On Thu, Jun 5, 2025 at 3:53 AM Sami Imseih wrote:
>
>> > Approach 2:
>> > - log_autovacuum_min_duration: Changed behavior, which controls only
>> > autovacuum logging.
>> > - log_autoanalyze_m
more flexible.
>
My concern is less about turning autovacuum and autoanalyze logs on or off
individually, and more about the fact that setting a large value for
log_autovacuum_min_duration prevents autoanalyze logs from being recorded.
--
Best regards,
Shinya Kato
NTT OSS Center
ple, the target columns could be on the first
line, with explanations or sub-columns on the lines that follow.
Considering this, the patch would become too complicated, so I'd like to
keep this out of scope. What do you think?
--
Best regards,
Shinya Kato
NTT OSS Center
at first and then
> check the performance overhead etc if necessary.
Thank you for your advice. I will create a patch.
--
Best regards,
Shinya Kato
NTT OSS Center
On Tue, Jun 10, 2025 at 2:34 PM Fujii Masao wrote:
>
>
>
> On 2025/06/10 9:43, Shinya Kato wrote:
> >>> Howe
multi-line headers
(although I don't personally think this is desirable). Furthermore,
various systems sometimes generate reports as CSV files that
unexpectedly contain multiple header lines.
--
Best regards,
Shinya Kato
NTT OSS Center
; [1]
> https://postgr.es/m/calay4q8ngsxp0p5uf56vn-md7rewqzp5k6ps1cgum26x4fs...@mail.gmail.com
Oh, I missed it. I will check it soon.
--
Best regards,
Shinya Kato
NTT OSS Center
ver17#firstrow--first_row
[3]
https://docs.oracle.com/en/database/oracle/oracle-database/23/sutil/oracle-sql-loader-commands.html#SUTIL-GUID-84244C46-6AFD-412D-9240-BEB0B5C2718B
--
Best regards,
Shinya Kato
NTT OSS Center
just have an extra case for it, like in the
> attached patch. A split already exists for temporary tables to handle
> the ON COMMIT clause after the attribute list.
>
> Thoughts?
Thank you. It looks good to me.
--
Best regards,
Shinya Kato
NTT OSS Center
>
>>
>>
>> On 2025/06/04 4:32, Sami Imseih wrote:
>> >> On Tue, Jun 03, 2025 at 10:57:11AM +0200, Michael Banck wrote:
>> >>> On Tue, Jun 03, 2025 at 05:25:40PM +0900, Shinya Kato wrote:
>> >>>> I surely think adding log_autoanalyze_min_d
On Wed, Jun 4, 2025 at 6:55 PM Shinya Kato wrote:
>
> On Wed, Jun 4, 2025 at 6:42 PM Michael Paquier wrote:
> >
> > On Thu, Sep 19, 2024 at 01:08:33PM +0900, Michael Paquier wrote:
> > > I have applied 0001 for now to add ATT_PARTITIONED_TABLE. Attached is
> > &
b2d79204.
> --
> Michael
Hi,
Should we consider preventing tab completion for PARTITION BY
immediately after CREATE TABLE name (...)? Or is it fine to leave it
as is, given that it's syntactically correct?
--
Best regards,
Shinya Kato
NTT OSS Center
ion.
In v1-0002-Add-log_autovacuum_analyze_min_duration.patch, add the new
GUC parameter log_autovacuum_analyze_min_duration.
Do you think?
Best regards,
Shinya Kato
NTT OSS Center
v1-0002-Add-log_autovacuum_analyze_min_duration.patch
Description: Binary data
v1-0001-Rename-log_autovacuum_min_duration.patch
Thank you for the comment!
On Tue, Jun 3, 2025 at 4:42 PM Michael Banck wrote:
>
> Hi,
>
> On Tue, Jun 03, 2025 at 03:35:20PM +0900, Shinya Kato wrote:
> > I am proposing the introduction of two new GUC parameters,
> > log_autovacuum_{vacuum|analyze}_min_duration,
On 2025-01-26 02:45, Tom Lane wrote:
Robert Treat writes:
On Wed, Jan 22, 2025 at 8:02 AM Shinya Kato
wrote:
I agree to it and fixed the patch.
LGTM
LGTM too. Pushed with a couple of very minor tweaks.
regards, tom lane
Thank you for pushing!
--
Regards
f -h and other short-form switches. We can write the added
paragraphs like
It is generally recommended to use the -X
(--no-psqlrc) option when restoring a database ...
to provide clarity about what the switch does.
I agree to it and fixed the patch.
--
Regards,
Shinya Kato
NTT D
ension the application admins (or whoever)
> may create, but that is another topic I think.
To use a certain extension, you may need to install the
postgresql-contrib package. In that case, is there a way to restrict
extensions other than the required one? Or is it unnecessary to impose
such restrictions?
Regards,
Shinya Kato
On 2024-10-10 14:56, Shinya Kato wrote:
A new patch is attached.
I am not a native English, so corrections to the texts are welcome.
I created a commit fest entry.
https://commitfest.postgresql.org/50/5306/
--
Regards,
Shinya Kato
NTT DATA GROUP CORPORATION
:
> >> On Wed, 09 Oct 2024 11:10:37 +0900
> >> Shinya Kato wrote:
> >>> When SQL scripts created with pg_dump/pg_dumpall/pg_restore are
> executed
> >>> in psql with AUTOCOMMIT turned off, they will not succeed in many
> cases.
>
> > Agreed.
AUTOCOMMIT on to the scripts created by
pg_dump/pg_dumpall/pg_restore, they will work fine.
A patch is attached
No documentation has been added as we could not find any documentation
on the details in the script.
Do you think?
Regards,
Shinya Kato
NTT DATA GROUP CORPORATIONFrom
On 2024-02-01 17:33, Michael Paquier wrote:
On Thu, Jan 11, 2024 at 06:18:38PM +0900, Shinya Kato wrote:
Hi, hackers
(Sorry for the delay, this thread was on my TODO list for some time.)
There is below description in docs for stats_fetch_consistency.
"Changing this parameter in a transa
wal_bytes
-+-+---
23592 | 628 | 5939027
(1 row)
--
I can see similar cases in pg_stat_archiver, pg_stat_bgwriter,
pg_stat_checkpointer, pg_stat_io, and pg_stat_slru.
Is it a bug? I fixed it, and do you think?
--
Regards,
Shinya Kato
NTT DATA GROUP CORPORATION
lock detector". I don't know if we want to go there.
Personally, I thought it was a good idea to separate log_lock_waits and
deadlock_timeout, but I have not checked how that is implemented.
--
Regards,
Shinya Kato
NTT DATA GROUP CORPORATION
rgument of BUFFER_USAGE_LIMIT can accept.
You can see the patch in the attached file.
Thanks for the patch.
You're right. It looks good to me.
--
Regards,
Shinya Kato
NTT DATA GROUP CORPORATION
16403 | 16401 | 16400 | 16400 | f | t | t
(2 rows)
---
Attached patch resolves this issue.
Do you think?
Regards,
Shinya Kato
diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c
index 058e41e749..8aeb669100 100644
--- a/src/bin/psql/describe.c
+++ b/src/bin/psql/describe
On 2022-09-14 18:12, bt22kawamotok wrote:
I fixed it in v6.
Thanks for updating.
+ COMPLETE_WITH("UPDATE", "DELETE", "DO NOTHING");
"UPDATE" is always followed by "SET", so why not complement it with
"UPDATE SET"?
ilMatches("WHEN", "MATCHED") ||
warning: 4 lines add whitespace errors.
--
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
you to fix them.
For example,
else if (TailMatches("WHEN", "MATCHED"))
COMPLETE_WITH("THEN", "AND");
else if (TailMatches("WHEN", "NOT", "MATCHED"))
COMPLETE_WITH("THEN", "AND");
above statement can be converted to the statement below.
else if (TailMatches("WHEN", "MATCHED") ||
TailMatches("WHEN", "NOT", "MATCHED"))
COMPLETE_WITH("THEN", "AND");
--
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
WHEN") ||
TailMatches("USING", MatchAny, "AS", MatchAny, "ON", MatchAny,
"WHEN") ||
TailMatches("USING", MatchAny, MatchAny, "ON", MatchAny,
"WHEN"))
COMPLETE_WITH("MATCHED", "NOT MATCHED");
There are similar redundancies in the tab completion of MERGE statement,
so why not fix that as well?
--
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
t as ready for committer.
--
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
tch!
A minor modification has been made so that the composite type is also
completed after "ALTER TABLE OF".
Thought?
--
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATIONdiff --git a/src/bin/psql/tab-complete.c
"ALTER TABLE NOT OF"?
--
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2022-08-26 14:07, Kyotaro Horiguchi wrote:
At Fri, 26 Aug 2022 10:23:01 +0900, Shinya Kato
wrote in
I've found typos in ja.po, and fixed them.
The patch is attached.
(This is not for -hackers but I'm fine with it being posted here;p)
Sorry, I didn't know there was an pg
Hi hackers,
I've found typos in ja.po, and fixed them.
The patch is attached.
--
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATIONdiff --git a/src/backend/po/ja.po b/src/backend/po/ja.po
index 0925465d22..189000792c 1
On 2022-08-24 20:47, David Rowley wrote:
On Wed, 24 Aug 2022 at 22:44, Shinya Kato
wrote:
I've found a duplicate "a a" in func.sgml and fixed it.
Patch is attached.
Thanks. Pushed.
David
Thanks for pushing!
--
Regards,
--
Shinya Kato
Advanced Computing Technology Cent
Hi hackers,
I've found a duplicate "a a" in func.sgml and fixed it.
Patch is attached.
--
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATIONdiff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
i
and subcategory is none at
postgresql.conf.sample.
--
Trivial changes were made to the following short_desc.
--
recovery_prefetch
enable_group_by_reordering
stats_fetch_consistency
--
I've attached a patch.
Thoghts?
--
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research and Development
es but this is not.
Sorry, I didn't quite understand the "fancier" pattern. Is a string like
this patch correct?
--
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATIONdiff --git a/doc/src/sgml/ref/createuser.
, this means to extend the tests to process lists for
--admin with more name patterns. And while on it, we could do the
same for the existing command for --role, but this one is on me, being
overly-pedantic while looking at the patch :)
Thanks! I fixed it.
--
Regards,
--
Shinya Kato
Advanced
k fancier string
patterns, while on it, to look after the use of fmtId(), say with
role names that include whitespaces or such.
Thanks!
I changed to the test that describes multiple "-m".
It seems to be working without any problems, how about it?
--
Regards,
--
Shinya Kato
Advanced
On 2022-05-21 06:45, Nathan Bossart wrote:
On Thu, May 19, 2022 at 10:35:23AM +0900, Shinya Kato wrote:
I created a new patch to test the new options!
Thanks for the new patch! I attached a new version with a few small
changes. What do you think?
Thanks for updating the patch!
It looks
n
about the new DB user.
psql is scary for some. :-)
Since the createuser command is a wrapper for the CREATE ROLE command, I
do not think it is appropriate to add options that the CREATE ROLE
command does not have.
--
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research
k "-m / --member" is the best choice, although it is
ambiguous:(
I'd like to hear others' opinions.
regards
--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATIONdiff --git a/doc/src/sgml/ref/createuser.sgml b/
On 2022-04-14 18:57, Daniel Gustafsson wrote:
On 14 Apr 2022, at 09:42, Shinya Kato
wrote:
To add the ROLE clause, the originally existing --role option
(corresponding to the IN ROLE clause) is changed to the --in-role
option. Would this not be good from a backward compatibility
standpoint
far as schedules are concerned, I don't think this has anything to
do with 15.
I have registered this patch for the July commit fest.
--
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATIONdiff --git a/doc/src/sgml/ref
?
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATIONdiff --git a/doc/src/sgml/ref/createuser.sgml b/doc/src/sgml/ref/createuser.sgml
index 17579e50af..6c2ee1e0c6 100644
--- a/doc/src/sgml/ref/createuser.sgml
+++ b/doc/sr
*/
4. In connection.c, There is a typo in line 1684, so "fucntion" should
be changed to "function".
Maybe all of them were fixed. Thanks!
Thank you, and it looks good to me.
--
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
me.
I'm tempted to propose that we also rename EmitWarningsOnPlaceholders
to something like MarkGUCPrefixReserved, to more clearly reflect
what it does now. (We could provide the old name as a macro alias
to avoid breaking extensions needlessly.)
+1
--
Regards,
--
Shinya Kato
Advanced Computing
On 2021-12-22 02:23, Tom Lane wrote:
Kyotaro Horiguchi writes:
At Mon, 20 Dec 2021 21:05:23 +0900, Shinya Kato
wrote in
We should use EmitWarningsOnPlaceholders when we use
DefineCustomXXXVariable.
I don't think there is any room for debate.
Unfortunately, pltcl.c defines variables
On 2021-12-17 15:42, Peter Eisentraut wrote:
On 17.12.21 03:25, Shinya Kato wrote:
For now, I'v attached the patch that fixed the compilation error.
I think it would be good if you could split the uncontroversial new
EmitErrorsOnPlaceholders() calls into a separate patch. And please
a
On 2021-12-17 01:55, Fujii Masao wrote:
On 2021/12/16 16:31, Shinya Kato wrote:
Thank you for the review and sorry for the late reply.
On 2021-11-16 19:25, Bharath Rupireddy wrote:
> I observed an odd behaviour:
> 1) I set postgres_fdw.XXX = 'I_messed_up_conf_file' in pos
cording to [1], we used the same function name, but the warning level
was INFO.
Therefore, I think it is OK to use the same function name.
[1]
https://www.postgresql.org/message-id/flat/200901051634.n05GYNr06169%40momjian.us#1d045374f014494e4b40a4862a000723
--
Regards,
--
Shinya Kato
A
servers while reading messages.
*/
to
/*
* Skip checking foreign servers while reading messages.
*/
4. In connection.c, There is a typo in line 1684, so "fucntion" should
be changed to "
the rest of the code, it is a good idea to enclose the
server name in double quotes.
I'll get back to you once I've read all the code.
[1] https://www.postgresql.org/docs/devel/error-style-guide.html
--
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
ird
party extensions.
I plan to change to emit an error when an invalid custom GUC is set in
the SET or ALTER SYSTEM SET commands, but I haven't tackled this yet.
The patch as of now is attached.
--
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research and Development He
t should not be attached because cfbot cannot understand
such a dependency
and will throw build error. Do you know how to deal with them in this
case?
I don't know how to deal with them, but I hope you will attach the PoC,
as it may be easier to review.
--
Regards,
--
Shinya Kato
Advanced
riables in src/pl/tcl/pltcl.c which probably should get this
treatment as
well, it would align it with the pl/perl counterpart.
I'll have a closer look and test tomorrow.
Thank you for the review!
I have missed src/pl/tcl/pltcl.c, so I created the new patch.
--
Regards,
--
Shinya Kato
Adv
-14 18:18:16.486 JST [487067] WARNING: unrecognized
configuration parameter "auth_delay.xxx"
---
What do you think?
--
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATIONdiff --git a/contrib/auth_delay/auth_delay.c
On 2021-10-28 07:21, Mark Dilger wrote:
On Oct 25, 2021, at 10:09 PM, Shinya Kato
wrote:
Hi! Thank you for the patch.
I too think that CREATEROLE escalation attack is problem.
I have three comments.
1. Is there a function to check the owner of a role, it would be nice
to be able to check
.
Thank you for the detailed explanation.
I now understand what you said.
--
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2021-10-28 07:21, Mark Dilger wrote:
On Oct 25, 2021, at 10:09 PM, Shinya Kato
wrote:
Hi! Thank you for the patch.
I too think that CREATEROLE escalation attack is problem.
I have three comments.
1. Is there a function to check the owner of a role, it would be nice
to be able to check
On 2021-10-27 14:45, Michael Paquier wrote:
On Tue, Oct 26, 2021 at 05:04:24PM +0900, Shinya Kato wrote:
Barring any objection, I will change status to Ready for Committer.
+ else if (Matches("COMMENT", "ON", "PROCEDURAL"))
+ COMPLETE_WITH("LANGUA
On 2021-10-15 17:49, Ken Kato wrote:
2021-10-15 13:29 に Shinya Kato さんは書きました:
On 2021-10-14 14:30, katouknl wrote:
It is very good, but it seems to me that there are some
tab-completion
missing in COMMENT command.
For example,
- CONSTRAINT ... ON DOMAIN
- OPERATOR CLASS
- OPERATOR FAMILY
CT]" like "DROP TABLE [ IF EXISTS ] name [,
...] [ CASCADE | RESTRICT ]". What do you think?
--
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
) IS 'test_success';
COMMENT
---
So, I think as with \do command, you do not need to complete the
operators.
Do you think?
--
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
PERATOR FAMILY
- POLICY ... ON
- [PROCEDURAL]
- RULE ... ON
- TRIGGER ... ON
I think these tab-comletion also can be improved and it's a good timing
for that.
--
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
uot; UNION SELECT
'TABLE'" " UNION SELECT 'ONLY'");
warning: 1 line adds whitespace errors.
---
2. The command "LOCK TABLE a, b;" can be executed, but tab-completion
doesn't work properly. Is it OK?
--
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
90 matches
Mail list logo
