Re: [HACKERS] GSoC 2017: weekly progress reports (week 6)

2018-03-16 Thread Shubham Barai
On 16 March 2018 at 03:57, Alexander Korotkov wrote: > On Tue, Mar 13, 2018 at 3:25 PM, Alvaro Herrera > wrote: > >> Alexander Korotkov wrote: >> >> > And what happen if somebody concurrently set (fastupdate = on)? >> > Can we miss conflicts because of that? >> >> I think it'd be better to have

Re: [HACKERS] GSoC 2017: weekly progress reports (week 6)

2018-03-08 Thread Shubham Barai
On 07-Mar-2018 11:00 PM, "Alvaro Herrera" wrote: I suggest to create a new function GinPredicateLockPage() that checks whether fast update is enabled for the index. The current arrangement looks too repetitive and it seems easy to make a mistake. Stylistically, please keep #include lines ordere

Re: [HACKERS] GSoC 2017: weekly progress reports (week 6)

2018-02-28 Thread Shubham Barai
On 28 February 2018 at 05:51, Thomas Munro wrote: > On Wed, Jan 3, 2018 at 4:31 AM, Shubham Barai > wrote: > > I have created new isolation tests. Please have a look at > > updated patch. > > Hi Shubham, > > Could we please have a rebased version of the gin o

Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index

2018-01-25 Thread Shubham Barai
On 25 January 2018 at 18:40, Alexander Korotkov wrote: > On Wed, Jan 10, 2018 at 9:55 PM, Shubham Barai > wrote: > >> The previous patch couldn't be applied cleanly because there were some >> modifications to isolation_schedule. I have updated the patch now. &g

Re: [HACKERS] GSoC 2017: weekly progress reports (week 4) and patch for hash index

2018-01-15 Thread Shubham Barai
On 15 January 2018 at 08:03, Stephen Frost wrote: > Greeting Shubham, all, > > * Michael Paquier (michael.paqu...@gmail.com) wrote: > > On Mon, Sep 25, 2017 at 10:34 PM, Shubham Barai > > wrote: > > > I have attached the rebased version of patch here. > > &g

Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index

2018-01-10 Thread Shubham Barai
On 8 January 2018 at 23:13, Shubham Barai wrote: > > > On 8 January 2018 at 22:44, Shubham Barai > wrote: > >> >> >> On 5 January 2018 at 03:18, Alexander Korotkov > > wrote: >> >>> On Thu, Jan 4, 2018 at 7:07 PM, Andrey Borodin >&g

Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index

2018-01-08 Thread Shubham Barai
On 8 January 2018 at 22:44, Shubham Barai wrote: > > > On 5 January 2018 at 03:18, Alexander Korotkov > wrote: > >> On Thu, Jan 4, 2018 at 7:07 PM, Andrey Borodin >> wrote: >> >>> 29 нояб. 2017 г., в 22:50, Shubham Barai >>> написал(а): &g

Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index

2018-01-08 Thread Shubham Barai
On 5 January 2018 at 03:18, Alexander Korotkov wrote: > On Thu, Jan 4, 2018 at 7:07 PM, Andrey Borodin > wrote: > >> 29 нояб. 2017 г., в 22:50, Shubham Barai >> написал(а): >> >> I have fixed formatting style. Please take a look at updated patch. >> >

Re: [HACKERS] GSoC 2017: weekly progress reports (week 6)

2018-01-02 Thread Shubham Barai
On 2 October 2017 at 22:21, Alexander Korotkov wrote: > On Sun, Oct 1, 2017 at 11:53 AM, Shubham Barai > wrote: > >> Yes, page-level predicate locking should happen only when fast update is >> off. >> Actually, I forgot to put conditions in updated patch. Does

Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index

2017-11-29 Thread Shubham Barai
On 27 November 2017 at 13:17, Alexander Korotkov wrote: > Hi, Shubham! > > On Wed, Nov 1, 2017 at 12:10 AM, Shubham Barai > wrote: > >> On 9 October 2017 at 18:57, Alexander Korotkov > > wrote: >> >>> Now, ITSM that predicate locks and conflict checks