Re: Doc of typmod arg perhaps deserves an update

2024-10-11 Thread Steve Lau
Hi Did you post the wrong link? This one looks same as the one I mentioned. Though I realized that you have replied to this thread: https://www.postgresql.org/message-id/56EA3507.6090701%40anastigmatix.net Regards, Steve. > On Oct 11, 2024, at 8:42 PM, Chapman Flack wrote: > > On

Doc of typmod arg perhaps deserves an update

2024-10-10 Thread Steve Lau
. However, it surprises me that it could also be unknown if your type needs type modifiers and the type modifiers have been successfully stored in the metadata. So I think we could elaborate on this a bit. Regards, Steve.

Re: Unknown annotation '-cim' in source code

2024-07-04 Thread Steve Lau
On Jul 4, 2024, at 4:33 PM, Alvaro Herrera wrote: On 2024-Jul-04, Tom Lane wrote: "David G. Johnston" writes: On Wed, Jul 3, 2024 at 8:46 PM Steve Lau wrote: While reading the source code, I noticed comments like "-cim 9/10/89". It's the initials of the person who

Re: Unknown annotation '-cim' in source code

2024-07-03 Thread Steve Lau
On Jul 4, 2024, at 12:16 PM, David G. Johnston wrote: On Wed, Jul 3, 2024 at 8:46 PM Steve Lau mailto:stevel...@outlook.com>> wrote: While reading the source code, I noticed comments like "-cim 9/10/89". I think this might be an annotation by a developer to indicate the

Unknown annotation '-cim' in source code

2024-07-03 Thread Steve Lau
al context you can provide regarding these annotations. Thank you! Best regards, Steve Lau.

Re: psql: add \create_function command

2024-03-10 Thread Steve Chavez
age-id/flat/CAGRrpzZU48F2oV3d8eDLr=4tu9xfh5jt9ed+qu1+x91gmh6...@mail.gmail.com Would be great to have the above fix reviewed/committed to keep making progress here. Besides that, since :{ is already sort of a prefix for psql functions, how about having `:{file()}`? That would be clearer than :{+ or :{{. Best reg

psql: fix variable existence tab completion

2024-03-02 Thread Steve Chavez
Hello hackers, psql has the :{?name} syntax for testing a psql variable existence. But currently doing \echo :{?VERB doesn't trigger tab completion. This patch fixes it. I've also included a TAP test. Best regards, Steve Chavez From adb1f997b67d8ef603017ab34e1b9061e4e229ea Mon Sep 1

Re: psql: add \create_function command

2024-01-29 Thread Steve Chavez
ear that you're using a file path, e.g. :{filename} vs :./filename. Examples: select jsonb_to_recordset(:./contents.json); create function foo() returns text AS :/absolute/path/contents.py language plpython3u; Any thoughts? Best regards, Steve Chavez On Mon, 29 Jan 2024 at 08:42, Andrew D

psql: add \create_function command

2024-01-26 Thread Steve Chavez
GUAGE plpython3u Its design is similar to the `\copy` command, which is a frontend version of the COPY statement. This patch is at an initial stage but includes tests with plpython3u, pltcl, plperl and tab completion. Any feedback is welcomed. Best regards, Steve Chavez

Re: Add pg_basetype() function to obtain a DOMAIN base type

2023-09-19 Thread Steve Chavez
aring any feedback. Or if this would be a bad idea. Best regards, Steve Chavez On Sat, 9 Sept 2023 at 01:17, Steve Chavez wrote: > Hello hackers, > > Currently obtaining the base type of a domain involves a somewhat long > recursive query. Consider: > > ``` > create domai

Add pg_basetype() function to obtain a DOMAIN base type

2023-09-08 Thread Steve Chavez
that exposes a `pg_basetype` SQL function that uses `getBaseType`, so the long query above just becomes: ``` select pg_basetype('mytext_child_2'::regtype); pg_basetype - text (1 row) ``` Tests and docs are added. Best regards, Steve Chavez From 9be553c2a3896c12d959bc722a808

Fwd: Castable Domains for different JSON representations

2023-06-26 Thread Steve Chavez
mple table create table mytbl(id int, val mytsrange); insert into mytbl values (1, '(2022-12-31 11:00, 2023-01-01 06:00)'); This output is directly consumable on web applications and as you can see the expression is pretty short, with no need to use the explicit casts as `json_agg` already does them internally. Best regards, Steve

Castable Domains for different JSON representations

2023-06-25 Thread Steve Chavez
gnored because the source data type is a domain CREATE CAST Checking the code seems supporting this is a TODO? Or are there any other concerns of why this shouldn't be done? I would like to work on this if there is an agreement. Best regards, Steve

Re: 'converts internal representation to "..."' comment is confusing

2023-06-25 Thread Steve Chavez
Hello hackers, Tom, could we apply this patch since Robert agrees it's an improvement? Best regards, Steve On Tue, 16 May 2023 at 07:49, Robert Haas wrote: > On Sun, May 14, 2023 at 9:37 PM Tom Lane wrote: > > Steve Chavez writes: > > > I found "..." co

Re: 'converts internal representation to "..."' comment is confusing

2023-05-14 Thread Steve Chavez
Thanks a lot for the clarification! The "..." looks enigmatic right now. I think cstring would save newcomers some head-scratching. Open to suggestions though. Best regards, Steve On Sun, 14 May 2023 at 22:36, Tom Lane wrote: > Steve Chavez writes: > > I found &quo

Re: Using make_ctags leaves tags files in git

2023-05-14 Thread Steve Chavez
e it's reasonable to ignore these as they're produced by make_ctags. Best regards, Steve On Sun, 14 May 2023 at 20:44, Michael Paquier wrote: > On Sun, May 14, 2023 at 06:13:21PM -0300, Steve Chavez wrote: > > I use postgres/src/tools/make_ctags and it works great. But it leaves t

Using make_ctags leaves tags files in git

2023-05-14 Thread Steve Chavez
Hello hackers, I use postgres/src/tools/make_ctags and it works great. But it leaves the tags files ready to be committed in git. So, I've added 'tags' to .gitignore. Best regards, Steve

'converts internal representation to "..."' comment is confusing

2023-05-14 Thread Steve Chavez
Hello hackers, I found "..." confusing in some comments, so this patch changes it to "cstring". Which seems to be the intention after all. Best regards, Steve From cb1792c45ea9a2fbd2c08e185653b60dc262a17d Mon Sep 17 00:00:00 2001 From: steve-chavez Date: Sun, 14 May 2023 18

Re: Allow placeholders in ALTER ROLE w/o superuser

2022-11-22 Thread Steve Chavez
simpler. So from my side this all looks good! Best regards, Steve On Sun, 20 Nov 2022 at 12:50, Alexander Korotkov wrote: > .On Sun, Nov 20, 2022 at 8:48 PM Alexander Korotkov > wrote: > > I've drafted a patch implementing ALTER ROLE ... SET ... TO ... USER SET > syntax. &g

csv_populate_recordset and csv_agg

2022-10-23 Thread Steve Chavez
good idea. I see there's already some code that deals with CSV on - src/backend/commands/copyfromparse.c(CopyReadAttributesCSV) - src/fe_utils/print.c(csv_print_field) - src/backend/utils/error/csvlog(write_csvlog) So perhaps a new csv module could benefit the codebase as well. Best reg

Re: Allow placeholders in ALTER ROLE w/o superuser

2022-07-18 Thread Steve Chavez
applied at login time right? So at this point we can WARN or ERR about the defined role GUCs. What do you think? On Mon, 18 Jul 2022 at 19:03, Nathan Bossart wrote: > On Fri, Jul 01, 2022 at 04:40:27PM -0700, Nathan Bossart wrote: > > On Sun, Jun 05, 2022 at 11:20:38PM -0500, Steve Chavez

Fwd: Add red-black tree missing comparison searches

2022-07-06 Thread Steve Chavez
-- Forwarded message - From: Steve Chavez Date: Wed, 6 Jul 2022 at 18:14 Subject: Re: Add red-black tree missing comparison searches To: Alexander Korotkov Thanks Alexander! wrt to the new patch. I think the following comment is misleading since keyDeleted can be true or false

Re: Add red-black tree missing comparison searches

2022-07-02 Thread Steve Chavez
e! On Thu, 30 Jun 2022 at 14:34, Alexander Korotkov wrote: > Hi, Steve! > > Thank you for working on this. > > On Thu, Jun 30, 2022 at 7:51 PM Steve Chavez wrote: > > Currently the red-black tree implementation only has an equality search. > Other extensions might need o

Re: Add red-black tree missing comparison searches

2022-06-30 Thread Steve Chavez
Yes, I've already added it here: https://commitfest.postgresql.org/38/3742/ Thanks! On Thu, 30 Jun 2022 at 12:09, Greg Stark wrote: > Please add this to the commitfest at > https://commitfest.postgresql.org/38/ so it doesn't get missed. The > commitfest starts imminently so best add it today. >

Add red-black tree missing comparison searches

2022-06-30 Thread Steve Chavez
eemed worth it. Also I refactored the sentinel used in the rbtree.c to use C99 designators. Thanks in advance for any feedback! -- Steve Chavez Engineering at https://supabase.com/ From 85435fe0fad92d593940f98a493d1acd973ccda2 Mon Sep 17 00:00:00 2001 From: steve-chavez Date: Tue, 28 Jun 2022

Allow placeholders in ALTER ROLE w/o superuser

2022-06-05 Thread Steve Chavez
fect permission checking when an extension defines its custom GUC variables. DefineCustomStringVariable("my.custom", NULL, NULL, &my_custom, NULL, PGC_SUSET, ..); Using PGC_SUSET or PGC_SIGHUP will fail accordingly. Also no tests fail when doing "make installcheck". ---

Re: Assert name/short_desc to prevent SHOW ALL segfault

2022-05-25 Thread Steve Chavez
Thank you for the reviews Nathan, Michael. I agree with handling NULL in ShowAllGUCConfig() instead. I've attached the updated patch. -- Steve Chavez Engineering at https://supabase.com/ On Tue, 24 May 2022 at 20:21, Michael Paquier wrote: > On Tue, May 24, 2022 at 11:41:49AM -0700

Assert name/short_desc to prevent SHOW ALL segfault

2022-05-24 Thread Steve Chavez
with --enable-cassert can prevent the above issue. --- Steve Chavez Engineering at https://supabase.com/ From ad8a61125a0fe33853d459f12e521dff771130d4 Mon Sep 17 00:00:00 2001 From: Steve Chavez Date: Thu, 19 May 2022 08:59:46 -0500 Subject: [PATCH] Assert name/short_desc to prevent SHOWALL seg

Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly

2019-11-23 Thread Steve Singer
On Wed, 20 Nov 2019, Alexey Kondratov wrote: Hi Steve, Thank you for review. I've looked through the patch and tested it. I don't see any issues with this version. I think it is ready for a committer. Regards -- Alexey Kondratov Postgres Professional https://www.postg

Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly

2019-11-16 Thread Steve Singer
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, failed Spec compliant: not tested Documentation:tested, failed * I had to replace heap_open/close with table_open/close to get t

Re: TCP Wrappers

2019-10-09 Thread Steve Crawford
Its security will be better. > > The last stable release of TCP Wrappers was a couple decades ago. It's deprecated in RHEL7 and removed in RHEL8. I'm not a PG core member or anything but rather doubt that's an area where the developers will want to expend effort. Cheers, Steve

Re: PG 12 beta 1 segfault during analyze

2019-06-18 Thread Steve Singer
On 6/18/19 12:32 AM, Tom Lane wrote: Steve Singer writes: The attached patch fixes the issue. Hmm, that's a pretty obvious mistake :-( but after some fooling around I've not been able to cause a crash with it. I wonder what test case you were using, on wha

Re: PG 12 beta 1 segfault during analyze

2019-06-17 Thread Steve Singer
On 6/15/19 10:18 PM, Tom Lane wrote: Steve Singer writes: I encountered the following segfault when running against a PG 12 beta1 during a analyze against a table. Nobody else has reported this, so you're going to have to work on producing a self-contained test case, or else debuggi

PG 12 beta 1 segfault during analyze

2019-06-15 Thread Steve Singer
I encountered the following segfault when running against a PG 12 beta1 during a analyze against a table. #0 0x56008ad0c826 in update_attstats (vacattrstats=0x0, natts=2139062143, inh=false, relid=0x40>) at analyze.c:572 #1 do_analyze_rel (onerel=onerel@entry=0x7f0bc59a7a38, params

pg_ssl_init

2019-05-05 Thread Steve
Update: I have moved the previously contributed "pg_ssl" package to a formal git, and have renamed it to "pg_ssl_init" (at the request of initial reviewers, who were concerned about future name collisions...) "pg_ssl_init" is a set of command line scripts that conveniently configures self-sign

Re: CHAR vs NVARCHAR vs TEXT performance

2019-04-30 Thread Steve Crawford
The statement may be true if one assumes the planner is able to make an optimal choice but clearly there are cases that prevent that. If the situation is better explained elsewhere in the documentation then just a link to that explanation may be all that is needed. Cheers, Steve

Re: pg_ssl

2019-04-28 Thread Steve
Will be doing in just a few days. I am taking _initial_ suggestions, incorporating them, then I will be setting that up. On 4/28/2019 11:25 AM, David Fetter wrote: On Sat, Apr 27, 2019 at 12:54:07PM -0400, Steve wrote: As you might know, generating SSL certificates for postgres (to be used by

pg_ssl

2019-04-27 Thread Steve
As you might know, generating SSL certificates for postgres (to be used by pgadmin, for example...) can be quite a bear; especially if you need more than one, since they are based on the username of the postgres user. I have made two command-line utilities written in python 3.6 to do just that

Re: PostgreSQL Limits and lack of documentation about them.

2018-11-28 Thread Steve Crawford
ll bitmap also occupies space. > > Both for my edification and as a potentially important documentation detail, do operations that rebuild the table such as CLUSTER or pg_repack reclaim the column space? Cheers, Steve

Re: settings to control SSL/TLS protocol version

2018-11-03 Thread Steve Singer
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:tested, passed I've reviewed the patch and here are my comments. The feature se

Re: heap_sync seems rather oblivious to partitioned tables (wal_level=minimal)

2018-11-01 Thread Steve Singer
vid Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services Steve

Re: heap_sync seems rather oblivious to partitioned tables (wal_level=minimal)

2018-10-31 Thread Steve Singer
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:tested, failed --- a/doc/src/sgml/perform.sgml +++ b/doc/src/sgml/perform.sgml @

Re: date_trunc() in a specific time zone

2018-10-29 Thread Steve Crawford
se I don't want '2001-02-16 00:00:00' (where?), I want the precise > moment in time that that represents ('2001-02-16 13:00:00+00') so I can > pull the correct rows out of my big table. > > This isn't for display purposes. > > I'm a bit confused as to the use case. Wouldn't someone who wants locally-based time-period ranges also want output displayed in the corresponding zone both of which are already well handled in one place by "set timezone..."? Cheers, Steve

Re: Postgres older version 8.3.7 on ubuntu 14

2018-10-23 Thread Steve Crawford
But if you insist on compiling, the answer is in your output - it isn't finding a compiler. Be sure to install gcc or other compiler. Cheers, Steve

Re: Compromised postgresql instances

2018-06-08 Thread Steve Atkins
> On Jun 8, 2018, at 1:47 PM, Tom Lane wrote: > > Andrew Dunstan writes: >> On 06/08/2018 04:34 PM, Steve Atkins wrote: >>> I've noticed a steady trickle of reports of postgresql servers being >>> compromised via being left available to the

Compromised postgresql instances

2018-06-08 Thread Steve Atkins
h the permissions of the postgresql user, apparently via an extension or an untrusted PL. Is anyone tracking or investigating this? Cheers, Steve

Re: [HACKERS] pgbench regression test failure

2017-11-14 Thread Steve Singer
On Mon, 13 Nov 2017, Fabien COELHO wrote: Hello Steve, printf("number of transactions actually processed: " INT64_FORMAT "/%d\n", - total->cnt - total->skipped, nxacts * nclients); + total->cnt,