> On Tue, 1 Oct 2024 22:20:55 +0900
> Yugo Nagata wrote:
>
>> On Tue, 1 Oct 2024 15:16:52 +0900
>> Yugo NAGATA wrote:
>>
>> > On Tue, 01 Oct 2024 10:33:50 +0900 (JST)
>> > Tatsuo Ishii wrote:
>> >
>> > > >> That'
> Hi
>
> pá 4. 10. 2024 v 15:16 odesílatel Tatsuo Ishii
> napsal:
>
>> Sorry if this has been discussed before.
>>
>> I wonder why SET ROLE command does not produce a parameter status
>> message noticing the new current_user. Note that SET
>> SESSI
Sorry if this has been discussed before.
I wonder why SET ROLE command does not produce a parameter status
message noticing the new current_user. Note that SET
SESSION_AUTHORIZATION command produces a parameter status message for
the new session_authorization value.
Best reagards,
--
Tatsuo
IMO.
> Or, if it would mean to the failover
> feature rather than the parameter, is it not proper to add tag to
> this
> "failover"?
I don't think so.
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
sing "option" there does not seem to be
inconsistent or incorrect. See following example in create
subscription manual:
This clause specifies optional parameters for a subscription.
:
:
connect (boolean)
:
:
Since no connection is made when this option is false, no tables are
subscri
s refereed to.
>
> We could also use "enable the failover parameter". I think both make sense,
> but
> it seems that "failover option" is preferred in the slot_name description.
But a few lines above we have:
This clause specifies optional parame
ched is the patch to do that.
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml
index 740b7d9421..4eed0f3d0f 100644
--- a/doc/sr
> On Mon, 30 Sep 2024 17:23:24 +0900 (JST)
> Tatsuo Ishii wrote:
>
>> >> I think there's an unnecessary underscore in config.sgml.
>> >> Attached patch fixes it.
>> >
>> > I could not apply the patch with an error.
>> >
>>
better way is use perl itself rather than grep as following.
>
> `perl -ne '/\xC2\xA0/ and print' `
>
> I attached a patch fixed in this way.
GNU sed can also be used without setting LC_ALL:
sed -n /"\xC2\xA0"/p
However I am not sure if non-GNU sed can do this too...
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
ample, locale und-u-kb sorts 'àe' before 'aé'.
>
> This is not non-breaking space, so should not be detected as an error.
That's because non-breaking space (nbsp) is not encoded as 0xa0 in
UTF-8. nbsp in UTF-8 is "0xc2 0xa0" (2 bytes) (A 0xa0 is a nbsp's
ert a non breaking space while editing config.sgml.
However the mistake does not affect the patch.
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
You can check it by looking at
line 9383 of config.sgml.
I think it was introduced by 28e858c0f95.
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
I think there's an unnecessary underscore in config.sgml.
Attached patch fixes it.
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 0aec11f443..08173
nterest in
>> having this kind of tool in the tree, I can work on making it
>> reviewable. Either way, I should be able to use it to double-check
>> more complicated test cases.
I definitely am interested in the tool!
>> A while back [2], you were wondering whether our Bison implementation
>> would be able to parse the PATTERN grammar directly. I think this tool
>> proves that the answer is "yes", but PERMUTE in particular causes a
>> shift/reduce conflict. To fix it, I applied the same precedence
>> workaround that we use for CUBE and ROLLUP.
That's a good news!
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
> With some bigger partitions, I hit an `ERROR: wrong pos: 1024`. A
> test that reproduces it is attached.
Thanks for the report. Attached is a patch on top of v22 patches to
fix the bug. We keep info in an array
(WindowAggState.reduced_frame_map) to track the rpr pattern match
result status for
h is pushed to master branch.
A small comment on the comments in the patch: pgindent dislikes some
of the comment indentation styles. See attached pgindent.txt. Although
such a small defect would be fixed by committers when a patch gets
committed anyway, you might want to help committers beforehand.
> On Mon, 23 Sept 2024 at 18:28, Tatsuo Ishii wrote:
>> I agree and made necessary changes. See attached v4 patches.
>
> Looks good to me.
Thank you for the review! I have pushed the patch.
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en
output.
After thinking more, I lean toward to your opinion. The new tests do
not give big value, but on the other hand they could become a burden
over the years. I do not include the new tests in the v4 patches.
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en
- 0 transactions (NaN% of total, tps = 0.00)
SQL script 2: d.sql
- weight: 1 (targets 50.0% of total)
- 0 transactions (NaN% of total, tps = 0.00)
- number of failed transactions: 1 (100.000%)
- number of serialization failures: 1 (100.000%)
- number of deadlock failures: 0 (0.00
age kind difference
in the two tuplestores.
Attached patch fixes 1 & 2.
[1]
https://www.postgresql.org/message-id/CAExHW5vRPRLvsZYLmNGcDLkPDWDHXGSWYjox-to-OsCVFETd3w%40mail.gmail.com
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
>From 814fa7bd
pushed that patch. That should now unblock you on the
> nodeRecursiveunion.c telemetry.
Thanks. Attached is a patch for CTE scan, table function scan and
recursive union scan nodes.
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
&
h:
Time: 3.641 ms
Time: 2.356 ms
Time: 2.347 ms
It seems with the patch the performance is slightly better or almost
same. I think the patch improves the performance without sacrificing
the smaller iteration case.
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
> On Thu, 19 Sept 2024 at 00:13, Tatsuo Ishii wrote:
>> Actually there's one more executor node type that uses tuplestore:
>> recursive union (used in "with recursive"). The particular node type
>> uses two tuplestore and we cannot simply apply tuplestore_get_
node type
uses two tuplestore and we cannot simply apply tuplestore_get_stats()
to the node type. We need to modify RecursiveUnionState to track the
maximum tuplestore usage. I am not sure this would be worth the
effort. Opinion?
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sra
> On Tue, 17 Sept 2024 at 14:40, Tatsuo Ishii wrote:
>> Attached is the v5 patch. The difference from v4 is addtion of two
>> more tests to explain.sql:
>>
>> 1) spils to disk case
>> 2) splis to disk then switch back to memory case
>
> Looks ok to me,
g < 3
> (as true == 1). So unless PostgreSQL changes the way to sort boolean
> data type, I think the result should be stable.
Attached is the v5 patch. The difference from v4 is addtion of two
more tests to explain.sql:
1) spils to disk case
2) splis to disk then switch back to memory ca
the way to sort boolean
data type, I think the result should be stable.
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
a (actual time=0.300..0.633 rows=2
000 loops=1)
Planning Time: 0.069 ms
Execution Time: 474515.476 ms
(8 rows)
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
am I correct?
> Do we want to cover those. This test would be
> the only one where those code paths could be tested.
I am fine to add the first test case.
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
Right. I will make the change.
> Aside from that, I think the patch is good. Thanks for working on it.
Thanks. Attached is the v4 patch. I am going push it if there's no
objection.
After this, I will work on remaining node types.
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: ht
show_storage_info so that the latter can be
used by other node types including window aggregate node. What do you
think?
I also added a test case in explain.sql per discussion with Maxim
Orlov.
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http
> I pushed a patch to change the API.
Thank you!
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
> On Thu, 12 Sept 2024 at 14:04, Tatsuo Ishii wrote:
>> Are you going to push the changes to tuplestore.c anytime soon? I
>> would like to rebase my patch[1] but the patch could be affected by
>> the tuplestore API change.
>
> Ok, I'll look at that.
Thanks.
I
> On Wednesday, September 11, 2024, Tatsuo Ishii wrote:
>
>>
>> test=# SELECT row_number() IGNORE NULLS OVER w FROM t1 WINDOW w AS (ORDER
>> BY i);
>> row_number
>>
>> 1
>> 2
>> (2 rows)
>>
>> Th
oint the output parameter of the stats function at the statically
> allocated constant.
Are you going to push the changes to tuplestore.c anytime soon? I
would like to rebase my patch[1] but the patch could be affected by
the tuplestore API change.
Best reagards,
[1]
https://www.postgresql.
>> >> On Sat, 6 May 2023, 04:57 Tatsuo Ishii, wrote:
>> >>>
>> >>> Attached is the patch to implement this (on top of your patch).
>> >>>
>> >>> test=# SELECT row_number() RESPECT NULLS OVER () FROM (SELECT 1) AS s;
>&
blog/understanding-the-postgres-hackers-mailing-list
Thank you for the excellent article. I think it is very useful for
non-native English speakers like me.
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
on, not by a separate
function looks more natural.
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
d less memory.
>
> I did this quickly, but playing around with the attached, I didn't see
> any slowdown.
Your patch looks good to me and I confirmed that with your patch I
didn't see any slowdown either. Thanks!
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
However, for 10, 2, 1 partitions. I see large performance
degradation with the patched version: patched is slower than stock
master in 1.5% (10 partitions), 41% (2 partitions) and 55.7% (1
partition). See the attached graph.
>From 4749d2018f33e883c292eb904f3253d393a47c99 Mon Sep 17 00:00:00 2001
From:
ds might go
away if I change the tuplestore infrastructure per David's suggestion:
https://www.postgresql.org/message-id/CAApHDvoY8cibGcicLV0fNh%3D9JVx9PANcWvhkdjBnDCc9Quqytg%40mail.gmail.com
After this I will rebase the patches. This commit requires changes.
https://git.postgresql.org
Hi,
> On Wed, 10 Jul 2024 at 21:36, Tatsuo Ishii wrote:
>> v2-0005-Add-memory-disk-usage-for-Window-Aggregate-nodes-.patch: This
>> adds memory/disk usage for Window Aggregate nodes in EXPLAIN (ANALYZE)
>> command. Note that if David's proposal
>> https://www.pos
basic tests for the added functionality
> to make it committable. For example, as in the
> mentioned 1eff8279d494b9.
Agreed. Probably add to explain.sql?
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
> Tatsuo Ishii writes:
>> In our documentations, "subquery", "sub-query", "sub-select" and
>> "sub-SELECT" are used. In English, are they interchangeable?
>
> Pretty nearly. I think "sub-query" can include DML such as
>
choose
single Japanese word for them. If not, we would like to use different
Japanese words to reflect the difference.
I noticed that "sub-SELECT" only appears in syntax rules in the
reference manuals. Maybe "sub-SELECT" should be tread differently from
others?
Best reagards,
h is a major
pain.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
t;END")
<= BE CommandComplete(COMMIT)
<= BE ReadyForQuery(I)
FE=> Execute(portal="c")
FE=> Sync
<= BE DataRow
<= BE DataRow
<= BE DataRow
<= BE DataRow
<= BE DataRow
<= BE PortalSuspended
<= BE ReadyForQuery(I)
FE=> Terminate
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
he member to a pointer
>>
>> - ErrorSaveContext escontext;
>> + ErrorSaveContext *escontext;
>> } JsonExprState;
>>
>> and make the required adjustments elsewhere in the code, the warning
>> goes away.
>
> I think this is not necessary. Jus
(IsA(&f, List))
| ^~~
At top level:
strict2.c:21:12: warning: ‘sub’ defined but not used [-Wunused-function]
21 | static int sub(void)
|^~~
> If you change the member to a pointer
>
> - ErrorSaveContext escontext;
> + ErrorSaveContext *escontext
iler option?
[1]
https://www.postgresql.org/message-id/flat/366.1535731324%40sss.pgh.pa.us#bd93089182d13c79b74593ec70bac435
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
diff --git a/src/backend/executor/execExprInterp.c
lf (ie "func/"), mainly due to the precedent
> of the existing subdirectory which is "ref/" not "reference/".
> It's hardly a big deal though.
I don't have strong preference neither but I agree that "func/" is
more consistent with existing
ag "functions-json".
> or another idea
> could be to make a new subdirectory func/ for these.
+1. Looks better than adding +30 files right under sgml directory.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
> I'm opposed to having a separate file for every function. I think
> breaking up func.sgml into one piece per sect1 is about right. If that
> proves cumbersome still we can look at breaking it up further, but
> let's start with that.
That will create at least 30 func-xx.sgml files.
t-ishii$ grep
t it possible, for example there's no row in a partition.
Sorry for noise.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
de->buffer = NULL;
+ }
+
Is it possible that node->buffer == NULL in ExecEndWindowAgg()? If
not, probably making it an Assert() or just removing the if() should
be fine.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
> On 2024-07-11 Th 5:34 AM, Tatsuo Ishii wrote:
>>>> The differences are that the result has an extra space at the end of
>>>> line. I am not familiar with Windows and has no idea why this could
>>>> happen (I haven't changed the patch set since May 24
of the regress test in Windows.
Yeah, it seems that explains. I see few buildfarm window animals
complain too.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
other tests (for
example http://cfbot.cputube.org/highlights/all.html#4337)
Any idea?
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
ANALYZE, COSTS OFF) SELECT * FROM jsonb_table_view6;
QUERY PLAN
---
Table Function Scan on "json_table" (actual time=0.024..0.025 rows=1 loops=1)
Union and Table Function Scan node.
> We might even convert it into a tuplestore
> specific implementation hook after David's work.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
> On Sat, 6 Jul 2024 at 23:23, Tatsuo Ishii wrote:
>> So I wanted to Add memory/disk usage for WindowAgg. Patch attached.
>
> Thanks for working on that.
Thank you for the infrastructure you created in tuplestore.c and explain.c.
BTW, it seems these executor nodes (other than
isk usage for WindowAgg. Patch attached.
Since WindowAgg node could create multiple tuplestore for each Window
partition, we need to track each tuplestore storage usage so that the
maximum storage usage is determined. For this purpose I added new
fields to the WindowAggState.
--
Tatsuo Ishii
SR
."
Good catch. The proposed message matches the PQCancelErrorMessage()
documentation and looks good.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
t's okay
> to do this for prominent files like the top-level one, but I suggest
> that for the rest we can keep it simple and just use plain text.
Agreed.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
o me those don't seem confusing.
> I'll plan to push the attached after the release freeze lifts.
Excellent!
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
haps s/As func_expr/Like func_expr/ would be less confusing?
+1. It's easier to understand at least for me.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
> On Sat, Jun 22, 2024 at 9:02 PM Tatsuo Ishii wrote:
>
>> I was unable to parse a comment in src/backend/parser/gram.y around line
>> 11364:
>>
>> /*
>> * As func_expr but does not accept WINDOW functions directly (they
>> * can still be contained
. (e.g. in CREATE INDEX)
*/
Maybe "but" is unnecessary in the first sentence in the comment?
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
> On Sat, Jun 15, 2024 at 7:25 PM Tatsuo Ishii wrote:
>
>>The rules for which initial
>>role membership options are enabled described below in the
>>IN ROLE, ROLE, and
>>ADMIN clauses.
>>
>> Maybe we need "are" in fron
t;are" in front of "described"?
Attached is the patch for that.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
diff --git a/doc/src/sgml/ref/create_role.sgml b/doc/src/sgml/ref/create_role.sgml
index 27e48da12
0 and less than or equal to m rows
---------
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
situation. BTW I
have just posted a v19 patch [1] and cfbot took care of it nicely.
[1]
https://www.postgresql.org/message-id/20240515.090203.2255390780622503596.t-ishii%40sranhm.sra.co.jp
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
I wonder why psql adds
the whitespace. Unless there's a good reason to do that, I think it's
better to fix psql so that it does not emit trailing spaces in its
output.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
anybody know what's wrong here?
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
> The Core Team would like to extend our congratulations to Melanie
> Plageman and Richard Guo, who have accepted invitations to become our
> newest PostgreSQL committers.
>
> Please join us in wishing them much success and few reverts!
Congratulations!
--
Tatsuo Ishii
SRA OSS LL
> On Tue, Apr 23, 2024 at 8:13 PM Tatsuo Ishii wrote:
>> SELECT v.a, count(*) OVER w
>> FROM (VALUES ('A'),('B'),('B'),('C')) AS v (a)
>> WINDOW w AS (
>> ORDER BY v.a
>> ROWS BETWEEN CURRENT ROW AND UNBOUNDE
rathern than NULL for row 3.
What do you think?
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
dj_of_a_sing_noun/?ref=share&ref_source=link
Thank you for the explanation. English is difficult :-)
Just out of a curiosity, is it possible to say "low a wal_level on the
primary"? (just "too" is removed)
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
"too low a" should be "too low" ('a' is not
necessary). Attached is the patch.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgm
> query protocol allows pipelining"
Good point. If we have started extended protocol messages, I think
there's no way to avoid the Sync messages before issuing simple
protocol messages.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
Hi Dave,
Oh, I see.
> Hi Tatsuo,
>
> Actually no need, I figured it out.
>
> I don't have a solution yet though.
>
> Dave Cramer
> www.postgres.rocks
>
>
> On Thu, 15 Feb 2024 at 19:43, Tatsuo Ishii wrote:
>
>> > Can you ask the OP
it should be 'SELECT version()', not 'select
version()'.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
gt; can tell we send BEGIN using SimpleQuery.
>
> Sure. I will get back once I get the JDBC version.
Here it is:
> JDBC driver version used:42.5.1 Regards, Karel.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
ng the extended query
>> protocol.
>>
>> [1]
>> https://www.pgpool.net/pipermail/pgpool-general/2023-December/009051.html
>
>
> Can you ask the OP what version of the driver they are using. From what I
> can tell we send BEGIN using SimpleQuery.
Sure. I wil
>> Hello Dave,
>>
>> > Tatsuo Ishii writes:
>> >> Below is outputs from "pgproto" command coming with Pgpool-II.
>> >> (Lines starting "FE" represents a message from frontend to backend.
>> >> Lines starting "BE&quo
Hello Dave,
> Tatsuo Ishii writes:
>> Below is outputs from "pgproto" command coming with Pgpool-II.
>> (Lines starting "FE" represents a message from frontend to backend.
>> Lines starting "BE" represents a message from backend
. Pipelining":
"When using this method, completion of the pipeline must be determined
by counting ReadyForQuery messages and waiting for that to reach the
number of Syncs sent."
Apparently this does not apply to the above example because there's 0
sync message.
Best reagards,
[1] https://www.pgpool.net/pipermail/pgpool-general/2023-December/009051.html
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
spotting the issue and creating the patch. I
confirmed that your patch applies cleanly and solve the issue. I will
include the patches into upcoming v13 patches.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
gt;
> Is the message useful for pgbench users? I saw the error is ignored
> in pg_dump, for example in bin/pg_dump/parallel.c
I think the situation is different from pg_dump. Unlike pg_dump, if
PQcancel does not work, users can fix the problem by using
pg_terminate_backend or kill command. I
. Fix like this?
* On non-Windows, any callback function is not set. When SIGINT is
* received, CancelRequested is just set, and only thread #0 is
* interrupted and returns from waiting input from the backend. After
* that, the thread sends cancel requests to all benchmark queries.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
>> On 9 Jan 2024, at 00:54, Tatsuo Ishii wrote:
>>
>>>> On 4 Jan 2024, at 13:39, Tatsuo Ishii wrote:
>>>
>>>>> Attached is the patch that does this.
>>>
>>> I don't think the patch was attached?
>>>
>>>&
>> On 4 Jan 2024, at 13:39, Tatsuo Ishii wrote:
>
>>> Attached is the patch that does this.
>
> I don't think the patch was attached?
>
>> Any objection?
>
> I didn't study the RFC in depth but as expected it seems to back up your
> c
>
> If we still want to list a use-one-encoding-form example, probably we
> could use LATIN2 instead or others that are not supported by
> ISO-2022-JP-2 (ISO-2022-JP-2 supports LATIN1 and LATIN7).
>
> Attached is the patch that does this.
Any objection?
--
Tatsuo Is
supported by
ISO-2022-JP-2 (ISO-2022-JP-2 supports LATIN1 and LATIN7).
Attached is the patch that does this.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
is, pgbench -i -s 22000 works now.
>
> I think only the following line can fix this.
>
> + int64 k;
>
> Do not need to modify the type of `n`, right?
You are right. n represents the return value of pg_snprintf, which is
the byte length of the formatted data,
> On 04.12.23 12:40, Tatsuo Ishii wrote:
>> diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
>> index d631ac89a9..5a77fca17f 100644
>> --- a/src/backend/parser/gram.y
>> +++ b/src/backend/parser/gram.y
>> @@ -251,6 +251,8 @@ static Node *makeRec
TION BY bid
> ORDER BY aid
> ROWS BETWEEN CURRENT ROW AND UNBOUNDED FOLLOWING
> AFTER MATCH SKIP PAST LAST ROW
> INITIAL
> PATTERN (START UP+)
> DEFINE
> START AS TRUE,
> UP AS aid > PREV(aid)
> );
I ran this against your patch. It failed around > 60k rows.
Best reag
> On Sat, Oct 21, 2023 at 7:39 PM Tatsuo Ishii wrote:
>> Attached is the v10 patch. This version enhances the performance of
>> pattern matching.
>
> Nice! I've attached a couple of more stressful tests (window
> partitions of 1000 rows each). Beware that the second
. It's not applied anymore.
- Enhance the description about DEFINE and PATTERN.
- Mention that quantifier '*' is supported.
Finally I have added more test cases to the regression test.
- same pattern variable appears twice
- case for quantifier '*'
Best reagards,
--
Tat
_slots. It did not correctly detect the end of full frame.
- Add test case using "ROWS BETWEEN CURRENT ROW AND offset FOLLOWING".
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
>From d8fd143ab717fd62814e73fd24bf1a1694
1 - 100 of 503 matches
Mail list logo
