Re: Add option --drop-cascade for pg_dump/restore

2021-09-08 Thread Wu Haotian
Hi, here's the rebased patch. 0005-pg_dump-restore-add-drop-cascade-option.patch Description: Binary data

Re: Add option --drop-cascade for pg_dump/restore

2021-08-15 Thread Wu Haotian
There are already documents for "--clean only works with plain text output", so adding checks for --clean seems like a breaking change to me. I've updated the docs to indicate --drop-cascade and --if-exists only works with plain text output. 0004-pg_dump-restore-add-drop-cascade-option.patch Des

Re: Add option --drop-cascade for pg_dump/restore

2021-08-11 Thread Wu Haotian
Hi, I've updated the patch to remove unnecessary changes and added tests. On Fri, Jul 16, 2021 at 9:09 PM vignesh C wrote: > pg_dump support plain, custom, tar and directory format, I think, > cascade option will be added by pg_dump only for plain format and for > the other format pg_restore wil

Re: Add option --drop-cascade for pg_dump/restore

2021-08-10 Thread Wu Haotian
supporting this option only during initial dump is safer. > > > Safer, but not nearly as useful. Maybe see what the OP (Wu Haotian) can come > up with as a first implementation? > > Cheers, > Greg > pg_restore already tries to edit the DROP commands during restore in ord

Re: Add option --drop-cascade for pg_dump/restore

2021-07-13 Thread Wu Haotian
> 2) I felt pg_dump will include the cascade option for plain format and > pg_restore will include the cascade option from pg_restore for other > formats. If my understanding is correct, should we document this? I may not understand it correctly, are you saying pg_dump will include the cascade opt