Re: "Type does not exist" error when returning array of type in non-public schema

2025-02-06 Thread Chris Cleveland
I solved the problem with: CREATE FUNCTION myfunc ... RETURNS Token[] ... SET search_path to rdb; I still don't know why it happens in the first place, though. On Thu, Feb 6, 2025 at 12:14 PM Tom Lane wrote: > "David G. Johnston" writes: > > On Thu, Feb 6, 2025 at

"Type does not exist" error when returning array of type in non-public schema

2025-02-06 Thread Chris Cleveland
REATE FUNCTION my_func ... RETURNS Token[] ... No amount of fiddling with the syntax seems to help. RETURN rdb.Token[], RETURN "rdb.Token"[], RETURN "rdb.Token[]" all fail. This problem is happening in pg17. Haven't tried other versions. Is there a solution here? -- Chris Cleveland 312-339-2677 mobile

Graceful way to handle too many locks

2024-11-13 Thread Chris Cleveland
r the limit, instead of later? -- Chris Cleveland 312-339-2677 mobile

Re: Add 64-bit XIDs into PostgreSQL 15

2024-07-25 Thread Chris Travers
GUCs but doesn't actually > convert any existing GUCs to use that. (Unlike the reloptions, which > your patch coverts.) And so there is no documentation about these > questions. > > -- Best Wishes, Chris Travers Efficito: Hosted Accounting and ERP. Robust and Flexible. No vendor lock-in. http://www.efficito.com/learn_more

Implementing CustomScan over an index

2024-05-29 Thread Chris Cleveland
just a normal index scan, but with the ability to do custom things with the quals and the projection. So... what's the best approach? Is there any sample code that does this? A search of github doesn't turn up much. Is there any way to do this without duplicating everything in node

Re: commitfest.postgresql.org is no longer fit for purpose

2024-05-17 Thread Chris Travers
I think there are actually a number of factors that make this much harder. On Fri, May 17, 2024 at 2:33 PM Heikki Linnakangas wrote: > > On 17/05/2024 05:26, Robert Haas wrote: > > For bonus points, suppose we make it so that when you click the link, > > it takes you to a box where you can type i

Re: Why is FOR ORDER BY function getting called when the index is handling ordering?

2024-05-02 Thread Chris Cleveland
or that, though: IndexScanDesc.xs_orderbyvals. If there were a way for the system to use that instead of a call to the ordering function, we'd be all set. It would also be nice if the orderbyval could be made available in the projection. That way we could report the score() in the result set. Matthias' response and links touch on some of these issues. -- Chris Cleveland 312-339-2677 mobile

Why is FOR ORDER BY function getting called when the index is handling ordering?

2024-05-02 Thread Chris Cleveland
nfo, but I can't figure out where or why it's getting set. Here's a sample query. I have not found a query that does *not* call rank_match(): SELECT * FROM products WHERE products <===> rdb.userquery('teddy') ORDER BY products <<=>> rdb.rank(); I'd be grateful for any help or insights. -- Chris Cleveland 312-339-2677 mobile

Possible to get LIMIT in an index access method?

2024-04-29 Thread Chris Cleveland
ess method is designed such that you have to fetch the entire result set in one go. It's not streaming, like most access methods. As such, it would be very helpful to know up front how many items I need to fetch from the index. -- Chris Cleveland 312-339-2677 mobile

Index access method not receiving an orderbys ScanKey

2024-04-25 Thread Chris Cleveland
nscan); amroutine.amrescan = Some(scan::amrescan); amroutine.amgettuple = Some(scan::amgettuple); amroutine.amgetbitmap = None; // Some(scan::ambitmapscan); amroutine.amendscan = Some(scan::amendscan); amroutine.ammarkpos = None; amroutine.amrestrpos = None; /* interface functions to support parallel index scans */ amroutine.amestimateparallelscan = None; amroutine.aminitparallelscan = None; amroutine.amparallelrescan = None; amroutine.into_pg_boxed() } -- Chris Cleveland 312-339-2677 mobile

Possible to trigger autovacuum?

2024-02-19 Thread Chris Cleveland
fire up a background worker to do the job, but it would be a lot simpler to call please_launch_autovacuum_right_now(); -- Chris Cleveland 312-339-2677 mobile

Re: Update docs for default value of fdw_tuple_cost

2024-01-03 Thread Chris Travers
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:tested, passed Good catch. This is a trivial fix and so I hope we can just get it in ri

Re: Moving forward with TDE

2023-12-16 Thread Chris Travers
ready encrypted, then do these forceably share the same data encrypting keys? Is there a need to have (possibly in a follow-up patch) an ability to decrypt and re-encrypt in pg_basebackup (which would need access to both keys) or is this handled already and I just missed it? Best Wishes, Chris Travers

Re: UUID v7

2023-10-09 Thread Chris Travers
So I am in the process of reviewing the patch and hopefully can provide something there soon. However I want to address in the mean time the question of timestamp functions. I know that is outside the scope of this patch but I would be in favor of adding them generally, not just as an extensio

Projection pushdown to index access method

2023-09-19 Thread Chris Cleveland
that case we make a custom PathTarget for it. * *For example, an indexscan might return index expressions that would * otherwise need to be explicitly calculated.* -- Chris Cleveland 312-339-2677 mobile

Simple CustomScan example

2023-09-06 Thread Chris Cleveland
simple example of a custom scan? Or maybe a tutorial? -- Chris Cleveland 312-339-2677 mobile

Re: New PostgreSQL Contributors

2023-07-30 Thread Chris Travers
Congrats! On Fri, Jul 28, 2023 at 10:29 PM Christoph Berg wrote: > The PostgreSQL contributors team has been looking over the community > activity and, over the first half of this year, has been recognizing > new contributors to be listed on > > https://www.postgresql.org/community/contributors/

Re: Moving forward with TDE

2023-03-28 Thread Chris Travers
. > > > > > > While it’s easy to label something as checkbox, I don’t feel we > have been > > fair > > > > No, actually, it isn't. I am not sure why you are saying that. > > > > I’m confused as to what is required to label a fe

Re: Moving forward with TDE

2023-03-28 Thread Chris Travers
there are holes in it. But there are others who really should be concerned (and this is becoming a bigger issue where data privacy, PCI-DSS, and other requirements may come into play), and those need better tooling than we have. I also think that as data privacy becomes a larger issue, this w

Re: POC: Lock updated tuples in tuple_update() and tuple_delete()

2023-03-10 Thread Chris Travers
"Right, the improvement this patch gives to the heap is not the full motivation. Another motivation is the improvement it gives to TableAM API. Our current API implies that the effort on locating the tuple by tid is small. This is more or less true for the heap, where we just need to pin and loc

Re: Moving forward with TDE

2023-03-06 Thread Chris Travers
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested I have decided to write a review here in terms of whether we want this featur

Re: Add 64-bit XIDs into PostgreSQL 15

2022-11-29 Thread Chris Travers
On Tue, Nov 29, 2022 at 5:57 PM Bruce Momjian wrote: > On Tue, Nov 29, 2022 at 11:41:07AM -0500, Robert Haas wrote: > > My argument is that removing xidStopLimit is totally fine, because it > > only serves to stop the database. What to do about xidWarnLimit is a > > slightly more complex question

Re: Add 64-bit XIDs into PostgreSQL 15

2022-11-29 Thread Chris Travers
On Mon, Nov 28, 2022 at 11:06 PM Peter Geoghegan wrote: > On Mon, Nov 28, 2022 at 1:52 PM Bruce Momjian wrote: > > I think the problem is that we still have bloat with 64-bit XIDs, > > specifically pg_xact and pg_multixact files. Yes, that bloat is less > > serious, but it is still an issue wor

Re: Add 64-bit XIDs into PostgreSQL 15

2022-11-29 Thread Chris Travers
:08 AM Chris Travers > wrote: > > I didn't see any changes to pg_upgrade to make this change possible on > upgrade. Is that also outside of the scope of your patch set? If so how > is that continuity supposed to be ensured? > > The scheme is documented in their 000

Re: Add 64-bit XIDs into PostgreSQL 15

2022-11-26 Thread Chris Travers
Hi; Trying to discuss where we are talking past eachother. On Fri, Nov 25, 2022 at 9:38 AM Aleksander Alekseev < aleksan...@timescale.com> wrote: > Hi hackers, > > > I'm wondering whether the safest way to handle this is by creating a > > new TAM called "heap64", so that all storage changes

Re: Add 64-bit XIDs into PostgreSQL 15

2022-11-23 Thread Chris Travers
On Tue, Nov 22, 2022 at 10:01 AM Aleksander Alekseev < aleksan...@timescale.com> wrote: > Hi Chris, > > > Right now the way things work is: > > 1. Database starts throwing warnings that xid wraparound is approaching > > 2. Database-owning team initiates a

Re: Add 64-bit XIDs into PostgreSQL 15

2022-11-21 Thread Chris Travers
vacuum, with a > configurable threshold. We could have this at two billion by default as > that would pose operational warnings not much later than we have now. > > > > Otherwise I can imagine cases where instead of 30 hours to vacuum a > table, it takes 300 hours on a data

Re: Add 64-bit XIDs into PostgreSQL 15

2022-11-21 Thread Chris Travers
On Mon, Nov 21, 2022 at 12:25 PM Aleksander Alekseev < aleksan...@timescale.com> wrote: > Hi hackers, > > > > I have a very serious concern about the current patch set. as someone > who has faced transaction id wraparound in the past. > > > > [...] > > > > I had a similar stance when I started wor

Re: Add 64-bit XIDs into PostgreSQL 15

2022-11-20 Thread Chris Travers
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested I have a very serious concern about the current patch set. as someone who has

Managing my own index partitions

2022-08-08 Thread Chris Cleveland
baseobject.objectId = parent_oid; baseobject.objectSubId = 0; segobject.classId = IndexRelationId; segobject.objectId = child_oid; segobject.objectSubId = 0; recordDependencyOn(&segobject, &baseobject, DEPENDENCY_INTERNAL); } The code where I use heap_create_with_catalog() is substantially the same. -- Chris Cleveland 312-339-2677 mobile

Managing my own index partitions

2022-08-08 Thread Chris Cleveland
I'm building a Postgres index access method. For a variety of reasons it's more efficient to store the index data in multiple physical files on disk rather in the index's main fork. I'm trying to create separate rels that can be created and destroyed by the parent index access method. I've succeed

Atomic GetFreeIndexPage()?

2022-05-04 Thread Chris Cleveland
etFreeIndexPage() with a lightweight lock, although I wonder if that would harm performance. Perhaps there is a more performant way to do this deep down in the FSM code. Thoughts? -- Chris Cleveland 312-339-2677 mobile

Re: Allow root ownership of client certificate key

2022-03-01 Thread Chris Bandy
s project to provide more control over ownership and permissions of mounted secrets.[2] PostgreSQL is mentioned repeatedly as motivation for the feature. [1]: https://kubernetes.io/docs/concepts/configuration/secret/ [2]: https://issue.kubernetes.io/81089 -- Chris

External data files possible?

2022-02-21 Thread Chris Cleveland
It's turning out to be difficult to store the data for my custom index access method in the main fork. Breaking up the data into pages with page headers means a lot of extra work, a big performance hit, and disk space management headaches. It's just not a good fit for my particular file format. It

Possible to go without page headers?

2022-02-14 Thread Chris Cleveland
I'm writing an index access method with its own unique file format. It involves storing large blobs that break across pages. The file format itself doesn't need or use page headers. There's no need for a checksum or to manage free space within the page. Can I treat pages as just a flat, open 8k b

More data files / forks

2022-01-11 Thread Chris Cleveland
I'm working on a table access method that stores indexes in a structure that looks like an LSM tree. Changes get written to small segment files, which then get merged into larger segment files. It's really tough to manage these files using existing fork/buffer/page files, because when you delete a

Look at all paths?

2021-12-28 Thread Chris Cleveland
I'm developing a new index access method. Sometimes the planner uses it and sometimes it doesn't. I'm trying to debug the process to understand why the index does or doesn't get picked up. Is there a way to dump all of the query plans that the planner considered, along with information on why they

Re: Confused with PostgreSQL on Synology NAS

2021-11-10 Thread chris
Wow, thanks so much, I checked it and there is a config on postgresql.conf. Regards, Chris On 11/10/2021 18:38,Sergei Kornilov wrote: Hello postgresql uses hba_file configuration parameter: https://www.postgresql.org/docs/current/runtime-config-file-locations.html So could be changed in

Re: Lost logs with csvlog redirected to stderr under WIN32 service

2021-10-06 Thread Chris Bandy
CSVLOG) != 0) This was originally "if (Log_destination & LOG_DESTINATION_CSVLOG)" and other conditions nearby still lack the "!= 0". Whatever the preferred style, the lines touched by this patch should probably do this consistently. -- Chris

Re: 64 bit TID?

2021-09-13 Thread Chris Cleveland
Pointer to 64 bits now preclude a variable-length TID in the future? Or make it more difficult? How much work would it take? Since the thread ended in May, has the group reached any kind of consensus on the issue? -- Chris Cleveland 312-339-2677 mobile

64 bit TID?

2021-09-13 Thread Chris Cleveland
ks to widen the TID? I saw some notes on this in the Zedstore project, but there hasn't been much activity in that project for almost a year. Chris -- Chris Cleveland 312-339-2677 mobile

Passing data out of indexam or tableam

2021-08-02 Thread Chris Cleveland
and attach it only to the first row. Is this possible? Is it possible to do it with a table access method, as opposed to an index access method? -- Chris Cleveland 312-339-2677 mobile

Re: Transactions and indexes

2021-07-22 Thread Chris Cleveland
> > Are you implementing a new index AM or a new table AM? Discarding data > based on something like a relevance score doesn't seem like something > that either API provides for. Indexes in Postgres can be lossy, but > that in itself doesn't change the result of queries. > (Sorry if this doesn't q

Re: Transactions and indexes

2021-07-22 Thread Chris Cleveland
is not going to work unless the system gives the index a clear picture of transactions, visibility, and deletes as they happen. Is this information available? On Mon, Jul 19, 2021 at 6:58 PM Peter Geoghegan wrote: > On Mon, Jul 19, 2021 at 4:31 PM Chris Cleveland > wrote: > &g

Transactions and indexes

2021-07-19 Thread Chris Cleveland
an. I'm guessing that all that magically happens in the storage and buffer managers. So... how do I handle this? Is there some way for me to implement my own storage manager that manages visibility? I'd be grateful for any guidance. -- Chris Cleveland 312-339-2677 mobile

Re: recovering from "found xmin ... from before relfrozenxid ..."

2020-08-18 Thread Chris Travers
same cannot be said of something like this new > heap_force_kill() stuff. > > > - Any ideas for additional things we should include, or improvements > > on the sketch above? > > Clearly you should work out a way of making it very hard to > accidentally (mis)use. For example, maybe you make the functions check > for the presence of a sentinel file in the data directory. > Agreed. > > > -- > Peter Geoghegan > > > -- Best Regards, Chris Travers Head of Database Tel: +49 162 9037 210 | Skype: einhverfr | www.adjust.com Saarbrücker Straße 37a, 10405 Berlin

Re: Making CASE error handling less surprising

2020-07-26 Thread Chris Travers
d. But it's been > true all along, and this patch isn't changing that behavior at all. > I'm not sure if we should do anything more than improve the docs, > but in any case it seems independent of the CASE issue. > > > The current behavior isn't great, but at least it handles these > > cases consistently. > > Really? > > regards, tom lane > > > -- Best Regards, Chris Travers Head of Database Tel: +49 162 9037 210 | Skype: einhverfr | www.adjust.com Saarbrücker Straße 37a, 10405 Berlin

Re: Making CASE error handling less surprising

2020-07-24 Thread Chris Travers
s route, would it be too much to ask to allow a GUC variable to preserve the old behavior? > regards, tom lane > > -- Best Regards, Chris Travers Head of Database Tel: +49 162 9037 210 | Skype: einhverfr | www.adjust.com Saarbrücker Straße 37a, 10405 Berlin

Re: [PATCH] Add schema and table names to partition error

2020-03-19 Thread Chris Bandy
On 3/18/20 11:46 PM, Amit Kapila wrote: > On Thu, Mar 19, 2020 at 3:55 AM Chris Bandy wrote: >> >> >> Sorry for these troubles. Attached are patches created using `git >> format-patch -n -v6` on master at 487e9861d0. >> > > No problem. I have extracte

Re: [PATCH] Add schema and table names to partition error

2020-03-18 Thread Chris Bandy
On 3/18/20 6:56 AM, Amit Kapila wrote: > On Thu, Mar 12, 2020 at 7:46 PM Amit Kapila wrote: >> >> On Wed, Mar 11, 2020 at 8:51 PM Chris Bandy wrote: >>> >>> On 3/11/20 6:29 AM, Amit Kapila wrote: >>>> >>>> I have tried with git am as we

Re: [PATCH] Add schema and table names to partition error

2020-03-11 Thread Chris Bandy
Amit, On 3/11/20 6:29 AM, Amit Kapila wrote: > On Tue, Mar 3, 2020 at 10:05 AM Chris Bandy wrote: >> >> On 3/1/20 10:09 PM, Amit Langote wrote: >>> Hi Chris, >>> >>> On Mon, Mar 2, 2020 at 8:51 AM Chris Bandy wrote: >>>> On 3/1/20 5:14 AM,

[PATCH] Add tests for integrity violation error fields

2020-03-06 Thread Chris Bandy
On 3/4/20 2:54 AM, Chris Bandy wrote: > I've also convinced myself that the number of integrity errors in the > entire codebase is manageable to test. If others think it is worthwhile, > I can spend some time over the next week to expand this test approach to > cover _all_ SQLSTAT

Re: [PATCH] Add object names to partition errors

2020-03-04 Thread Chris Bandy
On 3/3/20 11:18 PM, Chris Bandy wrote: > On 3/3/20 10:08 AM, Alvaro Herrera wrote: >> I don't suppose you mean to >> test that every single ereport() call that includes errtable() contains >> a TABLE NAME item. > > Correct. I intend only to test the few calls I&

Re: [PATCH] Add schema and table names to partition error

2020-03-03 Thread Chris Bandy
every error in SQLSTATE class 23 has one of these fields filled[1]. The errors in these patches are in that class but lacked any fields. [1] https://www.postgresql.org/docs/current/errcodes-appendix.html Thanks, Chris >From c6b39accf9f51f9c08a2fc62e848144776e23ffb Mon Sep 17 00:00:00 2001 Fr

Re: [PATCH] Add schema and table names to partition error

2020-03-02 Thread Chris Bandy
On 3/1/20 10:09 PM, Amit Langote wrote: Hi Chris, On Mon, Mar 2, 2020 at 8:51 AM Chris Bandy wrote: On 3/1/20 5:14 AM, Amit Kapila wrote: On Sun, Mar 1, 2020 at 10:10 AM Amit Langote wrote: There are couple more instances in src/backend/command/tablecmds.c where partition constraint is

Re: [PATCH] Documentation bug related to client authentication using TLS certificate

2020-03-02 Thread Chris Bandy
*server* is trustworthy by checking the *server* certificate up to the root. It does not verify that the host name matches the common name in the *server* certificate. In all cases, libpq is responsible for verifying the *server* is who it claims to be. -- Chris

Re: [PATCH] Add schema and table names to partition error

2020-03-01 Thread Chris Bandy
Thank you both for look at this! On 3/1/20 5:14 AM, Amit Kapila wrote: On Sun, Mar 1, 2020 at 10:10 AM Amit Langote wrote: Hi Chris, On Sun, Mar 1, 2020 at 4:34 AM Chris Bandy wrote: Hello, I'm writing telemetry data into a table partitioned by time. When there is no partition

[PATCH] Add schema and table names to partition error

2020-02-29 Thread Chris Bandy
for my use case: - Insert data into a partitioned table for which there is no partition. - Insert data directly into an incorrect partition. Thanks, Chris >From 8261b366c49b2d04baeb882d39dfa626b9315889 Mon Sep 17 00:00:00 2001 From: Chris Bandy Date: Sat, 29 Feb 2020 12:47:56 -0600 Subject: [PATCH] Ad

Re: Internal key management system

2020-02-02 Thread Chris Travers
eld does not need to be added as the > > padding-enabled output will already include it at the end[1]. This > > would be handled automatically by the OpenSSL encryption / decryption > > operations (if it's enabled): > > > > Yes, right. > > Regards, > > [1] > https://www.postgresql.org/message-id/031401d3f41d%245c70ed90%241552c8b0%24%40lab.ntt.co.jp > [2] > https://www.postgresql.org/message-id/CAD21AoD8QT0TWs3ma-aB821vwDKa1X519y1w3yrRKkAWjhZcrw%40mail.gmail.com > > -- > Masahiko Sawadahttp://www.2ndQuadrant.com/ > PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services > > > -- Best Regards, Chris Travers Head of Database Tel: +49 162 9037 210 | Skype: einhverfr | www.adjust.com Saarbrücker Straße 37a, 10405 Berlin

Re: ERROR: tuple concurrently updated when modifying privileges

2019-05-14 Thread Chris Travers
On Tue, May 14, 2019 at 9:11 AM Michael Paquier wrote: > On Tue, May 14, 2019 at 08:08:05AM +0200, Chris Travers wrote: > > Having thought about this a bit, I think the best solution would be to > have > > grant take out an access share lock to the tables granted. This

Re: ERROR: tuple concurrently updated when modifying privileges

2019-05-13 Thread Chris Travers
s share lock to the tables granted. This would prevent concurrent alter table operations from altering the schema underneath the grant as well, and thus possibly cause other race conditions. Any thoughts? > > Regards, > Nick. > > > -- Best Regards, Chris Travers Head of Database Tel: +49 162 9037 210 | Skype: einhverfr | www.adjust.com Saarbrücker Straße 37a, 10405 Berlin

Re: PostgreSQL pollutes the file system

2019-04-12 Thread Chris Travers
050. > > -- > Álvaro Herrerahttps://www.2ndQuadrant.com/ > PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services > -- Best Regards, Chris Travers Head of Database Tel: +49 162 9037 210 | Skype: einhverfr | www.adjust.com Saarbrücker Straße 37a, 10405 Berlin

Re: Berserk Autovacuum (let's save next Mandrill)

2019-04-11 Thread Chris Travers
certain criteria. This could have a lower max workers than autovacuum and therefore less of a threat in terms of total IO usage. Thoughts? > > > Andres > -- > Sent from my Android device with K-9 Mail. Please excuse my brevity. > > > -- Best Regards, Chris Travers Head of Database Tel: +49 162 9037 210 | Skype: einhverfr | www.adjust.com Saarbrücker Straße 37a, 10405 Berlin

Re: Berserk Autovacuum (let's save next Mandrill)

2019-04-10 Thread Chris Travers
bulk inserts all the time, vacuum freeze could have a lot of work to do, and in some cases I could imagine IO storms making that difficult. I plan to run some benchmarks on this to try to assess performance impact of this patch in standard pgbench scenarios.I will also try to come up with some o

Proposal: autovacuum_max_queue_depth

2019-03-29 Thread Chris Travers
hat very hot tables rise to the top of the queue and are vacuumed frequently even after setting Autovacuum to be far more aggressive on a large production database. Thoughts? Feedback? Waiting for a patch? -- Best Regards, Chris Travers Head of Database Tel: +49 162 9037 210 | Skype: einhve

Re: PostgreSQL pollutes the file system

2019-03-20 Thread Chris Travers
t; 2) -h/--help > >> > >> 3) rpm -qf $file (and similarly for other packagers) > >> > >> 4) set --prefix to install binaries so separate directory (which some > >> distros already do anyway) > >> > >> So to me this seems like a fairly invasiv

Re: PostgreSQL pollutes the file system

2019-03-20 Thread Chris Howard
Another pattern is to have a separate bin path for various software packages:  /opt/postgres/bin  for example. That doesn't directly answer "what is createdb?" but it does give a quicker indication via the 'which' command. On 3/20/19 5:43 AM, Fred .Flintstone wrote: It seems nothing came o

Re: PostgreSQL pollutes the file system

2019-03-20 Thread Chris Travers
ld be an even larger breakage and I > am not convinced the advantage would be worth it especially since our > executables are not as closely related and consistent as for example git's. > Git commands may be related, but I would actually argue that git commands have a lot of inconsist

Re: [HACKERS] Custom compression methods

2019-03-19 Thread Chris Travers
On Tue, Mar 19, 2019 at 12:19 PM Tomas Vondra wrote: > > On 3/19/19 10:59 AM, Chris Travers wrote: > > > > > > Not discussing whether any particular committer should pick this up but > > I want to discuss an important use case we have at Adjust for this sort > &

Re: [HACKERS] Custom compression methods

2019-03-19 Thread Chris Travers
d ... But I don't think that was the case. > While I am not currently able to speak for questions of how it is implemented, I can say with very little doubt that we would almost certainly use this functionality if it were there and I could see plenty of other cases where this would be a very appropriate direction for some other projects as well. > regards > > -- > Tomas Vondra http://www.2ndQuadrant.com > PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services > > -- Best Regards, Chris Travers Head of Database Tel: +49 162 9037 210 | Skype: einhverfr | www.adjust.com Saarbrücker Straße 37a, 10405 Berlin

Re: Data-only pg_rewind, take 2

2019-03-18 Thread Chris Travers
On Mon, Mar 18, 2019 at 4:09 AM Michael Paquier wrote: > On Sun, Mar 17, 2019 at 09:00:57PM +0800, Chris Travers wrote: > > I also added test cases and some docs. I don't know if the docs are > > sufficient. Feedback is appreciated. > > To be honest, I don't thi

Data-only pg_rewind, take 2

2019-03-17 Thread Chris Travers
x27;t know if the docs are sufficient. Feedback is appreciated. This is of course submitted for v13. -- Best Regards, Chris Travers Head of Database Tel: +49 162 9037 210 | Skype: einhverfr | www.adjust.com Saarbrücker Straße 37a, 10405 Berlin rewind_data_only_mode.patch Description: Binary data

Possible to modify query language in an extension?

2019-03-16 Thread Chris Cleveland
Noob here. I'm getting started on building a Postgres extension. I'd like to add some keywords/clauses to the SELECT statement. For my particular application, the syntax with new keywords would be way better than trying to do it through functions alone. I would add some new keywords followed by ex

Re: Re: Re: [HACKERS] Custom compression methods

2019-03-15 Thread Chris Travers
for some of our use cases and some other general use cases. I think as a feature, custom compression methods are a good thing but we are not the only ones with interests here and would be interested in pushing this forward if possible or finding ways to contribute to better approaches

Re: Ltree syntax improvement

2019-03-07 Thread Chris Travers
e can be a large SQL with a lot of things in it, > so > it is good to point that problem is with ltree staff). And is is better to > word from the point of view of a user. What for you (and me) is unexpected > end > of line, for him it is unclosed curly quote. > > Also I am not sure, if it is easy, but if it is possible, it would be good > to > move "^" symbol that points to the place of the error, to the place inside > ' ' > where unclosed curly quote is located. As a user I would appreciate that. > > So that's what I've seen while giving it superficial look... > > > -- Best Regards, Chris Travers Head of Database Tel: +49 162 9037 210 | Skype: einhverfr | www.adjust.com Saarbrücker Straße 37a, 10405 Berlin

Re: Proposal for Signal Detection Refactoring

2019-03-06 Thread Chris Travers
Here's a new patch. No rush on it. I am moving it to next commitfest anyway because as code documentation I think this is a low priority late in the release cycle. The changes mostly address Andres's feedback above. -- Best Regards, Chris Travers Head of Database Tel: +49 16

Re: Prevent extension creation in temporary schemas

2019-03-06 Thread Chris Travers
On Wed, Mar 6, 2019 at 9:33 AM Chris Travers wrote: > > >> Thoughts? >> > To re-iterate, my experience with PostgreSQL is that people doing particularly exotic work in PostgreSQL can expect to hit equally exotic bugs. I have a list that I will not bore people with here

Re: Prevent extension creation in temporary schemas

2019-03-06 Thread Chris Travers
On Wed, Mar 6, 2019 at 3:19 AM Michael Paquier wrote: > On Tue, Mar 05, 2019 at 12:47:54PM +0000, Chris Travers wrote: > > I tried installing a test extension into a temp schema. I found > > this was remarkably difficult to do because pg_temp did not work (I > > had to cre

Re: Prevent extension creation in temporary schemas

2019-03-05 Thread Chris Travers
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested I ran make checkworld and everything passed. I tried installing

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-03-04 Thread Chris Howard
Or on your laptop On 3/4/19 11:55 AM, Laurenz Albe wrote: Masahiko Sawada wrote: Why do people want to just encrypt everything? For satisfying some security compliance? I'd say that TDE primarily protects you from masked ninjas that break into your server room and rip out the disks with yo

Re: Prevent extension creation in temporary schemas

2019-02-18 Thread Chris Travers
r > > dependency links once the session is over. > > Extensions locate at pg_temp_* schemas are temporary objects IMO. > How do you think? Would you implement this functionality in future? > That's the way things are now as far as I understand it, or do I misunderstand your quest

Re: ALTER TABLE on system catalogs

2019-02-14 Thread Chris Travers
acuum on some table spaces, but set it aggressively on a couple system catalogs. Currently this is not really doable in any sane way. I also think that if the current catalogs violate expectations regarding precondition checks this needs to be corrected rather than special-cased and this seems to be the best way forward. > > regards. > > -- > Kyotaro Horiguchi > NTT Open Source Software Center > -- Best Regards, Chris Travers Head of Database Tel: +49 162 9037 210 | Skype: einhverfr | www.adjust.com Saarbrücker Straße 37a, 10405 Berlin

Re: Challenges preventing us moving to 64 bit transaction id (XID)?

2019-02-13 Thread Chris Travers
ith the idea that pages would be upgraded on write? > > -- > Alexander Korotkov > Postgres Professional: http://www.postgrespro.com > The Russian Postgres Company > -- Best Regards, Chris Travers Head of Database Tel: +49 162 9037 210 | Skype: einhverfr | www.adjust.com Saarbrücker Straße 37a, 10405 Berlin

Re: Challenges preventing us moving to 64 bit transaction id (XID)?

2019-02-13 Thread Chris Travers
s for most of that time), and having an ability to set idle-in-transaction timeouts to figures of greater than a month are things I could imagine doing. I would certainly favor the idea of 64-big GUC variables as a general rule. > > Greetings, > > Andres Freund > > -- Best Regards, Chris Travers Head of Database Tel: +49 162 9037 210 | Skype: einhverfr | www.adjust.com Saarbrücker Straße 37a, 10405 Berlin

Re: Prevent extension creation in temporary schemas

2019-02-13 Thread Chris Travers
extensions makes this behavior even more inconsistent. I guess I would vote against accepting this patch as it is. > -- > Michael > -- Best Regards, Chris Travers Head of Database Tel: +49 162 9037 210 | Skype: einhverfr | www.adjust.com Saarbrücker Straße 37a, 10405 Berlin

Re: Commit Fest 2019-01 is now closed

2019-02-08 Thread Chris Travers
ail. Right now it just lists one so you have to follow the link to the hackers list entry and look at each patch one at a time. So if we could grab all attachments ending in .diff or .patch and list line counts, that would be a welcome improvement. > > Regards > Takayuki T

Re: Prevent extension creation in temporary schemas

2019-02-04 Thread Chris Travers
This could probably use a quick note in the docs.

Re: Proposal for Signal Detection Refactoring

2019-01-23 Thread Chris Travers
attached is a new signal handing patch. Path is corrected and moved. The documentation is sightly streamlined in some places and expanded in others. Feedback requested. -- Best Regards, Chris Travers Head of Database Tel: +49 162 9037 210 | Skype: einhverfr | www.adjust.com Saarbrücker Straße

Re: Proposal for Signal Detection Refactoring

2019-01-17 Thread Chris Travers
rather than in code comments sine those might be scattered in a bunch of different places. > > Greetings, > > Andres Freund > -- Best Regards, Chris Travers Head of Database Tel: +49 162 9037 210 | Skype: einhverfr | www.adjust.com Saarbrücker Straße 37a, 10405 Berlin

Re: Proposal for Signal Detection Refactoring

2019-01-17 Thread Chris Travers
On Thu, Jan 17, 2019 at 6:38 PM Andres Freund wrote: > Hi, > > On 2019-01-17 10:50:56 +0100, Chris Travers wrote: > > diff --git a/src/backend/utils/init/globals.c > b/src/backend/utils/init/globals.c > > index c6939779b9..5ed715589e 100644 > > --- a/src/backend/

Re: Proposal for Signal Detection Refactoring

2019-01-17 Thread Chris Travers
Latest patch, simpler but answers the key questions as code comments On Mon, Dec 3, 2018 at 6:56 AM Chris Travers wrote: > On Thu, Nov 29, 2018 at 8:46 PM Dmitry Dolgov <9erthali...@gmail.com> > wrote: > >> > On Wed, Oct 10, 2018 at 7:10 PM Chris Travers >> wr

Re: Proposal for Signal Detection Refactoring

2018-12-02 Thread Chris Travers
On Thu, Nov 29, 2018 at 8:46 PM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > On Wed, Oct 10, 2018 at 7:10 PM Chris Travers > wrote: > > > >> More generally, I'd like this material to be code comments. It's the > >> kind of stuff tha

Re: Proposal for Signal Detection Refactoring

2018-10-10 Thread Chris Travers
On Tue, Oct 9, 2018 at 4:04 PM Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 01/10/2018 14:00, Chris Travers wrote: > > > > > > On Wed, Sep 26, 2018 at 9:54 AM Chris Travers > <mailto:chris.trav...@adjust.com>> wrote: > > > &

Possible important data point on stats collection, wondering about possible improvement

2018-10-04 Thread Chris Travers
planner extrapolate from existing stats in a more efficient way. -- Best Regards, Chris Travers Head of Database Tel: +49 162 9037 210 | Skype: einhverfr | www.adjust.com Saarbrücker Straße 37a, 10405 Berlin

Re: [HACKERS] Transactions involving multiple postgres foreign servers, take 2

2018-10-03 Thread Chris Travers
On Wed, Oct 3, 2018 at 9:41 AM Chris Travers wrote: > The following review has been posted through the commitfest application: > make installcheck-world: tested, failed > Implements feature: not tested > Spec compliant: not tested > Documentation:teste

Re: [HACKERS] Transactions involving multiple postgres foreign servers, take 2

2018-10-03 Thread Chris Travers
On Wed, Oct 3, 2018 at 9:56 AM Chris Travers wrote: > > > On Wed, Oct 3, 2018 at 9:41 AM Chris Travers > wrote: > >> >> (errmsg("preparing foreign transactions > (max_prepared_foreign_transactions > 0) requires maX_foreign_xact_resolvers > > 0")

Re: [HACKERS] Transactions involving multiple postgres foreign servers, take 2

2018-10-03 Thread Chris Travers
On Wed, Oct 3, 2018 at 9:41 AM Chris Travers wrote: > The following review has been posted through the commitfest application: > make installcheck-world: tested, failed > Implements feature: not tested > Spec compliant: not tested > Documentation:

Re: [HACKERS] Transactions involving multiple postgres foreign servers, take 2

2018-10-03 Thread Chris Travers
The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: not tested Spec compliant: not tested Documentation:tested, failed I am hoping I am not out of order in writing this before the commitfe

Re: Proposal for Signal Detection Refactoring

2018-10-01 Thread Chris Travers
Moving this to documentation due to a general consensus that abstracting this is not necessarily worth it. If we don't want to refactor and abstract this, it is worth documenting the design as to how things work now so that others who face bugs can consult docs instead of trying to determine ac

Re: Proposal for Signal Detection Refactoring

2018-10-01 Thread Chris Travers
On Wed, Sep 26, 2018 at 9:54 AM Chris Travers wrote: > > > On Tue, Sep 25, 2018 at 3:23 PM Tom Lane wrote: > >> Chris Travers writes: >> > However, what I think one could do is use a struct of volatile >> > sig_atomic_t members and macros for checking/sett

  1   2   >