On Thu, Nov 11, 2021 at 2:50 PM osumi.takami...@fujitsu.com
wrote:
>
> On Wednesday, November 10, 2021 1:23 PM Greg Nancarrow
> wrote:
> > On Wed, Nov 10, 2021 at 12:26 PM osumi.takami...@fujitsu.com
> > wrote:
> > >
> > > On Monday, Novembe
On Wed, Nov 10, 2021 at 11:16 AM Bharath Rupireddy
wrote:
>
> On Tue, Nov 9, 2021 at 9:27 PM vignesh C wrote:
> > Attached v12 version is rebased on top of Head.
>
> Thanks for the patch. Here are some comments on v12:
>
> 1) I think ERRCODE_TOO_MANY_ARGUMENTS isn
On Fri, Nov 12, 2021 at 5:15 PM Bharath Rupireddy
wrote:
>
> On Thu, Nov 11, 2021 at 12:14 PM vignesh C wrote:
> > Thanks for the comments, the attached v10 patch has the fixes for the same.
>
> Thanks for the patches. Here are some comments:
>
> 1) In the docs
On Fri, Nov 12, 2021 at 6:11 PM Bharath Rupireddy
wrote:
>
> On Fri, Nov 12, 2021 at 5:15 PM Bharath Rupireddy
> wrote:
> >
> > On Thu, Nov 11, 2021 at 12:14 PM vignesh C wrote:
> > > Thanks for the comments, the attached v10 patch has the fixes for the
>
On Mon, Nov 15, 2021 at 7:37 AM Bharath Rupireddy
wrote:
>
> On Sun, Nov 14, 2021 at 8:49 PM vignesh C wrote:
> > > 7) Do we need TAP tests for this function? I think it is sufficient to
> > > test the function in misc_functions.sql, please remove
> > > 002_pr
On Mon, Nov 15, 2021 at 11:00 AM Bharath Rupireddy
wrote:
>
> On Mon, Nov 15, 2021 at 10:34 AM vignesh C wrote:
> > > 2) I think "which is enough because the target process for logging of
> > > backtrace is a backend" isn't valid anymore with 0002, righi
On Mon, Nov 15, 2021 at 2:48 PM Masahiko Sawada wrote:
>
> On Mon, Nov 15, 2021 at 4:49 PM Greg Nancarrow wrote:
> >
> > On Mon, Nov 15, 2021 at 1:49 PM Masahiko Sawada
> > wrote:
> > >
> > > I've attached an updated patch that incorporates all comments I got so
> > > far. Please review it.
> >
On Mon, Nov 15, 2021 at 11:37 AM Dilip Kumar wrote:
>
> On Mon, Nov 15, 2021 at 10:34 AM vignesh C wrote:
>
> >
> > Thanks for the comments, the attached v12 patch has the changes for the
> > same.
>
> I have reviewed this patch and have some comments on v12-000
On Mon, Nov 15, 2021 at 7:47 AM Bharath Rupireddy
wrote:
>
> On Fri, Nov 5, 2021 at 11:12 AM Bharath Rupireddy
> wrote:
> > PSA v2 patch and review it.
>
> I've modified the docs part a bit, please consider v3 for review.
Thanks for the update patch, Few comments:
1) Should we change "CHECK_FOR_
On Tue, Nov 9, 2021 at 2:51 PM Amit Kapila wrote:
>
> On Tue, Nov 9, 2021 at 7:20 AM Peter Smith wrote:
> >
> > FYI - I spotted a trivial SQL mistake (?) of the schema publication patch
> > [1].
> >
> > See the file describe.c, function describeOneTableDetails.
> > The new SQL has a 3rd UNION t
On Tue, Nov 16, 2021 at 12:01 PM Masahiko Sawada wrote:
>
> On Mon, Nov 15, 2021 at 11:43 PM vignesh C wrote:
> >
> > On Mon, Nov 15, 2021 at 2:48 PM Masahiko Sawada
> > wrote:
> > >
> > > On Mon, Nov 15, 2021 at 4:49 PM Greg Nancarrow
> > &g
On Tue, Nov 16, 2021 at 12:01 PM Masahiko Sawada wrote:
>
> On Mon, Nov 15, 2021 at 11:43 PM vignesh C wrote:
> >
> > On Mon, Nov 15, 2021 at 2:48 PM Masahiko Sawada
> > wrote:
> > >
> > > On Mon, Nov 15, 2021 at 4:49 PM Greg Nancarrow
> > &g
On Tue, Nov 16, 2021 at 1:12 AM Justin Pryzby wrote:
>
> On Mon, Nov 15, 2021 at 09:12:49PM +0530, vignesh C wrote:
> > The idea here is to implement & expose pg_print_backtrace function,
> > internally
>
> This patch is closely related to this one
> https://co
On Tue, Nov 16, 2021 at 6:04 PM osumi.takami...@fujitsu.com
wrote:
>
> On Monday, November 15, 2021 9:14 PM I wrote:
> > I've conducted some update for this.
> > (The rebased part is only C code and checked by pgindent)
> I'll update my patches since a new skip xid patch
> has been shared in [1].
On Fri, Nov 19, 2021 at 9:22 AM Amit Kapila wrote:
>
> On Thu, Nov 18, 2021 at 5:10 PM Masahiko Sawada wrote:
> >
> > On Thu, Nov 18, 2021 at 5:45 PM tanghy.f...@fujitsu.com
> > wrote:
> > >
> > > On Tuesday, November 16, 2021 2:31 PM Masahiko Sawada
> > > wrote:
> > > >
> > > > Right. I've fi
On Fri, Nov 19, 2021 at 12:22 PM Amit Kapila wrote:
>
> On Fri, Nov 19, 2021 at 11:09 AM vignesh C wrote:
> >
> > On Fri, Nov 19, 2021 at 9:22 AM Amit Kapila wrote:
> > >
> > > On Thu, Nov 18, 2021 at 5:10 PM Masahiko Sawada
> > > wrote:
&g
On Thu, Nov 18, 2021 at 9:52 PM Justin Pryzby wrote:
>
> On Wed, Nov 17, 2021 at 08:12:44PM +0530, vignesh C wrote:
> > Attached v14 patch has the fixes for the same.
>
> Thanks for updating the patch.
>
> I cleaned up the docs and comments. I think this could be nearly
On Fri, Nov 19, 2021 at 7:41 PM Masahiko Sawada wrote:
>
> On Thu, Nov 18, 2021 at 12:26 PM Amit Kapila wrote:
> >
> > On Wed, Nov 17, 2021 at 7:12 PM osumi.takami...@fujitsu.com
> > wrote:
> > >
> > > On Wednesday, November 17, 2021 10:00 PM Amit Kapila
> > > wrote:
> > > >
> > > > Can you pl
On Thu, Nov 18, 2021 at 12:52 PM osumi.takami...@fujitsu.com
wrote:
>
> On Thursday, November 18, 2021 2:08 PM Greg Nancarrow
> wrote:
> > A minor comment:
> Thanks for your comments !
>
> > doc/src/sgml/ref/alter_subscription.sgml
> > (1) disable_on_err?
> >
> > + disable_on_err.
> >
> > T
On Thu, Nov 18, 2021 at 7:04 AM Peter Smith wrote:
>
> PSA new set of v40* patches.
Few comments:
1) When a table is added to the publication, replica identity is
checked. But while modifying the publish action to include
delete/update, replica identity is not checked for the existing
tables. I f
On Tue, Nov 23, 2021 at 4:58 PM Ajin Cherian wrote:
>
> Attaching a new patchset v41 which includes changes by both Peter and myself.
Few comments on v41-0002 patch:
1) Tab completion should be handled for completion of "WITH(" in
"create publication pub1 for table t1 where (c1 > 10)":
@@ -2757,1
On Tue, Nov 23, 2021 at 4:58 PM Ajin Cherian wrote:
>
> Attaching a new patchset v41 which includes changes by both Peter and myself.
>
> Patches v40-0005 and v40-0006 have been merged to create patch
> v41-0005 which reduces the patches to 6 again.
Few comments:
1) I'm not sure if we will be abl
On Wed, Nov 24, 2021 at 5:14 PM Masahiko Sawada wrote:
>
> On Wed, Nov 17, 2021 at 8:14 PM Amit Kapila wrote:
> >
> > On Tue, Nov 16, 2021 at 12:01 PM Masahiko Sawada
> > wrote:
> > >
> > > Right. I've fixed this issue and attached an updated patch.
One very minor comment:
conflict can be move
On Mon, Nov 15, 2021 at 10:27 PM Bharath Rupireddy
wrote:
>
> On Mon, Nov 15, 2021 at 10:04 PM vignesh C wrote:
> >
> > On Mon, Nov 15, 2021 at 7:47 AM Bharath Rupireddy
> > wrote:
> > >
> > > On Fri, Nov 5, 2021 at 11:12 AM Bharath Rupireddy
> &
On Sun, Nov 28, 2021 at 12:25 PM Bharath Rupireddy
wrote:
>
> On Sun, Nov 28, 2021 at 12:22 PM vignesh C wrote:
> > > Attaching v4 patch, please review it further.
> >
> > One small comment:
> > 1) There should be a space in between "LOGmessage level&quo
On Sun, Nov 28, 2021 at 7:15 PM Bharath Rupireddy
wrote:
>
> On Sun, Nov 28, 2021 at 5:21 PM vignesh C wrote:
> > Thanks for the updated patch, one comment:
> > 1) The function can be indented similar to other functions in the same
> > file:
> > +CREATE FUN
On Fri, Nov 26, 2021 at 8:06 PM osumi.takami...@fujitsu.com
wrote:
>
> On Monday, November 22, 2021 3:53 PM vignesh C wrote:
> > Few comments:
> Thank you so much for your review !
>
> > 1) Changes to handle pg_dump are missing. It should be done in
> > dumpSub
On Mon, Nov 29, 2021 at 9:13 AM Amit Kapila wrote:
>
> On Mon, Nov 29, 2021 at 7:12 AM Masahiko Sawada wrote:
> >
> > On Sat, Nov 27, 2021 at 7:56 PM Amit Kapila wrote:
> > >
> >
> > Thank you for updating the patch!
> >
> > > I have made a number of changes in the attached patch which includes
> > previous code without using an additional variable.
> >
>
> Fixed.
>
> > 2.
> > +typedef struct {
> > + Relation rel;
> > + bool check_replident;
> > + Bitmapset *bms_replident;
> > +}
> > +rf_context;
> >
> > Add rf_conte
On Tue, Nov 30, 2021 at 12:33 PM Ajin Cherian wrote:
>
> On Thu, Nov 25, 2021 at 2:22 PM Peter Smith wrote:
> >
> > Thanks for all the review comments so far! We are endeavouring to keep
> > pace with them.
> >
> > All feedback is being tracked and we will fix and/or reply to everything
> > ASAP
On Tue, Nov 30, 2021 at 7:09 PM Masahiko Sawada wrote:
>
> On Tue, Nov 30, 2021 at 8:41 PM Masahiko Sawada wrote:
> >
> > On Tue, Nov 30, 2021 at 6:28 PM Amit Kapila wrote:
> > >
> > > On Mon, Nov 29, 2021 at 11:38 AM vignesh C wrote:
> > > >
>
On Tue, Nov 30, 2021 at 5:34 PM osumi.takami...@fujitsu.com
wrote:
>
> On Tuesday, November 30, 2021 1:10 PM Greg Nancarrow
> wrote:
> > On Sat, Nov 27, 2021 at 1:36 AM osumi.takami...@fujitsu.com
> > wrote:
> > >
> > > This v7 uses v26 of skip xid patch [1]
> > This patch no longer applies on
On Thu, Dec 2, 2021 at 9:29 AM houzj.f...@fujitsu.com
wrote:
>
> On Thur, Dec 2, 2021 5:21 AM Peter Smith wrote:
> > PSA the v44* set of patches.
> >
> > The following review comments are addressed:
> >
> > v44-0001 main patch
> > - Renamed the TAP test 026->027 due to clash caused by recent comm
,
Vignesh
From d0d0d2d8944a66f28b239da5fb80c15415a016e6 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Thu, 2 Dec 2021 19:44:15 +0530
Subject: [PATCH v1] Fix for new owner of ALL TABLES IN SCHEMA publication
should be superuser.
Currently while changing the owner of ALL TABLES IN SCHEMA publication
On Fri, Dec 3, 2021 at 9:58 AM Bossart, Nathan wrote:
>
> On 12/2/21, 7:07 PM, "vignesh C" wrote:
> > Currently while changing the owner of ALL TABLES IN SCHEMA
> > publication, it is not checked if the new owner has superuser
> > permission or not. Added a
On Fri, Dec 3, 2021 at 9:53 AM Greg Nancarrow wrote:
>
> On Fri, Dec 3, 2021 at 2:06 PM vignesh C wrote:
> >
> > Currently while changing the owner of ALL TABLES IN SCHEMA
> > publication, it is not checked if the new owner has superuser
> > permission or not. Adde
On Wed, Dec 1, 2021 at 3:04 PM osumi.takami...@fujitsu.com
wrote:
>
> On Friday, November 19, 2021 11:11 PM Masahiko Sawada
> wrote:
> > Besides that, I’m not sure how useful commit_bytes, abort_bytes, and
> > error_bytes are. I originally thought these statistics track the size of
> > received
On Fri, Dec 3, 2021 at 12:45 AM Alvaro Herrera wrote:
>
> On 2021-Sep-16, Peter Smith wrote:
>
> > I noticed that the latest v5 no longer includes the TAP test which was
> > in the v4 patch.
> >
> > (src/test/subscription/t/021_column_filter.pl)
> >
> > Was that omission deliberate?
>
> Somehow I
On Fri, Dec 3, 2021 at 1:13 PM Michael Paquier wrote:
>
> On Thu, Aug 26, 2021 at 09:00:39PM +0530, vignesh C wrote:
> > The previous patch was failing because of the recent test changes made
> > by commit 201a76183e2 which unified new and get_new_node, attached
> >
On Sat, Dec 4, 2021 at 6:32 PM osumi.takami...@fujitsu.com
wrote:
>
> On Friday, December 3, 2021 3:12 PM vignesh C wrote:
> > Thanks for the updated patch.
> > Currently we are storing the commit count, error_count and abort_count for
> > each table of the table sy
code. The attached v3 patch has the changes
for the same.
Regards,
Vignesh
From cc4226ced0e535a324dde5b1ff0e48d6e0035e17 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Thu, 2 Dec 2021 19:44:15 +0530
Subject: [PATCH v3] Fix for new owner of ALL TABLES IN SCHEMA publication
should be superuser.
Cu
On Tue, Dec 7, 2021 at 6:07 AM Masahiko Sawada wrote:
>
> Hi all,
>
> While updating the patch I recently posted[1] to make pg_waldump
> report replication origin ID, LSN, and timestamp, I found a bug that
> replication origin timestamp is not set in ROLLBACK PREPARED case.
> Commit 8bdb1332eb5 (C
On Fri, Dec 3, 2021 at 11:24 AM houzj.f...@fujitsu.com
wrote:
>
> On Thursday, December 2, 2021 4:54 PM houzj.f...@fujitsu.com
> wrote:
> > On Thursday, December 2, 2021 12:50 PM Amit Kapila
> > wrote:
> > > On Thu, Dec 2, 2021 at 9:41 AM Greg Nancarrow
> > > wrote:
> > > >
> > > > On Thu, Dec
On Sun, Aug 8, 2021 at 4:26 PM tanghy.f...@fujitsu.com
wrote:
>
> On Sunday, August 8, 2021 6:34 PM, vignesh C wrote
> >Thanks for the updated patch, your changes look good to me. You might
> >want to include the commit message in the patch, that will be useful.
>
>
On Wed, Dec 8, 2021 at 11:11 AM Amit Kapila wrote:
>
> On Tue, Dec 7, 2021 at 5:53 PM vignesh C wrote:
> >
> > On Fri, Dec 3, 2021 at 11:24 AM houzj.f...@fujitsu.com
> > wrote:
> > >
> >
> > 2) Any particular reason why the code and tests are
On Fri, Dec 10, 2021 at 6:24 AM Alvaro Herrera wrote:
>
> I just noticed that this (commit 5a2832465fd8) added a separate catalog
> to store schemas which are part of a publication, side-by-side with the
> catalog to store relations which are part of a publication. This seems
> a strange way to r
On Mon, Dec 6, 2021 at 4:22 PM osumi.takami...@fujitsu.com
wrote:
>
> On Monday, December 6, 2021 1:16 PM Greg Nancarrow
> wrote:
> > On Sat, Dec 4, 2021 at 12:20 AM osumi.takami...@fujitsu.com
> > wrote:
> > >
> > > Hi, I've made a new patch v11 that incorporated suggestions described
> > abov
On Tue, Dec 7, 2021 at 3:12 PM osumi.takami...@fujitsu.com
wrote:
>
> On Monday, December 6, 2021 11:27 PM vignesh C wrote:
> > Thanks for the updated patch, few comments:
> Thank you for your review !
>
> > 1) We can keep the documentation similar to mention the count
On Wed, Dec 8, 2021 at 11:07 AM tanghy.f...@fujitsu.com
wrote:
>
> On Wednesday, December 8, 2021 1:49 PM, vignesh C wrote:
>
> > The patch no longer applies, could you post a rebased patch.
>
> Thanks for your kindly reminder. Attached a rebased patch.
> Some changes in
On Fri, Dec 10, 2021 at 11:14 AM Masahiko Sawada wrote:
>
> On Thu, Dec 9, 2021 at 6:16 PM Amit Kapila wrote:
> >
> > On Thu, Dec 9, 2021 at 2:24 PM Masahiko Sawada
> > wrote:
> > >
> > > On Thu, Dec 9, 2021 at 11:47 AM Amit Kapila
> > > wrote:
> > > >
> > > > I am thinking that we can start
On Fri, Dec 10, 2021 at 11:14 AM Masahiko Sawada wrote:
>
> On Thu, Dec 9, 2021 at 6:16 PM Amit Kapila wrote:
> >
> > On Thu, Dec 9, 2021 at 2:24 PM Masahiko Sawada
> > wrote:
> > >
> > > On Thu, Dec 9, 2021 at 11:47 AM Amit Kapila
> > > wrote:
> > > >
> > > > I am thinking that we can start
On Tue, Dec 14, 2021 at 7:58 AM Amit Kapila wrote:
>
> On Mon, Dec 13, 2021 at 5:48 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Monday, December 13, 2021 6:19 PM Amit Kapila
> > wrote:
> > > On Tue, Dec 7, 2021 at 3:12 PM osumi.takami...@fujitsu.com
> > > wrote:
> > >
> > > Few question
On Mon, Dec 20, 2021 at 8:41 AM houzj.f...@fujitsu.com
wrote:
>
> On Fri, Dec 17, 2021 6:09 PM Amit Kapila wrote:
> > On Fri, Dec 17, 2021 at 4:11 AM Peter Smith wrote:
> > >
> > > PSA the v47* patch set.
> Thanks for the comments, I agree with all the comments.
> Attach the V49 patch set, which
On Tue, Dec 21, 2021 at 2:29 PM Peter Smith wrote:
>
> Here is the v51* patch set:
>
> Main changes from Euler's v50* are
> 1. Most of Euler's "fixes" patches are now merged back in
> 2. Patches are then merged per Amit's suggestion [Amit 20/12]
> 3. Some other review comments are addressed
>
> ~~
On Tue, Dec 21, 2021 at 2:29 PM Peter Smith wrote:
>
> Here is the v51* patch set:
>
I tweaked the query slightly based on Euler's changes, the explain
analyze of the updated query based on Euler's suggestions, existing
query and Euler's query is given below:
1) updated query based on Euler's sug
On Fri, Dec 11, 2020 at 4:30 PM Greg Nancarrow wrote:
>
> Posting an updated set of patches to address recent feedback:
>
> - Removed conditional-locking code used in parallel-safety checking
> code (Tsunakawa-san feedback). It turns out that for the problem test
> case, no parallel-safety checkin
On Fri, Jan 8, 2021 at 4:32 PM Amit Kapila wrote:
>
> On Thu, Jan 7, 2021 at 10:03 PM vignesh C wrote:
> >
> > This feature adds schema option while creating publication. Users will
> > be able to specify one or more schemas while creating publication,
> > when th
Thanks for your comments Bharath, please find my opinion below.
On Sat, Jan 9, 2021 at 8:08 PM Bharath Rupireddy
wrote:
> I think this feature can be useful, in case a user has a lot of tables
> to publish inside a schema. Having said that, I wonder if this feature
> mandates users to create the
On Sat, Jan 9, 2021 at 8:14 PM Bharath Rupireddy
wrote:
>
> One more point - if the publication is created for a schema with no or
> some initial tables, will all the future tables that may get added to
> the schema will be replicated too?
>
I agree on this, when a relation is added to the schema
On Mon, Jan 11, 2021 at 11:45 AM Bharath Rupireddy
wrote:
>
> On Sun, Jan 10, 2021 at 11:21 PM vignesh C wrote:
> > On Sat, Jan 9, 2021 at 8:08 PM Bharath Rupireddy
> > wrote:
> > > I think this feature can be useful, in case a user has a lot of tables
> > >
Thanks Rahila for your comments, please find my thoughts below.
On Tue, Jan 12, 2021 at 5:16 PM Rahila Syed wrote:
>
> Hi Vignesh,
>
> I had a look at the patch, please consider following comments.
>
> On Thu, Jan 7, 2021 at 10:03 PM vignesh C wrote:
>>
>> Hi,
On Sat, Jan 16, 2021 at 1:40 AM Andres Freund wrote:
>
> On 2021-01-15 09:53:05 +0100, Peter Eisentraut wrote:
> > On 2020-12-08 10:38, vignesh C wrote:
> > > I have implemented printing of backtrace based on handling it in
> > > CHECK_FOR_INTERRUPTS. This patch als
On Sat, Jan 16, 2021 at 11:10 PM Andres Freund wrote:
>
> Hi,
>
> On Sat, Jan 16, 2021, at 09:34, vignesh C wrote:
> > On Sat, Jan 16, 2021 at 1:40 AM Andres Freund wrote:
> > >
> > > On 2021-01-15 09:53:05 +0100, Peter Eisentraut wrote:
> > > > O
On Sat, Jan 9, 2021 at 5:21 PM vignesh C wrote:
>
> On Fri, Jan 8, 2021 at 4:32 PM Amit Kapila wrote:
> >
> > On Thu, Jan 7, 2021 at 10:03 PM vignesh C wrote:
> > >
> > > This feature adds schema option while creating publication. Users will
> > >
On Sat, Jan 9, 2021 at 8:08 PM Bharath Rupireddy <
bharath.rupireddyforpostg...@gmail.com> wrote:
>
>
> As Amit pointed out earlier, the behaviour when schema dropped, I
> think we should also consider when schema is altered, say altered to a
> different name, maybe we should change that in the pub
On Sun, Jan 17, 2021 at 10:26 PM vignesh C wrote:
>
> On Sat, Jan 16, 2021 at 11:10 PM Andres Freund wrote:
> >
> > Hi,
> >
> > On Sat, Jan 16, 2021, at 09:34, vignesh C wrote:
> > > On Sat, Jan 16, 2021 at 1:40 AM Andres Freund wrote:
> > &g
On Wed, Jan 20, 2021 at 2:52 AM Tom Lane wrote:
>
> Robert Haas writes:
> > On Tue, Jan 19, 2021 at 12:50 PM Tom Lane wrote:
> >> I think it's got security hazards as well. If we restricted the
> >> feature to cause a trace of only one process at a time, and required
> >> that process to be log
From 2e7a6e41f789f7f1717058e9c78441ae8d5faf9e Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Thu, 21 Jan 2021 18:38:54 +0530
Subject: [PATCH v1] Identify missing publications from publisher while
create/alter subscription.
Creating/altering subscription is successful when we specify a publication
Thanks Rahila for your comments. Please find my thoughts below:
On Wed, Jan 20, 2021 at 6:27 PM Rahila Syed wrote:
>
> Hi Vignesh,
>
>>
>> I have handled the above scenario(drop schema should automatically
>> remove the schema entry from publication schema relation) & addition
>> of tests in the
On Fri, Jan 22, 2021 at 12:14 PM Bharath Rupireddy
wrote:
>
> On Fri, Jan 22, 2021 at 10:14 AM japin wrote:
> > > 2) Can't we know whether the publications exist on the publisher with
> > > the existing (or modifying it a bit if required) query in
> > > fetch_table_list(), so that we can avoid ma
On Fri, Jan 22, 2021 at 10:14 AM japin wrote:
>
>
> On Fri, 22 Jan 2021 at 00:51, Bharath Rupireddy
> wrote:
> > On Thu, Jan 21, 2021 at 6:56 PM vignesh C wrote:
> >>
> >> Hi,
> >>
> >> Creating/altering subscription is successful when we
On Thu, Jan 21, 2021 at 10:21 PM Bharath Rupireddy
wrote:
>
> On Thu, Jan 21, 2021 at 6:56 PM vignesh C wrote:
> >
> > Hi,
> >
> > Creating/altering subscription is successful when we specify a
> > publication which does not exist in the publisher. I felt
On Mon, Jan 25, 2021 at 5:18 PM japin wrote:
>
>
> On Mon, 25 Jan 2021 at 17:18, Bharath Rupireddy
> wrote:
> > On Mon, Jan 25, 2021 at 2:42 PM Dilip Kumar wrote:
> >>
> >> On Mon, Jan 25, 2021 at 1:10 PM vignesh C wrote:
> >> >
> >
On Mon, Jan 25, 2021 at 3:07 PM Dilip Kumar wrote:
>
> On Mon, Jan 25, 2021 at 2:48 PM Bharath Rupireddy
> wrote:
> >
> > On Mon, Jan 25, 2021 at 2:42 PM Dilip Kumar
wrote:
> > >
> > > On Mon, Jan 25, 2021 at 1:10 PM vignesh C wrote:
> > > &g
has
fixes based on the suggestions. It includes the following fixes: 1)
Removal of support to get callstack of all postgres process, user can
get only one process callstack. 2) Update the documentation. 3) Added
necessary checks for pg_print_callstack similar to
pg_terminate_backend. 4) Changed
On Wed, Jan 27, 2021 at 10:40 PM Andres Freund wrote:
>
> Hi,
>
> On 2021-01-27 19:05:16 +0530, vignesh C wrote:
>
> > /*
> > + * LogBackTrace
> > + *
> > + * Get the backtrace and log the backtrace to log file.
> > + */
> >
Thanks Bharath for your review comments. Please find my comments inline below.
On Thu, Jan 28, 2021 at 7:40 PM Bharath Rupireddy
wrote:
>
> On Thu, Jan 28, 2021 at 5:22 PM vignesh C wrote:
> > Thanks for the comments, I have fixed and attached an updated patch
> > with the
On Fri, Jan 22, 2021 at 10:01 AM vignesh C wrote:
>
> Thanks Rahila for your comments. Please find my thoughts below:
>
> On Wed, Jan 20, 2021 at 6:27 PM Rahila Syed wrote:
> >
> > Hi Vignesh,
> >
> >>
> >> I have handled the above scenario(drop sc
Thanks Bharath for your comments.
On Mon, Feb 1, 2021 at 6:14 AM Bharath Rupireddy
wrote:
>
> On Fri, Jan 29, 2021 at 7:10 PM vignesh C wrote:
> > > 4) How about following
> > > + errmsg("must be a superuser to print backtrace
> > > of
On Mon, Feb 1, 2021 at 11:04 AM Bharath Rupireddy
wrote:
>
> On Mon, Feb 1, 2021 at 6:14 AM Bharath Rupireddy
> wrote:
> > On Fri, Jan 29, 2021 at 7:10 PM vignesh C wrote:
> > > > 4) How about following
> > > > + errmsg("must
On Wed, Feb 3, 2021 at 1:00 PM Tom Lane wrote:
>
> vignesh C writes:
> > On Mon, Feb 1, 2021 at 11:04 AM Bharath Rupireddy
> > wrote:
> >> Are these superuser and permission checks enough from a security
> >> standpoint that we don't expose so
I have made a patch for the above with the changes suggested and
rebased it with the head code.
Attached v21 patch which has the changes for the same.
Thoughts?
Regards,
Vignesh
From 9d85abfe1e4b43d67ee746891830abe53077c0e7 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Mon, 8 Feb 2021 11:23:31 +0530
Subject: [PAT
On Tue, Feb 9, 2021 at 5:47 AM Greg Nancarrow wrote:
>
> On Mon, Feb 8, 2021 at 8:17 PM vignesh C wrote:
> >
> > >
> > > I think what we want to do is mark default_transaction_read_only as
> > > GUC_REPORT, instead. That will give a reliable report of what
Thanks for the comments Greg, please find my comments inline below.
On Tue, Feb 9, 2021 at 2:27 PM Greg Nancarrow wrote:
>
> On Mon, Feb 8, 2021 at 8:17 PM vignesh C wrote:
> >
> > >
> > > I think what we want to do is mark default_transaction_read_only as
> &g
On Mon, Sep 13, 2021 at 7:06 PM tanghy.f...@fujitsu.com
wrote:
>
> On Sunday, September 12, 2021 11:13 PM vignesh C wrote:
> >
> > Thanks for the changes, the suggested changes make the parsing code
> > simpler. I have merged the changes to the main patch. Attached v27
&
On Tue, Sep 14, 2021 at 6:31 AM houzj.f...@fujitsu.com
wrote:
>
> From Sun, Sept 12, 2021 11:13 PM vignesh C wrote:
> > On Fri, Sep 10, 2021 at 11:21 AM Hou Zhijie wrote:
> > > Attach the without-flag version and add comments about the pubobj_name.
> >
> > Than
On Tue, Sep 7, 2021 at 11:38 AM houzj.f...@fujitsu.com
wrote:
>
> From Tues, Sep 7, 2021 12:02 PM Amit Kapila wrote:
> > On Mon, Sep 6, 2021 at 1:49 PM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > I can reproduce this bug.
> > >
> > > I think the reason is it didn't invalidate all the leaf par
On Wed, Sep 15, 2021 at 5:20 PM Alvaro Herrera wrote:
>
> On 2021-Sep-15, Amit Kapila wrote:
>
> > On Mon, Sep 6, 2021 at 11:21 PM Alvaro Herrera
> > wrote:
> > >
> > > I pushed the clerical part of this -- namely the addition of
> > > PublicationTable node and PublicationRelInfo struct.
> >
> >
On Thu, Sep 16, 2021 at 8:45 AM Amit Kapila wrote:
>
> On Wed, Sep 15, 2021 at 6:06 PM Alvaro Herrera
> wrote:
> >
> > On 2021-Sep-15, vignesh C wrote:
> > > The patch
> > > Generic_object_type_parser_002_table_schema_publication.patch has the
> > &
On Thu, Sep 16, 2021 at 7:20 PM Alvaro Herrera wrote:
>
> On 2021-Sep-16, vignesh C wrote:
>
> > diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
> > index e3068a374e..c50bb570ea 100644
> > --- a/src/backend/parser/gram.y
> > +++ b/src/backend/p
On Thu, Sep 16, 2021 at 8:59 AM houzj.f...@fujitsu.com
wrote:
>
> On Tuesday, September 14, 2021 4:39 PM vignesh C wrote:
> >
> > I have handled this in the patch attached.
>
> Thanks for updating the patch.
> Here are some comments.
>
> 1)
> +st
On Thu, Sep 16, 2021 at 9:54 AM Amit Kapila wrote:
>
> On Wed, Sep 15, 2021 at 12:30 PM Amit Kapila wrote:
> >
> > On Tue, Sep 14, 2021 at 2:08 PM vignesh C wrote:
> > >
> > > I have handled this in the patch attached.
> >
On Thu, Sep 16, 2021 at 11:24 AM Amit Kapila wrote:
>
> On Wed, Sep 15, 2021 at 4:45 PM Greg Nancarrow wrote:
> >
> > On Tue, Sep 14, 2021 at 6:38 PM vignesh C wrote:
> > >
> > > I have handled this in the patch attached.
> > >
> >
> &g
On Mon, Sep 20, 2021 at 3:57 PM Amit Kapila wrote:
>
> On Fri, Sep 17, 2021 at 5:40 PM vignesh C wrote:
> >
> > On Thu, Sep 16, 2021 at 9:54 AM Amit Kapila wrote:
> > >
> > > I think there is one more similar locking problem.
> > > AlterPublicati
On Tue, Sep 21, 2021 at 9:03 AM Greg Nancarrow wrote:
>
> On Fri, Sep 17, 2021 at 10:09 PM vignesh C wrote:
> >
> > Attached v29 patch has the fixes for the same.
> >
>
> Some minor comments on the v29-0002 patch:
>
> (1)
> In get_object_address_
On Mon, Sep 20, 2021 at 4:20 PM vignesh C wrote:
>
> On Mon, Sep 20, 2021 at 3:57 PM Amit Kapila wrote:
> >
> > On Fri, Sep 17, 2021 at 5:40 PM vignesh C wrote:
> > >
> > > On Thu, Sep 16, 2021 at 9:54 AM Amit Kapila
> > > wrote:
> > &g
On Tue, Sep 21, 2021 at 9:03 AM Greg Nancarrow wrote:
>
> On Fri, Sep 17, 2021 at 10:09 PM vignesh C wrote:
> >
> > Attached v29 patch has the fixes for the same.
> >
>
> Some minor comments on the v29-0002 patch:
>
> (1)
> In get_object_address_
On Tue, Sep 21, 2021 at 6:05 PM Greg Nancarrow wrote:
>
> On Tue, Sep 21, 2021 at 4:12 PM vignesh C wrote:
> >
> > > (1)
> > > In get_object_address_publication_schema(), the error message:
> > >
> > > + errmsg("publication tables of sch
On Fri, Sep 24, 2021 at 8:40 AM Amit Kapila wrote:
>
> On Fri, Sep 24, 2021 at 12:45 AM Tomas Vondra
> wrote:
> >
> > Hi,
> >
> > I wanted to do a review of this patch, but I'm a bit confused about
> > which patch(es) to review. There's the v5 patch, and then these two
> > patches - which seem to
On Wed, Sep 22, 2021 at 8:52 AM Masahiko Sawada wrote:
>
> On Wed, Sep 22, 2021 at 3:02 AM vignesh C wrote:
> >
> >
> > Attached v30 patch has the fixes for the same.
> >
>
> Thank you for updating the patches.
>
> Here are random comments on v30-0002
201 - 300 of 1409 matches
Mail list logo
