On Fri, 11 Nov 2022 at 11:13, wangw.f...@fujitsu.com
wrote:
>
> On Fri, Oct 21, 2022 at 17:02 PM Peter Smith wrote:
> >
>
> Thanks for your comments. Sorry for not replying in time.
>
> > On Mon, Oct 17, 2022 at 4:49 PM wangw.f...@fujitsu.com
> > wrote:
> > >
> > > On Wed, Oct 5, 2022 at
On Mon, 24 Oct 2022 at 13:15, Peter Smith wrote:
>
> Hi hackers.
>
> There is a docs Logical Replication section "31.10 Configuration
> Settings" [1] which describes some logical replication GUCs, and
> details on how they interact with each other and how to take that into
> account when setting
On Thu, 11 Aug 2022 at 02:03, Euler Taveira wrote:
>
> On Wed, Aug 10, 2022, at 9:39 AM, osumi.takami...@fujitsu.com wrote:
>
> Minor review comments for v6.
>
> Thanks for your review. I'm attaching v7.
>
> "If the subscriber sets min_apply_delay parameter, ..."
>
> I suggest we use subscription
n updated patch which is rebased on top of HEAD.
Regards,
Vignesh
From 22d17bd8eeb2c35870b80cbc41c23e89e2c8f981 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Sun, 6 Nov 2022 06:34:44 +0530
Subject: [PATCH v9 1/2] Add RESET clause to Alter Publication which will reset
the publication with defaul
On Wed, 2 Nov 2022 at 05:13, vignesh C wrote:
>
> On Mon, 31 Oct 2022 at 16:17, vignesh C wrote:
> >
> > On Thu, 27 Oct 2022 at 16:02, vignesh C wrote:
> > >
> > > On Thu, 27 Oct 2022 at 02:09, Zheng Li wrote:
> > > >
> > > > > Add
On Mon, 31 Oct 2022 at 16:17, vignesh C wrote:
>
> On Thu, 27 Oct 2022 at 16:02, vignesh C wrote:
> >
> > On Thu, 27 Oct 2022 at 02:09, Zheng Li wrote:
> > >
> > > > Adding support for deparsing of CREATE/ALTER/DROP LANGUAGE for ddl
> > > > re
On Thu, 27 Oct 2022 at 16:02, vignesh C wrote:
>
> On Thu, 27 Oct 2022 at 02:09, Zheng Li wrote:
> >
> > > Adding support for deparsing of CREATE/ALTER/DROP LANGUAGE for ddl
> > > replication.
> >
> > Adding support for deparsing of:
> > COMM
On Fri, 28 Oct 2022 at 08:02, Dong Wook Lee wrote:
>
> On Fri, Oct 28, 2022 at 12:08 AM vignesh C wrote:
> >
> > Hi,
> >
> > Tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE action was
> > missing, this patch adds the tab completion for the same.
>
Hi,
Tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE action was
missing, this patch adds the tab completion for the same.
Regards,
Vignesh
From 4b0473799a0d6af126ccd3d7802e5d0cbb83b944 Mon Sep 17 00:00:00 2001
From: "vignesh.c"
Date: Thu, 27 Oct 2022 14:00:46 +0530
Subject: [PATCH v1] Tab
On Mon, 24 Oct 2022 at 12:30, Michael Paquier wrote:
>
> On Wed, Oct 19, 2022 at 04:06:51PM +0530, vignesh C wrote:
> > I noticed that the tab completion for ALTER STATISTICS .. SET was not
> > handled. The attached patch displays SCHEMA and STATISTICS for tab
> > comple
HI,
I noticed that the tab completion for ALTER STATISTICS .. SET was not
handled. The attached patch displays SCHEMA and STATISTICS for tab
completion of ALTER STATISTICS name SET.
Regards,
Vignesh
From 2177167ee74ab3748e23aac15c65b8391e73528f Mon Sep 17 00:00:00 2001
From: "vignesh.c"
Date:
On Wed, 12 Oct 2022 at 16:16, vignesh C wrote:
>
> On Thu, 6 Oct 2022 at 12:44, Amit Kapila wrote:
> >
> > On Sat, Oct 1, 2022 at 12:35 AM Andres Freund wrote:
> > >
> > > This issue does occasionally happen in CI, as e.g. noted in this thread:
> &g
On Thu, 6 Oct 2022 at 12:44, Amit Kapila wrote:
>
> On Sat, Oct 1, 2022 at 12:35 AM Andres Freund wrote:
> >
> > This issue does occasionally happen in CI, as e.g. noted in this thread:
> > https://www.postgresql.org/message-id/20220930185345.GD6256%40telsasoft.com
> >
> > On 2022-08-18 15:17:47
On Wed, 5 Oct 2022 at 08:17, Michael Paquier wrote:
>
> On Tue, Oct 04, 2022 at 10:35:25AM +0100, Dagfinn Ilmari Mannsåker wrote:
> > LGTM, +1 to commit.
>
> Fine by me, so done.
Thanks for pushing this.
Regards,
Vignesh
On Tue, 4 Oct 2022 at 09:13, Michael Paquier wrote:
>
> On Mon, Oct 03, 2022 at 06:29:32PM +0100, Dagfinn Ilmari Mannsåker wrote:
> > vignesh C writes:
> >> +else if (TailMatchesCS("\\dRp*"))
> >> +COMPLETE_WITH_QUERY(Query_for_list_o
he changes to handle the same.
Regards,
Vignesh
From 1d454be7e89828bdacb191681e469c9581b615d5 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Sun, 2 Oct 2022 10:45:04 +0530
Subject: [PATCH v1 1/2] Display publications and subscriptions for tab
completion of \dRp and \dRs.
Display pu
On Sat, 10 Sept 2022 at 07:32, Amit Kapila wrote:
>
> On Fri, Sep 9, 2022 at 8:48 PM Robert Haas wrote:
> >
> > On Fri, Sep 9, 2022 at 10:29 AM houzj.f...@fujitsu.com
> > wrote:
> > > IIRC, the feature currently works almost the same as you described. It
> > > doesn't
> > > create entry for
On Fri, 9 Sept 2022 at 11:12, Amit Kapila wrote:
>
> On Thu, Sep 8, 2022 at 9:32 AM vignesh C wrote:
> >
> >
> > The attached patch has the changes to handle the same.
> >
>
> Pushed. I am not completely sure whether we want the remaining
> documentation p
On Thu, 8 Sept 2022 at 08:57, vignesh C wrote:
>
> On Thu, 8 Sept 2022 at 08:23, Amit Kapila wrote:
> >
> > On Thu, Sep 8, 2022 at 7:57 AM vignesh C wrote:
> > >
> > > There is a buildfarm failure on mylodon at [1] because of the new test
> > >
On Thu, 8 Sept 2022 at 08:23, Amit Kapila wrote:
>
> On Thu, Sep 8, 2022 at 7:57 AM vignesh C wrote:
> >
> > There is a buildfarm failure on mylodon at [1] because of the new test
> > added. I will analyse and share the findings for the same.
> >
> > [1] -
Hi,
There is a buildfarm failure on mylodon at [1] because of the new test
added. I will analyse and share the findings for the same.
[1] -
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=mylodon=2022-09-08%2001%3A40%3A27
Regards,
Vignesh
On Wed, 7 Sept 2022 at 17:10, vignesh C wrote
On Wed, 7 Sept 2022 at 14:34, Amit Kapila wrote:
>
> On Wed, Sep 7, 2022 at 9:53 AM vignesh C wrote:
> >
> > Thanks for the comments, the attached v47 patch has the changes for the
> > same.
> >
>
> V47-0001* looks good to me apart from below minor things. I
On Tue, 6 Sept 2022 at 15:25, Amit Kapila wrote:
>
> On Tue, Sep 6, 2022 at 9:31 AM wangw.f...@fujitsu.com
> wrote:
> >
> > On Tues, 6 Sept 2022 at 11:14, vignesh C wrote:
> > > Thanks for the comments, the attached patch has the changes for the same.
> &g
On Tue, 6 Sept 2022 at 09:31, wangw.f...@fujitsu.com
wrote:
>
> On Tues, 6 Sept 2022 at 11:14, vignesh C wrote:
> > Thanks for the comments, the attached patch has the changes for the same.
>
> Thanks for updating the patch.
>
> Here is one comment for 0001 patch.
&g
On Tue, 6 Sept 2022 at 09:31, shiy.f...@fujitsu.com
wrote:
>
> On Tue, Sep 6, 2022 11:14 AM vignesh C wrote:
> >
> > Thanks for the comments, the attached patch has the changes for the same.
> >
>
> Thanks for updating the patch. Here are some comments.
>
On Mon, 5 Sept 2022 at 15:10, Amit Kapila wrote:
>
> On Mon, Sep 5, 2022 at 9:47 AM Peter Smith wrote:
> >
> > Here are my review comments for v45-0001:
> >
> > ==
> >
> > 1. doc/src/sgml/logical-replication.sgml
> >
> >
> >To find which tables might potentially include non-local
On Mon, 5 Sept 2022 at 09:47, Peter Smith wrote:
>
> Here are my review comments for v45-0001:
>
> ==
>
> 1. doc/src/sgml/logical-replication.sgml
>
>
>To find which tables might potentially include non-local origins (due to
>other subscriptions created on the publisher) try this
On Fri, 2 Sept 2022 at 13:51, Peter Smith wrote:
>
> Here are my review comments for the latest patch v44-0001.
>
> ==
>
> 1. doc/src/sgml/logical-replication.sgml
>
> +
> + Specifying origins for subscription
>
> I thought the title is OK, but maybe can be better. OTOH, I am not
> sure if
On Mon, 29 Aug 2022 at 16:35, Amit Kapila wrote:
>
> On Wed, Aug 24, 2022 at 7:27 PM vignesh C wrote:
> >
> > Since there was no objections to change it to throw a warning, I have
> > made the changes for the same.
> >
>
> Review comments for v42-0001*
>
On Thu, 1 Sept 2022 at 09:19, Amit Kapila wrote:
>
> On Wed, Aug 31, 2022 at 11:35 AM Peter Smith wrote:
> >
> > Here are my review comments for v43-0001.
> >
> > ==
> >
> > 1. Commit message
> >
> > The initial copy phase has no way to know the origin of the row data,
> > so if 'copy_data =
On Thu, 1 Sept 2022 at 08:01, shiy.f...@fujitsu.com
wrote:
>
> On Wed, Aug 31, 2022 1:06 AM vignesh C wrote:
> >
> > The attached v43 patch has the changes for the same.
> >
>
> Thanks for updating the patch.
>
> Here is a comment on the 0001 patch.
On Wed, 31 Aug 2022 at 11:45, Peter Smith wrote:
>
> Here are some review comments for patch v43-0002:
>
> ==
>
> 1. doc/src/sgml/ref/create_subscription.sgml
>
> @@ -403,7 +403,9 @@ CREATE SUBSCRIPTION class="parameter">subscription_name warning to notify the user to check the publisher
On Mon, 29 Aug 2022 at 16:35, Amit Kapila wrote:
>
> On Wed, Aug 24, 2022 at 7:27 PM vignesh C wrote:
> >
> > Since there was no objections to change it to throw a warning, I have
> > made the changes for the same.
> >
>
> Review comments for v42-0001*
>
On Wed, 31 Aug 2022 at 11:35, Peter Smith wrote:
>
> Here are my review comments for v43-0001.
>
> ==
>
> 1. Commit message
>
> The initial copy phase has no way to know the origin of the row data,
> so if 'copy_data = true' in the step 4 below, log a warning to notify user
> that potentially
On Mon, 29 Aug 2022 at 12:01, Peter Smith wrote:
>
> Here are some review comments for patch v42-0002:
>
> ==
>
> 1. doc/src/sgml/logical-replication.sgml
>
> copy_data = true
>
> There are a couple of these tags where there is a trailing space
> before the . I guess it is doing no harm, but
On Mon, 29 Aug 2022 at 11:59, Peter Smith wrote:
>
> Here are some review comments for patch v42-0001:
>
> ==
>
> 1. Commit message
>
> A later review comment below suggests some changes to the WARNING
> message so if those changes are made then the example in this commit
> message also needs
On Fri, Aug 26, 2022 at 9:52 AM Dilip Kumar wrote:
>
> On Mon, Aug 22, 2022 at 9:19 AM houzj.f...@fujitsu.com
> wrote:
> >
> > > Jonathan, Sawada-San, Hou-San, and others, what do you think is the best
> > > way
> > > to move forward here?
> >
> > I think it's fine to throw a WARNING in this
On Tue, Aug 23, 2022 at 7:52 AM Peter Smith wrote:
>
> On Mon, Aug 22, 2022 at 9:25 PM vignesh C wrote:
> >
> ...
>
> > Few comments:
> > 1) I felt no expressions are allowed in case of column filters. Only
> > column names can be specified. The second pa
On Mon, Aug 22, 2022 at 9:19 AM houzj.f...@fujitsu.com
wrote:
>
> On Thursday, August 18, 2022 11:13 AM Amit Kapila
> wrote:
> >
> > On Wed, Aug 17, 2022 at 12:34 PM Peter Smith
> > wrote:
> > >
> > > On Wed, Aug 17, 2022 at 4:33 PM Amit Kapila
> > wrote:
> > > >
> > > > On Wed, Aug 17, 2022
On Tue, Aug 16, 2022 at 9:04 PM Bruce Momjian wrote:
>
> On Mon, Aug 15, 2022 at 10:09:29PM +0530, vignesh C wrote:
> > I have updated the patch to display "Objects depending on extension"
> > as describe extension footer. The changes for the same are available
On Mon, Aug 22, 2022 at 1:58 PM Peter Smith wrote:
>
> Thanks for the view of v1-0001.
>
> On Wed, Aug 17, 2022 at 3:04 AM vignesh C wrote:
> ...
> > 1) Row filters mentions that "It has no effect on TRUNCATE commands.",
> > the same is not present in c
On Mon, Aug 8, 2022 at 2:53 PM vignesh C wrote:
>
> On Mon, Aug 8, 2022 at 12:46 PM vignesh C wrote:
> >
> > On Fri, Jun 3, 2022 at 3:36 PM vignesh C wrote:
> > >
> > > On Thu, May 26, 2022 at 7:04 PM osumi.takami...@fujitsu.com
> > > wrote:
&g
On Thu, Aug 18, 2022 at 12:33 PM Nitin Jadhav
wrote:
>
> I spent some time on understanding the proposal and the patch. Here
> are a few comments wrt the test cases.
>
> > +ALTER PUBLICATION testpub_reset ADD TABLE pub_sch1.tbl1;
> > +
> > +-- Verify that tables associated with the publication
On Mon, Aug 8, 2022 at 2:08 PM Peter Smith wrote:
>
> PSA patch version v1* for a new "Column Lists" pgdocs section
>
> This is just a first draft, but I wanted to post it as-is, with the
> hope that I can get some feedback while continuing to work on it.
Few comments:
1) Row filters mentions
On Sun, Aug 14, 2022 at 10:24 PM vignesh C wrote:
>
> On Sun, Aug 14, 2022 at 11:07 AM Tom Lane wrote:
> >
> > vignesh C writes:
> > > Currently we do not include the dependent extension information for
> > > index and materialized view in the describe comm
On Mon, Aug 15, 2022 at 10:42 AM Michael Paquier wrote:
>
> On Sun, Aug 14, 2022 at 07:56:00PM +0530, vignesh C wrote:
> > Modified the patch to list all the properties in case of "ALTER TYPE
> > typename SET (". I have included the properties in alphab
On Sun, Aug 14, 2022 at 11:07 AM Tom Lane wrote:
>
> vignesh C writes:
> > Currently we do not include the dependent extension information for
> > index and materialized view in the describe command. I felt it would
> > be useful to include this information as part
On Sun, Aug 14, 2022 at 3:41 PM Michael Paquier wrote:
>
> On Sun, Aug 14, 2022 at 08:25:01AM +0530, vignesh C wrote:
> > Attached patch has the changes for the same. Thoughts?
> >
> > a) Add tab completion for "ALTER TYPE typename SET" was missing.
>
> Wh
Hi,
This patch does a couple of things:
a) Tab completion for "ALTER TYPE typename SET" was missing. Added tab
completion for the same. b) Tab completion for "ALTER TYPE
RENAME VALUE" was not along with tab completion of "ALTER TYPE"
commands, it was present after "ALTER GROUP ", rearranged
Hi,
Currently we do not include the dependent extension information for
index and materialized view in the describe command. I felt it would
be useful to include this information as part of the describe command
like:
\d+ idx_depends
Index "public.idx_depends"
Column | Type |
On Wed, Aug 10, 2022 at 2:52 PM Amit Kapila wrote:
>
> On Wed, Aug 10, 2022 at 10:58 AM Andres Freund wrote:
> >
> > Hi,
> >
> > On 2022-08-09 20:21:19 -0700, Mark Dilger wrote:
> > > > On Aug 9, 2022, at 7:26 PM, Andres Freund wrote:
> > > >
> > > > The relevant code triggering it:
> > > >
> >
On Mon, Aug 8, 2022 at 12:46 PM vignesh C wrote:
>
> On Fri, Jun 3, 2022 at 3:36 PM vignesh C wrote:
> >
> > On Thu, May 26, 2022 at 7:04 PM osumi.takami...@fujitsu.com
> > wrote:
> > >
> > > On Monday, May 23, 2022 2:13 PM vignesh C wrote:
> >
On Fri, Jun 3, 2022 at 3:36 PM vignesh C wrote:
>
> On Thu, May 26, 2022 at 7:04 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Monday, May 23, 2022 2:13 PM vignesh C wrote:
> > > Attached v7 patch which fixes the buildfarm warning for an unused warnin
On Sat, Mar 12, 2022 at 1:29 PM vignesh C wrote:
>
> On Fri, Dec 3, 2021 at 3:21 PM vignesh C wrote:
> >
> > On Fri, Dec 3, 2021 at 1:13 PM Michael Paquier wrote:
> > >
> > > On Thu, Aug 26, 2021 at 09:00:39PM +0530, vignesh C wrote:
> > > > The
On Fri, Jul 29, 2022 at 10:51 AM vignesh C wrote:
>
> On Fri, Jul 29, 2022 at 8:31 AM Peter Smith wrote:
> >
> > Here are some comments for the patch v40-0001:
> >
> > ==
> >
> > 1. Commit message
> >
> > It might be better to alw
On Wed, Jul 27, 2022 at 6:02 PM Dilip Kumar wrote:
>
> On Wed, Jul 27, 2022 at 3:27 PM vignesh C wrote:
> >
>
> > Thanks for the updated patch, Few comments:
> > 1) The format specifier should be changed from %u to INT64_FORMAT
> >
e t1 has a unique key, this will lead to a unique key
violation and replication won't proceed.
This problem can be avoided by using origin and copy_data parameters as given
below:
Step 1 & Step 2 are same as above.
step 3: Create a subscription on node1 to subscribe to node2:
node1=# CREATE S
ring initial sync:
node2=# CREATE SUBSCRIPTION sub_node2_node1 CONNECTION ''
node2-# PUBLICATION pub_node1 WITH (copy_data = force, origin = none);
CREATE SUBSCRIPTION
Author: Vignesh C
Reviewed-By: Peter Smith, Amit Kapila, Jonathan Katz, Shi yu, Wang wei
Discussion: https://www.postgresql.org/mess
On Thu, Jul 28, 2022 at 11:28 AM Peter Smith wrote:
>
> Hi Vignesh.
>
> FYI the v39* patch fails to apply [1]. Can you please rebase it?
>
>
> [1]
> === Applying patches on top of PostgreSQL commit ID
> 5f858dd3bebd1f3845aef2bff7f4345bfb7b74b3 ===
> === applying patch
>
On Wed, Jul 27, 2022 at 4:22 PM Michael Paquier wrote:
>
> On Wed, Jul 27, 2022 at 08:47:46AM +0530, vignesh C wrote:
> > I feel this would be an overkill, I did not make any changes for this.
>
> Agreed. Using an extra layer of wrappers for that seems a bit too
> much, so I
On Tue, Jul 26, 2022 at 1:32 PM Dilip Kumar wrote:
>
> On Thu, Jul 21, 2022 at 9:53 AM Thomas Munro wrote:
> >
> > On Wed, Jul 20, 2022 at 11:27 PM Dilip Kumar wrote:
> > > [v10 patch set]
> >
> > Hi Dilip, I'm experimenting with these patches and will hopefully have
> > more to say soon, but I
On Mon, Jul 25, 2022 at 10:22 AM Amit Kapila wrote:
>
> On Mon, Jul 25, 2022 at 8:34 AM Peter Smith wrote:
> >
> > On Mon, Jul 25, 2022 at 11:08 AM Michael Paquier
> > wrote:
> > >
> > > On Sun, Jul 24, 2022 at 09:52:16PM +0530, vignesh C wrote
On Mon, Jul 25, 2022 at 8:34 AM Peter Smith wrote:
>
> On Mon, Jul 25, 2022 at 11:08 AM Michael Paquier wrote:
> >
> > On Sun, Jul 24, 2022 at 09:52:16PM +0530, vignesh C wrote:
> > > Thanks for the comments, i have modified it by changing it to a
> > > bool
On Mon, Jul 25, 2022 at 12:58 PM Peter Smith wrote:
>
> Firstly, I have some (case-sensitivity) questions about the previous
> patch which was already pushed [1].
>
> Q1. create_subscription docs
>
> I did not understand why the docs refer to slot_name = NONE, yet the
> newly added option says
On Tue, Jul 26, 2022 at 2:12 PM wangw.f...@fujitsu.com
wrote:
>
> On Sun, Jul 24, 2022 1:28 AM vignesh C wrote:
> > Added a note for the same and referred it to the conflicts section.
> >
> > Thanks for the comments, the attached v38 patch has the changes for the
>
On Tue, Jul 26, 2022 at 1:35 PM shiy.f...@fujitsu.com
wrote:
>
> On Sun, Jul 24, 2022 1:28 AM vignesh C wrote:
> >
> > Added a note for the same and referred it to the conflicts section.
> >
> > Thanks for the comments, the attached v38 patch has the changes fo
On Tue, Jul 26, 2022 at 7:16 AM Peter Smith wrote:
>
> Here are some review comments for the patch v38-0002:
>
> ==
>
> - terminology
>
> There seemed to be an inconsistent alternation of the terms
> "primaries" and "nodes"... For example "Setting replication between
> two primaries" versus
ess of
node1 sending data to node2 and node2 sending data to node1 will repeat
infinitely. If table t1 has a unique key, this will lead to a unique key
violation and replication won't proceed.
This problem can be avoided by using origin and copy_data parameters as given
below:
Step 1 &am
On Mon, Jul 25, 2022 at 2:24 PM vignesh C wrote:
>
> On Sun, Jul 24, 2022 at 10:21 PM Jonathan S. Katz
> wrote:
> >
> > On 7/22/22 12:47 AM, Amit Kapila wrote:
> > > On Fri, Jul 22, 2022 at 1:39 AM Jonathan S. Katz
> > > wrote:
> >
> >
On Mon, Jul 25, 2022 at 12:58 PM Peter Smith wrote:
>
> Firstly, I have some (case-sensitivity) questions about the previous
> patch which was already pushed [1].
>
> Q1. create_subscription docs
>
> I did not understand why the docs refer to slot_name = NONE, yet the
> newly added option says
On Sun, Jul 24, 2022 at 10:21 PM Jonathan S. Katz wrote:
>
> On 7/22/22 12:47 AM, Amit Kapila wrote:
> > On Fri, Jul 22, 2022 at 1:39 AM Jonathan S. Katz
> > wrote:
>
> >> 1. I'm concerned by calling this "Bidirectional replication" in the docs
> >> that we are overstating the current
e of a common function for
GetSubscriptionRelations and GetSubscriptionNotReadyRelations.
Most of the code is common between GetSubscriptionRelations and
GetSubscriptionNotReadyRelations. Added a parameter to GetSubscriptionRelations
which could provide the same functionality for GetSubscriptionRelations
and
On Fri, Jul 22, 2022 at 10:17 AM Amit Kapila wrote:
>
> On Fri, Jul 22, 2022 at 1:39 AM Jonathan S. Katz wrote:
> >
> > Thanks for the work on this feature -- this is definitely very helpful
> > towards supporting more types of use cases with logical replication!
> >
> > I've read through the
On Fri, Jul 22, 2022 at 1:39 AM Jonathan S. Katz wrote:
>
> Hi,
>
> On 7/21/22 6:34 AM, vignesh C wrote:
> > On Thu, Jul 21, 2022 at 2:06 PM Amit Kapila wrote:
> >>
> >> On Wed, Jul 20, 2022 at 2:33 PM vignesh C wrote:
> >>>
> >>> Modi
On Wed, Jul 20, 2022 at 4:57 PM Dilip Kumar wrote:
>
> On Mon, Jul 18, 2022 at 4:51 PM Dilip Kumar wrote:
> >
> > I was doing some more testing by setting the FirstNormalRelFileNumber
> > to a high value(more than 32 bits) I have noticed a couple of problems
> > there e.g. relpath is still using
On Thu, Jul 21, 2022 at 2:06 PM Amit Kapila wrote:
>
> On Wed, Jul 20, 2022 at 2:33 PM vignesh C wrote:
> >
> > Modified. Apart from this I have run pgperltidy on the perl file and
> > renamed 032_origin.pl to 030_origin.pl as currently there is
> > 029_o
On Wed, Jul 20, 2022 at 10:38 AM Peter Smith wrote:
>
> On Tue, Jul 19, 2022 at 11:34 PM Amit Kapila wrote:
> >
> > On Mon, Jul 18, 2022 at 9:46 PM vignesh C wrote:
> > >
> > > I have updated the patch to handle the origin value case
> > > inse
On Thu, Jul 14, 2022 at 6:42 PM Dilip Kumar wrote:
>
> On Thu, 14 Jul 2022 at 6:34 PM, vignesh C wrote:
>>
>> On Thu, Jul 14, 2022 at 11:26 AM Dilip Kumar wrote:
>> >
>> > On Wed, Jul 13, 2022 at 4:49 PM Dilip Kumar wrote:
>> > >
>>
On Thu, Jul 14, 2022 at 4:34 AM Peter Smith wrote:
>
> On Wed, Jul 13, 2022 at 7:55 PM vignesh C wrote:
> >
> > On Wed, Jul 13, 2022 at 1:13 PM Michael Paquier wrote:
> > >
> > > On Wed, Jul 13, 2022 at 12:22:06PM +0530, vignesh C wrote:
> &
On Wed, Jul 13, 2022 at 1:13 PM Michael Paquier wrote:
>
> On Wed, Jul 13, 2022 at 12:22:06PM +0530, vignesh C wrote:
> > Most of the code is common between GetSubscriptionRelations and
> > GetSubscriptionNotReadyRelations. Added a parameter to
> > GetSubscriptionRelat
Hi,
Most of the code is common between GetSubscriptionRelations and
GetSubscriptionNotReadyRelations. Added a parameter to
GetSubscriptionRelations which could provide the same functionality as
the existing GetSubscriptionRelations and
GetSubscriptionNotReadyRelations. Attached patch has the
On Mon, Jul 11, 2022 at 5:03 PM Amit Kapila wrote:
>
> On Sat, Jul 9, 2022 at 8:11 PM vignesh C wrote:
> >
>
> Thanks, a few more comments on v30_0002*
> 1.
> +/*
> + * Represents whether copy_data parameter is specified with off, on or force.
>
> A comma is
On Thu, Jun 23, 2022 at 2:25 AM Ibrar Ahmed wrote:
>
>
>
> On Thu, Jun 23, 2022 at 1:04 AM David G. Johnston
> wrote:
>>
>> On Wed, Jun 22, 2022 at 12:11 PM Ibrar Ahmed wrote:
>>>
>>> On Thu, Jun 23, 2022 at 12:01 AM Tom Lane wrote:
Robert Haas writes:
> On Jun 2, 2009, at
On Tue, Jul 5, 2022 at 6:14 AM Peter Smith wrote:
>
> I checked again the v26* patch set.
>
> I had no more comments for v26-0001, v26-0002, or v26-0004, but below
> are some comments for v26-0003.
>
>
> v26-0003
>
>
> 3.1 src/backend/catalog/pg_subscription.c
>
> 3.1.a
> +/*
>
On Mon, Jul 4, 2022 at 7:44 PM Alvaro Herrera wrote:
>
> > From d8f8844f877806527b6f3f45320b6ba55a8e3154 Mon Sep 17 00:00:00 2001
> > From: Vigneshwaran C
> > Date: Thu, 26 May 2022 19:29:33 +0530
> > Subject: [PATCH v27 1/4] Add a missing test to verify only-local parameter
> > in
> >
On Mon, Jul 4, 2022 at 9:23 AM Amit Kapila wrote:
>
> On Mon, Jul 4, 2022 at 3:59 AM Peter Smith wrote:
> >
> > On Mon, Jul 4, 2022 at 12:59 AM vignesh C wrote:
> > ...
> > > > 2.
> > > > /* ALTER SUBSCRIPTION SET ( */
> > > &
On Mon, Jul 4, 2022 at 1:46 PM shiy.f...@fujitsu.com
wrote:
>
> On Sun, Jul 3, 2022 11:00 PM vignesh C wrote:
> >
> > Thanks for the comments, the attached v27 patch has the changes for the
> > same.
> >
>
> Thanks for updating th
On Sat, Jul 2, 2022 at 8:51 AM Amit Kapila wrote:
>
> On Fri, Jul 1, 2022 at 10:22 PM vignesh C wrote:
> >
> > On Wed, Jun 29, 2022 at 3:25 PM houzj.f...@fujitsu.com
> > wrote:
> > >
> >
> > Thanks for the updated patch.
> > Few comments
On Wed, Jun 29, 2022 at 3:25 PM houzj.f...@fujitsu.com
wrote:
>
> On Wednesday, June 29, 2022 11:07 AM Amit Kapila
> wrote:
> >
> > On Tue, Jun 28, 2022 at 5:43 PM Amit Kapila
> > wrote:
> > >
> > > 5.
> > > +static ObjTree *
> > > +deparse_CreateStmt(Oid objectId, Node *parsetree)
> > > {
> >
On Tue, Jun 21, 2022 at 5:49 PM houzj.f...@fujitsu.com
wrote:
>
> On Monday, June 20, 2022 11:32 AM houzj.f...@fujitsu.com
> wrote:
> >
> > On Saturday, June 18, 2022 3:38 AM Zheng Li wrote:
> > > On Wed, Jun 15, 2022 at 12:00 AM Amit Kapila
> > > wrote:
> > > >
> > > > On Wed, Jun 15, 2022
On Thu, Jun 23, 2022 at 7:05 AM shiy.f...@fujitsu.com
wrote:
>
> On Mon, Jun 20, 2022 7:55 PM vignesh C wrote:
> >
> > Thanks for the comment, the v22 patch attached has the changes for the
> > same.
>
> Thanks for updating the patch, here are some comments on 00
On Tue, Jun 21, 2022 at 5:49 PM houzj.f...@fujitsu.com
wrote:
>
> On Monday, June 20, 2022 11:32 AM houzj.f...@fujitsu.com
> wrote:
> >
> > On Saturday, June 18, 2022 3:38 AM Zheng Li wrote:
> > > On Wed, Jun 15, 2022 at 12:00 AM Amit Kapila
> > > wrote:
> > > >
> > > > On Wed, Jun 15, 2022
On Mon, Jun 20, 2022 at 3:16 PM vignesh C wrote:
>
> On Mon, Jun 20, 2022 at 2:37 PM Dilip Kumar wrote:
> >
> > On Thu, Jun 16, 2022 at 3:48 PM vignesh C wrote:
> > >
> > > On Wed, Jun 15, 2022 at 12:09 PM Peter Smith
> > > wrote:
> > >
On Mon, Jun 20, 2022 at 2:37 PM Dilip Kumar wrote:
>
> On Thu, Jun 16, 2022 at 3:48 PM vignesh C wrote:
> >
> > On Wed, Jun 15, 2022 at 12:09 PM Peter Smith wrote:
> > >
>
> > Thanks for the comments, the attached v21 patch has the changes for the
> &g
On Wed, Jun 15, 2022 at 12:13 PM Peter Smith wrote:
>
> Here are some review comments for patch v20-0004.
>
> ==
>
> 1. General
>
> I thought that it is better to refer to the
> subscription/publications/table "on" the node, rather than "in" the
> node. Most of the review comments below are
On Wed, Jun 15, 2022 at 12:11 PM Peter Smith wrote:
>
> Here are some review comments for patch v20-0003.
>
> ==
>
> 1. Commit message
>
> In case, table t1 has a unique key, it will lead to a unique key
> violation and replication won't proceed.
>
> SUGGESTION
> If table t1 has a unique key,
On Fri, Jun 10, 2022 at 2:09 PM Peter Smith wrote:
>
> Below are some review comments for the patch v18-0004
>
> ==
>
> 1. Commit message
>
> Document the steps for the following:
> a) Create a two-node bidirectional replication when there is no data in both
> the
> nodes.
> b) Adding a new
On Fri, Jun 3, 2022 at 11:01 AM Peter Smith wrote:
>
> Please find below my review comments for patch v17-0002:
>
> ==
>
> 1. Commit message
>
> This patch adds a new SUBSCRIPTION parameter "origin". It Specifies whether
> the subscription will request the publisher to only send changes that
On Tue, May 31, 2022 at 11:51 AM Peter Smith wrote:
>
> Here are my review comments for patch v7-0002.
>
> ==
>
> 1. doc/src/sgml/logical-replication.sgml
>
> @@ -1167,8 +1167,9 @@ CONTEXT: processing remote data for replication
> origin "pg_16395" during "INSER
>
> To add tables to
'On Mon, May 30, 2022 at 1:51 PM Peter Smith wrote:
>
> Here are some minor review comments for v7-0001.
>
> ==
>
> 1. General
>
> Probably the commit message and all the PG docs and code comments
> should be changed to refer to "publication parameters" instead of
> (currently) "publication
601 - 700 of 1507 matches
Mail list logo
