RE: [Bug Fix] ECPG: could not use some CREATE TABLE AS syntax

2019-02-18 Thread Higuchi, Daisuke
Hi, Meskes-san > Thank you, committed. Thank you! By the way, I have found another bugs which are related to ECPG , so I will post that later. Regards, Daisuke, Higuchi

Re: [Bug Fix] ECPG: could not use some CREATE TABLE AS syntax

2019-02-18 Thread Michael Meskes
Hi Higuchi-san, > I updated and attached the patch. As I show in previous post, this > version is that "IF NOT EXISTS" keyword and variable for "WITH NO > DATA" are added to ecpg.trailer. Thank you, committed. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Co

RE: [Bug Fix] ECPG: could not use some CREATE TABLE AS syntax

2019-02-18 Thread Higuchi, Daisuke
Hi, Meskes-san > Yes, I fully understand that. However, in doing so you accept > statements that the backend later on rejects. The sole reason for > the big ecpg grammar is to prevent those cases whenever possible. Ok, I agree with you. > > I also want to hear your opinion. I will change my o

Re: [Bug Fix] ECPG: could not use some CREATE TABLE AS syntax

2019-02-18 Thread Michael Meskes
Hi Higuchi-san, > My goal is to accept syntax which is currently rejected by ECPG. To > realize that, I am considering following two ways: > (a) new syntax of create as statement should be added to ECPG Correct. > (b) make ECPG to use not ecpg.trailer but gram.y in the syntax of > create as stat

RE: [Bug Fix] ECPG: could not use some CREATE TABLE AS syntax

2019-02-17 Thread Higuchi, Daisuke
Hi, Meskes-san, Thanks for your response! > I beg to disagree, or I don't understand. Why would ecpg's changes to > the statement be wrong nowadays? I might confuse you, but it does not mean that it is wrong to reject CREATE TABLE AS ... INTO ... syntax in ECPG. My goal is to accept syntax

Re: [Bug Fix] ECPG: could not use some CREATE TABLE AS syntax

2019-02-15 Thread Michael Meskes
Higuchi-san, > I found some "CREATE TABLE ... AS ... " syntaxes could not be used in > ECPG. > ... > [Investigation] > In my investigation, parse.pl ignore type CreateAsStmt of gram.y and > CreateAsStmt is defined in ecpg.trailer. ECPG use ecpg.trailer's > CreateAsStmt. However, ecpg.trailer lack

[Bug Fix] ECPG: could not use some CREATE TABLE AS syntax

2019-02-13 Thread Higuchi, Daisuke
Hi, I found some "CREATE TABLE ... AS ... " syntaxes could not be used in ECPG. [PROBLEM] First, ECPG command is failed when the source code (*.pgc) has "IF NOT EXISTS". --- EXEC SQL CREATE TABLE IF NOT EXISTS test_cta AS SELECT *