Re: [DOC] Update ALTER SUBSCRIPTION documentation v3

2023-06-21 Thread Amit Kapila
On Tue, Jun 20, 2023 at 9:02 AM Peter Smith wrote: > > FYI - I have created and tested back-patches for Amit's v5 patch, > going all the way to REL_10_STABLE. > Pushed. I haven't used PG10 patch as REL_10_STABLE is out of support now. -- With Regards, Amit Kapila.

Re: [DOC] Update ALTER SUBSCRIPTION documentation v3

2023-06-19 Thread Peter Smith
FYI - I have created and tested back-patches for Amit's v5 patch, going all the way to REL_10_STABLE. (the patches needed tweaking several times due to minor code/docs differences in the earlier versions) PSA. -- Kind Regards, Peter Smith. Fujitsu Australia logical_replication_slot_disable

Re: [DOC] Update ALTER SUBSCRIPTION documentation v3

2023-06-16 Thread Amit Kapila
On Fri, Jun 16, 2023 at 7:15 PM Peter Eisentraut wrote: > > On 15.06.23 04:49, Amit Kapila wrote: > > > > Now, along with this change, there is a change in errhint as well > > which I am not sure about whether to backpatch or not. I think we have > > the following options (a) commit both doc and c

Re: [DOC] Update ALTER SUBSCRIPTION documentation v3

2023-06-16 Thread Peter Eisentraut
On 15.06.23 04:49, Amit Kapila wrote: I wanted to backpatch the following change which provides somewhat accurate information about what a user needs to do when it faces an error. To proceed in - this situation, disassociate the subscription from the replication slot by - executing ALTER SUBS

Re: [DOC] Update ALTER SUBSCRIPTION documentation v3

2023-06-14 Thread Amit Kapila
On Wed, Jun 14, 2023 at 6:52 PM Peter Eisentraut wrote: > > On 14.06.23 05:09, Amit Kapila wrote: > > The latest version looks good to me as well. I think we should > > backpatch this change as this is a user-facing message change in docs > > and code. What do you guys think? > > Isn't that a reas

Re: [DOC] Update ALTER SUBSCRIPTION documentation v3

2023-06-14 Thread Peter Eisentraut
On 14.06.23 05:09, Amit Kapila wrote: The latest version looks good to me as well. I think we should backpatch this change as this is a user-facing message change in docs and code. What do you guys think? Isn't that a reason *not* to backpatch it?

Re:Re: [DOC] Update ALTER SUBSCRIPTION documentation v3

2023-06-14 Thread 刘庄
Hi: postgres ODBC's driver psqlodbcw.so supports Unicode. You can do this by checking the value of the SQL_ATTR_ANSI_APP attribute; if it is SQL_AA_FALSE, Unicode is supported; If the value is SQL_AA_TRUE, ANSI is supported At 2023-06-14 11:54:46, "Peter Smith" wrote: >On Wed,

Re: [DOC] Update ALTER SUBSCRIPTION documentation v3

2023-06-13 Thread Amit Kapila
On Wed, Jun 14, 2023 at 9:25 AM Peter Smith wrote: > > On Wed, Jun 14, 2023 at 1:10 PM Amit Kapila wrote: > > > > On Wed, May 17, 2023 at 11:57 AM Peter Smith wrote: > > > > > > On Wed, May 17, 2023 at 2:53 PM Robert Sjöblom > > > wrote: > > > > > > > > Attached is the revised version. > > > >

Re: [DOC] Update ALTER SUBSCRIPTION documentation v3

2023-06-13 Thread Peter Smith
On Wed, Jun 14, 2023 at 1:10 PM Amit Kapila wrote: > > On Wed, May 17, 2023 at 11:57 AM Peter Smith wrote: > > > > On Wed, May 17, 2023 at 2:53 PM Robert Sjöblom > > wrote: > > > > > > Attached is the revised version. > > > > > > > v4 looks good to me. > > > > The latest version looks good to me

Re: [DOC] Update ALTER SUBSCRIPTION documentation v3

2023-06-13 Thread Amit Kapila
On Wed, May 17, 2023 at 11:57 AM Peter Smith wrote: > > On Wed, May 17, 2023 at 2:53 PM Robert Sjöblom > wrote: > > > > Attached is the revised version. > > > > v4 looks good to me. > The latest version looks good to me as well. I think we should backpatch this change as this is a user-facing me

Re: [DOC] Update ALTER SUBSCRIPTION documentation v3

2023-05-16 Thread Peter Smith
On Wed, May 17, 2023 at 2:53 PM Robert Sjöblom wrote: > > Den ons 17 maj 2023 kl 03:18 skrev Peter Smith : > > > > + errhint("Use %s to disassociate the subscription from the slot after > > disabling the subscription.", > > > > IMO it looked strange having the word "subscription" 2x in the same >

Re: [DOC] Update ALTER SUBSCRIPTION documentation v3

2023-05-16 Thread Robert Sjöblom
Den ons 17 maj 2023 kl 03:18 skrev Peter Smith : > > + errhint("Use %s to disassociate the subscription from the slot after > disabling the subscription.", > > IMO it looked strange having the word "subscription" 2x in the same sentence. > > Maybe you can reword the errhint like: > > BEFORE > "Use

Re: [DOC] Update ALTER SUBSCRIPTION documentation v3

2023-05-16 Thread Peter Smith
+ errhint("Use %s to disassociate the subscription from the slot after disabling the subscription.", IMO it looked strange having the word "subscription" 2x in the same sentence. Maybe you can reword the errhint like: BEFORE "Use %s to disassociate the subscription from the slot after disabling

Re: [DOC] Update ALTER SUBSCRIPTION documentation v3

2023-05-16 Thread Robert Sjöblom
Den tis 16 maj 2023 kl 01:44 skrev Peter Smith : > > On Mon, May 15, 2023 at 11:36 PM Robert Sjöblom > wrote: > > > > > > > > On 2023-05-05 15:17, Robert Sjöblom wrote: > > > > > > Hi, > > > > > > We have recently used the PostgreSQL documentation when setting up our > > > logical replication. We