Re: [HACKERS] [WIP] Zipfian distribution in pgbench

2018-10-08 Thread Peter Geoghegan
On Fri, Jul 7, 2017 at 12:45 AM Alik Khilazhev wrote: > PostgreSQL shows very bad results in YCSB Workload A (50% SELECT and 50% > UPDATE of random row by PK) on benchmarking with big number of clients using > Zipfian distribution. MySQL also has decline but it is not significant as it > is in

Re: [HACKERS] [WIP] Zipfian distribution in pgbench

2017-12-14 Thread Teodor Sigaev
Thank you for all, pushed Fabien COELHO wrote: Note that the patch may interact with other patches which add functions to pgbench, so might need a rebase depending on the order in which the patch are applied. Attached a minor rebase after 16827d4424. -- Teodor Sigaev

Re: [HACKERS] [WIP] Zipfian distribution in pgbench

2017-11-21 Thread Fabien COELHO
Note that the patch may interact with other patches which add functions to pgbench, so might need a rebase depending on the order in which the patch are applied. Attached a minor rebase after 16827d4424. -- Fabien.diff --git a/doc/src/sgml/ref/pgbench.sgml b/doc/src/sgml/ref/pgbench.sgml ind

Re: [HACKERS] [WIP] Zipfian distribution in pgbench

2017-11-20 Thread Alik Khilazhev
> I have added the thread to the next CF (January 2018), and marked it as > "ready for committer”. That’s cool, thank you for review! — Thanks and Regards, Alik Khilazhev Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] [WIP] Zipfian distribution in pgbench

2017-11-20 Thread Fabien COELHO
Fixed. Applies, compiles, make check ok, doc ok. Note that the patch may interact with other patches which add functions to pgbench, so might need a rebase depending on the order in which the patch are applied. We'll see. I have added the thread to the next CF (January 2018), and marked i

Re: [HACKERS] [WIP] Zipfian distribution in pgbench

2017-11-20 Thread Alik Khilazhev
> I would suggest to use [1, 9] and the simpler regex [1-9] instead of the full > list. > > Also, there should be an empty line between functions. I just noticed that > one is missing after zipfFindOrCreateCacheCell(). Fixed. pgbench-zipf-11v.patch Description: Binary data — Thanks and Regar

Re: [HACKERS] [WIP] Zipfian distribution in pgbench

2017-11-20 Thread Fabien COELHO
Hello Alik, Patch applies, compiles, works (I checked the distribution). Doc gen ok. make check ok. I have reduced range to [1, 10] and updated the test. I would suggest to use [1, 9] and the simpler regex [1-9] instead of the full list. Also, there should be an empty line between funct

Re: [HACKERS] [WIP] Zipfian distribution in pgbench

2017-11-20 Thread Alik Khilazhev
> Patch applies with "patch", but not with "git apply", probably because it is > in CR-NL eol format. No big deal. > > Documentation has been switched from SGML to XML, so now tags must be > explicitely closed, i.e. use x instead of x. > > Patch compiles with a warning: > > Declaration must m

Re: [HACKERS] [WIP] Zipfian distribution in pgbench

2017-11-19 Thread Fabien COELHO
Hello Alik, Patch applies with "patch", but not with "git apply", probably because it is in CR-NL eol format. No big deal. Documentation has been switched from SGML to XML, so now tags must be explicitely closed, i.e. use x instead of x. Patch compiles with a warning: pgbench.c: In funct

Re: [HACKERS] [WIP] Zipfian distribution in pgbench

2017-11-19 Thread Alik Khilazhev
Hello Fabien, Sorry for not respondingfor long time. > Two typos: > - "usinng" -> "using" > - "a rejection method used" -> "a rejection method is used" > > I'm not sure of "least_recently_used_i", this naming style is not used in > pgbench. "least_recently_used" would be ok. > > "..nb