On Tue, Mar 06, 2018 at 02:23:19AM +0900, Fujii Masao wrote:
> I have no objection to mark the patch "returned with feedback".
Yes I have done so, that's way too late.
--
Michael
signature.asc
Description: PGP signature
On Mon, Mar 5, 2018 at 11:01 PM, David Steele wrote:
> On 3/5/18 1:06 AM, Michael Paquier wrote:
>> On Fri, Mar 02, 2018 at 03:41:57PM -0500, David Steele wrote:
>>> On 3/2/18 1:03 PM, Fujii Masao wrote:
On Fri, Mar 2, 2018 at 1:07 PM, Michael Paquier
wrote:
> We would talk about t
On 3/5/18 1:06 AM, Michael Paquier wrote:
> On Fri, Mar 02, 2018 at 03:41:57PM -0500, David Steele wrote:
>> On 3/2/18 1:03 PM, Fujii Masao wrote:
>>> On Fri, Mar 2, 2018 at 1:07 PM, Michael Paquier wrote:
We would talk about two backups running
simultaneously on a standby, which would o
On Fri, Mar 02, 2018 at 03:41:57PM -0500, David Steele wrote:
> On 3/2/18 1:03 PM, Fujii Masao wrote:
>> On Fri, Mar 2, 2018 at 1:07 PM, Michael Paquier wrote:
>>> We would talk about two backups running
>>> simultaneously on a standby, which would overlap with each other to
>>> generate a file ai
Hi,
On 3/2/18 1:03 PM, Fujii Masao wrote:
> On Fri, Mar 2, 2018 at 1:07 PM, Michael Paquier wrote:
>
>> We would talk about two backups running
>> simultaneously on a standby, which would overlap with each other to
>> generate a file aimed only at being helpful for debugging purposes, and
>> we
On Fri, Mar 2, 2018 at 12:26 PM, Andres Freund wrote:
> Hi!
>
> On 2018-03-02 02:29:13 +0900, Fujii Masao wrote:
>> On Fri, Feb 2, 2018 at 2:06 PM, Michael Paquier
>> wrote:
>> > On Fri, Feb 02, 2018 at 12:47:26AM +0900, Fujii Masao wrote:
>> >> The patch basically looks good to me. Here are some
On Fri, Mar 2, 2018 at 1:07 PM, Michael Paquier wrote:
> On Fri, Mar 02, 2018 at 02:29:13AM +0900, Fujii Masao wrote:
>> + * write a backup history file with the same name.
>>
>> So more than one backup history files with the same name
>> but the diffferent content can be created and archived.
>>
On 3/1/18 11:07 PM, Michael Paquier wrote:
> On Fri, Mar 02, 2018 at 02:29:13AM +0900, Fujii Masao wrote:
>> + * write a backup history file with the same name.
>>
>> So more than one backup history files with the same name
>> but the diffferent content can be created and archived.
>> Isn't this pr
On Thu, Mar 01, 2018 at 07:26:09PM -0800, Andres Freund wrote:
> On 2018-03-02 02:29:13 +0900, Fujii Masao wrote:
>> + * write a backup history file with the same name.
>>
>> So more than one backup history files with the same name
>> but the diffferent content can be created and archived.
>> Isn'
On Fri, Mar 02, 2018 at 02:29:13AM +0900, Fujii Masao wrote:
> + * write a backup history file with the same name.
>
> So more than one backup history files with the same name
> but the diffferent content can be created and archived.
> Isn't this problematic because the backup history file that
>
Hi!
On 2018-03-02 02:29:13 +0900, Fujii Masao wrote:
> On Fri, Feb 2, 2018 at 2:06 PM, Michael Paquier
> wrote:
> > On Fri, Feb 02, 2018 at 12:47:26AM +0900, Fujii Masao wrote:
> >> The patch basically looks good to me. Here are some small comments.
> >>
> >>
> >> The backup history fil
On Fri, Feb 2, 2018 at 2:06 PM, Michael Paquier
wrote:
> On Fri, Feb 02, 2018 at 12:47:26AM +0900, Fujii Masao wrote:
>> The patch basically looks good to me. Here are some small comments.
>>
>>
>> The backup history file is not created in the database cluster backed
>> up.
>>
>>
>>
On Fri, Feb 02, 2018 at 12:47:26AM +0900, Fujii Masao wrote:
> The patch basically looks good to me. Here are some small comments.
>
>
> The backup history file is not created in the database cluster backed
> up.
>
>
> The above should be deleted in pg_basebackup.sgml.
>
> * D
On Thu, Jan 11, 2018 at 9:47 PM, Michael Paquier
wrote:
> On Thu, Jan 11, 2018 at 07:10:50PM +0900, Masahiko Sawada wrote:
>> On Sun, Jan 7, 2018 at 1:35 AM, David Steele wrote:
>>> On 1/6/18 3:48 AM, Michael Paquier wrote:
On Fri, Jan 5, 2018 at 11:27 PM, Simon Riggs
wrote:
>
On Thu, Jan 11, 2018 at 09:47:42PM +0900, Michael Paquier wrote:
> Cool. Thanks for the feedback.
The last patch still applies, but no committer has been interested, so I
am moving my patch to the next CF.
--
Michael
signature.asc
Description: PGP signature
On Thu, Jan 11, 2018 at 07:10:50PM +0900, Masahiko Sawada wrote:
> On Sun, Jan 7, 2018 at 1:35 AM, David Steele wrote:
>> On 1/6/18 3:48 AM, Michael Paquier wrote:
>>> On Fri, Jan 5, 2018 at 11:27 PM, Simon Riggs
>>> wrote:
>>>
Which also makes it a smaller and clearer patch
>>>
>>> Yes, thi
On Sun, Jan 7, 2018 at 1:35 AM, David Steele wrote:
> On 1/6/18 3:48 AM, Michael Paquier wrote:
>>
>> On Fri, Jan 5, 2018 at 11:27 PM, Simon Riggs
>> wrote:
>>
>>> Which also makes it a smaller and clearer patch
>>
>>
>> Yes, this generates less diffs, reducing the likelihood of bugs. What
>> do
On 1/6/18 3:48 AM, Michael Paquier wrote:
On Fri, Jan 5, 2018 at 11:27 PM, Simon Riggs wrote:
Which also makes it a smaller and clearer patch
Yes, this generates less diffs, reducing the likelihood of bugs. What
do you think about the v3 attached?
I agree that this is a cleaner solution.
On Fri, Jan 5, 2018 at 11:27 PM, Simon Riggs wrote:
> I'm not.
>
> If we want to do this why not only do it in the modes that have meaning?
> i.e. put an if() test in for archive_mode == always.
OK, I can see value in your point as well. The check is a bit more
complicated that just looking for a
On 19 September 2017 at 00:33, David Steele wrote:
> On 9/18/17 7:26 PM, Michael Paquier wrote:
>> On Tue, Sep 19, 2017 at 8:14 AM, David Steele wrote:
>>> On 8/31/17 11:56 PM, Michael Paquier wrote:
Here is an updated patch with refreshed documentation, as a result of
449338c which was
20 matches
Mail list logo