Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2019-01-31 Thread Pavel Stehule
čt 31. 1. 2019 v 14:44 odesílatel Andres Freund napsal: > Hi, > > On 2018-09-18 11:33:38 -0400, Tom Lane wrote: > > Pavel Stehule writes: > > > [ xml-xpath-default-ns-7.patch ] > > > > At Andrew's prompting, I took a look over this patch. I don't know much > > of anything about XML, so I have

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2019-01-31 Thread Andres Freund
Hi, On 2018-09-18 11:33:38 -0400, Tom Lane wrote: > Pavel Stehule writes: > > [ xml-xpath-default-ns-7.patch ] > > At Andrew's prompting, I took a look over this patch. I don't know much > of anything about XML, so I have no idea as to standards compliance here, > but I do have some comments:

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2018-11-30 Thread Pavel Stehule
pá 30. 11. 2018 v 9:26 odesílatel Kyotaro HORIGUCHI < horiguchi.kyot...@lab.ntt.co.jp> napsal: > Hello. > > At Fri, 30 Nov 2018 07:48:26 +0100, Pavel Stehule > wrote in < > cafj8prd7zg07t4npzu09t4rgxz0btvyyg2emvoh+o_drnoi...@mail.gmail.com> > > Hi > > > > čt 29. 11. 2018 v 14:44 odesílatel

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2018-11-30 Thread Kyotaro HORIGUCHI
Hello. At Fri, 30 Nov 2018 07:48:26 +0100, Pavel Stehule wrote in > Hi > > čt 29. 11. 2018 v 14:44 odesílatel Dmitry Dolgov <9erthali...@gmail.com> > napsal: > > > > On Fri, Sep 21, 2018 at 1:30 PM Pavel Stehule > > wrote: > > > > > > Thank you for comments > > > > > > Attached updated

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2018-11-29 Thread Pavel Stehule
Hi čt 29. 11. 2018 v 14:44 odesílatel Dmitry Dolgov <9erthali...@gmail.com> napsal: > > On Fri, Sep 21, 2018 at 1:30 PM Pavel Stehule > wrote: > > > > Thank you for comments > > > > Attached updated patch > > Unfortunately, current version of the patch doesn't pass make check, > something > is

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2018-11-29 Thread Dmitry Dolgov
> On Fri, Sep 21, 2018 at 1:30 PM Pavel Stehule wrote: > > Thank you for comments > > Attached updated patch Unfortunately, current version of the patch doesn't pass make check, something is missing for xml tests. Could you please rebase it? After that I hope someone from reviewers (Kyotaro?)

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2018-09-21 Thread Pavel Stehule
Hi út 18. 9. 2018 v 17:33 odesílatel Tom Lane napsal: > Pavel Stehule writes: > > [ xml-xpath-default-ns-7.patch ] > > At Andrew's prompting, I took a look over this patch. I don't know much > of anything about XML, so I have no idea as to standards compliance here, > but I do have some

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2018-09-18 Thread Tom Lane
Pavel Stehule writes: > [ xml-xpath-default-ns-7.patch ] At Andrew's prompting, I took a look over this patch. I don't know much of anything about XML, so I have no idea as to standards compliance here, but I do have some comments: * I'm fairly uncomfortable with the idea that we're going to

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2018-09-17 Thread Pavel Stehule
po 17. 9. 2018 v 23:15 odesílatel Thomas Munro < thomas.mu...@enterprisedb.com> napsal: > On Mon, Sep 17, 2018 at 5:36 PM Pavel Stehule > wrote: > > po 17. 9. 2018 v 2:05 odesílatel Thomas Munro < > thomas.mu...@enterprisedb.com> napsal: > >> On Fri, Aug 10, 2018 at 6:26 AM Andrew Dunstan > >>

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2018-09-16 Thread Pavel Stehule
po 17. 9. 2018 v 2:05 odesílatel Thomas Munro napsal: > On Fri, Aug 10, 2018 at 6:26 AM Andrew Dunstan > wrote: > > On 01/24/2018 04:30 AM, Pavel Stehule wrote: > > > > > > I am sending updated version. > > > > > > Very much thanks for very precious review > > > > Thomas, > > > > I am unable to

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2018-09-16 Thread Thomas Munro
On Fri, Aug 10, 2018 at 6:26 AM Andrew Dunstan wrote: > On 01/24/2018 04:30 AM, Pavel Stehule wrote: > > > > I am sending updated version. > > > > Very much thanks for very precious review > > Thomas, > > I am unable to replicate the Linux failure seen in the cfbot on my > Fedora machine. Both

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2018-08-09 Thread Andrew Dunstan
On 01/24/2018 04:30 AM, Pavel Stehule wrote: I am sending updated version. Very much thanks for very precious review Thomas, I am unable to replicate the Linux failure seen in the cfbot on my Fedora machine. Both when building with libxml2 and without, after applying the latest

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2018-01-29 Thread Kyotaro HORIGUCHI
Hello. I reviewed this and think that this is in Ready for Committer stage. The patch is available here. https://www.postgresql.org/message-id/CAFj8pRBVUVvG1CXxgrs0UipTziUX6M788z-%3DL9gQvwAB4UGLeg%40mail.gmail.com The following list consists of the same items in upthread message as

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2018-01-29 Thread Kyotaro HORIGUCHI
Hello. At Wed, 24 Jan 2018 10:30:39 +0100, Pavel Stehule wrote in

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2018-01-24 Thread Pavel Stehule
Hi 2018-01-23 8:13 GMT+01:00 Kyotaro HORIGUCHI : > Hello, I returned to this. > > I thouroughly checked the translator's behavior against the XPath > specifications and checkd out the documentation and regression > test. Almost everything is fine for me and this

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2018-01-23 Thread Pavel Stehule
Hi 2018-01-23 8:13 GMT+01:00 Kyotaro HORIGUCHI : > Hello, I returned to this. > > I thouroughly checked the translator's behavior against the XPath > specifications and checkd out the documentation and regression > test. Almost everything is fine for me and this

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2018-01-22 Thread Kyotaro HORIGUCHI
Hello, I returned to this. I thouroughly checked the translator's behavior against the XPath specifications and checkd out the documentation and regression test. Almost everything is fine for me and this would be the last comment from me. At Fri, 24 Nov 2017 18:32:43 +0100, Pavel Stehule

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2017-12-12 Thread Kyotaro HORIGUCHI
At Wed, 29 Nov 2017 14:33:08 +0900, Michael Paquier wrote in > On Sat, Nov 25, 2017 at 2:32 AM, Pavel Stehule > wrote: > > fixed regress test > > The last patch still

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2017-11-24 Thread Pavel Stehule
2017-11-24 18:13 GMT+01:00 Pavel Stehule : > > > 2017-11-24 17:53 GMT+01:00 Pavel Stehule : > >> Hi >> >> 2017-11-22 22:49 GMT+01:00 Thomas Munro : >> >>> On Thu, Nov 9, 2017 at 10:11 PM, Pavel Stehule

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2017-11-24 Thread Pavel Stehule
2017-11-24 17:53 GMT+01:00 Pavel Stehule : > Hi > > 2017-11-22 22:49 GMT+01:00 Thomas Munro : > >> On Thu, Nov 9, 2017 at 10:11 PM, Pavel Stehule >> wrote: >> > Attached new version. >> >> Hi Pavel, >> >> FYI my

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2017-11-22 Thread Thomas Munro
On Thu, Nov 9, 2017 at 10:11 PM, Pavel Stehule wrote: > Attached new version. Hi Pavel, FYI my patch testing robot says[1]: xml ... FAILED regression.diffs says: + SELECT x.* FROM t1, xmltable(XMLNAMESPACES(DEFAULT 'http://x.y'), '/rows/row'