Re: [PATCH] Allow specification of custom slot for custom nodes

2022-12-02 Thread Alexander Korotkov
On Sat, Nov 26, 2022 at 2:05 PM Ian Lawrence Barwick wrote: > 2022年11月22日(火) 5:50 Alexander Korotkov : > > > > On Mon, Nov 21, 2022 at 4:34 PM Pavel Borisov > > wrote: > > > The following review has been posted through the commitfest application: > > > make installcheck-world: tested, passed >

Re: [PATCH] Allow specification of custom slot for custom nodes

2022-11-26 Thread Ian Lawrence Barwick
2022年11月22日(火) 5:50 Alexander Korotkov : > > On Mon, Nov 21, 2022 at 4:34 PM Pavel Borisov wrote: > > The following review has been posted through the commitfest application: > > make installcheck-world: tested, passed > > Implements feature: tested, passed > > Spec compliant:

Re: [PATCH] Allow specification of custom slot for custom nodes

2022-11-21 Thread Alexander Korotkov
On Mon, Nov 21, 2022 at 4:34 PM Pavel Borisov wrote: > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: not tested > Documentation:not tested > >

Re: [PATCH] Allow specification of custom slot for custom nodes

2022-11-21 Thread Pavel Borisov
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:not tested I've looked at this patch and don't see any problems with it. It is

[PATCH] Allow specification of custom slot for custom nodes

2022-06-30 Thread Alexander Korotkov
Hackers, we have supported custom nodes for while. Custom slots are a bit more "recent" feature. Since we now support custom slots, which could handle custom tuple format, why not allow custom nodes to use them? For instance, a custom table access method can have its own tuple format and use a