Re: [PATCH] Fix fragile walreceiver test.

2025-11-06 Thread Michael Paquier
On Thu, Nov 06, 2025 at 07:58:55AM +0900, Michael Paquier wrote: > I owe you one here for noticing the issue quickly. The buildfarm > took some time to reproduce the failure and we have a minor release > coming next week. It would be annoying to release something with a > known instability, at le

Re: [PATCH] Fix fragile walreceiver test.

2025-11-05 Thread Michael Paquier
On Wed, Nov 05, 2025 at 07:38:23AM -0600, Bryan Green wrote: > Thanks for the quick turnaround and for including both Xuneng and me. I owe you one here for noticing the issue quickly. The buildfarm took some time to reproduce the failure and we have a minor release coming next week. It would be

Re: [PATCH] Fix fragile walreceiver test.

2025-11-05 Thread Bryan Green
On 11/5/2025 1:55 AM, Michael Paquier wrote: > On Wed, Nov 05, 2025 at 03:30:30PM +0800, Xuneng Zhou wrote: >> On Wed, Nov 5, 2025 at 2:50 PM Michael Paquier wrote: >>> Timing issue then, the buildfarm has not been complaining on this one >>> AFAIK, there have been no recoveryCheck failures report

Re: [PATCH] Fix fragile walreceiver test.

2025-11-05 Thread Xuneng Zhou
Hi, On Wed, Nov 5, 2025 at 3:56 PM Michael Paquier wrote: > > On Wed, Nov 05, 2025 at 03:30:30PM +0800, Xuneng Zhou wrote: > > On Wed, Nov 5, 2025 at 2:50 PM Michael Paquier wrote: > >> Timing issue then, the buildfarm has not been complaining on this one > >> AFAIK, there have been no recoveryC

Re: [PATCH] Fix fragile walreceiver test.

2025-11-04 Thread Michael Paquier
On Wed, Nov 05, 2025 at 03:30:30PM +0800, Xuneng Zhou wrote: > On Wed, Nov 5, 2025 at 2:50 PM Michael Paquier wrote: >> Timing issue then, the buildfarm has not been complaining on this one >> AFAIK, there have been no recoveryCheck failures reported: >> https://buildfarm.postgresql.org/cgi-bin/sh

Re: [PATCH] Fix fragile walreceiver test.

2025-11-04 Thread Xuneng Zhou
Hi, On Wed, Nov 5, 2025 at 2:50 PM Michael Paquier wrote: > > On Wed, Nov 05, 2025 at 12:03:29AM -0600, Bryan Green wrote: > > Problem: restart() kills the walreceiver (as it should), which writes > > that exact FATAL message to the log. The test then searches the log and > > finds it. > > Timing

Re: [PATCH] Fix fragile walreceiver test.

2025-11-04 Thread Michael Paquier
On Wed, Nov 05, 2025 at 12:03:29AM -0600, Bryan Green wrote: > Problem: restart() kills the walreceiver (as it should), which writes > that exact FATAL message to the log. The test then searches the log and > finds it. Timing issue then, the buildfarm has not been complaining on this one AFAIK, th

[PATCH] Fix fragile walreceiver test.

2025-11-04 Thread Bryan Green
The recovery/004_timeline_switch test has been failing for me on Windows. The test is wrong. The test does this: $node_standby_2->restart; # ... timeline switch happens ... ok( !$node_standby_2->log_contains( "FATAL: .* terminating walreceiver process due to administrator