Re: [PATCH] Move user options to the end of the command in pg_upgrade

2019-09-10 Thread Tom Lane
I wrote: > Patrik Novotny writes: >> thanks for you reply. You're right, and I apologise for the confusion. >> Options I was talking about are specified via the `--old-options` >> parameter of the pg_upgrade (ex.: --old-options '-c >> unix_socket_directories=/run') >> Mentioning of the environment

Re: [PATCH] Move user options to the end of the command in pg_upgrade

2019-09-10 Thread Tom Lane
Patrik Novotny writes: > thanks for you reply. You're right, and I apologise for the confusion. > Options I was talking about are specified via the `--old-options` > parameter of the pg_upgrade (ex.: --old-options '-c > unix_socket_directories=/run') > Mentioning of the environment variable came o

Re: [PATCH] Move user options to the end of the command in pg_upgrade

2019-09-10 Thread Patrik Novotny
Hi Tom, thanks for you reply. You're right, and I apologise for the confusion. Options I was talking about are specified via the `--old-options` parameter of the pg_upgrade (ex.: --old-options '-c unix_socket_directories=/run') Mentioning of the environment variable came only from my own confusion

Re: [PATCH] Move user options to the end of the command in pg_upgrade

2019-09-10 Thread Tom Lane
Patrik Novotny writes: > when the environment variable POSTGRESQL_UPGRADE_PGUPGRADE_OPTIONS is > used to specify options for pg_upgrade, options related to > unix_socket_directory/ies are being overridden by hardcoded options, > making it difficult to upgrade in some usecases. > The attached patc

[PATCH] Move user options to the end of the command in pg_upgrade

2019-09-10 Thread Patrik Novotny
Hi, when the environment variable POSTGRESQL_UPGRADE_PGUPGRADE_OPTIONS is used to specify options for pg_upgrade, options related to unix_socket_directory/ies are being overridden by hardcoded options, making it difficult to upgrade in some usecases. The attached patch changes the order of those