[PATCH] Note effect of max_replication_slots on subscriber side in documentation.

2021-02-16 Thread Paul Martinez
Hey, all, The configuration parameter max_replication_slots is most notably used to control how many replication slots can be created on a server, but it also controls how many replication origins can be tracked on the subscriber side. This is noted in the Configuration Settings section in the Lo

Re: [PATCH] Note effect of max_replication_slots on subscriber side in documentation.

2021-02-24 Thread Paul Martinez
Hey, all, I went ahead and made a patch for introducing a new GUC variable, max_replication_origins, to replace the awkward re-use of max_replication_slots. I'm mostly indifferent whether a new GUC variable is necessary, or simply just updating the existing documentation (the first patch I sent)

Re: [PATCH] Note effect of max_replication_slots on subscriber side in documentation.

2021-02-25 Thread Amit Kapila
On Thu, Feb 25, 2021 at 2:19 AM Paul Martinez wrote: > > Hey, all, > > I went ahead and made a patch for introducing a new GUC variable, > max_replication_origins, to replace the awkward re-use of > max_replication_slots. > > I'm mostly indifferent whether a new GUC variable is necessary, or > sim

Re: [PATCH] Note effect of max_replication_slots on subscriber side in documentation.

2021-02-26 Thread Paul Martinez
On Thu, Feb 25, 2021 at 5:31 AM Amit Kapila wrote: > > For docs only patch, I have few suggestions: > 1. On page [1], it is not very clear that we are suggesting to set > max_replication_slots for origins whereas your new doc patch has > clarified it, can we update the other page as well. Sorry,

Re: [PATCH] Note effect of max_replication_slots on subscriber side in documentation.

2021-02-26 Thread Amit Kapila
On Fri, Feb 26, 2021 at 1:53 AM Paul Martinez wrote: > > On Thu, Feb 25, 2021 at 5:31 AM Amit Kapila wrote: > > > > For docs only patch, I have few suggestions: > > 1. On page [1], it is not very clear that we are suggesting to set > > max_replication_slots for origins whereas your new doc patch

Re: [PATCH] Note effect of max_replication_slots on subscriber side in documentation.

2021-02-26 Thread Paul Martinez
On Fri, Feb 26, 2021 at 5:22 AM Amit Kapila wrote: > > https://www.postgresql.org/docs/devel/logical-replication-config.html > Ah, yep. I added a clause to the end of the sentence to clarify why we're using max_replication_slots here: - The subscriber also requires the max_replication_slots to b

Re: [PATCH] Note effect of max_replication_slots on subscriber side in documentation.

2021-02-27 Thread Amit Kapila
On Sat, Feb 27, 2021 at 2:47 AM Paul Martinez wrote: > > On Fri, Feb 26, 2021 at 5:22 AM Amit Kapila wrote: > > > > https://www.postgresql.org/docs/devel/logical-replication-config.html > > > > Ah, yep. I added a clause to the end of the sentence to clarify why we're > using max_replication_slots

Re: [PATCH] Note effect of max_replication_slots on subscriber side in documentation.

2021-03-01 Thread Amit Kapila
On Sat, Feb 27, 2021 at 2:35 PM Amit Kapila wrote: > > On Sat, Feb 27, 2021 at 2:47 AM Paul Martinez wrote: > > > > On Fri, Feb 26, 2021 at 5:22 AM Amit Kapila wrote: > > > > > > https://www.postgresql.org/docs/devel/logical-replication-config.html > > > > > > > Ah, yep. I added a clause to the

Re: [PATCH] Note effect of max_replication_slots on subscriber side in documentation.

2021-03-03 Thread Amit Kapila
On Mon, Mar 1, 2021 at 5:32 PM Amit Kapila wrote: > > On Sat, Feb 27, 2021 at 2:35 PM Amit Kapila wrote: > > > > On Sat, Feb 27, 2021 at 2:47 AM Paul Martinez wrote: > > > > > > On Fri, Feb 26, 2021 at 5:22 AM Amit Kapila > > > wrote: > > > > > > > > https://www.postgresql.org/docs/devel/logic